Re: [PATCH v2] drivers: visorbus: move driver out of staging

On Fri, 2017-12-08 at 21:55 +, Kershner, David A wrote: > > -Original Message- > > From: Joe Perches [mailto:j...@perches.com] > > Sent: Friday, December 8, 2017 11:53 AM > > To: Greg KH ; Kershner, David A > > > > Cc: jes.soren...@gmail.com; linux-ker...@vger.kernel.org; driverdev- >

RE: [PATCH v2] drivers: visorbus: move driver out of staging

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, December 8, 2017 1:32 PM > To: Greg KH > Cc: Kershner, David A ; > wadgaonkar...@gmail.com; driverdev-devel@linuxdriverproject.org; > jes.soren...@gmail.com; *S-Par-Maintainer > ; linux-ker...@vger

RE: [PATCH v2] drivers: visorbus: move driver out of staging

> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, December 8, 2017 11:53 AM > To: Greg KH ; Kershner, David A > > Cc: jes.soren...@gmail.com; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; *S-Par-Maintainer > ; erik.arfvid...@gmail

Re: [PATCH v2] Staging: pi433: fix brace coding style issues in pi433_if.c

On 12/06/2017 07:01 AM, Greg KH wrote: > On Mon, Dec 04, 2017 at 09:40:10PM +0100, Tomas Marek wrote: >> This patch fix several brace on next line, braces not necessary, space >> around =/<, and space before/after open/close parenthesis coding style >> errors find by checkpatch in pi433_if.c. >> >

[PATCH] Staging: ks7010: ks_wlan_net: Fixing coding style warning

Removing the extra spaces before tabs, checkpatch: WARNING: please, no space before tabs Signed-off-by: SUNIL KALLUR RAMEGOWDA --- drivers/staging/ks7010/ks_wlan_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/

RE: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip

> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Friday, December 8, 2017 3:34 AM > To: Eduardo Otubo > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; Stephen > Hemminger ; Haiyang Zhang > ; KY Srinivasan ; > vkuzn...@redhat.com; mga...@redhat.com

[PATCH] Staging: comedi: drivers: serial2002 fixed a blank line coding style

Fixed a blank line coding style after a declaration Signed-off-by: Vikash Kesarwani --- drivers/staging/comedi/drivers/serial2002.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/serial2002.c b/drivers/staging/comedi/drivers/serial2002.c index cc18e25103ca..c

Re: [PATCH v2] drivers: visorbus: move driver out of staging

On Fri, Dec 08, 2017 at 04:39:13PM +0100, Greg KH wrote: > On Thu, Dec 07, 2017 at 12:11:07PM -0500, David Kershner wrote: > > Move the visorbus driver out of staging (drivers/staging/unisys/visorbus) > > and to drivers/visorbus. Modify the configuration and makefiles so they > > now reference the

Re: [PATCH 3/6] x86/hyper-v: reenlightenment notifications support

On Fri, Dec 08, 2017 at 11:49:57AM +0100, Vitaly Kuznetsov wrote: > Hyper-V supports Live Migration notification. This is supposed to be used > in conjunction with TSC emulation: when we are migrated to a host with > different TSC frequency for some short period host emulates our accesses > to TSC

Re: [PATCH 6/6] x86/kvm: support Hyper-V reenlightenment

On Fri, Dec 08, 2017 at 11:50:00AM +0100, Vitaly Kuznetsov wrote: > When we run nested KVM on Hyper-V guests we need to update masterclocks for > all guests when L1 migrates to a host with different TSC frequency. > Implement the procedure in the following way: > - Pause all guests. > - Tell our ho

Re: [PATCH v2] drivers: visorbus: move driver out of staging

On Fri, 2017-12-08 at 16:39 +0100, Greg KH wrote: > On Thu, Dec 07, 2017 at 12:11:07PM -0500, David Kershner wrote: > > Move the visorbus driver out of staging (drivers/staging/unisys/visorbus) > > and to drivers/visorbus. Modify the configuration and makefiles so they > > now reference the new loc

[PATCH 07/10] staging: pi433: pi433_if.c space required in for loop

This patch fixes this codesstyle issues: ERROR: that open brace { should be on the previous line + for (i=0; i --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index

[PATCH 09/10] staging: pi433: open brace on previous line

This patch fixes this codestyle issue: ERROR: that open brace { should be on the previous line + for (i = 0; i < NUM_DIO; i++) + { Signed-off-by: Oliver Graute --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/

[PATCH 01/10] staging: pi433: codestyle space required

ERROR: spaces required around that '+=' (ctx:WxV) + position +=temp; ^ Signed-off-by: Oliver Graute --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/

[PATCH 02/10] staging: pi433: space prohibited before closing parenthesis

ERROR: space prohibited before that close parenthesis ')' + (size - position) ); Signed-off-by: Oliver Graute --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 726b71

[PATCH 08/10] staging: pi433: forbidden space and open brace

This patch fixes this codestyle issues: ERROR: that open brace { should be on the previous line + if ( IS_ERR(device->gpiod[i]) ) + { ERROR: space prohibited after that open parenthesis '(' + if ( IS_ERR(device->gpiod[i]) ) ERROR: space prohibited befor

[PATCH 06/10] staging: pi433: space prohibited

This patch fixes this codestyle issues: ERROR: space prohibited after that open parenthesis '(' + if ( retval != sizeof(instance->tx_cfg) ) ERROR: space prohibited before that close parenthesis ')' + if ( retval != sizeof(instance->tx_cfg) ) Signed-off-by: Oliver Graute --- drivers

[PATCH 05/10] staging: pi433: codestyle brace should be on previous line

This patch fixed codestyle issues of kind: ERROR: that open brace { should be on the previous line + if (device->rx_active) + { ERROR: that open brace { should be on the previous line + else + { ERROR: else should follow close brace '}' + } + else Signed-off

[PATCH 04/10] staging: pi433: pi433_if.c codestyle brace on previous line

ERROR: that open brace { should be on the previous line + if (rx_interrupted) + { Signed-off-by: Oliver Graute --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c

[PATCH 03/10] staging: pi433: space prohibted before that close parentesis

ERROR: space prohibited before that close parenthesis ')' +kthread_should_stop() ); Signed-off-by: Oliver Graute --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/dr

[PATCH 10/10] staging: pi433: space prohibited in IS_ERR

This patch fixes this codestyle issue: ERROR: space prohibited after that open parenthesis '(' + if ( IS_ERR(device->gpiod[i]) ) ERROR: space prohibited before that close parenthesis ')' + if ( IS_ERR(device->gpiod[i]) ) Signed-off-by: Oliver Graute --- drivers/stag

RE: [PATCH net 3/3] hv_netvsc: Fix the default receive buffer size

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, December 8, 2017 5:45 AM > To: Stephen Hemminger > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; de...@linuxdriverproject.org; > net...@vger.kernel.org > Subject: Re: [PATCH net 3/3

RE: [PATCH net 1/3] hv_netvsc: Correct the max receive buffer size

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, December 8, 2017 5:33 AM > To: Stephen Hemminger > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; de...@linuxdriverproject.org; > net...@vger.kernel.org > Subject: Re: [PATCH net 1/3

Re: [PATCH net 1/3] hv_netvsc: Correct the max receive buffer size

From: Dan Carpenter Date: Fri, 8 Dec 2017 13:33:25 +0300 > On Thu, Dec 07, 2017 at 04:10:53PM -0800, Stephen Hemminger wrote: >> From: Haiyang Zhang >> >> It should be 31 MB on recent host versions. >> >> Signed-off-by: Haiyang Zhang >> Signed-off-by: Stephen Hemminger > > This is very vagu

Re: [PATCH v2] drivers: visorbus: move driver out of staging

On Thu, Dec 07, 2017 at 12:11:07PM -0500, David Kershner wrote: > Move the visorbus driver out of staging (drivers/staging/unisys/visorbus) > and to drivers/visorbus. Modify the configuration and makefiles so they > now reference the new location. The s-Par header file visorbus.h that is > referenc

[PATCH 2/2] staging: pi433: Fix validation of rf69_get_modulation value

Checking of modulation in rf69_set_modulation_shaping is done by if-else and since else part covers OOK and UNDEF values it possible to set modulation shaping for undefined modulation type. To fix this validation should be done by switch clause and in case of undefined modulation error returned. S

[PATCH 0/2] Fix usage and validation of undefined value in enum modulation

This patches fixes usage and validation of undefined enum modulation value. First one adds missing enum which is returned from rf69_get_modulation function, second one fixes validation issue in rf69_set_modulation_shaping function. The issue is that return value is checked against FSK enum value

[PATCH 1/2] staging: pi433: Fix missing 'undefined' value in enum modulation

It is possible that rf69_get_modulation() function will return 'undefined' value and this value is missing in enum modulation. Fix this by adding appropriate entry in enum modulation. Signed-off-by: Marcin Ciupak --- drivers/staging/pi433/rf69.c | 2 +- drivers/staging/pi433/rf69_enum.h | 3

Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip

On Fri, Dec 08, 2017 at 12:33:38PM +0100, Olaf Hering wrote: > On Fri, Dec 08, Eduardo Otubo wrote: > > > tools/hv/hv_set_ifconfig.sh | 45 > > +++-- > > 1 file changed, 43 insertions(+), 2 deletions(-) > > > +# let's wait for 3 minutes > > Was t

[PATCH 5/6] staging: fsl-dpaa2/eth: Compute needed headroom per frame

For non-linear skbs we build scatter-gather frames and allocate a new buffer for the S/G table in which we reserve the required headroom, so the actual skb headroom size doesn't matter. Rather than use a one-size-fits-all approach, decide when to enforce headroom requirements on a frame by frame b

[PATCH 4/6] staging: fsl-dpaa2/eth: Don't enable FAS on Tx

For Tx confirmed frames that have an error indication in the frame descriptor, we look at the Frame Annotation Status field (in the buffer headroom) for details on the root cause and then print a debug message with that information. While useful in initial development stages, it doesn't bring enou

[PATCH 1/6] staging: fsl-dpaa2/eth: Fix access to FAS field

Commit 4b2d9fe87950 ("staging: fsl-dpaa2/eth: Extra headroom in RX buffers") removes the software annotation (SWA) area from the RX buffer layout, as it's not used by anyone, but fails to update the macros for accessing hardware annotation (HWA) fields, which is right after the SWA in the buffer he

[PATCH 6/6] staging: fsl-dpaa2/eth: Make Tx buffer alignment optional

Aligning the Tx buffers at 64B is a performance optimization recommendation, not a hard requirement. Make optional the alignment of Tx FD buffers, without enforcing a reallocation in case there is not enough headroom for it. On Rx, we keep allocating buffers with enough headroom to allow Tx align

[PATCH 0/6] staging: fsl-dpaa2/eth: Frame buffer optimizations

This patchset continues the work related to frame buffer layout. The first two patches fix an issue and simplify some rather convoluted formulas introduced by a previous commit. The third adds a new counter for TX skb reallocations due to insufficient headroom. This helped us notice that most of

[PATCH 3/6] staging: fsl-dpaa2/eth: Add counter for skb reallocs

Add a counter for the number of egress frames that need to be realloc'ed due to insufficient headroom space. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 1 + drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 1 + drivers/staging/fsl-dpaa2/ethernet/d

[PATCH 2/6] staging: fsl-dpaa2/eth: Don't set netdev->needed_headroom

Commit 4b2d9fe87950 ("staging: fsl-dpaa2/eth: Extra headroom in RX buffers") tried to avoid the performance penalty of doing skb reallocations in the network stack for IP forwarded frames between two DPAA2 Ethernet interfaces. This led to a (too) complicated formula that relies on the stack's inter

[PATCH] staging: wlan-ng: Fixing coding style warning

Removes following warnings found by checkpatch.pl script: WARNING: line over 80 characters Signed-off-by: Rodrigo Zaiden --- drivers/staging/wlan-ng/p80211netdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/stag

[PATCH] staging: ccree: cleanup a small white space issue

The call to set_flow_mode() was supposed to be on the next line. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c index 5548c7b24fc9..24e56d69039e 100644 --- a/drivers/staging/ccree/ssi_aead.c +++ b/drivers/staging/ccree/ssi_aead.c @@

Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip

On Fri, Dec 08, Eduardo Otubo wrote: > tools/hv/hv_set_ifconfig.sh | 45 > +++-- > 1 file changed, 43 insertions(+), 2 deletions(-) > +# let's wait for 3 minutes Was this codepath runtime tested? Last time this came up, the conclusion was that W

Re: [PATCH] android: binder: Check for errors in binder_alloc_shrinker_init().

On Wed, Dec 06, 2017 at 02:05:58PM -0500, Sherry Yang wrote: > Hi Tetsuo, > > It looks like this patch was not submitted to LKML. Perhaps you want > to send it to the mailing list and add the correct set of recipients > using scripts/get_maintainer.pl as suggested here > https://www.kernel.org/doc

[PATCH 0/6] x86/kvm/hyperv: stable clocksorce for L2 guests when running nested KVM on Hyper-V

Changes since RFC: - Handle disabled TSC page case [Radim Krčmář] - Function/parameter renames [Radim Krčmář] - Protect against simultaneous CPU shutdown (future-proof) [Radim Krčmář] - BUG() in !CONFIG_HYPERV_TSCPAGE case [Stephen Hemminger, Paolo Bonzini] - Fix build issues (hopefully) [kbuild te

[PATCH 4/6] x86/hyper-v: redirect reenlightment notifications on CPU offlining

It is very unlikely for CPUs to get offlined when we run on Hyper-V as we have a protection in vmbus module which prevents it when we have any VMBus devices assigned. This, however, may change in future if an option to reassign an already active channel will be added. It is also possible to run wi

[PATCH 2/6] x86/hyper-v: add a function to read both TSC and TSC page value simulateneously

This is going to be used from KVM code where we need to get both TSC and TSC page value. When Hyper-V code is compiled out just return rdtsc(), this will allow us to avoid ugly ifdefs in non-Hyper-V code. Signed-off-by: Vitaly Kuznetsov --- RFC -> v1: - EXPORT_SYMBOL_GPL(hv_get_tsc_page) [kbuild

[PATCH 3/6] x86/hyper-v: reenlightenment notifications support

Hyper-V supports Live Migration notification. This is supposed to be used in conjunction with TSC emulation: when we are migrated to a host with different TSC frequency for some short period host emulates our accesses to TSC and sends us an interrupt to notify about the event. When we're done updat

[PATCH 6/6] x86/kvm: support Hyper-V reenlightenment

When we run nested KVM on Hyper-V guests we need to update masterclocks for all guests when L1 migrates to a host with different TSC frequency. Implement the procedure in the following way: - Pause all guests. - Tell our host (Hyper-V) to stop emulating TSC accesses. - Update our gtod copy, recompu

[PATCH 1/6] x86/hyper-v: check for required priviliges in hyperv_init()

In hyperv_init() we presume we always have access to VP index and hypercall MSRs while according to the specification we should check if we're allowed to access the corresponding MSRs before accessing them. Signed-off-by: Vitaly Kuznetsov --- RFC -> v1: - 'requied_msrs' -> 'required_msrs' [Andrew

[PATCH 5/6] x86/kvm: pass stable clocksource to guests when running nested on Hyper-V

Currently, KVM is able to work in 'masterclock' mode passing PVCLOCK_TSC_STABLE_BIT to guests when the clocksource we use on the host is TSC. When running nested on Hyper-V we normally use a different one: TSC page which is resistant to TSC frequency changes on event like L1 migration. Add support

Re: [PATCHv4] staging: pi433: pi433_if.c remove SET_CHECKED macro

On Fri, Dec 08, 2017 at 11:43:19AM +0100, Nguyen Phan Quang Minh wrote: > The macro calls its argument -a function- twice, makes the calling > function return prematurely -skipping resource cleanup code- and hurts > understandability. > > Signed-off-by: Nguyen Phan Quang Minh Looks good. Thanks

Re: [PATCH net 3/3] hv_netvsc: Fix the default receive buffer size

On Thu, Dec 07, 2017 at 04:10:55PM -0800, Stephen Hemminger wrote: > From: Haiyang Zhang > > The intended size is 16 MB, and the default slot size is 1728. > So, NETVSC_DEFAULT_RX should be 16*1024*1024 / 1728 = 9709. > > Fixes: 5023a6db73196 ("netvsc: increase default receive buffer size") > Si

[PATCHv4] staging: pi433: pi433_if.c remove SET_CHECKED macro

The macro calls its argument -a function- twice, makes the calling function return prematurely -skipping resource cleanup code- and hurts understandability. Signed-off-by: Nguyen Phan Quang Minh --- v4: rebase the patch on lastest tree drivers/staging/pi433/pi433_if.c | 193

Re: [PATCH net 1/3] hv_netvsc: Correct the max receive buffer size

On Thu, Dec 07, 2017 at 04:10:53PM -0800, Stephen Hemminger wrote: > From: Haiyang Zhang > > It should be 31 MB on recent host versions. > > Signed-off-by: Haiyang Zhang > Signed-off-by: Stephen Hemminger This is very vague. What does "recent" mean in this context? There are also some unrel

[PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip

This patch fixes the behavior of the hv_set_ifconfig script when setting the interface ip. Sometimes the interface has already been configured by network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file exists error"; in order to avoid this error this patch makes sure double checks the