Re: [Outreachy kernel] [PATCH] staging: rtl8712: Fixed 'tabstop' coding style warning

On Fri, 2 Mar 2018, Arushi Singhal wrote: > Replace a mix of tabs and spaces indentation by tabs only. > > Fixed checkpatch warning "Statements should start on a tabstop" in > rtl8712 module. There is no need to say "in rtl8712 module". That is apparent from the subject line and the diffstat

[PATCH] staging: rtl8712: Fixed 'tabstop' coding style warning

Replace a mix of tabs and spaces indentation by tabs only. Fixed checkpatch warning "Statements should start on a tabstop" in rtl8712 module. Signed-off-by: Arushi Singhal --- drivers/staging/rtl8712/drv_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'.

On Thu, Mar 01, 2018 at 05:28:26PM -0800, Quytelda Kahja wrote: > Tobin, > I understand your point, and I've read submitting-patches.rst. I made > that wording choice because I was looking at some older commits that > were worded like that. I'm fairly new to the kernel workflow, so I > was just

[PATCH 2/2] staging: most: Fix a coding style problem

Indent the parameters for a function call that extends past 80 characters. Signed-off-by: Quytelda Kahja --- drivers/staging/most/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c index

[PATCH 1/2] staging: most: Fix a coding style problem.

Use a blank line after components_show() function declaration. Signed-off-by: Quytelda Kahja --- drivers/staging/most/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c index 0ab2de5ecf18..67e2d7f29967

Re: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'.

Tobin, I understand your point, and I've read submitting-patches.rst. I made that wording choice because I was looking at some older commits that were worded like that. I'm fairly new to the kernel workflow, so I was just trying to emulate something established, and it sounded less stilted than

Re: [PATCH net 8/9] hv_netvsc: propagate rx filters to VF

On Thu, 1 Mar 2018 10:27:55 -0800 Stephen Hemminger wrote: > + if (change & IFF_PROMISC) > + dev_set_promiscuity(net, > + (net->flags & IFF_PROMISC) ? 1 : -1); This should be vf_netdev here.

Re: [PATCH net 8/9] hv_netvsc: propagate rx filters to VF

On Thu, 1 Mar 2018 10:27:55 -0800, Stephen Hemminger wrote: > The netvsc device should propagate filters to the SR-IOV VF > device (if present). The flags also need to be propagated to the > VF device as well. This only really matters on local Hyper-V > since Azure does not support multiple

[staging:staging-testing 217/217] drivers/staging/nvec/nvec_power.c:361:10: warning: 'return' with a value, in function returning void

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 501b9cb070bc35073f4195b58e74098a9d31375c commit: 501b9cb070bc35073f4195b58e74098a9d31375c [217/217] staging: nvec: add error checking to nvec_event config: arm-multi_v7_defconfig (attached as

Re: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'.

On Thu, Mar 01, 2018 at 02:15:00PM +0300, Dan Carpenter wrote: > On Thu, Mar 01, 2018 at 05:37:21PM +1100, Tobin C. Harding wrote: > > On Wed, Feb 28, 2018 at 09:19:09PM -0800, Quytelda Kahja wrote: > > > The code that generates a WLAN capability mask is repeated in five > > > functions. This

[PATCH net 0/9] hv_netvsc: minor bug fixes

These are improvements to netvsc driver. They aren't functionality changes so not targeting net-next; and they are not show stopper bugs that need to go to stable either. Stephen Hemminger (9): hv_netvsc: avoid retry on send during shutdown hv_netvsc: only wake transmit queue if link is up

[PATCH net 2/9] hv_netvsc: only wake transmit queue if link is up

Don't wake transmit queues if link is not up yet. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index

[PATCH net 1/9] hv_netvsc: avoid retry on send during shutdown

Change the initialization order so that the device is ready to transmit (ie connect vsp is completed) before setting the internal reference to the device with RCU. This avoids any races on initialization and prevents retry issues on shutdown. Signed-off-by: Stephen Hemminger

[PATCH net 5/9] hv_netvsc: fix race in napi poll when rescheduling

There is a race between napi_reschedule and re-enabling interrupts which could lead to missed host interrrupts. This occurs when interrupts are re-enabled (hv_end_read) and vmbus irq callback (netvsc_channel_cb) has already scheduled NAPI. Signed-off-by: Stephen Hemminger

[PATCH net 9/9] hv_netvsc: defer queue selection to VF

When VF is used for accelerated networking it will likely have more queues (and different policy) than the synthetic NIC. This patch defers the queue policy to the VF so that all the queues can be used. This impacts workloads like local generate UDP. Signed-off-by: Stephen Hemminger

[PATCH net 4/9] hv_netvsc: cancel subchannel setup before halting device

Block setup of multiple channels earlier in the teardown process. This avoids possible races between halt and subchannel initialization. Suggested-by: Haiyang Zhang Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/rndis_filter.c | 3 +++ 1

[PATCH net 7/9] hv_netvsc: don't need full irqsave for request_lock

Since the driver incoming handling is done with NAPI. This path is run in softirq (not hardirq) therefore don't need to do full local irq save/restore. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/rndis_filter.c | 16 ++-- 1 file changed, 6

[PATCH net 8/9] hv_netvsc: propagate rx filters to VF

The netvsc device should propagate filters to the SR-IOV VF device (if present). The flags also need to be propagated to the VF device as well. This only really matters on local Hyper-V since Azure does not support multiple addresses. The rx filter management in netvsc device does not need to be

[PATCH net 3/9] hv_netvsc: fix error unwind handling if vmbus_open fails

Need to delete NAPI association if vmbus_open fails. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index

[PATCH net 6/9] hv_netvsc: use napi_schedule_irqoff

Since the netvsc_channel_cb is already called in interrupt context from vmbus, there is no need to do irqsave/restore. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/3] staging: fsl-mc: Move DPBP out of staging

Move the source files out of staging into their final locations: - dpbp.c goes to drivers/bus/fsl-mc/, next to the core infrastructure - dpbp-cmd.h gets merged into drivers/bus/fsl-mc/fsl-mc-private.h, next to the other internally used APIs - dpbp.h gets merged into include/linux/fsl/mc.h,

[PATCH 3/3] staging: fsl-mc: Move DPCON out of staging

Move the source files out of staging into their final locations: - dpcon.c goes to drivers/bus/fsl-mc/, next to the core infrastructure - dpcon-cmd.h gets merged into drivers/bus/fsl-mc/fsl-mc-private.h, next to the other internally used APIs - dpcon.h gets merged into include/linux/fsl/mc.h,

[PATCH 1/3] staging: fsl-mc: Cleanup dpbp and dpcon API

Some functions and associated structures are not used by current code, so remove them. Signed-off-by: Bogdan Purcareata --- drivers/staging/fsl-mc/bus/dpbp-cmd.h | 10 -- drivers/staging/fsl-mc/bus/dpbp.c | 67 ---

[PATCH 0/3] staging: fsl-mc: Move DPBP and DPCON out of staging

Commit 6bd067c48ef ("staging: fsl-mc: Move core bus out of staging") moves the fsl-mc bus driver infrastructure out of staging to drivers/bus/fsl-mc. The next step is moving a couple of tightly connected DPAA2 objects - DPBP (Data Path Buffer Pool) and DPCON (Data Path Concentrator). Patch 1

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

On Thu, Mar 1, 2018 at 1:27 PM, Philipp Zabel wrote: > Oh, this only works for csi ports that have pinctrl in their csi port > node, like: > > _csi0 { > pinctrl-names = "default"; > pinctrl-0 = <_ipu1_csi0>; > }; This is the case for imx6qdl-sabresd.dtsi

Re: [PATCH 4/4] staging: fsl-dpaa2/eth: allow the driver to compile multi-arch

On Mon, Feb 26, 2018 at 10:28:07AM -0600, Ioana Radulescu wrote: > Drop dependency on ARCH_LAYERSCAPE (which in turn depends on ARM64), > thus allowing this driver to compile on all architectures supported > by the fsl-mc bus driver. > > This was compile tested on: > - powerpc

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

On Thu, 2018-03-01 at 13:02 -0300, Fabio Estevam wrote: > On Thu, Mar 1, 2018 at 1:09 AM, Gustavo A. R. Silva > wrote: > > Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. > > The proper pointer to be passed as argument is pinctrl > > instead of priv->vdev. > > > >

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

Steve, Phiipp, On Thu, Mar 1, 2018 at 1:02 PM, Fabio Estevam wrote: > So imx_csi_probe() does not succeed anymore since > devm_pinctrl_get_select_default() always fails. > > Not sure I understand the comments that explain the need for pinctrl > handling inside the driver. >

Re: [PATCH] drivers:staging: Fix alignment warnings reported by tool

On Sat, Feb 24, 2018 at 11:22:40PM +0530, umesh.freela...@gmail.com wrote: > From: Umesh3034 > > Fix alignment warnings reported by checkpatch.pl > > Signed-off-by: Umesh3034 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You

Re: [PATCH 2/4] staging: most: Replace calls to BUG_ON() with WARN_ONCE() and return.

On Fri, Feb 23, 2018 at 11:58:33PM -0800, Quytelda Kahja wrote: > Replace calls to BUG_ON() used to check for NULL pointers with WARN_ONCE() > followed by a return. Are you sure this will work? > > Signed-off-by: Quytelda Kahja > --- > drivers/staging/most/core.c | 13

Re: [PATCH 1/4] staging: most: Fix coding style problems.

On Fri, Feb 23, 2018 at 11:58:32PM -0800, Quytelda Kahja wrote: > Makes two very minor changes indicated by checkpatch: > 1) Add a newline after components_show() definition. > 2) Fix a line over the 80 character limit. Do not do multiple things in the same patch, whenever possible. Please break

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

On Thu, Mar 1, 2018 at 1:09 AM, Gustavo A. R. Silva wrote: > Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. > The proper pointer to be passed as argument is pinctrl > instead of priv->vdev. > > This issue was detected with the help of Coccinelle. > > Fixes:

Re: [PATCH 2/2] staging: rts5208: rename SG_END macro

On Thu, Mar 1, 2018 at 12:31 PM, Arnd Bergmann wrote: > A change to the generic scatterlist code caused a conflict with > the rtsx card reader driver: > > In file included from drivers/staging/rts5208/rtsx.h:180, > from drivers/staging/rts5208/rtsx.c:28: >

Re: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'.

On Thu, Mar 01, 2018 at 05:37:21PM +1100, Tobin C. Harding wrote: > On Wed, Feb 28, 2018 at 09:19:09PM -0800, Quytelda Kahja wrote: > > The code that generates a WLAN capability mask is repeated in five > > functions. This change refactors that code into a new function, which is > > called now in

[PATCH 2/2] staging: rts5208: rename SG_END macro

A change to the generic scatterlist code caused a conflict with the rtsx card reader driver: In file included from drivers/staging/rts5208/rtsx.h:180, from drivers/staging/rts5208/rtsx.c:28: drivers/staging/rts5208/rtsx_chip.h:343: error: "SG_END" redefined [-Werror] This

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

On Wed, 2018-02-28 at 22:09 -0600, Gustavo A. R. Silva wrote: > Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. > The proper pointer to be passed as argument is pinctrl > instead of priv->vdev. > > This issue was detected with the help of Coccinelle. > > Fixes: 52e17089d185 ("media: imx: