Re: [PATCH net-next,0/2] hv_netvsc: Fix/improve RX path error handling

2018-03-25 Thread David Miller
From: Haiyang Zhang Date: Thu, 22 Mar 2018 12:01:12 -0700 > Fix the status code returned to the host. Also add range > check for rx packet offset and length. Series applied, thank you. ___ devel mailing list

Re: meter ABI: (was Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR)

2018-03-25 Thread John Syne
> On Mar 25, 2018, at 9:54 AM, Jonathan Cameron wrote: > > On Sun, 25 Mar 2018 01:29:41 -0700 > John Syne wrote: > >> Hi Jonathan, > Hi John, > > Please wrap your normal emails (excepting tables) to 80 chars. Yeah, I’m trying to do that, but I use a Mac

Re: meter ABI: (was Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR)

2018-03-25 Thread John Syne
> > On Mar 25, 2018, at 9:44 AM, Jonathan Cameron wrote: > > On Sat, 24 Mar 2018 16:06:17 -0700 > John Syne wrote: > > This thread is becoming unmanageable so I am cropping this down to just > the questions that remain open. > Probably easier to

Re: meter ABI: (was Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR)

2018-03-25 Thread John Syne
> On Mar 25, 2018, at 9:44 AM, Jonathan Cameron wrote: > > On Sat, 24 Mar 2018 16:06:17 -0700 > John Syne wrote: > > This thread is becoming unmanageable so I am cropping this down to just > the questions that remain open. > Probably easier to copy

Re: meter ABI: (was Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR)

2018-03-25 Thread John Syne
> On Mar 25, 2018, at 9:29 AM, Jonathan Cameron wrote: > > On Sat, 24 Mar 2018 15:45:21 -0700 > John Syne wrote: > >>> On Mar 24, 2018, at 8:02 AM, Jonathan Cameron wrote: >>> >>> On Mon, 19 Mar 2018 22:57:16 -0700 >>> John Syne

Re: [PATCH 4/4] staging: iio: tsl2x7x: move out of staging

2018-03-25 Thread Jonathan Cameron
On Sat, 24 Mar 2018 16:05:55 -0400 Brian Masney wrote: > Move the tsl2x7x driver out of staging and into mainline. > > Signed-off-by: Brian Masney Various comments inline. I'm wondering if we should rename the driver before moving it. The wild

Re: [PATCH 3/4] staging: iio: tsl2x7x: use either direction for IIO_EV_INFO_{ENABLE,PERIOD}

2018-03-25 Thread Jonathan Cameron
On Sat, 24 Mar 2018 16:05:54 -0400 Brian Masney wrote: > The events IIO_EV_INFO_VALUE and IIO_EV_INFO_ENABLE currently have a > falling and rising direction configured. There does not need to be a > separate distinction so this patch changes these to use the > either

Re: [PATCH 2/4] staging: iio: tsl2x7x: move IIO_CHAN_INFO_CALIB{SCALE,BIAS} to IIO_LIGHT channel

2018-03-25 Thread Jonathan Cameron
On Sat, 24 Mar 2018 16:05:53 -0400 Brian Masney wrote: > The IIO_CHAN_INFO_CALIBSCALE and IIO_CHAN_INFO_CALIBBIAS masks are > currently associated with the IIO_INTENSITY channel but should be > associated with the IIO_LIGHT channel since these values are used to >

Re: [PATCH 1/4] staging: iio: tsl2x7x: use auto increment I2C protocol

2018-03-25 Thread Jonathan Cameron
On Sat, 24 Mar 2018 16:05:52 -0400 Brian Masney wrote: > The hardware supports 16-bit ALS and proximity readings, however the > datasheet recommends using the I2C auto increment protocol so that the > correct high and low bytes are read even if the integration cycle ends >

[PATCH][V3] staging: r8822be: fix typos in header guard macros

2018-03-25 Thread Colin King
From: Colin Ian King The macros for __PHYDMKFREE_H__ and __PHYDM_FEATURES_H__ contain typos and don't match the #if guard check. Defined them correctly. Cleans up clang warnings: warning: '__PHYDMKFREE_H__' is used as a header guard here, followed by #define of a

Re: meter ABI: (was Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR)

2018-03-25 Thread Jonathan Cameron
On Sat, 24 Mar 2018 16:06:17 -0700 John Syne wrote: This thread is becoming unmanageable so I am cropping this down to just the questions that remain open. > >> Probably easier to copy and paste this table into a spreadsheet. Let me > >> know if there is anything I got

Re: meter ABI: (was Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR)

2018-03-25 Thread Jonathan Cameron
On Sat, 24 Mar 2018 15:45:21 -0700 John Syne wrote: > > On Mar 24, 2018, at 8:02 AM, Jonathan Cameron wrote: > > > > On Mon, 19 Mar 2018 22:57:16 -0700 > > John Syne wrote: > > > >> Hi Jonathan, > >> > >> Thank you for all your

Re: [PATCH] staging: pi433: add descriptions for mutex locks

2018-03-25 Thread Valentin Vidic
On Sun, Mar 25, 2018 at 03:12:52PM +0200, Marcus Wolf wrote: > I am not at home the next two weeks. So I can do a codereading on > Easter, but testing will not take place earlier then mid/end of April :-( > > If you are interested, I can provide you an engineering sample of Pi433. Sure, let me

Re: [PATCH v4] staging: bcm2835-audio: Release resources on module_exit()

2018-03-25 Thread Kirill Marinushkin
On 03/25/18 15:03, Andy Shevchenko wrote: > On Sun, Mar 25, 2018 at 1:44 PM, Kirill Marinushkin > wrote: >> On 03/25/18 12:33, Andy Shevchenko wrote: >>> On Fri, Mar 23, 2018 at 9:22 PM, Kirill Marinushkin >>> wrote: On 03/23/18 17:23, Andy

Re: [PATCH] staging: pi433: add descriptions for mutex locks

2018-03-25 Thread Marcus Wolf
Hi Valentin, I am not at home the next two weeks. So I can do a codereading on Easter, but testing will not take place earlier then mid/end of April :-( If you are interested, I can provide you an engineering sample of Pi433. Cheers, Marcus Am 25.03.2018 um 15:09 schrieb Valentin Vidic: > On

Re: [PATCH] staging: pi433: add descriptions for mutex locks

2018-03-25 Thread Valentin Vidic
On Sun, Mar 25, 2018 at 03:00:09PM +0200, Marcus Wolf wrote: > Unfortunaly I can't find the time to have a closer look on the code this > weekend - still busy with tax stuff :-( > > Idea sounds great. I'll try to look at the code and think about it > during Easter hollidays. No problem, there is

Re: [PATCH v4] staging: bcm2835-audio: Release resources on module_exit()

2018-03-25 Thread Andy Shevchenko
On Sun, Mar 25, 2018 at 1:44 PM, Kirill Marinushkin wrote: > On 03/25/18 12:33, Andy Shevchenko wrote: >> On Fri, Mar 23, 2018 at 9:22 PM, Kirill Marinushkin >> wrote: >>> On 03/23/18 17:23, Andy Shevchenko wrote: After addressing above,

Re: [PATCH] staging: pi433: add descriptions for mutex locks

2018-03-25 Thread Marcus Wolf
Hi Valentin, > But I have an idea to remove this kfifo_reset call in pi433_write > handling partial message writes: > > kfifo_reset(>tx_fifo); // TODO: maybe find a solution, not to > discard already stored, valid entries > > The writer could acquire the lock and than use kfifo_avail to

Re: [PATCH][next][V2] staging: r8822be: fix typos in header guard macros

2018-03-25 Thread Greg Kroah-Hartman
On Fri, Mar 23, 2018 at 06:00:18PM +, Colin King wrote: > From: Colin Ian King > > The macros for __PHYDMKFREE_H__ and __PHYDM_FEATURES_H__ contain > typos and don't match the #if guard check. Defined them correctly. > > Cleans up clang warnings: > warning:

Re: [PATCH v4] staging: bcm2835-audio: Release resources on module_exit()

2018-03-25 Thread Kirill Marinushkin
On 03/25/18 12:33, Andy Shevchenko wrote: > On Fri, Mar 23, 2018 at 9:22 PM, Kirill Marinushkin > wrote: >> On 03/23/18 17:23, Andy Shevchenko wrote: >>> After addressing above, FWIW, >>> >>> Reviewed-by: Andy Shevchenko > Seems you missed my

Re: [PATCH v5] staging: bcm2835-audio: Release resources on module_exit()

2018-03-25 Thread Andy Shevchenko
On Fri, Mar 23, 2018 at 9:32 PM, Kirill Marinushkin wrote: > In the current implementation, `rmmod snd_bcm2835` does not release > resources properly. It causes an oops when trying to list sound devices. > > This commit fixes it. > > The details WRT allocation / free are

Re: [PATCH v4] staging: bcm2835-audio: Release resources on module_exit()

2018-03-25 Thread Andy Shevchenko
On Fri, Mar 23, 2018 at 9:22 PM, Kirill Marinushkin wrote: > On 03/23/18 17:23, Andy Shevchenko wrote: >> After addressing above, FWIW, >> >> Reviewed-by: Andy Shevchenko Seems you missed my tag in new version. When someone gives you a tag

Re: meter ABI: (was Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR)

2018-03-25 Thread John Syne
Hi Jonathan, I was speaking with Rodrigo and here is what I think must be done to move ADE7878 out of staging Here are the steps as I see them: 1) Define the IIO Attributes so they are consistent with the IIO ABI. This should be pretty simple given agreement on the naming convention. 2) Map

Re: meter ABI: (was Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR)

2018-03-25 Thread John Syne
> On Mar 24, 2018, at 8:18 AM, Jonathan Cameron wrote: > > On Mon, 19 Mar 2018 23:28:45 -0700 > John Syne wrote: > >> Hi Jonathan, >> >> I broke out the {Direction}_{Type}_{Index}_{Modifier}_{Info_Mask} into >> separate columns to make sure I understand

Re: meter ABI: (was Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR)

2018-03-25 Thread John Syne
Hi Jonathan, I have attached a CSV version of this table below. Hopefully that will make things easier for you. RegisterIIO Attribute Device Tree or Code Direction type Index ModifierInfo Mask AIGAIN in_current0_phaseA_scalein current 0