Re: [greybus-dev] [PATCH 47/61] staging: greybus: simplify getting .drvdata

On 19-04-18, 16:06, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang > --- > > Build tested only. buildbot is happy. Please apply

[Patch v2] Storvsc: Select channel based on available percentage of ring buffer to write

From: Long Li This is a best effort for estimating on how busy the ring buffer is for that channel, based on available buffer to write in percentage. It is still possible that at the time of actual ring buffer write, the space may not be available due to other processes may

Re: KASAN: use-after-free Read in binder_release_work

On Tue, Apr 03, 2018 at 08:02:02PM -0700, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > f2d285669aae656dfeafa0bf25e86bbbc5d22329 (Tue Apr 3 17:45:39 2018 +) > Merge tag 'pm-4.17-rc1' of > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm > syzbot

Re: simplify procfs code for seq_file instances

> git://git.infradead.org/users/hch/misc.git proc_create I want to ask if it is time to start using poorman function overloading with _b_c_e(). There are millions of allocation functions for example, all slightly difference, and people will add more. Seeing /proc interfaces doubled like this

Re: [PATCH 03/39] proc: introduce proc_create_seq_private

On Thu, Apr 19, 2018 at 02:41:04PM +0200, Christoph Hellwig wrote: > Variant of proc_create_data that directly take a struct seq_operations > --- a/fs/proc/internal.h > +++ b/fs/proc/internal.h > @@ -45,6 +45,7 @@ struct proc_dir_entry { > const struct inode_operations *proc_iops; >

Re: [PATCH 14/39] proc: introduce proc_create_net_single

On Thu, Apr 19, 2018 at 02:41:15PM +0200, Christoph Hellwig wrote: > Variant of proc_create_data that directly take a seq_file show > +struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode, > + struct proc_dir_entry *parent, > + int (*show)(struct

Re: [PATCH 02/39] proc: introduce proc_create_seq{,_data}

On Thu, Apr 19, 2018 at 02:41:03PM +0200, Christoph Hellwig wrote: > Variants of proc_create{,_data} that directly take a struct seq_operations > argument and drastically reduces the boilerplate code in the callers. > +static int proc_seq_open(struct inode *inode, struct file *file) > +{ > +

Re: [PATCH v3 15/20] net: Remove depends on HAS_DMA in case of platform dependency

(adding linux-wireless) Geert Uytterhoeven writes: > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". > In most cases this other symbol is an architecture or platform specific >

Re: [PATCH 16/39] ipmi: simplify procfs code

On 04/19/2018 07:41 AM, Christoph Hellwig wrote: Use remove_proc_subtree to remove the whole subtree on cleanup instead of a hand rolled list of proc entries, unwind the registration loop into individual calls. Switch to use proc_create_single to further simplify the code. I'm yanking all the

RE: [PATCH v4 02/13] dt-bindings: usb: add documentation for typec port controller(TCPCI)

> -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: 2018年4月16日 22:28 > To: Jun Li > Cc: gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com; > li...@roeck-us.net; a.ha...@samsung.com; shufan_...@richtek.com; Peter > Chen ;

Re: [PATCH 07/15] media: staging/imx: add 10 bit bayer support

Hi Philip, Thanks for the review. On Thu 19 Apr 2018 at 13:38, Philipp Zabel wrote: On Thu, 2018-04-19 at 11:18 +0100, Rui Miguel Silva wrote: Some sensors can only output 10 bit bayer formats, like the OV2680. Add support for that in imx-media. Signed-off-by: Rui Miguel Silva

Re: [PATCH 03/39] proc: introduce proc_create_seq_private

On Thu, Apr 19, 2018 at 02:41:04PM +0200, Christoph Hellwig wrote: > diff --git a/drivers/s390/cio/blacklist.c b/drivers/s390/cio/blacklist.c > index 2a3f874a21d5..ad35cddcf6af 100644 > --- a/drivers/s390/cio/blacklist.c > +++ b/drivers/s390/cio/blacklist.c > @@ -391,28 +391,15 @@ static const

[PATCH 48/61] staging: iio: adc: simplify getting .drvdata

We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. Please apply individually. drivers/staging/iio/adc/ad7606_par.c | 6 ++

[PATCH 47/61] staging: greybus: simplify getting .drvdata

We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. Please apply individually. drivers/staging/greybus/arche-platform.c | 3 +--

[PATCH 00/61] tree-wide: simplify getting .drvdata

I got tired of fixing this in Renesas drivers manually, so I took the big hammer. Remove this cumbersome code pattern which got copy-pasted too much already: - struct platform_device *pdev = to_platform_device(dev); - struct ep93xx_keypad *keypad = platform_get_drvdata(pdev); +

[PATCH 49/61] staging: nvec: simplify getting .drvdata

We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. Please apply individually. drivers/staging/nvec/nvec.c | 6 ++ 1 file

Re: [cfs_trace_lock_tcd] BUG: KASAN: null-ptr-deref in cfs_trace_lock_tcd+0x25/0xeb

On 04/19/2018 04:35 PM, Andrey Ryabinin wrote: > > > On 04/18/2018 09:37 PM, Linus Torvalds wrote: >> Ugh, that lustre code is disgusting. >> >> I thought we were getting rid of it. >> >> Anyway, I started looking at why the stack trace is such an incredible >> mess, with lots of stale

Re: [PATCH 05/15] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

Hi Dan, On Thu 19 Apr 2018 at 12:45, Dan Carpenter wrote: +static int mipi_csis_clk_get(struct csi_state *state) +{ + struct device *dev = >pdev->dev; + int ret = true; Better to leave ret unitialized. ack. + + state->mipi_clk = devm_clk_get(dev, "mipi"); + if

Re: [PATCH 02/15] media: staging/imx7: add imx7 CSI subdev driver

Hi, On Thu 19 Apr 2018 at 12:22, Dan Carpenter wrote: On Thu, Apr 19, 2018 at 11:17:59AM +0100, Rui Miguel Silva wrote: +static int imx7_csi_link_setup(struct media_entity *entity, + const struct media_pad *local, + const struct media_pad *remote, u32

Re: [PATCH 01/15] media: staging/imx: add support to media dev for no IPU systems

Hi Dan, Thanks for this and the other reviews. On Thu 19 Apr 2018 at 12:06, Dan Carpenter wrote: On Thu, Apr 19, 2018 at 11:17:58AM +0100, Rui Miguel Silva wrote: Some i.MX SoC do not have IPU, like the i.MX7, add to the the media device infrastructure support to be used in this type of

Re: [cfs_trace_lock_tcd] BUG: KASAN: null-ptr-deref in cfs_trace_lock_tcd+0x25/0xeb

On 04/18/2018 09:37 PM, Linus Torvalds wrote: > Ugh, that lustre code is disgusting. > > I thought we were getting rid of it. > > Anyway, I started looking at why the stack trace is such an incredible > mess, with lots of stale entries. > > The reason (well, _one_ reason) seems to be

Re: [PATCH 07/15] media: staging/imx: add 10 bit bayer support

On Thu, 2018-04-19 at 11:18 +0100, Rui Miguel Silva wrote: > Some sensors can only output 10 bit bayer formats, like the OV2680. Add > support > for that in imx-media. > > Signed-off-by: Rui Miguel Silva > --- > drivers/staging/media/imx/imx-media-utils.c | 24

Re: [PATCH v3 13/20] mmc: Remove depends on HAS_DMA in case of platform dependency

On 17 April 2018 at 19:49, Geert Uytterhoeven wrote: > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". > In most cases this other symbol is an architecture or platform specific >

Re: [PATCH 26/39] rtc/proc: switch to proc_create_single_data

On 19/04/2018 14:41:27+0200, Christoph Hellwig wrote: > And stop trying to get a reference on the submodule, procfs code deals > with release after and unloaded module and thus removed proc entry. > Are you sure about that? The rtc module is not the one adding the procfs file so I'm not sure how

[PATCH 26/39] rtc/proc: switch to proc_create_single_data

And stop trying to get a reference on the submodule, procfs code deals with release after and unloaded module and thus removed proc entry. Signed-off-by: Christoph Hellwig --- drivers/rtc/rtc-proc.c | 33 ++--- 1 file changed, 2 insertions(+), 31

[PATCH 30/39] netfilter/xt_hashlimit: switch to proc_create_{seq, single}_data

And use proc private data directly instead of doing a detour through seq->private. Signed-off-by: Christoph Hellwig --- net/netfilter/xt_hashlimit.c | 92 +++- 1 file changed, 18 insertions(+), 74 deletions(-) diff --git

[PATCH 12/39] net: move seq_file_single_net to

This helper deals with single_{open,release}_net internals and thus belongs here. Signed-off-by: Christoph Hellwig --- include/linux/seq_file_net.h | 13 + include/net/ip_vs.h | 12 2 files changed, 13 insertions(+), 12 deletions(-) diff --git

[PATCH 39/39] tty: replace ->proc_fops with ->proc_show

Just set up the show callback in the tty_operations, and use proc_create_single_data to create the file without additional boilerplace code. Signed-off-by: Christoph Hellwig --- arch/ia64/hp/sim/simserial.c| 15 +-- arch/xtensa/platforms/iss/console.c | 15

[PATCH 38/39] ide: replace ->proc_fops with ->proc_show

Just set up the show callback in the tty_operations, and use proc_create_single_data to create the file without additional boilerplace code. Signed-off-by: Christoph Hellwig --- drivers/ide/ide-cd.c | 15 +--- drivers/ide/ide-disk_proc.c | 62 ++--

[PATCH 13/39] proc: introduce proc_create_net{,_data}

Variants of proc_create{,_data} that directly take a struct seq_operations and deal with network namespaces in ->open and ->release. All callers of proc_create + seq_open_net converted over, and seq_{open,release}_net are removed entirely. Signed-off-by: Christoph Hellwig ---

[PATCH 19/39] sg: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- drivers/scsi/sg.c | 124 +- 1

[PATCH 36/39] proc: don't detour through seq->private to get the inode

Signed-off-by: Christoph Hellwig --- fs/proc/array.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/fs/proc/array.c b/fs/proc/array.c index ae2c807fd719..b34796b562ef 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c @@ -677,7 +677,7 @@

[PATCH 21/39] ext4: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- fs/ext4/ext4.h| 2 +- fs/ext4/mballoc.c | 29

[PATCH 28/39] hostap: switch to proc_create_{seq,single}_data

And use proc private data directly instead of doing a detour through seq->private. Signed-off-by: Christoph Hellwig --- .../net/wireless/intersil/hostap/hostap_ap.c | 70 ++--- .../net/wireless/intersil/hostap/hostap_hw.c | 17 +-- .../wireless/intersil/hostap/hostap_proc.c

[PATCH 25/39] drbd: switch to proc_create_single

And stop messing with try_module_get on THIS_MODULE, which doesn't make any sense here. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_int.h | 2 +- drivers/block/drbd/drbd_main.c | 3 ++- drivers/block/drbd/drbd_proc.c | 34 +- 3

[PATCH 34/39] atm: switch to proc_create_seq_private

And remove proc boilerplate code. Signed-off-by: Christoph Hellwig --- net/atm/proc.c | 72 +- 1 file changed, 13 insertions(+), 59 deletions(-) diff --git a/net/atm/proc.c b/net/atm/proc.c index f272b0f59d82..0b0495a41bbe 100644 ---

[PATCH 17/39] sgi-gru: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- drivers/misc/sgi-gru/gruprocfs.c | 81 ++-- 1

[PATCH 37/39] ide: remove ide_driver_proc_write

The driver proc file hasn't been writeable for a long time, so this is just dead code. Signed-off-by: Christoph Hellwig --- drivers/ide/ide-proc.c | 46 -- 1 file changed, 46 deletions(-) diff --git a/drivers/ide/ide-proc.c

[PATCH 01/39] net/can: single_open_net needs to be paired with single_release_net

Otherwise we will leak a reference to the network namespace. Signed-off-by: Christoph Hellwig --- net/can/bcm.c | 2 +- net/can/proc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/can/bcm.c b/net/can/bcm.c index ac5e5e34fee3..8073fa14e143 100644

[PATCH 07/39] ipv{4,6}/ping: simplify proc file creation

Remove the pointless ping_seq_afinfo indirection and make the code look like most other protocols. Signed-off-by: Christoph Hellwig --- include/net/ping.h | 11 -- net/ipv4/ping.c| 50 +- net/ipv6/ping.c| 35

[PATCH 33/39] atm: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- net/atm/proc.c | 65 ++ 1

[PATCH 04/39] proc: introduce proc_create_single{,_data}

Variants of proc_create{,_data} that directly take a seq_file show callback and drastically reduces the boilerplate code in the callers. All trivial callers converted over. Signed-off-by: Christoph Hellwig --- arch/arm/kernel/dma.c | 14 +---

[PATCH 02/39] proc: introduce proc_create_seq{,_data}

Variants of proc_create{,_data} that directly take a struct seq_operations argument and drastically reduces the boilerplate code in the callers. All trivial callers converted over. Signed-off-by: Christoph Hellwig --- arch/ia64/hp/common/sba_iommu.c | 15 +-

[PATCH 31/39] netfilter/x_tables: switch to proc_create_seq_private

And remove proc boilerplate code. Signed-off-by: Christoph Hellwig --- net/netfilter/x_tables.c | 42 ++-- 1 file changed, 6 insertions(+), 36 deletions(-) diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c index

[PATCH 18/39] megaraid: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_single. Signed-off-by: Christoph Hellwig --- drivers/scsi/megaraid.c | 140 +++-

[PATCH 24/39] resource: switch to proc_create_seq_data

And use the root resource directly from the proc private data. Signed-off-by: Christoph Hellwig --- kernel/resource.c | 43 +-- 1 file changed, 5 insertions(+), 38 deletions(-) diff --git a/kernel/resource.c b/kernel/resource.c index

[PATCH 23/39] staging/rtl8192u: simplify procfs code

Unwind the registration loop into individual calls. Switch to use proc_create_single where applicable. Signed-off-by: Christoph Hellwig --- drivers/staging/rtl8192u/r8192U_core.c | 67 ++ 1 file changed, 14 insertions(+), 53 deletions(-) diff --git

[PATCH 15/39] acpi/battery: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- drivers/acpi/battery.c | 121 + 1

[PATCH 29/39] neigh: switch to proc_create_seq_data

And use proc private data directly instead of doing a detour through seq->private. Signed-off-by: Christoph Hellwig --- net/core/neighbour.c | 31 ++- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/net/core/neighbour.c

[PATCH 16/39] ipmi: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup instead of a hand rolled list of proc entries, unwind the registration loop into individual calls. Switch to use proc_create_single to further simplify the code. Signed-off-by: Christoph Hellwig ---

[PATCH 05/39] ipv{4,6}/udp{,lite}: simplify proc registration

Remove a couple indirections to make the code look like most other protocols. Signed-off-by: Christoph Hellwig --- include/net/udp.h | 20 -- net/ipv4/udp.c | 99 +- net/ipv4/udplite.c | 21 +++--- net/ipv6/udp.c | 30

[PATCH 20/39] afs: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- fs/afs/proc.c | 134 ++ 1

[PATCH 22/39] jfs: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- fs/jfs/jfs_debug.c| 43 ++-

[PATCH 11/39] netfilter/x_tables: simplify ѕeq_file code

Just use the address family from the proc private data instead of copying it into per-file data. Signed-off-by: Christoph Hellwig --- net/netfilter/x_tables.c | 39 +++ 1 file changed, 11 insertions(+), 28 deletions(-) diff --git

[PATCH 14/39] proc: introduce proc_create_net_single

Variant of proc_create_data that directly take a seq_file show callback and deals with network namespaces in ->open and ->release. All callers of proc_create + single_open_net converted over, and single_{open,release}_net are removed entirely. Signed-off-by: Christoph Hellwig ---

simplify procfs code for seq_file instances

We currently have hundreds of proc files that implement plain, read-only seq_file based interfaces. This series consolidates them using new procfs helpers that take the seq_operations or simple show callback directly. A git tree is available at: git://git.infradead.org/users/hch/misc.git

[PATCH 35/39] isdn: replace ->proc_fops with ->proc_show

And switch to proc_create_single_data. Signed-off-by: Christoph Hellwig --- drivers/isdn/capi/kcapi.c | 3 ++- drivers/isdn/gigaset/capi.c| 16 +--- drivers/isdn/hardware/avm/avmcard.h| 4 ++-- drivers/isdn/hardware/avm/b1.c | 17

[PATCH 32/39] bluetooth: switch to proc_create_seq_data

And use proc private data directly instead of doing a detour through seq->private and private state. Signed-off-by: Christoph Hellwig --- net/bluetooth/af_bluetooth.c | 40 +--- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git

[PATCH 27/39] bonding: switch to proc_create_seq_data

And use proc private data directly instead of doing a detour through seq->private. Signed-off-by: Christoph Hellwig --- drivers/net/bonding/bond_procfs.c | 36 ++- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git

[PATCH 03/39] proc: introduce proc_create_seq_private

Variant of proc_create_data that directly take a struct seq_operations argument + a private state size and drastically reduces the boilerplate code in the callers. All trivial callers converted over. Signed-off-by: Christoph Hellwig --- drivers/s390/cio/blacklist.c | 21

[PATCH 08/39] ipv{4, 6}/raw: simplify ѕeq_file code

Pass the hashtable to the proc private data instead of copying it into the per-file private data. Signed-off-by: Christoph Hellwig --- include/net/raw.h | 4 net/ipv4/raw.c| 36 net/ipv6/raw.c| 6 -- 3 files changed, 16

[PATCH 09/39] ipv6/flowlabel: simplify pid namespace lookup

The shole seq_file sequence already operates under a single RCU lock pair, so move the pid namespace lookup into it, and stop grabbing a reference and remove all kinds of boilerplate code. Signed-off-by: Christoph Hellwig --- net/ipv6/ip6_flowlabel.c | 28

[PATCH 06/39] ipv{4,6}/tcp: simplify procfs registration

Avoid most of the afinfo indirections and just call the proc helpers directly. Signed-off-by: Christoph Hellwig --- include/net/tcp.h | 11 ++ net/ipv4/tcp_ipv4.c | 85 + net/ipv6/tcp_ipv6.c | 27 +- 3 files changed, 53

[PATCH 10/39] net/kcm: simplify proc registration

Remove a couple indirections to make the code look like most other protocols. Signed-off-by: Christoph Hellwig --- net/kcm/kcmproc.c | 71 --- 1 file changed, 17 insertions(+), 54 deletions(-) diff --git a/net/kcm/kcmproc.c

Re: [PATCH 20/39] afs: simplify procfs code

Christoph Hellwig wrote: > Use remove_proc_subtree to remove the whole subtree on cleanup, and > unwind the registration loop into individual calls. Switch to use > proc_create_seq where applicable. Note that this is likely going to clash with my patch to net-namespace all of the

Re: [PATCH 05/15] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

> +static int mipi_csis_clk_get(struct csi_state *state) > +{ > + struct device *dev = >pdev->dev; > + int ret = true; Better to leave ret unitialized. > + > + state->mipi_clk = devm_clk_get(dev, "mipi"); > + if (IS_ERR(state->mipi_clk)) { > + dev_err(dev, "Could not

Re: [PATCH 02/15] media: staging/imx7: add imx7 CSI subdev driver

On Thu, Apr 19, 2018 at 11:17:59AM +0100, Rui Miguel Silva wrote: > +static int imx7_csi_link_setup(struct media_entity *entity, > +const struct media_pad *local, > +const struct media_pad *remote, u32 flags) > +{ > + struct v4l2_subdev

Re: [PATCH 01/15] media: staging/imx: add support to media dev for no IPU systems

On Thu, Apr 19, 2018 at 11:17:58AM +0100, Rui Miguel Silva wrote: > Some i.MX SoC do not have IPU, like the i.MX7, add to the the media device > infrastructure support to be used in this type of systems that do not have > internal subdevices besides the CSI. > > Signed-off-by: Rui Miguel Silva

Re: [PATCH 7/9] staging: nvec: Augment TODO file with GPIO work item

Hi Linus, Am Donnerstag, 19. April 2018, 10:41:19 CEST schrieb Linus Walleij: > To make sure that this driver does not leave staging before it > is properly converted to use the new GPIO descriptor API, > augment the TODO file with this work item. I just sent a patch to convert it. Thanks for

[PATCH 2/2] staging: nvec: convert to use GPIO descriptors

Use GPIO descriptors instead of relying on the old method. Cc: Linus Walleij Signed-off-by: Marc Dietrich --- This obsolets the ToDo reminder sent by Linus a few hours ago. --- drivers/staging/nvec/nvec.c | 42 +

[PATCH 1/2] staging: nvec: cleanup use of dev in probe function

This cleanups the probe function a bit by using a dev variable instead of Signed-off-by: Marc Dietrich --- drivers/staging/nvec/nvec.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/staging/nvec/nvec.c

Re: [PATCH 1/2] staging: fsl-dpaa2/rtc: add rtc driver

On Thu, Apr 19, 2018 at 04:31:36PM +0800, Yangbo Lu wrote: > +int dprtc_open(struct fsl_mc_io *mc_io, > +u32 cmd_flags, > +int dprtc_id, > +u16 *token) > +{ > + struct dprtc_cmd_open *cmd_params; > + struct fsl_mc_command cmd = { 0 }; > + int err; >

Re: [PATCH v2] staging: pi433: cleanup tx_fifo locking

Reviewed-by: Marcus Wolf Am 19.04.2018 um 12:25 schrieb Valentin Vidic: > pi433_write requires locking due to multiple writers. After acquiring > the lock check if enough free space is available in the kfifo to write > the whole message. This check should

[PATCH 09/15] media: dt-bindings: add bindings for i.MX7 media driver

Add bindings documentation for i.MX7 media drivers. Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/imx7.txt| 158 ++ 1 file changed, 158 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx7.txt diff

[PATCH 14/15] media: imx7.rst: add documentation for i.MX7 media driver

Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva --- Documentation/media/v4l-drivers/imx7.rst | 157 ++

[PATCH 02/15] media: staging/imx7: add imx7 CSI subdev driver

This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 +

[PATCH v2] staging: pi433: cleanup tx_fifo locking

pi433_write requires locking due to multiple writers. After acquiring the lock check if enough free space is available in the kfifo to write the whole message. This check should prevent partial writes to tx_fifo so kfifo_reset is not needed anymore. pi433_tx_thread is the only reader so it does

[PATCH 01/15] media: staging/imx: add support to media dev for no IPU systems

Some i.MX SoC do not have IPU, like the i.MX7, add to the the media device infrastructure support to be used in this type of systems that do not have internal subdevices besides the CSI. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx-media-dev.c|

[PATCH 05/15] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1154 2 files changed, 1155

[PATCH 11/15] ARM: dts: imx7s: add multiplexer controls

The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 9 - 1 file

[PATCH 12/15] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Also add the pin control related with the mipi_csi in that board. Signed-off-by: Rui Miguel Silva

[PATCH 06/15] media: staging/imx: add imx7 capture subsystem

Add imx7 capture subsystem to imx-media core to allow the use some of the existing modules for i.MX5/6 with i.MX7 SoC. Since i.MX7 does not have an IPU set the no_ipu_present flag to differentiate some runtime behaviors. Signed-off-by: Rui Miguel Silva ---

[PATCH 00/15] media: staging/imx7: add i.MX7 media driver

*** BLURB HERE *** Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an IPU and because of that some changes in the imx media core are made along this series to make it

[PATCH 13/15] ARM: dts: imx7s: add capture subsystem

Add media capture subsystem device to i.MX7 definitions. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 6b49b73053f9..333d9fe6b989

[PATCH 15/15] media: staging/imx: add i.MX7 entries to TODO file

Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324

[PATCH 04/15] clk: imx7d: reset parent for mipi csi root

To guarantee that we do not get Overflow in image FIFO the outer bandwidth has to be faster than inputer bandwidth. For that it must be possible to set a faster frequency clock. So set new parent to sys_pfd3 clock for the mipi csi block. Signed-off-by: Rui Miguel Silva ---

[PATCH 10/15] ARM: dts: imx7s: add mipi phy power domain

Add power domain index 0 related with mipi-phy to imx7s. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 142ea709d296..d913c3f9c284

[PATCH 03/15] clk: imx7d: fix mipi dphy div parent

Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a orphan clock and set the correct parent. before: cat clk_orphan_summary enable prepare protect clock countcountcountrate accuracy phase

[PATCH 08/15] ARM: dts: increase default cma size to 40MB

To support camera in i.MX7 the cma heap is used to allocate frame buffers. The default size of CMA is 16MB which is not enough for higher resolutions (ex: 1600x1200). So, increase the default CMA size to 40MB. Signed-off-by: Rui Miguel Silva ---

[PATCH 07/15] media: staging/imx: add 10 bit bayer support

Some sensors can only output 10 bit bayer formats, like the OV2680. Add support for that in imx-media. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx-media-utils.c | 24 + 1 file changed, 24 insertions(+) diff --git

[PATCH 1/2] staging: fsl-dpaa2/rtc: add rtc driver

This patch is to add driver for the DPAA2 1588 timer module (RTC) which interfaces to up to an unlimited number of 10/100/1000 or 10G ethernet MACs, providing current time, alarm, and fiper support. The 1588 IP control block includes these distinctive features. - External GPIO trigger for

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Hi! So if you like, give me your address, and I'll send you two development samples of Pi433. Cheers, Marcus Am 19.04.2018 um 11:47 schrieb Valentin Vidic: > On Thu, Apr 19, 2018 at 11:25:19AM +0200, Marcus Wolf wrote: >> let me know, what you like to have. For sure with just one station and

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Thu, Apr 19, 2018 at 11:25:19AM +0200, Marcus Wolf wrote: > let me know, what you like to have. For sure with just one station and > no other 433MHz equipment, options for testing are quite limited. I can get Rpi3 and with two shields test 433MHz communication between Rpi2 and Rpi3. --

RE: [PATCH 4/9] staging: iio: Augment TODO file with GPIO work item

> To make sure that these drivers do not leave staging before they > are properly converted to use the new GPIO descriptor API, > augment the TODO file with this work item. > > Cc: Jonathan Cameron > Signed-off-by: Linus Walleij Acked-by:

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Am 12.04.2018 um 20:46 schrieb Valentin Vidic: > On Sun, Apr 08, 2018 at 05:22:46PM +0200, Marcus Wolf wrote: >> Regarding your patch, I did not understand, why you did not remove >> the mutex_lock in pi433_write. Wasn't it the goal to remove it? > > Is it possible for more than one userspace

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Am 12.04.2018 um 19:15 schrieb Valentin Vidic: > On Sun, Apr 08, 2018 at 04:15:30PM +0200, Marcus Wolf wrote: >> The hardware of Pi433 is working with every Raspberry Pi (on zero, you >> need to solder the GPIO-pins) and with several other fruits like banana >> pi. The only thing is, that you

[PATCH 2/2] MAINTAINERS: add maintainer for the DPAA2 PTP clock driver

This patch is to add maintainer for the DPAA2 PTP clock driver. Signed-off-by: Yangbo Lu --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0a1410d..7733efa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH 3/9] staging: greybus: Add TODO file with GPIO work items

To make sure that these drivers do not leave staging before they are properly converted to use the new GPIO descriptor API, and the GPIOLIB_IRQCHIP helper library, create the TODO file with these work items. Cc: Johan Hovold Signed-off-by: Linus Walleij

[PATCH 6/9] staging: gpio-mt7621: Include the right header

GPIO drivers should include only, the header is deprecated. Cc: John Crispin Cc: Zhiyong Tao Cc: Sean Wang Signed-off-by: Linus Walleij --- I was philosophizing whether

[PATCH 8/9] staging: olpc_dcon: Augment TODO file with GPIO work item

To make sure that this driver does not leave staging before it is properly converted to use the new GPIO descriptor API, augment the TODO file with this work item. Cc: Andres Salomon Cc: Jens Frederich Signed-off-by: Linus Walleij

  1   2   >