Re: [PATCH v4 1/3] resource: Use list_head to link sibling resource

On 05/07/18 at 07:42pm, kbuild test robot wrote: > Hi Baoquan, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.17-rc4 next-20180504] > [if your patch is applied to the wrong git tree, please drop us a note to > help

Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource

On Tue, May 08, 2018 at 08:11:23PM +0800, Baoquan He wrote: >On 05/08/18 at 08:48pm, Wei Yang wrote: >> On Mon, May 07, 2018 at 09:14:29AM +0800, Baoquan He wrote: >> >Hi Wei Yang, >> > >> >On 04/26/18 at 09:18am, Wei Yang wrote: >> >> On Thu, Apr 19, 2018 at 08:18:46AM +0800, Baoquan He wrote: >>

RE: [PATCH] Drivers: hv: vmbus: enable VMBus protocol version 5.0

> From: Stephen Hemminger > Sent: Tuesday, May 8, 2018 15:45 > On Tue, 8 May 2018 22:26:21 + > Dexuan Cui wrote: > > > @@ -63,6 +63,9 @@ static __u32 vmbus_get_next_version(__u32 > current_version) > > case (VERSION_WIN10): > >

Re: [PATCH] hv_netvsc: Fix net device attach on older Windows hosts

On Tue, 08 May 2018 20:17:51 +0200 Mohammed Gamal wrote: > On Tue, 2018-05-08 at 11:13 -0700, Stephen Hemminger wrote: > > On Tue,  8 May 2018 19:40:47 +0200 > > Mohammed Gamal wrote: > > > > > On older windows hosts the net_device instance is returned

Re: [PATCH] Drivers: hv: vmbus: enable VMBus protocol version 5.0

On Tue, 8 May 2018 22:26:21 + Dexuan Cui wrote: > --- a/drivers/hv/connection.c > +++ b/drivers/hv/connection.c > @@ -63,6 +63,9 @@ static __u32 vmbus_get_next_version(__u32 current_version) > case (VERSION_WIN10): > return VERSION_WIN8_1; > > +

[PATCH] Drivers: hv: vmbus: enable VMBus protocol version 5.0

With VMBus protocol 5.0, we're able to better support new features, e.g. running two or more VMBus drivers simultaneously in a single VM -- note: we can't simply load the current VMBus driver twice, instead, a secondary VMBus driver must be implemented. This patch adds the support for the new

Re: [PATCH 3/3] staging: mt7621-eth: Fix quoted string split across lines

On Wed, May 09 2018, Kamal Heib wrote: > Quoted strings should not be split to help text grep in the source. > > Signed-off-by: Kamal Heib > --- > drivers/staging/mt7621-eth/mtk_eth_soc.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH 2/3] staging: mt7621-eth: Fix line over 80 characters

On Wed, May 09 2018, Kamal Heib wrote: > This change fixes all the lines that get over 80 characters. > > Signed-off-by: Kamal Heib > --- > drivers/staging/mt7621-eth/ethtool.c| 3 ++- > drivers/staging/mt7621-eth/gsw_mt7621.c | 3 ++- >

[PATCH 1/3] staging: mt7621-eth: Prefer unsigned int to bare use of unsigned

This commit replaces all the unsigned definitions in favour of 'unsigned int' which is preferred. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/gsw_mt7620.h | 4 ++-- drivers/staging/mt7621-eth/gsw_mt7621.c | 4 ++-- drivers/staging/mt7621-eth/mtk_eth_soc.c |

[PATCH 0/3] staging: Cleanup some checkpatch issue

This patch set fixes multiple issues reported by checkpatch within the mt7621-eth driver. Kamal Heib (3): staging: mt7621-eth: Prefer unsigned int to bare use of unsigned staging: mt7621-eth: Fix line over 80 characters staging: mt7621-eth: Fix quoted string split across lines

[PATCH 2/3] staging: mt7621-eth: Fix line over 80 characters

This change fixes all the lines that get over 80 characters. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/ethtool.c| 3 ++- drivers/staging/mt7621-eth/gsw_mt7621.c | 3 ++- drivers/staging/mt7621-eth/mdio.c | 3 ++-

[PATCH 3/3] staging: mt7621-eth: Fix quoted string split across lines

Quoted strings should not be split to help text grep in the source. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c

[PATCH] PCI: hv: fix spelling mistake: "reqquest" -> "request"

From: Colin Ian King Trivial fix to spelling mistake in dev_err error message Signed-off-by: Colin Ian King --- drivers/pci/host/pci-hyperv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pci-hyperv.c

Re: [PATCH] hv_netvsc: Fix net device attach on older Windows hosts

On Tue, 2018-05-08 at 11:13 -0700, Stephen Hemminger wrote: > On Tue,  8 May 2018 19:40:47 +0200 > Mohammed Gamal wrote: > > > On older windows hosts the net_device instance is returned to > > the caller of rndis_filter_device_add() without having the presence > > bit set

Re: [PATCH] hv_netvsc: Fix net device attach on older Windows hosts

On Tue, 8 May 2018 19:40:47 +0200 Mohammed Gamal wrote: > On older windows hosts the net_device instance is returned to > the caller of rndis_filter_device_add() without having the presence > bit set first. This would cause any subsequent calls to network device > operations

Re: [PATCH v3 13/14] media: imx7.rst: add documentation for i.MX7 media driver

Hi, I have a few editing suggestions below... On 05/07/2018 09:21 AM, Rui Miguel Silva wrote: > Add rst document to describe the i.MX7 media driver and also a working example > from the Warp7 board usage with a OV2680 sensor. > > Signed-off-by: Rui Miguel Silva > --- >

[PATCH] hv_netvsc: Fix net device attach on older Windows hosts

On older windows hosts the net_device instance is returned to the caller of rndis_filter_device_add() without having the presence bit set first. This would cause any subsequent calls to network device operations (e.g. MTU change, channel change) to fail after the device is detached once, returning

[PATCH] staging: most: video: remove debugging code

This patch removes debugging code in video.c that causes the following checkpatch warning: WARNING: Prefer using '\"%s...\", __func__' to using function's name in a string Signed-off-by: Abdun Nihaal --- drivers/staging/most/video/video.c | 23 --- 1

Re: [PATCH v3 2/5] efi: Add embedded peripheral firmware support

On Tue, May 08, 2018 at 03:38:05PM +, Luis R. Rodriguez wrote: > On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote: > > On Wed, Apr 25, 2018 at 10:55 AM, Luis R. Rodriguez > > wrote: > > > Android became the primary user of

Re: [PATCH v3 2/5] efi: Add embedded peripheral firmware support

On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote: > On Wed, Apr 25, 2018 at 10:55 AM, Luis R. Rodriguez wrote: > > Android became the primary user of CONFIG_FW_LOADER_USER_HELPER_FALLBACK. > > > > It would be good for us to hear from Android folks if their current

Re: [PATCH v3 07/14] media: dt-bindings: add bindings for i.MX7 media driver

On Mon, 2018-05-07 at 17:21 +0100, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > > Signed-off-by: Rui Miguel Silva > --- > .../devicetree/bindings/media/imx7.txt| 152 ++ > 1 file changed, 152 insertions(+) >

Re: [PATCHv2] staging: speakup: Add pause command used on switching to graphical mode

Greg KH, le mar. 08 mai 2018 13:31:31 +0200, a ecrit: > On Mon, May 07, 2018 at 10:14:27PM +0200, Samuel Thibault wrote: > > For software speech syntheses to be able to manage concurrent audio card > > access, they need to know when speakup stops emitting text to be spoken > > because the console

Re: [PATCH] android: binder: Fix a possible data race in binder_alloc_mmap_handler

On Tue, May 8, 2018 at 2:06 AM, Jia-Ju Bai wrote: > The write operations to "alloc->buffer" are protected by > the lock on line 679 and 730, but the read operation to > this data on line 712 is not protected by the lock. > Thus, there may exist a data race for

Re: [PATCH v3 12/14] ARM: dts: imx7s-warp: add ov2680 sensor node

Hi Rui, On Mon, May 7, 2018 at 1:21 PM, Rui Miguel Silva wrote: > + reg_peri_3p15v: regulator-peri-3p15v { > + compatible = "regulator-fixed"; > + regulator-name = "peri_3p15v_reg"; > + regulator-min-microvolt = <315>; >

Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug

On Tue, May 08, 2018 at 08:04:54AM -0500, Wenwen Wang wrote: > On Tue, May 8, 2018 at 7:16 AM, Dan Carpenter > wrote: > > On Wed, May 02, 2018 at 05:38:49PM -0500, Wenwen Wang wrote: > >> At the end of atomisp_subdev_set_selection(), the function > >>

Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug

On Tue, May 8, 2018 at 7:16 AM, Dan Carpenter wrote: > On Wed, May 02, 2018 at 05:38:49PM -0500, Wenwen Wang wrote: >> At the end of atomisp_subdev_set_selection(), the function >> atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. Since >> this

Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug

On Wed, May 02, 2018 at 05:38:49PM -0500, Wenwen Wang wrote: > At the end of atomisp_subdev_set_selection(), the function > atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. Since > this function may return a NULL pointer, it is firstly invoked to check > the returned pointer.

Re: [PATCH v4 1/3] resource: Use list_head to link sibling resource

On 05/07/18 at 11:50pm, kbuild test robot wrote: > Hi Baoquan, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.17-rc4 next-20180504] > [if your patch is applied to the wrong git tree, please drop us a note to > help

Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource

On 05/08/18 at 08:48pm, Wei Yang wrote: > On Mon, May 07, 2018 at 09:14:29AM +0800, Baoquan He wrote: > >Hi Wei Yang, > > > >On 04/26/18 at 09:18am, Wei Yang wrote: > >> On Thu, Apr 19, 2018 at 08:18:46AM +0800, Baoquan He wrote: > >> >The struct resource uses singly linked list to link siblings.

Re: [PATCH 1/7] staging: ks7010: Replace license boilerplate with SPDX identifiers

On Tue, May 08, 2018 at 01:43:13PM +0200, Greg Kroah-Hartman wrote: > On Sun, May 06, 2018 at 03:02:58PM -0700, Nathan Chancellor wrote: > > This satisfies a checkpatch.pl warning and is the preferred method for > > notating the license due to its lack of ambiguity. > > > > Signed-off-by: Nathan

Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource

On Mon, May 07, 2018 at 09:14:29AM +0800, Baoquan He wrote: >Hi Wei Yang, > >On 04/26/18 at 09:18am, Wei Yang wrote: >> On Thu, Apr 19, 2018 at 08:18:46AM +0800, Baoquan He wrote: >> >The struct resource uses singly linked list to link siblings. It's not >> >easy to do reverse iteration on sibling

Re: [PATCH 4/7] staging: ks7010: Adjust spacing around functions and declarations

On Sun, May 06, 2018 at 03:03:01PM -0700, Nathan Chancellor wrote: > checkpatch.pl warns about too many or not enough spaces in these > locations. Adjust them accordingly. > > Signed-off-by: Nathan Chancellor > --- > drivers/staging/ks7010/ks7010_sdio.c | 1 - >

Re: [PATCH 6/7] staging: ks7010: Adjust alignment to open parenthesis

On Sun, May 06, 2018 at 03:03:03PM -0700, Nathan Chancellor wrote: > Fixes a checkpatch.pl warning. > > Signed-off-by: Nathan Chancellor > --- > drivers/staging/ks7010/ks_hostif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Also does not apply :(

Re: [PATCH 4/4] staging: lustre: obdclass: change object lookup to no wait mode

> /* >* Allocate new object. This may result in rather complicated >* operations, including fld queries, inode loading, etc. >*/ > o = lu_object_alloc(env, dev, f, conf); > - if (IS_ERR(o)) > + if (unlikely(IS_ERR(o))) > return o; > This

Re: [PATCH 5/7] staging: ks7010: Remove unnecessary parentheses

On Sun, May 06, 2018 at 03:03:02PM -0700, Nathan Chancellor wrote: > Fixes checkpatch.pl warnings. > > Signed-off-by: Nathan Chancellor > --- > drivers/staging/ks7010/ks_hostif.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH 1/7] staging: ks7010: Replace license boilerplate with SPDX identifiers

On Sun, May 06, 2018 at 03:02:58PM -0700, Nathan Chancellor wrote: > This satisfies a checkpatch.pl warning and is the preferred method for > notating the license due to its lack of ambiguity. > > Signed-off-by: Nathan Chancellor > --- >

Re: [PATCH 7/7] staging: ks7010: Move from bool to int in structs

On Tue, May 08, 2018 at 01:34:31PM +0200, Greg Kroah-Hartman wrote: > On Sun, May 06, 2018 at 03:03:04PM -0700, Nathan Chancellor wrote: > > Fixes checkpatch.pl warnings. > > > > Signed-off-by: Nathan Chancellor > > --- > > drivers/staging/ks7010/ks_hostif.c | 4 ++--

Re: [PATCH 7/7] staging: ks7010: Move from bool to int in structs

On Sun, May 06, 2018 at 03:03:04PM -0700, Nathan Chancellor wrote: > Fixes checkpatch.pl warnings. > > Signed-off-by: Nathan Chancellor > --- > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > drivers/staging/ks7010/ks_wlan.h | 4 ++-- >

Re: [PATCHv2] staging: speakup: Add pause command used on switching to graphical mode

On Mon, May 07, 2018 at 10:14:27PM +0200, Samuel Thibault wrote: > For software speech syntheses to be able to manage concurrent audio card > access, they need to know when speakup stops emitting text to be spoken > because the console has switched to graphical mode. This introduces a > PAUSE

[PATCH 03/28] staging: most: i2c: prevent division by zero

This prevents division by zero scan_rate. The zero scan_rate does not need any special action as it actually means "never poll again". Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/i2c/i2c.c | 2 +-

[PATCH 27/28] staging: most: usb: fix usb_disconnect race condition

The functions usb_disconnect and usb_sndbulkpipe are racing for the struct usb_device, which might cause a null pointer dereference exception. This patch fixes this race condition by protecting the critical section inside the function hdm_enque with the io_mutex. Signed-off-by: Christian Gromm

[PATCH 13/28] staging: most: i2c: remove redundant list_mutex

The elements of the dev->rx.list are consumed in the pending_rx_work and populated in the function enqueue() that cancels the pending_rx_work. The function enqueue() and poison_channel() do not race anyway. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm

[PATCH 17/28] staging: most: cdev: avoid warning about potentially uninitialized variable

This patch avoids the warning that the pointer mbo might be used uninitialized that some environmens throw. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 23/28] staging: most: dim2: use device tree

This patch removes the dependency to platform specific source files that do platform specific initialization and supply the IRQ number. Instead DT code is added Signed-off-by: Christian Gromm --- drivers/staging/most/dim2/Kconfig | 2 +-

[PATCH 21/28] staging: most: dim2: fix startup sequence

Platform specific initialization (data->init) has to be done before calling dim_startup to start the DIM2 IP. Signed-off-by: Christian Gromm --- drivers/staging/most/dim2/dim2.c | 90 +--- 1 file changed, 39 insertions(+), 51

[PATCH 28/28] staging: most: usb: remove local variable

This patch removes the local variable dev that is used to store the pointer to the usb_device whenever it is used only once. Signed-off-by: Christian Gromm --- drivers/staging/most/usb/usb.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff

[PATCH 24/28] staging: most: dim2: read clock speed from the device

This patch implemets reading of the clock speed from DT. Signed-off-by: Christian Gromm --- drivers/staging/most/dim2/dim2.c | 50 +++- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git

[PATCH 09/28] staging: most: i2c: avoid polling in case of misconfig

This patch prevents the driver from falling back to polling mode in case of IRQ misconfiguration. Signed-off-by: Christian Gromm --- drivers/staging/most/i2c/i2c.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

[PATCH 25/28] staging: most: dim2: use device to allocate coherent memory

On several architectures the allocation of coherent memory needs a device that has the dma_ops structure properly initialized. This patch enables the DIM2 platform to be used to allocate this type of memory. Signed-off-by: Christian Gromm ---

[PATCH 19/28] staging: most: usb: add ep number to log

This patch adds the endpoint number of the USB pipe that reports to be broken into the log message. It is needed to make debugging for applications more comfortable. Signed-off-by: Christian Gromm --- drivers/staging/most/usb/usb.c | 9 ++--- 1 file changed, 6

[PATCH 05/28] staging: most: add channel property dbr_size

This patch adds the channel property dbr_size to control the corresponding buffer size of the channels of the DIM2 interface. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 22 ++ drivers/staging/most/core.h | 1 +

[PATCH 02/28] staging: most: dim2: remove clock speed processing from the HDM

This removes the module parameter clock_speed from the HDM code. Instead, the platform-dependent clock speed must be delivered by the platform driver with the help of the dim2_platform_data.clk_speed. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm

[PATCH 26/28] staging: most: usb: don't set URB_ZERO_PACKET flag for synchronous data

This patch avoids setting the URB_ZERO_PACKET transfer flag for synchronous data. This is needed to prevent the host from sending an empty packet when data is aligned to an endpoint packet boundary. Signed-off-by: Christian Gromm --- drivers/staging/most/usb/usb.c

[PATCH 00/28] staging: most: fix issues

This patch set is needed to fix open issues of the MOST driver. Christian Gromm (28): staging: most: allocate only all requested memory staging: most: dim2: remove clock speed processing from the HDM staging: most: i2c: prevent division by zero staging: most: i2c: remove unnecessary

[PATCH 10/28] staging: most: i2c: prevent zero delay polling

This patch avoids that a configured scan_rate of more than MSEC_PER_SEC might result in a polling delay of zero. Signed-off-by: Christian Gromm --- drivers/staging/most/i2c/i2c.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH 20/28] staging: most: cdev: fix function return value

The function ch_get_mbo declares its return value as type bool, but returns a pointer to mbo. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/cdev/cdev.c

[PATCH 22/28] staging: most: cdev: fix race condition

This patch fixes a race condition between the functions disconnect and poll. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/cdev/cdev.c

[PATCH 14/28] staging: most: i2c: reduce parameters inconsistency

Currently, there are two module parameters for the i2c driver: - polling_req: boolean irq/polling mode; - scan_rate: polling rate, that is used in the case where the polling mode is active This model is misconfiguration-prone. For example, it is possible to select polling mode with the

[PATCH 18/28] staging: most: cdev: fix chrdev_region leak

The function unregister_chrdev_region is called with a different counter as the alloc_chrdev_region. To fix this, this patch introduces the constant CHRDEV_REGION_SIZE that is used in both functions. Signed-off-by: Christian Gromm ---

[PATCH 16/28] staging: most: sound: call snd_card_new with struct device

This patch is needed as function snd_card_new needs a valid parent device. Passing a NULL pointer leads to kernel Ooops. Signed-off-by: Christian Gromm --- drivers/staging/most/core.h| 1 + drivers/staging/most/sound/sound.c | 2 +-

[PATCH 15/28] staging: most: make interface drivers allocate coherent memory

On arm64/aarch64 architectures the allocation of coherent memory needs a device that has the dma_ops properly set. That's why the core module of the MOST driver is no longer able to allocate this type or memory. This patch moves the allocation process down to the interface drivers where the proper

[PATCH 08/28] staging: most: i2c: do not wait in work function

This patch removes the function wait_event_interruptible from the work function to avoid waiting. Signed-off-by: Christian Gromm --- drivers/staging/most/i2c/i2c.c | 54 -- 1 file changed, 21 insertions(+), 33 deletions(-)

[PATCH 01/28] staging: most: allocate only all requested memory

This prohibits the allocation of the memory for the MBOs if only the part of the MBOs, requested by the application, may be allocated. The function arm_mbo_chain, if cannot allocate all requested MBO, frees all prior allocated memory and returns 0. Signed-off-by: Andrey Shvetsov

[PATCH 07/28] staging: most: i2c: shorten lifetime of IRQ handler

Currently the IRQ handler used for the rx channel lives between the functions i2c_probe and i2c_remove. This patch shortens the lifetime and keeps the handler alive only between the functions configure_channel and poison_channel. Signed-off-by: Christian Gromm ---

[PATCH 12/28] staging: most: i2c: remove redundant is_open

The variable is_open is checked only in the work function pending_rx_work() that is only active between the calls configure_channel() and poison_channel(). Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm ---

[PATCH 11/28] staging: most: i2c: trace real polling rate

The real polling rate depends on the CONFIG_HZ and may differ from the required polling rate. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/i2c/i2c.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 04/28] staging: most: i2c: remove unnecessary poison_channel call

This removes call of the poison_channel that is: - not allowed after most_deregister_interface; - is made during the most_deregister_interface call. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm ---

[PATCH] android: binder: Fix a possible data race in binder_alloc_mmap_handler

The write operations to "alloc->buffer" are protected by the lock on line 679 and 730, but the read operation to this data on line 712 is not protected by the lock. Thus, there may exist a data race for "alloc->buffer". To fix this data race, the read operation to "alloc->buffer" should be also

Re: [PATCH] media: atomisp: fix spelling mistake: "diregard" -> "disregard"

On 2018-04-29 at 13:06:47 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in ia_css_print message text Hi Colin, The atomisp drivers will soon EOL accorinding to the ML discussion. > > Signed-off-by: Colin Ian King