[PATCH] ANDROID: binder: rename parameter to resolve name collision.

2018-05-29 Thread kuangrufan
From: Kuang Rufan both bind.c & binder_alloc.c define the same kernel parameter 'debug_mask', rename the one in binder_alloc.c to 'alloc_debug_mask'. Signed-off-by: Kuang Rufan --- drivers/android/binder_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/6] staging: mt7621-dts: fix property #interrupt-cells for the gpio node

2018-05-29 Thread Sergio Paracuellos
On Wed, May 30, 2018 at 09:34:39AM +1000, NeilBrown wrote: > On Tue, May 29 2018, Sergio Paracuellos wrote: > > > Most gpio chips have two cells for interrupts and this should be also. > > Set this property accordly fixing this up. > > > > Signed-off-by: Sergio Paracuellos > > --- > >

Re: [greybus-dev] [PATCH 01/13] staging: greybus: camera: no need to check debugfs return values

2018-05-29 Thread Viresh Kumar
On 29-05-18, 16:29, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Clean up the greybus camera driver by not caring about the

[PATCH v2] staging: mt7621-gpio: update #interrupt-cells for the gpio node

2018-05-29 Thread Sergio Paracuellos
Most gpio chips have two cells for interrupts and this should be also. Set this property in the device tree accordly fixing this up. In order to make this working properly the xlate function for the irq_domain must be updated to use the 'irq_domain_xlate_twocell' one in the driver. One more

Re: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-05-29 Thread Greg KH
On Wed, May 30, 2018 at 06:42:14AM +0200, Greg KH wrote: > On Tue, May 29, 2018 at 08:11:40PM +, Sunil Muthuswamy wrote: > > The V3 patch should address the concerns/comments below. Happy to > > address any additional comments, if there are any. > > Why not respond to the v3 patch so I don't

Re: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-05-29 Thread Greg KH
On Tue, May 29, 2018 at 08:11:40PM +, Sunil Muthuswamy wrote: > The V3 patch should address the concerns/comments below. Happy to > address any additional comments, if there are any. Why not respond to the v3 patch so I don't have to go dig it up? :) And really, it's up to the maintainer of

Re: [PATCH net-next v4 5/8] dsa: port: Ignore bridge VLAN events

2018-05-29 Thread Florian Fainelli
On 05/29/2018 05:59 PM, Petr Machata wrote: > A follow-up patch enables emitting VLAN notifications for the bridge CPU > port in addition to the existing slave port notifications. These > notifications have orig_dev set to the bridge in question. > > Because there's no specific support for

Re: [PATCH] staging: mt7621-eth: Refactor RX ring resource allocation and cleanup

2018-05-29 Thread NeilBrown
On Tue, May 29 2018, Dan Carpenter wrote: > On Mon, May 21, 2018 at 09:37:31AM +1000, NeilBrown wrote: >> On Fri, May 18 2018, Kamal Heib wrote: >> >> > Simplify the code of allocate and cleanup RX ring resources by using >> > helper functions, also make sure to free the allocated resources in

[PATCH net-next v4 8/8] mlxsw: spectrum_switchdev: Schedule respin during trans prepare

2018-05-29 Thread Petr Machata
Since there's no special support for the bridge events, the driver returns -EOPNOTSUPP, and thus the commit never happens. Therefore schedule respin during the prepare stage: there's no real difference one way or another. This fixes the problem that mirror-to-gretap offload wouldn't adapt to

[PATCH net-next v4 7/8] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Petr Machata
A driver might need to react to changes in settings of brentry VLANs. Therefore send switchdev port notifications for these as well. Reuse SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use netif_is_bridge_master() on orig_dev to determine whether the notification is about a bridge

[PATCH net-next v4 6/8] staging: fsl-dpaa2: ethsw: Ignore bridge VLAN events

2018-05-29 Thread Petr Machata
A follow-up patch enables emitting VLAN notifications for the bridge CPU port in addition to the existing slave port notifications. These notifications have orig_dev set to the bridge in question. Because there's no specific support for these VLANs, just ignore the notifications to maintain the

[PATCH net-next v4 5/8] dsa: port: Ignore bridge VLAN events

2018-05-29 Thread Petr Machata
A follow-up patch enables emitting VLAN notifications for the bridge CPU port in addition to the existing slave port notifications. These notifications have orig_dev set to the bridge in question. Because there's no specific support for these VLANs, just ignore the notifications to maintain the

[PATCH net-next v4 4/8] rocker: rocker_main: Ignore bridge VLAN events

2018-05-29 Thread Petr Machata
A follow-up patch enables emitting VLAN notifications for the bridge CPU port in addition to the existing slave port notifications. These notifications have orig_dev set to the bridge in question. Because there's no specific support for these VLANs, just ignore the notifications to maintain the

[PATCH net-next v4 3/8] mlxsw: spectrum_switchdev: Ignore bridge VLAN events

2018-05-29 Thread Petr Machata
A follow-up patch enables emitting VLAN notifications for the bridge CPU port in addition to the existing slave port notifications. These notifications have orig_dev set to the bridge in question. Because there's no specific support for these VLANs, just ignore the notifications to maintain the

[PATCH net-next v4 2/8] net: bridge: Extract br_vlan_add_existing()

2018-05-29 Thread Petr Machata
Extract the code that deals with adding a preexisting VLAN to bridge CPU port to a separate function. A follow-up patch introduces a need to roll back operations in this block due to an error, and this split will make the error-handling code clearer. Signed-off-by: Petr Machata ---

[PATCH net-next v4 1/8] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-29 Thread Petr Machata
A call to switchdev_port_obj_add() or switchdev_port_obj_del() involves initializing a struct switchdev_obj_port_vlan, a piece of code that repeats on each call site almost verbatim. While in the current codebase there is just one duplicated add call, the follow-up patches add more of both add and

[PATCH net-next v4 0/8] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Petr Machata
In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap mirror"), mlxsw got support for offloading mirror-to-gretap such that the underlay packet path involves a bridge. In that case, the offload is also influenced by PVID setting of said bridge. However, changes to VLAN

Re: [PATCH v2 01/25] staging: lustre: libcfs: restore UMP handling

2018-05-29 Thread NeilBrown
On Tue, May 29 2018, James Simmons wrote: > With the cleanup of the libcfs SMP handling all UMP handling > was removed. In the process now various NULL pointers and > empty fields are return in the UMP case which causes lustre > to crash hard. Restore the proper UMP handling so Lustre can >

Re: [PATCH 1/6] staging: mt7621-dts: fix property #interrupt-cells for the gpio node

2018-05-29 Thread NeilBrown
On Tue, May 29 2018, Sergio Paracuellos wrote: > Most gpio chips have two cells for interrupts and this should be also. > Set this property accordly fixing this up. > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/mt7621-dts/mt7621.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH v1] media: staging: tegra-vde: Reset VDE regardless of memory client resetting failure

2018-05-29 Thread Dmitry Osipenko
A failed memory client reset doesn't prevent VDE from resetting, hence reset VDE regardless of preceding memory client resetting failure. Signed-off-by: Dmitry Osipenko --- drivers/staging/media/tegra-vde/tegra-vde.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff

Re: [PATCH] staging: mt7621-mmc: Fix line size exceeding 80 columns.

2018-05-29 Thread NeilBrown
On Tue, May 29 2018, Sankalp Negi wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: line over 80 characters > > Signed-off-by: Sankalp Negi > --- > drivers/staging/mt7621-mmc/dbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

RE: [PATCH] PCI: hv: Do not wait forever on a device that has disappeared

2018-05-29 Thread Dexuan Cui
> From: Andy Shevchenko > Sent: Tuesday, May 29, 2018 14:21 > On Thu, May 24, 2018 at 12:12 AM, Dexuan Cui > wrote: > > > > Before the guest finishes the device initialization, the device can be > > removed anytime by the host, and after that the host won't respond to > > the guest's request, so

Re: [PATCH] PCI: hv: Do not wait forever on a device that has disappeared

2018-05-29 Thread Andy Shevchenko
On Thu, May 24, 2018 at 12:12 AM, Dexuan Cui wrote: > > Before the guest finishes the device initialization, the device can be > removed anytime by the host, and after that the host won't respond to > the guest's request, so the guest should be prepared to handle this > case. > + while

[staging:debugfs_cleanup 283/813] drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.o: warning: objtool: ieee80211_sta_wakeup.cold.36()+0x22: sibling call from callable instruction with modified st

2018-05-29 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git debugfs_cleanup head: a93e95df61f8aab471226cb38eaf46923727c4d6 commit: a40c973eebe61aa9242f5501d5d5598778e3bea2 [283/813] staging: rtl8192u: Replace GFP_ATOMIC with GFP_KERNEL in ieee80211_softmac_init config:

RE: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-05-29 Thread Sunil Muthuswamy
The V3 patch should address the concerns/comments below. Happy to address any additional comments, if there are any. - Sunil > -Original Message- > From: Sunil Muthuswamy > Sent: Monday, May 21, 2018 9:48 AM > To: 'Greg KH' > Cc: de...@linuxdriverproject.org; Haiyang Zhang > ; Stephen

RE: [PATCH] PCI: hv: Do not wait forever on a device that has disappeared

2018-05-29 Thread Dexuan Cui
> From: Michael Kelley (EOSG) > Sent: Monday, May 28, 2018 17:19 > > While this patch solves the immediate problem of getting hung waiting > for a response from Hyper-V that will never come, there's another scenario > to look at that I think introduces a race. Suppose the guest VM issues a >

[PATCH 1/2] staging: wilc1000: fix some endianness sparse warnings

2018-05-29 Thread Thibaut Robert
This commit fix a few sparse warnings. It mostly consists of fixing the type declarations and avoiding the use of variables with mixed endianness values. Signed-off-by: Thibaut Robert --- drivers/staging/wilc1000/wilc_spi.c | 15 ++-

[PATCH 1/1] staging: wilc1000: Use common structs to parse ip packets

2018-05-29 Thread Thibaut Robert
Use structs ethhdr, iphdr and tcphdr instead of manual parsing in tcp_process. This commit fix handling of ip packets containing options. It also fixes the following sparse warning: drivers/staging/wilc1000//wilc_wlan.c:201:19: warning: cast to restricted __be16 Signed-off-by: Thibaut Robert

[PATCH] staging: comedi: comedi_usb.h: SPDX License Identifier is added in the first line

2018-05-29 Thread Bhanusree Pola
SPDX License Identifier is added in form of a comment. Signed-off-by: Bhanusree Pola --- drivers/staging/comedi/comedi_usb.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/comedi_usb.h b/drivers/staging/comedi/comedi_usb.h index 50287de..601e29d

[PATCH] staging: mt7621-mmc: Fix line size exceeding 80 columns.

2018-05-29 Thread Sankalp Negi
This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters Signed-off-by: Sankalp Negi --- drivers/staging/mt7621-mmc/dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mmc/dbg.c index

Re: [PATCH net-next v2 3/7] rocker: rocker_main: Ignore bridge VLAN events

2018-05-29 Thread Ilias Apalodimas
On Tue, May 29, 2018 at 05:37:30PM +0300, Petr Machata wrote: > Ilias Apalodimas writes: > > >> diff --git a/drivers/net/ethernet/rocker/rocker_main.c > >> b/drivers/net/ethernet/rocker/rocker_main.c > >> index e73e4fe..aeafdb9 100644 > >> --- a/drivers/net/ethernet/rocker/rocker_main.c > >>

Re: [PATCH net-next v2 3/7] rocker: rocker_main: Ignore bridge VLAN events

2018-05-29 Thread Petr Machata
Ilias Apalodimas writes: >> diff --git a/drivers/net/ethernet/rocker/rocker_main.c >> b/drivers/net/ethernet/rocker/rocker_main.c >> index e73e4fe..aeafdb9 100644 >> --- a/drivers/net/ethernet/rocker/rocker_main.c >> +++ b/drivers/net/ethernet/rocker/rocker_main.c >> @@ -1632,6 +1632,9 @@

[PATCH 10/13] staging: lustre: unwrap some ldebugfs_register() calls

2018-05-29 Thread Greg Kroah-Hartman
When the third option (list) to ldebugfs_register() is NULL, it's the same as just calling debugfs_create_dir(). So unwind this and call debugfs_create_dir() directly. This ends up saving lots of code as we do not need to do any error checking of the return value (because it does not matter).

[PATCH 05/13] staging: lustre: no need to check debugfs return values

2018-05-29 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Clean up the lustre core code by not caring about the value of debugfs calls. This ends up removing a number of

[PATCH 08/13] staging: lustre: remove ldebugfs_seq_create() wrapper function

2018-05-29 Thread Greg Kroah-Hartman
It was just calling debugfs_create_file() so unwind things and just call the real function instead. This ends up saving a number of lines as there was never any error handling happening anyway, so that all can be removed as well. Cc: Oleg Drokin Cc: Andreas Dilger Cc: James Simmons Cc:

[PATCH 12/13] staging: lustre: make ldebugfs_add_vars a void function

2018-05-29 Thread Greg Kroah-Hartman
The call to ldebugfs_add_vars() can not really fail, so have it just return nothing, which allows us to clean up a lot of unused error handling code. Cc: Oleg Drokin Cc: Andreas Dilger Cc: James Simmons Cc: NeilBrown Cc: Roman Storozhenko Cc: Arnd Bergmann Cc: Quentin Bouget Cc: Aastha

[PATCH 06/13] staging: lustre: remove ldebugfs_add_simple() wrapper

2018-05-29 Thread Greg Kroah-Hartman
It was only being called in one place, and is an unneeded wrapper function around debugfs_create_file() so just call the real debugfs function instead. This ends up cleaning up some unneeded error handling logic that was never needed as well. Cc: Oleg Drokin Cc: Andreas Dilger Cc: James

[PATCH 01/13] staging: greybus: camera: no need to check debugfs return values

2018-05-29 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Clean up the greybus camera driver by not caring about the value of debugfs calls. This ends up removing a number

[PATCH 04/13] staging: vc04_services: no need to check debugfs return values

2018-05-29 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Clean up the vchiq_arm code by not caring about the value of debugfs calls. This ends up removing a number of

[PATCH 07/13] staging: lustre: remove ldebugfs_register_stats() wrapper function

2018-05-29 Thread Greg Kroah-Hartman
It was just calling debugfs_create_file() so unwind things and just call the real function instead. This ends up saving a number of lines as there was never any error handling happening anyway, so that all can be removed as well. Cc: Oleg Drokin Cc: Andreas Dilger Cc: James Simmons Cc: Ben

[PATCH 09/13] staging: lustre: remove ldebugfs_obd_seq_create() wrapper function

2018-05-29 Thread Greg Kroah-Hartman
It was just calling debugfs_create_file() so unwind things and just call the real function instead. This ends up saving a number of lines as there was never any error handling happening anyway, so that all can be removed as well. Cc: Oleg Drokin Cc: Andreas Dilger Cc: James Simmons Cc:

[PATCH 03/13] staging: unisys: visornic: no need to check debugfs return values

2018-05-29 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Clean up the visornic driver code by not caring about the value of debugfs calls. This ends up removing a number

[PATCH 11/13] staging: lustre: remove last two users of ldebugfs_register()

2018-05-29 Thread Greg Kroah-Hartman
ldebugfs_register() is just a call to debugfs_create_dir() and ldebugfs_add_vars() if the list option is set. Fix up the last two users of this function to just call these two functions instead, and delete the now unused ldebugfs_register() call. This ends up cleaning up more code and making

[PATCH 13/13] staging: lustre: get rid of ldebugfs_remove()

2018-05-29 Thread Greg Kroah-Hartman
It was just a dumb wrapper around debugfs_remove_recursive() so just call the function properly. Also, there is no need to set the dentry to NULL, it's gone, who cares about it anymore... Cc: Oleg Drokin Cc: Andreas Dilger Cc: James Simmons Cc: NeilBrown Cc: Ingo Molnar Cc: Roman

[PATCH 02/13] staging: rtlwifi: don't check the return value of debugfs_create_file

2018-05-29 Thread Greg Kroah-Hartman
We never did anything with the return value, and it does not matter if the call succeeds or not (it's just debugging code), so don't even check it. Cc: Larry Finger Cc: Ping-Ke Shih Cc: Colin Ian King Cc: "Frank A. Cancio Bello" Cc: Nathan Chancellor Signed-off-by: Greg Kroah-Hartman ---

[PATCH v2 17/25] staging: lustre: libcfs: rename cpumask_var_t variables to *_mask

2018-05-29 Thread James Simmons
From: Dmitry Eremin Because we handle both cpu mask as well as core identifiers it can easily be confused. To avoid this rename various cpumask_var_t to have appended *_mask to their names. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on:

[PATCH v2 25/25] staging: lustre: ptlrpc: use current CPU instead of hardcoded 0

2018-05-29 Thread James Simmons
From: Dmitry Eremin fix crash if CPU 0 disabled. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8710 Reviewed-on: https://review.whamcloud.com/23305 Reviewed-by: Doug Oucharek Reviewed-by: Andreas Dilger Signed-off-by: James Simmons --- Changelog: v1) New

[PATCH v2 19/25] staging: lustre: libcfs: update debug messages

2018-05-29 Thread James Simmons
From: Dmitry Eremin For cfs_cpt_bind() change the CERROR to CDEBUG. Make the debug message in cfs_cpt_table_create_pattern() more understandable. Report rc value for when cfs_cpt_create_table() fails. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703

[PATCH v2 20/25] staging: lustre: libcfs: make tolerant to offline CPUs and empty NUMA nodes

2018-05-29 Thread James Simmons
From: Dmitry Eremin Rework CPU partition code in the way of make it more tolerant to offline CPUs and empty nodes. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James

[PATCH v2 23/25] staging: lustre: libcfs: rework CPU pattern parsing code

2018-05-29 Thread James Simmons
From: Dmitry Eremin Currently the module param string for CPU pattern can be modified which is wrong. Rewrite CPU pattern parsing code to avoid the passed buffer from being changed. This change also enables us to add real errors propogation to the caller functions. Signed-off-by: Dmitry Eremin

[PATCH v2 24/25] staging: lustre: libcfs: change CPT estimate algorithm

2018-05-29 Thread James Simmons
From: Dmitry Eremin The main idea to have more CPU partitions is based on KNL experience. When a thread submit IO for network communication one of threads from current CPT is used for network stack. Whith high parallelization many threads become involved in network submission but having less CPU

[PATCH v2 22/25] staging: lustre: libcfs: update debug messages in CPT code

2018-05-29 Thread James Simmons
From: Dmitry Eremin Update the debug messages for the CPT table creation code. Place the passed in string in quotes to make it clear what it is. Captialize cpu in the debug strings. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on:

[PATCH v2 18/25] staging: lustre: libcfs: rename goto label in cfs_cpt_table_print

2018-05-29 Thread James Simmons
From: Dmitry Eremin Change goto label out to err. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons

[PATCH v2 13/25] staging: lustre: libcfs: fix libcfs_cpu coding style

2018-05-29 Thread James Simmons
From: Dmitry Eremin This patch bring the lustre CPT code into alignment with the Linux kernel coding style. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23304 Reviewed-by: James Simmons Reviewed-by: Doug

[PATCH v2 16/25] staging: lustre: libcfs: rename i to cpu for cfs_cpt_bind

2018-05-29 Thread James Simmons
From: Dmitry Eremin Rename variable i to cpu to make code easier to understand. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin

[PATCH v2 15/25] staging: lustre: libcfs: rename i to node for cfs_cpt_set_nodemask

2018-05-29 Thread James Simmons
From: Dmitry Eremin Rename variable i to node to make code easier to understand. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin

[PATCH v2 21/25] staging: lustre: libcfs: report NUMA node instead of just node

2018-05-29 Thread James Simmons
From: Dmitry Eremin Reporting "HW nodes" is too generic. It really is reporting "HW NUMA nodes". Update the debug message. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23306 Reviewed-by: James Simmons

[PATCH v2 08/25] staging: lustre: libcfs: NUMA support

2018-05-29 Thread James Simmons
From: Amir Shehata This patch adds NUMA node support. NUMA node information is stored in the CPT table. A NUMA node mask is maintained for the entire table as well as for each CPT to track the NUMA nodes related to each of the CPTs. Add new function cfs_cpt_of_node() which returns the CPT of a

[PATCH v2 14/25] staging: lustre: libcfs: use int type for CPT identification.

2018-05-29 Thread James Simmons
From: Dmitry Eremin Use int type for CPT identification to match the linux kernel CPU identification. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23304 Reviewed-by: James Simmons Reviewed-by: Doug Oucharek

[PATCH v2 12/25] staging: lustre: libcfs: invert error handling for cfs_cpt_table_print

2018-05-29 Thread James Simmons
From: Amir Shehata Instead of setting rc to -EFBIG for several cases in the loop lets just go to the out label on error which returns -E2BIG directly. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916

[PATCH v2 10/25] staging: lustre: libcfs: use distance in cpu and node handling

2018-05-29 Thread James Simmons
From: Amir Shehata Take into consideration the location of NUMA nodes and core when calling cfs_cpt_[un]set_cpu() and cfs_cpt_[un]set_node(). This enables functioning on platforms with 100s of cores and NUMA nodes. Signed-off-by: Amir Shehata Intel-bug-id:

[PATCH v2 01/25] staging: lustre: libcfs: restore UMP handling

2018-05-29 Thread James Simmons
With the cleanup of the libcfs SMP handling all UMP handling was removed. In the process now various NULL pointers and empty fields are return in the UMP case which causes lustre to crash hard. Restore the proper UMP handling so Lustre can properly function. Signed-off-by: James Simmons

[PATCH v2 04/25] staging: lustre: libcfs: properly handle failure cases in SMP code

2018-05-29 Thread James Simmons
While pushing the SMP work some bugs were pointed out by Dan Carpenter in the code. Due to single err label in cfs_cpu_init() and cfs_cpt_table_alloc() a few items were being cleaned up that were never initialized. This can lead to crashed and other problems. In those initialization function

[PATCH v2 09/25] staging: lustre: libcfs: add cpu distance handling

2018-05-29 Thread James Simmons
From: Amir Shehata Add functionality to calculate the distance between two CPTs. Expose those distance in debugfs so people deploying a setup can debug what is being created for CPTs. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on:

[PATCH v2 11/25] staging: lustre: libcfs: provide debugfs files for distance handling

2018-05-29 Thread James Simmons
From: Amir Shehata On systems with large number of NUMA nodes and cores it is easy to incorrectly configure their use with Lustre. Provide debugfs files which can help track down any issues. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on:

[PATCH v2 05/25] staging: lustre: libcfs: replace MAX_NUMNODES with nr_node_ids

2018-05-29 Thread James Simmons
From: Amir Shehata Replace MAX_NUMNODES which is considered deprocated with nr_nodes_ids. Looking at page_malloc.c you will see that nr_nodes_ids is equal to MAX_NUMNODES. MAX_NUMNODES is actually setup with Kconfig. Signed-off-by: Amir Shehata Intel-bug-id:

[PATCH v2 v2 07/25] staging: lustre: libcfs: replace num_possible_cpus() with nr_cpu_ids

2018-05-29 Thread James Simmons
From: Amir Shehata Move from num_possible_cpus() to nr_cpu_ids. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Signed-off-by: James Simmons --- Changelog:

[PATCH v2 00/25] staging: lustre: libcfs: SMP rework

2018-05-29 Thread James Simmons
From: James Simmons Recently lustre support has been expanded to extreme machines with as many as a 1000+ cores. On the other end lustre also has been ported to platforms like ARM and KNL which have uniquie NUMA and core setup. For example some devices exist that have NUMA nodes with no cores.

[PATCH v2 03/25] staging: lustre: libcfs: rename variable i to cpu

2018-05-29 Thread James Simmons
From: Dmitry Eremin Change the name of the variable i used for for_each_cpu() to cpu for code readability. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23303 Reviewed-by: James Simmons Reviewed-by: Doug

[PATCH v2 3/6] staging: lustre: llite: remove unused parameters from md_{get, set}xattr()

2018-05-29 Thread James Simmons
From: "John L. Hammond" md_getxattr() and md_setxattr() each have several unused parameters. Remove them and improve the naming or remaining parameters. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10792 Reviewed-on: https://review.whamcloud.com/

[PATCH v2 06/25] staging: lustre: libcfs: remove excess space

2018-05-29 Thread James Simmons
From: Amir Shehata The function cfs_cpt_table_print() was adding two spaces to the string buffer. Just add it once. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug

[PATCH v2 02/25] staging: lustre: libcfs: remove useless CPU partition code

2018-05-29 Thread James Simmons
From: Dmitry Eremin * remove scratch buffer and mutex which guard it. * remove global cpumask and spinlock which guard it. * remove cpt_version for checking CPUs state change during setup because of just disable CPUs state change during setup. * remove whole global struct cfs_cpt_data

[PATCH v2 6/6] staging: lustre: mdc: use large xattr buffers for old servers

2018-05-29 Thread James Simmons
From: "John L. Hammond" Pre 2.10.1 MDTs will crash when they receive a listxattr (MDS_GETXATTR with OBD_MD_FLXATTRLS) RPC for an orphan or dead object. So for clients connected to these older MDTs, try to avoid sending listxattr RPCs by making the bulk getxattr (MDS_GETXATTR with

[PATCH v2 1/6] staging: lustre: llite: create acl.c file

2018-05-29 Thread James Simmons
Move ll_get_acl() to its own file acl.c just like all the other linux file systems do. Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6142 Signed-off-by: James Simmons --- Changelog: v1) Initial patch to add acl.c file which contains acl handling for lustre

[PATCH v2 4/6] staging: lustre: acl: increase ACL entries limitation

2018-05-29 Thread James Simmons
From: Fan Yong Originally, the limitation of ACL entries is 32, that is not enough for some use cases. In fact, restricting ACL entries count is mainly for preparing the RPC reply buffer to receive the ACL data. So we cannot make the ACL entries count to be unlimited. But we can enlarge the RPC

[PATCH v2 2/6] staging: lustre: llite: add support set_acl method in inode operations

2018-05-29 Thread James Simmons
From: Dmitry Eremin Linux kernel v3.14 adds set_acl method to inode operations. This patch adds support to Lustre for proper acl management. Signed-off-by: Dmitry Eremin Signed-off-by: John L. Hammond Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183

[PATCH v2 5/6] staging: lustre: mdc: excessive memory consumption by the xattr cache

2018-05-29 Thread James Simmons
From: Andrew Perepechko The refill operation of the xattr cache does not know the reply size in advance, so it makes a guess based on the maxeasize value returned by the MDS. In practice, it allocates 16 KiB for the common case and 4 MiB for the large xattr case. However, a typical reply is

[PATCH v2 0/6] staging: lustre: llite: remaining xattr patches

2018-05-29 Thread James Simmons
From: James Simmons Fixed the bugs in the set_acl patch pointed out by Dan Carpenter. Rebased the next patch 'remove unused parameter..." on the parent patch. Created new acl.c file to match what other linx kernel file systems do. Added newer xattr fixes that were recently pushed. Andrew

[PATCH] Staging:media:imx Fix multiple assignments in a line

2018-05-29 Thread Janani Sankara Babu
This patch solves multiple assignments warning shown by checkpatch script. Signed-off-by: Janani Sankara Babu --- drivers/staging/media/imx/imx-media-csi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/imx/imx-media-csi.c

Re: [PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Petr Machata
Dan Carpenter writes: > On Mon, May 28, 2018 at 05:11:04PM +0200, Petr Machata wrote: >> @@ -580,6 +591,9 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 >> flags, bool *changed) >> vg->num_vlans++; >> *changed = true; >> } >> +

Re: [PATCH v2] media: staging: tegra-vde: Reset memory client

2018-05-29 Thread Dmitry Osipenko
On 29.05.2018 09:18, Hans Verkuil wrote: > Hi Dmitry, > > On 05/26/2018 04:27 PM, Dmitry Osipenko wrote: >> DMA requests must be blocked before resetting VDE HW, otherwise it is >> possible to get a memory corruption or a machine hang. Use the reset >> control provided by the Memory Controller to

Re: [PATCH net-next v3 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-29 Thread Vivien Didelot
Hi Petr, Petr Machata writes: > A call to switchdev_port_obj_add() or switchdev_port_obj_del() involves > initializing a struct switchdev_obj_port_vlan, a piece of code that > repeats on each call site almost verbatim. While in the current codebase > there is just one duplicated add call, the

Re: [PATCH] staging: mt7621-eth: Refactor RX ring resource allocation and cleanup

2018-05-29 Thread Dan Carpenter
On Mon, May 21, 2018 at 09:37:31AM +1000, NeilBrown wrote: > On Fri, May 18 2018, Kamal Heib wrote: > > > Simplify the code of allocate and cleanup RX ring resources by using > > helper functions, also make sure to free the allocated resources in > > cause of allocation failure. > > > >

[PATCH] Staging:rtl888eu:include Fix CamelCase issue

2018-05-29 Thread Janani Sankara Babu
This patch is created to solve the CamelCase issue. The members 'IEs' and 'IELength' of struct wlan_bssid_ex are being modified to 'ie' and 'ie_length' to solve the issue. And the places where these variables are referenced inside rtl8188eu driver are also changed. Signed-off-by: Janani Sankara

Re: [PATCH net-next v3 0/7] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Ido Schimmel
On Tue, May 29, 2018 at 01:46:09PM +0300, Dan Carpenter wrote: > It occured to me that I should read the cover letter and here are the > answers I was looking for. But the cover letter isn't saved after the > commits are merged. DaveM adds the cover letter to the merge commit.

Re: [PATCH net-next v3 0/7] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Dan Carpenter
On Tue, May 29, 2018 at 01:58:53PM +0300, Ido Schimmel wrote: > On Tue, May 29, 2018 at 01:46:09PM +0300, Dan Carpenter wrote: > > It occured to me that I should read the cover letter and here are the > > answers I was looking for. But the cover letter isn't saved after the > > commits are

Re: [PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Dan Carpenter
On Mon, May 28, 2018 at 05:11:04PM +0200, Petr Machata wrote: > @@ -580,6 +591,9 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 > flags, bool *changed) > vg->num_vlans++; > *changed = true; > } > + ret =

Re: [PATCH net-next v3 0/7] net: bridge: Notify about bridge VLANs

2018-05-29 Thread Dan Carpenter
On Mon, May 28, 2018 at 05:10:22PM +0200, Petr Machata wrote: > In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap > mirror"), mlxsw got support for offloading mirror-to-gretap such that > the underlay packet path involves a bridge. In that case, the offload is > also

Re: [PATCH net-next v3 2/7] mlxsw: spectrum_switchdev: Ignore bridge VLAN events

2018-05-29 Thread Dan Carpenter
On Mon, May 28, 2018 at 05:10:40PM +0200, Petr Machata wrote: > Ignore VLAN events where the orig_dev is the bridge device itself. > I don't know this code, and I have not looked at it either... But this changelog just says what you are doing and not why. Is this a bug fix? What are the user

Re: [PATCH net-next v3 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-29 Thread Dan Carpenter
On Mon, May 28, 2018 at 05:10:28PM +0200, Petr Machata wrote: > /* Try switchdev op first. In case it is not supported, fallback to >* 8021q add. >*/ > - err = switchdev_port_obj_add(dev, ); > + int err = br_switchdev_port_vlan_add(dev, vid, flags); > if (err ==

Re: [PATCH net-next v2 3/7] rocker: rocker_main: Ignore bridge VLAN events

2018-05-29 Thread Ilias Apalodimas
Hi Petr, On Mon, May 28, 2018 at 12:50:09PM +0200, Petr Machata wrote: > Ignore VLAN events where the orig_dev is the bridge device itself. > > Signed-off-by: Petr Machata > --- > drivers/net/ethernet/rocker/rocker_main.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [PATCH v2] media: staging: tegra-vde: Reset memory client

2018-05-29 Thread Hans Verkuil
Hi Dmitry, On 05/26/2018 04:27 PM, Dmitry Osipenko wrote: > DMA requests must be blocked before resetting VDE HW, otherwise it is > possible to get a memory corruption or a machine hang. Use the reset > control provided by the Memory Controller to block DMA before resetting > the VDE HW. > >