Re: [staging:staging-testing 754/791] drivers/staging/lustre/lustre/ptlrpc/errno.c:49:3: error: 'ENXIO' undeclared here (not in a function)

2018-05-30 Thread NeilBrown
On Sat, May 26 2018, Greg Kroah-Hartman wrote: > On Fri, May 25, 2018 at 09:40:09PM +0200, Greg Kroah-Hartman wrote: >> On Sat, May 26, 2018 at 02:04:59AM +0800, kbuild test robot wrote: >> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git >> > staging-testing >> >

Re: [PATCH v2] staging: mt7621-gpio: update #interrupt-cells for the gpio node

2018-05-30 Thread NeilBrown
On Wed, May 30 2018, Sergio Paracuellos wrote: > Most gpio chips have two cells for interrupts and this should be also. > Set this property in the device tree accordly fixing this up. In order > to make this working properly the xlate function for the irq_domain must > be updated to use the

[staging:debugfs_cleanup 814/814] arch/powerpc/platforms/powernv/opal-lpc.c:379:37: error: 'root' undeclared; did you mean 'ror8'?

2018-05-30 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git debugfs_cleanup head: cfe0305886b14a4f65cba2014f1963db2a534113 commit: cfe0305886b14a4f65cba2014f1963db2a534113 [814/814] arch/*: no need to check return value of debugfs_create functions config: powerpc-defconfig

Re: [PATCH] staging: lustre: include linux/highmem.h when needed

2018-05-30 Thread NeilBrown
On Wed, May 30 2018, Arnd Bergmann wrote: > Something in recent linux-next kernels caused linux/highmem.h to > no longer be included implicitly from o2iblnd_cb.c, causing a build > failure: > > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c: In function > 'kiblnd_kvaddr_to_page': >

Re: [PATCH] ANDROID: binder: rename parameter to resolve name collision.

2018-05-30 Thread kuangrufan
> Why is this needed? These don't collide in the namespace: Sorry, I check it again, you’re right. my bad. PS: I need to change the binder API between 32bit & 64bit dynamically. So I was trying to compile binder as a “.ko”. I compiled the 2 files into the same kernel module, which causes problem.

[PATCH net-next] hv_netvsc: fix error return code in netvsc_probe()

2018-05-30 Thread Wei Yongjun
Fix to return a negative error code from the failover register fail error handling case instead of 0, as done elsewhere in this function. Fixes: 1ff78076d8dd ("netvsc: refactor notifier/event handling code to use the failover framework") Signed-off-by: Wei Yongjun ---

Re: [PATCH v2] staging: mt7621-mmc: Fix line size exceeding 80 columns

2018-05-30 Thread NeilBrown
On Thu, May 31 2018, Sankalp Negi wrote: > This patch fixes checkpatch.pl warning and check: > WARNING: line over 80 characters > CHECK: Alignment should match open parenthesis > > Signed-off-by: Sankalp Negi Reviewed-by: NeilBrown Thanks, NeilBrown > --- > Changes in v2: > - Made

[PATCH] staging: lustre: include linux/highmem.h when needed

2018-05-30 Thread Arnd Bergmann
Something in recent linux-next kernels caused linux/highmem.h to no longer be included implicitly from o2iblnd_cb.c, causing a build failure: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c: In function 'kiblnd_kvaddr_to_page':

Re: [PATCH 04/13] staging: vc04_services: no need to check debugfs return values

2018-05-30 Thread Eric Anholt
Greg Kroah-Hartman writes: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Clean up the vchiq_arm code by not caring about the value of debugfs > calls.

RE: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-05-30 Thread KY Srinivasan
> -Original Message- > From: Sunil Muthuswamy > Sent: Wednesday, May 30, 2018 12:40 PM > To: Greg KH ; Haiyang Zhang > ; Stephen Hemminger > ; KY Srinivasan > Cc: de...@linuxdriverproject.org > Subject: RE: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump > over Hyper-V during

RE: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-05-30 Thread Sunil Muthuswamy
The maintainers of Hyper-V; Haiyang Zhang and Stephen Hemminger have always been included since the beginning in all mail & patches. I missed K. Y. Srinivasan, whom I have added now. @KY Srinivasan, @Stephen Hemminger, @Haiyang Zhang - Can we get some reviews/sign-offs? Thanks, Sunil >

[PATCH v2] staging: mt7621-mmc: Fix line size exceeding 80 columns

2018-05-30 Thread Sankalp Negi
This patch fixes checkpatch.pl warning and check: WARNING: line over 80 characters CHECK: Alignment should match open parenthesis Signed-off-by: Sankalp Negi --- Changes in v2: - Made alignments to match open parenthesis. --- drivers/staging/mt7621-mmc/dbg.c | 3 ++- 1 file changed, 2

[staging:debugfs_cleanup 814/814] arch/x86//kernel/kdebugfs.c:146:3: error: label 'err_data' used but not defined

2018-05-30 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git debugfs_cleanup head: 05f6bcf9002239baec3686f19f6b279cb67dccbd commit: 05f6bcf9002239baec3686f19f6b279cb67dccbd [814/814] arch/*: no need to check return value of debugfs_create functions config:

Re: [PATCH net-next v4 7/8] net: bridge: Notify about bridge VLANs

2018-05-30 Thread Nikolay Aleksandrov
On 30/05/18 04:00, Petr Machata wrote: > A driver might need to react to changes in settings of brentry VLANs. > Therefore send switchdev port notifications for these as well. Reuse > SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use > netif_is_bridge_master() on orig_dev to

[staging:debugfs_cleanup 814/814] arch/x86/kernel/kdebugfs.c:151:17: error: 'data' undeclared

2018-05-30 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git debugfs_cleanup head: 4c08a9f6835cff642bc71face6ab47ebfdeda70c commit: 4c08a9f6835cff642bc71face6ab47ebfdeda70c [814/814] arch/*: no need to check return value of debugfs_create functions config:

Re: [PATCH net-next v4 2/8] net: bridge: Extract br_vlan_add_existing()

2018-05-30 Thread Nikolay Aleksandrov
On 30/05/18 03:56, Petr Machata wrote: > Extract the code that deals with adding a preexisting VLAN to bridge CPU > port to a separate function. A follow-up patch introduces a need to roll > back operations in this block due to an error, and this split will make > the error-handling code clearer.

Re: [PATCH net-next v4 1/8] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-30 Thread Nikolay Aleksandrov
On 30/05/18 03:56, Petr Machata wrote: > A call to switchdev_port_obj_add() or switchdev_port_obj_del() involves > initializing a struct switchdev_obj_port_vlan, a piece of code that > repeats on each call site almost verbatim. While in the current codebase > there is just one duplicated add call,

[staging:debugfs_cleanup 814/814] arch/x86//kernel/kdebugfs.c:153:17: error: 'version' undeclared; did you mean 'err_version'?

2018-05-30 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git debugfs_cleanup head: 4c08a9f6835cff642bc71face6ab47ebfdeda70c commit: 4c08a9f6835cff642bc71face6ab47ebfdeda70c [814/814] arch/*: no need to check return value of debugfs_create functions config:

Re: [PATCH 1/2] staging: wilc1000: fix some endianness sparse warnings

2018-05-30 Thread Ajay Singh
On Tue, 29 May 2018 21:11:43 +0200 Thibaut Robert wrote: > This commit fix a few sparse warnings. It mostly consists of fixing > the type declarations and avoiding the use of variables with mixed > endianness values. > > Signed-off-by: Thibaut Robert > --- >

Re: [PATCH] staging: lustre: libcfs: add parens around macros args

2018-05-30 Thread Dan Carpenter
On Tue, May 22, 2018 at 04:34:39PM +0300, Ivan Bornyakov wrote: > One may call 'CFS_FAIL_TIMEOUT(id, secs + 5);' and get unexpected result > after macro substitution, viz., 'secs + 5' will turn into > 'secs + 5 * 1000' > We actually do that in ptl_send_rpc() as well so this is a real bug. It's

Re: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-05-30 Thread Dan Carpenter
Gmail really seems to hate @microsoft.com addresses... I never get Dexuan's emails either. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v1] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-05-30 Thread Dan Carpenter
It's weird, I only get Greg's side of this thread. Sunil's emails are going to the list: https://marc.info/?l=linux-driver-devel=152762471013289=2 But they're not getting to my gmail account. I've checked the spam folder as well and they're not there. Anyone else having this issue? regards,

Re: [PATCH 1/1] staging: wilc1000: Use common structs to parse ip packets

2018-05-30 Thread Dan Carpenter
On Tue, May 29, 2018 at 09:08:39PM +0200, Thibaut Robert wrote: > static inline void tcp_process(struct net_device *dev, struct txq_entry_t > *tqe) > { > - u8 *eth_hdr_ptr; > + const struct ethhdr *eth_hdr_ptr = (const struct ethhdr *)tqe->buffer; > + > u8 *buffer = tqe->buffer;

Re: [PATCH 1/2] staging: wilc1000: fix some endianness sparse warnings

2018-05-30 Thread Dan Carpenter
On Tue, May 29, 2018 at 09:11:43PM +0200, Thibaut Robert wrote: > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > index e248702ee519..745bf5ca2622 100644 > --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > +++

Re: [PATCH v2 01/25] staging: lustre: libcfs: restore UMP handling

2018-05-30 Thread Dan Carpenter
On Tue, May 29, 2018 at 10:21:41AM -0400, James Simmons wrote: > @@ -208,20 +222,52 @@ void cfs_cpt_unset_nodemask(struct cfs_cpt_table *cptab, > void cfs_cpu_fini(void); > > #else /* !CONFIG_SMP */ > -struct cfs_cpt_table; > -#define cfs_cpt_tab ((struct cfs_cpt_table *)NULL) > > -static

Re: [PATCH] staging: mt7621-eth: Refactor RX ring resource allocation and cleanup

2018-05-30 Thread Dan Carpenter
On Wed, May 30, 2018 at 11:16:10AM +1000, NeilBrown wrote: > "obviously" we would first fix mtk_rx_free_frags() to do the right thing > if ring->rx_data were NULL. This is a crucial part of robust error > handling. > The very best error handling style is devm_*. When that is not > practical,