Re: [bug report] staging: mt7621-pinctrl: ralink: add pinctrl driver

2018-06-21 Thread Sergio Paracuellos
Hi Dan, There are some patches (they haven't been tested now, I think) that should solve the issue pointed here. The following should resolve it: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-June/121761.html Best regards, Sergio Paracuellos

pi433: initialization of tx config in pi433_open()

2018-06-21 Thread Hugo Lefeuvre
Hi Marcus, I'm currently working on the following TODO: 966 /* setup instance data*/ 967 instance->device = device; 968 instance->tx_cfg.bit_rate = 4711; 969 // TODO: fill instance->tx_cfg; If a user calls write() right after open()-ing an instance, the

Re: rf69_set_deviation in rf69.c (pi433 driver)

2018-06-21 Thread Hugo Lefeuvre
Hi Marcus, > > According to the datasheet[0], the deviation should always be smaller > > than 300kHz, and the following equation should be respected: > > > > (1) FDA + BRF/2 =< 500 kHz > > > > Why did you choose 500kHz as max for FDA, instead of 300kHz ? It looks like > > a bug to me. > > My

[PATCH] staging: rtl8723bs: remove rtw_set_tx_chksum_offload()

2018-06-21 Thread Michael Straube
The function rtw_set_tx_chksum_offload() has empty definition. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 -- drivers/staging/rtl8723bs/include/xmit_osdep.h | 2 -- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 5 - 3 files changed, 9

[PATCH] staging: rtl8723bs: do not use assignment in if condition

2018-06-21 Thread Michael Straube
Fix checkpatch error 'do not use assignment in if condition'. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c

[PATCH] staging: rtl8723bs: fix comparsion to NULL - coding style

2018-06-21 Thread Michael Straube
Fix comparsion to NULL issues found by checkpatch. Use !x instead of x == NULL. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c

Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key

2018-06-21 Thread Chris Opperman
Hi Dan, The header also states "DO NOT EDIT OR MODIFY". As you suggested, I will rather leave this patch for now. P.S. Please advise if there is anything specific I can help out with, or I'll keep looking for more obvious fixes I can make while I'm learning the ropes. Kind Regards, Chris

what you need

2018-06-21 Thread Simon Ryan
We provide you a complete image editing package. Our service includes: Image Retouching Clipping Path Image Masking White Background Selective Color Change Image Enhancement Image Manipulation Color Correction Image Restoration Background Change Satisfaction guarantee 24 hours TAT Fast and

[PATCH v2] x86/hyper-v: use cheaper HVCALL_FLUSH_VIRTUAL_ADDRESS_{LIST, SPACE} hypercalls when possible

2018-06-21 Thread Vitaly Kuznetsov
While working on Hyper-V style PV TLB flush support in KVM I noticed that real Windows guests use TLB flush hypercall in a somewhat smarter way: when the flush needs to be performed on a subset of first 64 vCPUs or on all present vCPUs Windows avoids more expensive hypercalls which support sparse

Re: [PATCH] staging: android: ion: fix ion_dma_buf_attach signatur

2018-06-21 Thread Christian König
Am 21.06.2018 um 08:34 schrieb Daniel Vetter: On Wed, Jun 20, 2018 at 08:52:19PM +0200, Christian König wrote: Fixup for "dma_buf: remove device parameter from attach callback v2". I missed this driver, sorry for the noise. Patch is not even compile tested. Signed-off-by: Christian König

[bug report] staging: mt7621-pinctrl: ralink: add pinctrl driver

2018-06-21 Thread Dan Carpenter
Hello NeilBrown, The patch 0317d60de869: "staging: mt7621-pinctrl: ralink: add pinctrl driver" from Mar 15, 2018, leads to the following static checker warning: drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:144 rt2880_pinctrl_dt_node_to_map() info: return a literal instead of

Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key

2018-06-21 Thread Dan Carpenter
On Thu, Jun 21, 2018 at 06:42:52AM +0200, Chris Opperman wrote: > Hi Dan, > > I agree completely. I was concerned whether the preprocessor definitions in > p80211metadef.h were named according to some convention as there are > many definitions named similarly there. > Yeah, sure but in that

Re: [PATCH] staging: android: ion: fix ion_dma_buf_attach signatur

2018-06-21 Thread Daniel Vetter
On Wed, Jun 20, 2018 at 08:52:19PM +0200, Christian König wrote: > Fixup for "dma_buf: remove device parameter from attach callback v2". > > I missed this driver, sorry for the noise. Patch is not even compile > tested. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter Also