Re: [PATCH v5 18/18] staging: mt7621-gpio: avoid use banks in device tree

2018-06-29 Thread NeilBrown
On Mon, Jun 18 2018, Sergio Paracuellos wrote: > Banks shouldn't be defined in DT if number of resources > per bank is not variable. We actually know that this SoC > has three banks so take that into account in order to don't > overspecify the device tree. Device tree will only have one > node

[PATCH net] hv_netvsc: split sub-channel setup into async and sync

2018-06-29 Thread Haiyang Zhang
From: Stephen Hemminger When doing device hotplug the sub channel must be async to avoid deadlock issues because device is discovered in softirq context. When doing changes to MTU and number of channels, the setup must be synchronous to avoid races such as when MTU and device settings are done

Hello

2018-06-29 Thread Margaret Kwan Wing Han
I believe you've a busy schedule and this is the only means I can get to you, I have a deal for you rely for more details ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Sergio Paracuellos
On Fri, Jun 29, 2018 at 6:52 PM, Sergio Paracuellos wrote: > On Fri, Jun 29, 2018 at 6:43 PM, kbuild test robot wrote: >> Hi Sergio, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on gpio/for-next] >> [also buil

[PATCH] staging: rtl8188eu: remove unnecessary parentheses

2018-06-29 Thread Michael Straube
Remove unnecessary parentheses as reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 ++-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c

Re: [PATCH] staging: fbtft: fix line indent

2018-06-29 Thread Greg KH
On Fri, Jun 29, 2018 at 05:20:32PM +0200, Radek Dostál wrote: > Signed-off-by: Radek Dostál > --- > drivers/staging/fbtft/fbtft_device.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that

[PATCH 2/3] staging: rtl8192u Remove redundant #include directive

2018-06-29 Thread John Whitmore
The file includes the file rtl819x_HT.h, which has already been included by the previously included file ieee80211.h Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/3] staging: rtl8192u: Use __func__ instead of hardcoded string - Style

2018-06-29 Thread John Whitmore
Chnaged logging statements to use %s and __func__ instead of hard coding the function name in a string. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

staging: rtl8192u: RFC - harmonisation of rtl819x_HT.h ?

2018-06-29 Thread John Whitmore
This patch set includes two fairly trivial patches but the third patch is possibly controversial. There are two files called rtl819x_HT.h $ find -name rtl819x_HT.h -print ./drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h ./drivers/staging/rtl8192e/rtl819x_HT.h The two files are very similar but

[PATCH 3/3] staging: rtl8192u: Prune the rtl819x_HT.h file of unused definitions.

2018-06-29 Thread John Whitmore
There are two files named "rtl819x_HT.h" $ find . -name rtl819x_HT.h -print ./drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h ./drivers/staging/rtl8192e/rtl819x_HT.h The two files are very similar but differ slightly. Unsed definitions have been removed from

Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Sergio Paracuellos
On Fri, Jun 29, 2018 at 6:43 PM, kbuild test robot wrote: > Hi Sergio, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on gpio/for-next] > [also build test ERROR on v4.18-rc2 next-20180629] > [if your patch is applied to the wrong git tree,

Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread kbuild test robot
Hi Sergio, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.18-rc2 next-20180629] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCH] staging: fbtft: fix line indent

2018-06-29 Thread Radek Dostál
Signed-off-by: Radek Dostál --- drivers/staging/fbtft/fbtft_device.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index 4a54b46..cad244c 100644 ---

Re: [PATCH 2/2] pci: host: pci-hyperv: Replace GFP_ATOMIC with GFP_KERNEL in new_pcichild_device

2018-06-29 Thread Lorenzo Pieralisi
On Sun, Mar 18, 2018 at 10:53:28PM +0800, Jia-Ju Bai wrote: > new_pcichild_device() is not called in atomic context. > > The call chain ending up at new_pcichild_device() is: > [1] new_pcichild_device() <- pci_devices_present_work() > pci_devices_present_work() is only set in INIT_WORK(). > >

Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Sergio Paracuellos
On Fri, Jun 29, 2018 at 3:31 PM, Dan Carpenter wrote: > Looks pretty clean to me. Sorry for not reviewing v1. Smatch (private > devel version) points out a little bit of dead code. > > drivers/staging/mt7621-gpio/gpio-mt7621.c:200 mediatek_gpio_irq_handler() > warn: address of

Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Dan Carpenter
On Fri, Jun 29, 2018 at 04:31:35PM +0300, Dan Carpenter wrote: > Looks pretty clean to me. Sorry for not reviewing v1. Smatch (private > devel version) points out a little bit of dead code. > > drivers/staging/mt7621-gpio/gpio-mt7621.c:200 mediatek_gpio_irq_handler() > warn: address of

Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Dan Carpenter
Looks pretty clean to me. Sorry for not reviewing v1. Smatch (private devel version) points out a little bit of dead code. drivers/staging/mt7621-gpio/gpio-mt7621.c:200 mediatek_gpio_irq_handler() warn: address of 'gpio_data->gc_map[i]' is non-NULL drivers/staging/mt7621-gpio/gpio-mt7621.c:225

Re: [PATCH 2/2] staging: goldfish: cleanup in goldfish_audio

2018-06-29 Thread Dan Carpenter
On Thu, Jun 28, 2018 at 06:19:14PM -0700, r...@google.com wrote: > From: Roman Kiryanov > > * added a mutex to protect open/read/write/release calls; > * put the global atomic counter for opened files into the > driver state; > * retired the global variable for the driver state; These three

[PATCH v3 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Sergio Paracuellos
Add driver support for gpio of MT7621 SoC. Signed-off-by: Sergio Paracuellos --- drivers/gpio/Kconfig | 8 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-mt7621.c | 320 + 3 files changed, 329 insertions(+) create mode 100644

[PATCH v3 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-29 Thread Sergio Paracuellos
Add a devicetree binding documentation for the mt7621 gpio. Signed-off-by: Sergio Paracuellos --- .../bindings/gpio/mediatek,mt7621-gpio.txt | 35 ++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/mediatek,mt7621-gpio.txt

[PATCH v3 0/2] gpio: mediatek: driver for gpio chip in MT7621 SoC

2018-06-29 Thread Sergio Paracuellos
This patch series add support for gpio driver in mediatek MT7621 SoC. This driver has been in staging for a while and after some cleanups cycles we consider to give it a new try to get mainlined. Previous comments from Linus Walleij are here:

[PATCH v2 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-29 Thread Sergio Paracuellos
Add a devicetree binding documentation for the mt7621 gpio. Signed-off-by: Sergio Paracuellos --- .../bindings/gpio/mediatek,mt7621-gpio.txt | 35 ++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/mediatek,mt7621-gpio.txt

[PATCH v2 0/2] gpio: mediatek: driver for gpio chip in MT7621 SoC

2018-06-29 Thread Sergio Paracuellos
This patch series add support for gpio driver in mediatek MT7621 SoC. This driver has been in staging for a while and after some cleanups cycles we consider to give it a new try to get mainlined. Previous comments from Linus Walleij are here:

[PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Sergio Paracuellos
Add driver support for gpio of MT7621 SoC. Signed-off-by: Sergio Paracuellos --- drivers/gpio/Kconfig | 8 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-mt7621.c | 320 + 3 files changed, 329 insertions(+) create mode 100644

Re: [PATCH] PCI: hv: Fix a __local_bh_enable_ip warning in hv_compose_msi_msg()

2018-06-29 Thread Lorenzo Pieralisi
On Wed, Jun 13, 2018 at 10:50:05PM +, Dexuan Cui wrote: > > From: Bjorn Helgaas > > Sent: Wednesday, June 13, 2018 15:15 > > > ... > > > It looks Lorenzo's pci.git tree has not been updated for 3+ weeks. > > > I guess Lorenzo may be on vacation. > > > > > > @Bjorn, can this patch go through

Re: [PATCH 4/4] staging:iio:adc:ad7280a: Use GFP_ATOMIC in interrupt handler

2018-06-29 Thread Dan Carpenter
On Fri, Jun 29, 2018 at 01:49:28AM +0200, Karim Eshapa wrote: > Use GFP_ATOMIC rather GFP_KERNEL in interrupt handler, > as GFP_KERNEL may sleep according to slab allocator. > This is a threaded IRQ so it can sleep. You should always think about the impact of a bug. If this were a bug it would

Re: [PATCH 1/2] staging: goldfish: fix whitespace in goldfish_audio

2018-06-29 Thread Greg KH
On Thu, Jun 28, 2018 at 06:19:13PM -0700, r...@google.com wrote: > From: Roman Kiryanov > > Linux kernel coding style: spaces are never used for > indentation. > > Signed-off-by: Roman Kiryanov > --- > drivers/staging/goldfish/goldfish_audio.c | 15 --- > 1 file changed, 8

Re: [PATCH 2/2] staging: goldfish: cleanup in goldfish_audio

2018-06-29 Thread Greg KH
On Thu, Jun 28, 2018 at 06:19:14PM -0700, r...@google.com wrote: > From: Roman Kiryanov > > * added a mutex to protect open/read/write/release calls; > * put the global atomic counter for opened files into the > driver state; > * retired the global variable for the driver state; > * retired

Re: [PATCH] Remove references to the retired driver from README

2018-06-29 Thread Greg KH
On Thu, Jun 28, 2018 at 01:33:23PM -0700, r...@google.com wrote: > From: Roman Kiryanov > > The goldfish nand driver was retired (not used). > > Signed-off-by: Roman Kiryanov > --- > drivers/staging/goldfish/README | 6 -- > 1 file changed, 6 deletions(-) Your subject line needs to say