[PATCH 1/1] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-07-07 Thread kys
From: Sunil Muthuswamy In the VM mode on Hyper-V, currently, when the kernel panics, an error code and few register values are populated in an MSR and the Hypervisor notified. This information is collected on the host. The amount of information currently collected is found to be limited and not

[RFC PATCH v1] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-07 Thread Jacob Feder
Hi all, I have developed this driver for a Xilinx-provided IP block for their Zynq SoC. I fixed all of the checkpatch.pl problems I knew how to. If someone could chime in on how to fix the remaining few it would be appreciated. Also looking for feedback on general structure. It's my first driver

[PATCH] staging: mt7621-pci: refactor pci related read and writes functions

2018-07-07 Thread Sergio Paracuellos
This commit simplifies and clean a lot of stuff related with pci reads and writes. It deletes a lot of not needed at all functions and use kernel arch operations read[b,w,l] and write[b,w,l] instead of use custom macros. It also include one function helper called 'mt7621_pci_get_cfgaddr' to easily

[PATCH v1] media: staging: tegra-vde: Replace debug messages with trace points

2018-07-07 Thread Dmitry Osipenko
Trace points are much more efficient than debug messages for extensive tracing and could be conveniently enabled / disabled dynamically, hence let's replace debug messages with the trace points. Signed-off-by: Dmitry Osipenko --- drivers/staging/media/tegra-vde/tegra-vde.c | 221

[PATCH 07/12] staging:rtl8192u: Correct spacing before and after parenthesis - Style

2018-07-07 Thread John Whitmore
Corrected coding style issues aroung opening and closed parenthesis. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 78 +-- 1 file changed, 36 insertions(+), 42 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

[PATCH 11/12] staging:rtl8192u: Correct indentation of ieee80211_softmac_new_net()

2018-07-07 Thread John Whitmore
Coding style change to correct the indentation of the function ieee80211_softmac_new_net() Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 101 +- 1 file changed, 50 insertions(+), 51 deletions(-) diff --git

[PATCH 08/12] staging:rtl8192u: Remove prohibited spaces - Coding Style

2018-07-07 Thread John Whitmore
Simple removal of spaces prohibited by the coding standard. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

[PATCH 12/12] staging:rtl8192u: Correction of indentation issues - Coding Style

2018-07-07 Thread John Whitmore
Simple changes to correct indentation issues. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 24 +-- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

[PATCH 09/12] staging:rtl8192u: Move trailing conditional statement to the following line

2018-07-07 Thread John Whitmore
Coding standard requires that the conditional statement is not on the same line as the 'if' or 'else' but on the following line. Statements moved accordingly. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 25 +-- 1 file changed, 17

[PATCH 10/12] staging:rtl8192u: Remove unnecessary parentheses - Coding Style

2018-07-07 Thread John Whitmore
checkpatch.pl flags unnecessary parentheses so removed from code. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

[PATCH 05/12] staging:rtl8192u: Correct indentation and spacing for braces of code blocks

2018-07-07 Thread John Whitmore
Simple style change to fix the indentaiton and spacing of the braces around multi ling code blocks. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 250 -- 1 file changed, 105 insertions(+), 145 deletions(-) diff --git

[PATCH 04/12] staging:rtl8192u: Add spaces required around operators - Coding Style

2018-07-07 Thread John Whitmore
Added the spaces, required by coding style, around the various operators. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 124 +- 1 file changed, 62 insertions(+), 62 deletions(-) diff --git

[PATCH 06/12] staging:rtl8192u: rename HT_EXTCHNL_OFFSET -> enum ht_extension_chan_width

2018-07-07 Thread John Whitmore
remove the typedef of enumerated type HT_EXTCHNL_OFFSET and replace it with 'enum ht_extension_chan_offset' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211.h| 4 ++-- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 2 +-

[PATCH 03/12] staging:rtl8192u: Remove blank lines before '}' and after '{' characters

2018-07-07 Thread John Whitmore
Coding style change to simply remove the unrequired spaces before a closing brace or before an opening brace. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 44 ++- 1 file changed, 13 insertions(+), 31 deletions(-) diff --git

[PATCH 02/12] staging:rtl8192u: Add space required before '(' - Style

2018-07-07 Thread John Whitmore
Simple addition of the coding style required space before '('. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 174 +- 1 file changed, 86 insertions(+), 88 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

[PATCH 01/12] staging:rtl8192u: rename HT_CHANNEL_WIDTH -> enum ht_channel_width

2018-07-07 Thread John Whitmore
remove the typedef HT_CHANNEL_WIDTH and replace with 'enum ht_channel_width' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211.h| 4 ++-- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 4 ++-- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h

Re: [PATCH] staging: rtl8188eu: replace while with shorter for loop

2018-07-07 Thread Greg KH
On Sat, Jul 07, 2018 at 01:22:50PM +0200, Michael Straube wrote: > Simplify rtw_get_rateset_len() by replacing the while loop > with a shorter for loop. Also replace tabs with spaces in > the definition line. Normally I will insist that this be two separate patches, as you are doing two different

Re: [PATCH 3/3] drivers/speakup: kobjects : Fixed Coding issues -Debugging

2018-07-07 Thread Greg KH
On Thu, Jul 05, 2018 at 02:12:20AM +, Tamir Suliman wrote: > Updated printk() of i18n messages to include KERN_INFO facility level to > improve debuggin. > then later noticed that I forgot to add a space on printk. > > Signed-off-by: Tamir Suliman > --- > drivers/staging/speakup/kobjects.c

Re: [PATCH] staging: speakup: fix wraparound in uaccess length check

2018-07-07 Thread Greg Kroah-Hartman
On Sat, Jul 07, 2018 at 10:29:26AM +0200, Samuel Thibault wrote: > Re, > > Could you review, test, and resubmit the patch below instead? > > Samuel > > > If softsynthx_read() is called with `count < 3`, `count - 3` wraps, causing > the loop to copy as much data as available to the provided

[PATCH] staging: rtl8723bs: remove rtw_beamforming.h

2018-07-07 Thread Michael Straube
The header rtw_beamforming.h is not used anywhere. 'git grep rtw_beamforming.h' returns nothing, remove the file. Signed-off-by: Michael Straube --- .../rtl8723bs/include/rtw_beamforming.h | 127 -- 1 file changed, 127 deletions(-) delete mode 100644

[PATCH] staging: rtl8723bs: remove rtw_br_ext.h

2018-07-07 Thread Michael Straube
The header rtw_br_ext.h is not used anywhere. 'git grep rtw_br_ext.h' returns nothing, remove the file. Signed-off-by: Michael Straube --- .../staging/rtl8723bs/include/rtw_br_ext.h| 55 --- 1 file changed, 55 deletions(-) delete mode 100644

Re: [PATCH v1 1/2] ARM: dts: tegra20: Add Memory Client reset to VDE

2018-07-07 Thread Dmitry Osipenko
On Sunday, 20 May 2018 16:48:44 MSK Dmitry Osipenko wrote: > Hook up Memory Client reset of the Video Decoder to the decoders DT node. > > Signed-off-by: Dmitry Osipenko Thierry, is there anything I could do in order to get these patches applied?

Re: [PATCH] staging: speakup: fix wraparound in uaccess length check

2018-07-07 Thread Samuel Thibault
Jann Horn, le sam. 07 juil. 2018 10:22:52 +0200, a ecrit: > Or should I rewrite the > patch to be simple and just bail out on `count < 3`? Our mails have crossed :) I believe what I sent is correct: for softsynth it does not make sense to have room for less than 1 (non-unicode) or 3 (unicode)

Re: [PATCH] staging: speakup: fix wraparound in uaccess length check

2018-07-07 Thread Samuel Thibault
Re, Could you review, test, and resubmit the patch below instead? Samuel If softsynthx_read() is called with `count < 3`, `count - 3` wraps, causing the loop to copy as much data as available to the provided buffer. If softsynthx_read() is invoked through sys_splice(), this causes an unbounded

Re: [PATCH] staging: speakup: fix wraparound in uaccess length check

2018-07-07 Thread Samuel Thibault
Jann Horn, le sam. 07 juil. 2018 03:53:44 +0200, a ecrit: > @@ -257,6 +257,8 @@ static ssize_t softsynthx_read(struct file *fp, char > __user *buf, size_t count, > 0x80 | (ch & 0x3f) > }; > > + if (chars_sent + 2 > count) >

Re: [PATCH] staging: speakup: fix wraparound in uaccess length check

2018-07-07 Thread Greg Kroah-Hartman
On Sat, Jul 07, 2018 at 03:53:44AM +0200, Jann Horn wrote: > If softsynthx_read() is called with `count < 3`, `count - 3` wraps, causing > the loop to copy as much data as available to the provided buffer. If > softsynthx_read() is invoked through sys_splice(), this causes an > unbounded kernel

Re: [PATCH] drivers/staging/gasket: Use refcount_read()

2018-07-07 Thread Greg Kroah-Hartman
On Fri, Jul 06, 2018 at 11:43:10PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Use the refcount_read accessor function, avoid reaching into refcount > and atomic struct fields. > > Signed-off-by: Todd Poynor > --- > drivers/staging/gasket/gasket_sysfs.c | 2 +- > 1 file changed, 1

[PATCH 4/4] staging: mt7621-pci: Move open-braces to match kernel code style

2018-07-07 Thread Peter Vernia
Moves some open-braces to the end of the conditional statement to match the kernel's coding style Signed-off-by: Peter Vernia --- drivers/staging/mt7621-pci/pci-mt7621.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c

[PATCH 3/4] staging: mt7621-pci: Add spaces after commas in pci-mt7621.c

2018-07-07 Thread Peter Vernia
Adds spaces after commas in parameter lists in pci-mt7621.c Signed-off-by: Peter Vernia --- drivers/staging/mt7621-pci/pci-mt7621.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c

[PATCH 2/4] staging: mt7621-pci: Fix spacing around equals sign

2018-07-07 Thread Peter Vernia
Add spaces in front of the equals sign in assignment operations Signed-off-by: Peter Vernia --- drivers/staging/mt7621-pci/pci-mt7621.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c

[PATCH 1/4] staging: mt7621-pci: Fix spaces around parenthesis in pci-7621.c

2018-07-07 Thread Peter Vernia
Adds spaces before open parenthesis, and removes spaces after open parenthesis Signed-off-by: Peter Vernia --- drivers/staging/mt7621-pci/pci-mt7621.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c

Re: [PATCH] staging: mt7621-pinctrl: Replace unsigned with unsigned int

2018-07-07 Thread Peter Vernia
On Fri, Jul 06, 2018 at 05:37:49PM +0200, Greg Kroah-Hartman wrote: > Someone else sent this same change before you did, sorry :( Thanks for the review anyway. I realize now that I was looking at the wrong tree. ___ devel mailing list

[PATCH] drivers/staging/gasket: Use refcount_read()

2018-07-07 Thread Todd Poynor
From: Todd Poynor Use the refcount_read accessor function, avoid reaching into refcount and atomic struct fields. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_sysfs.c