On Mon, Aug 6, 2018 at 2:21 AM, NeilBrown wrote:
> On Fri, Aug 03 2018, Sergio Paracuellos wrote:
>
>> This patch series include an attempt to avoid the use of custom
>> read and writes in driver code and use PCI subsystem common ones.
>>
>> In order to do this 'map_bus' callback is implemented
Fix warning generated by checkpatch.pl for alignment should match open
parenthesis. This is a coding style change only.
Signed-off-by: Greg Gallagher
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
There is an extra semicolon in z_erofs_vle_unzip_all, remove it.
Reported-by: Julia Lawall
Signed-off-by: zhong jiang
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
zhongjiang also submitted a patch yesterday titled
"drivers/staging: Remove some unneeded semicolon"
Since it was
So should I change this into a revert patch, or you will revert commit
6efb21d6d0e7 ("staging:mt29f_spinand: MT29F2G failing as only 16 bits
used for addressing.") by yourself?
Thanks.
Best Regards,
Jheng-Jhong Wu (Victor Wu)
___
devel mailing list
On 2018/8/5 23:21, Kristaps Čivkulis wrote:
> Fix coding style issue "do not use assignment in if condition"
> detected by checkpatch.pl.
>
> Signed-off-by: Kristaps Čivkulis
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
On Fri, Aug 03 2018, Sergio Paracuellos wrote:
> This patch series include an attempt to avoid the use of custom
> read and writes in driver code and use PCI subsystem common ones.
>
> In order to do this 'map_bus' callback is implemented and also
> data structures for driver are included. The
On 08/05/18 16:07, Greg Kroah-Hartman wrote:
On Thu, Aug 02, 2018 at 06:35:05PM +0200, Michael Straube wrote:
On 07/16/18 15:30, Michael Straube wrote:
On 07/14/18 19:54, Ivan Safonov wrote:
Put data to skb, decrypt with lib80211_crypt_ccmp, and place back to tx buffer.
Signed-off-by: Ivan
On a Raven Ridge system with a r8188eu usb wifi device
commit 515ce733e86e ("staging:r8188eu: Use lib80211 to encrypt (CCMP) tx
frames")
is causing two bugs and a warning in dmesg:
[ 22.618465] BUG: scheduling while atomic: NetworkManager/489/0x0202
[ 22.618466] Modules linked in: amdkfd
On 08/05/2018 02:35 PM, Umang Parmar wrote:
Directly return value and remove unneeded variables.
Signed-off-by: Umang Parmar
This patch also has the same problem with the subject. Otherwise it is OK.
Larry
___
devel mailing list
On 08/05/2018 02:35 PM, Umang Parmar wrote:
Remove unnecessary conditions where if and else block had same code.
Signed-off-by: Umang Parmar
The subject should be "staging: rtlwifi: ...". If someone wants to search for
fixes to the modules in drivers/staging/rtlwifi/, your subject would not
From: Todd Poynor
Gasket device drivers are now in charge of the device add and remove
sequences; the framework callbacks for these are deleted. Move the
apex device add callback code to the probe function. Apex did not
implement the removal callback.
Signed-off-by: Todd Poynor
---
From: Todd Poynor
Keep mutex held across the unregistration operation, until the
driver_desc field of the global table is removed, to prevent a
concurrent accessor from looking up the driver_desc while
gasket_unregister_device() is in the processing of removing it.
Reported-by: Guenter Roeck
From: Todd Poynor
Gasket device drivers are now in charge of orchestrating the device add
and removal sequences, so the callbacks from the framework to the device
drivers for these events are no longer needed.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 10 --
From: Todd Poynor
A copy-and-pasted comment from another code sequence is removed from
gasket core init sequence.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_core.c
From: Todd Poynor
The apex device is left out of reset mode at the end of device
probe/initialize processing. Add a call to enter reset at the end of
the sequence, triggering power gating and other low power features.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 4
From: Todd Poynor
Remaining info-level logs in gasket core converted to debug-level; the
information is not needed during normal system operation.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
From: Todd Poynor
The gasket framework no longer provides callbacks to the device driver
for sysfs setup and teardown. Move the sysfs setup code to the device
probe function. Apex does not implement sysfs cleanup code.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 14
From: Todd Poynor
Move gasket device enable/disable functions from internal calls to
external calls from the gasket device drivers. The device driver will
call these functions at appropriate times in its processing, placing
the device driver in control of this sequence and reducing the need for
From: Todd Poynor
Gasket device drivers now call into the gasket framework to initialize
and de-initialize, rather than the other way around. The calling code
can perform sysfs setup and cleanup actions without callbacks from the
framework. Remove the sysfs setup and cleanup callbacks.
From: Todd Poynor
Device enable/disable operations are moving from being initiated through
the gasket framework to being initiated by the gasket device driver.
The driver can perform any processing needed for these operations before
or after the calls into the framework. Neither of these
From: Todd Poynor
Remove gasket wrapping of PCI probe, enable, disable, and remove
functions. Replace with calls to add and remove PCI gasket devices,
to be called by the gasket device drivers.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 82
From: Todd Poynor
Gasket framework now places device drivers in charge of calling APIs to
enable and disable gasket device operations. Make the appropriate calls
from the apex driver.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 12
1 file changed, 12
From: Todd Poynor
These are not implemented for apex, and are now being removed from the
gasket framework.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/gasket/apex_driver.c
From: Todd Poynor
Stop wrapping PCI core calls like probe, enable, remove, etc. in the
gasket framework, move these calls to the device driver instead. Have
gasket drivers call into framework on init, enable, disable,
etc. sequences, rather than the other way around. Remove the
From: Todd Poynor
Apex driver moves PCI core calls like probe, enable, and remove from
gasket to apex. Call new functions in gasket to register apex as a PCI
device to the gasket framework.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 49 +++-
From: Todd Poynor
If kcalloc() returns NULL in put_mapping(), continue to clean up state,
including dropping the reference on the struct device and free attribute
memory.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_sysfs.c | 13 ++---
1 file changed, 6 insertions(+),
Want to know if you have photos for editing?
We can edit 300+ images each day.
We can work on ecommerce photos, jewelry photos, and portrait photos.
We give cut out and clipping path for different kind of photos, and also we
provide retouching for
them.
Send us a test photo and we will do
Removed 5 inline comments "/*volatile*/" rtl87x_event.h, to fix
a coding style issue "Statements should start on a tabstop"
detected by checkpatch.pl script.
Signed-off-by: Frank Werner-Krippendorf
---
drivers/staging/rtl8712/rtl871x_event.h | 10 +-
1 file changed, 5 insertions(+), 5
Remove unnecessary conditions where if and else block had same code.
Signed-off-by: Umang Parmar
---
.../rtlwifi/btcoexist/halbtc8822b2ant.c | 6
.../staging/rtlwifi/btcoexist/halbtcoutsrc.c | 6 ++--
drivers/staging/rtlwifi/phydm/phydm_debug.c | 29 ++-
Directly return value and remove unneeded variables.
Signed-off-by: Umang Parmar
---
.../staging/rtlwifi/phydm/phydm_hwconfig.c| 23 +--
1 file changed, 6 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtlwifi/phydm/phydm_hwconfig.c
Use is_multicast_ether_addr instead of custom IS_MCAST in
os_dep/recv_linux.c.
Signed-off-by: Michael Straube
---
v2: changed duplicate subjects
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Use is_multicast_ether_addr instead of custom IS_MCAST in
core/rtw_sta_mgt.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
Replace tabs with spaces and/or remove spaces where appropriate.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/hal/rtl8188eu_xmit.c| 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
Replace tabs with spaces and/or remove spaces where appropriate.
Add a missing blank line after declarations.
Also clears checkpatch warnings.
WARNING: Statements should start on a tabstop
WARNING: suspect code indent for conditional statements (8, 17)
Signed-off-by: Michael Straube
---
Cleanup a block comment to conform with kernel coding style.
Also cleans 'line over 80 characters' checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
Use is_multicast_ether_addr instead of custom IS_MCAST in
hal/rtl8188eu_xmit.c.
There is only one use, so remove the extra variable for the
result of IS_MCAST.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 3 +--
1 file changed, 1 insertion(+), 2
On Sun, Aug 05, 2018 at 07:12:32PM +0200, Frank Werner-Krippendorf wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Frank Werner-Krippendorf
> ---
> drivers/staging/rtl8712/rtl871x_event.h | 10 +-
> drivers/staging/rtl8712/rtl871x_io.h | 2 +-
>
Fixed a coding style issue.
Signed-off-by: Frank Werner-Krippendorf
---
drivers/staging/rtl8712/rtl871x_event.h | 10 +-
drivers/staging/rtl8712/rtl871x_io.h | 2 +-
drivers/staging/rtl8712/rtl871x_pwrctrl.h | 10 +-
drivers/staging/rtl8712/rtl871x_xmit.h| 14
Hi Kristaps,
On 2018/8/5 23:21, Kristaps Čivkulis wrote:
> Fix coding style issue "do not use assignment in if condition"
> detected by checkpatch.pl.
>
> Signed-off-by: Kristaps Čivkulis
I don't know whether this rule is mandatory or not for the current linux
kernel
when I checked the original
Want to know if you have photos for editing?
We can edit 300+ images each day.
We can work on ecommerce photos, jewelry photos, and portrait photos.
We give cut out and clipping path for different kind of photos, and also we
provide retouching for
them.
Send us a test photo and we will do
Fix coding style issue "do not use assignment in if condition"
detected by checkpatch.pl.
Signed-off-by: Kristaps Čivkulis
---
drivers/staging/erofs/unzip_vle.c | 3 ++-
drivers/staging/erofs/xattr.c | 16
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git
On Sat, Aug 04, 2018 at 10:18:58AM +0100, John Whitmore wrote:
> Remove name of 'reserved' bitfield member which is simply used to pad
> the bitfield to a byte boundary. The actual bit has been left in place
> so alignment should not change. The name, which is not required has
> been removed.
>
>
On Thu, Aug 02, 2018 at 07:18:22PM +0200, Michael Straube wrote:
> Use is_multicast_ether_addr instead of custom IS_MCAST in
> core/rtw_sta_mgt.c.
>
> Signed-off-by: Michael Straube
> ---
> drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On Thu, Aug 02, 2018 at 07:18:19PM +0200, Michael Straube wrote:
> Use is_multicast_ether_addr instead of custom IS_MCAST in
> hal/rtl8188eu_xmit.c.
>
> There is only one use, so remove the extra variable for the
> result of IS_MCAST.
>
> Signed-off-by: Michael Straube
> ---
>
On Fri, Aug 03, 2018 at 01:58:51PM +0530, Ajay Singh wrote:
> Hi Greg,
>
> On Thu, 2 Aug 2018 09:34:15 +0200
> Greg KH wrote:
>
> > On Sun, Jul 29, 2018 at 11:36:56AM +0530, Ajay Singh wrote:
> > > Cleanup patch to avoid the below checkpatch reported issue.
> > >
> > > "usleep_range is
On Thu, Aug 02, 2018 at 06:35:05PM +0200, Michael Straube wrote:
> On 07/16/18 15:30, Michael Straube wrote:
> > On 07/14/18 19:54, Ivan Safonov wrote:
> > > Put data to skb, decrypt with lib80211_crypt_ccmp, and place back to tx
> > > buffer.
> > >
> > > Signed-off-by: Ivan Safonov
> > > ---
>
Use rtlwifi/phydm/phydm_regdefine11n.h instead of odm_RegDefine11N.h
and remove the now unused odm_RegDefine11N.h.
The defines from odm_RegDefine11N.h are defined with the same values
in rtlwifi/phydm/phydm_regdefine11n.h.
There is one define that is named different, but that one is not
used in
This patch fixes the "Lines should not end with a '('" warning reported by
checkpatch.pl script. The line containing 'rtl_mrate_idx_to_arfr_id' function
previously ended with '(', which did not conform to the linux kernel
coding style.
Signed-off-by: Sohil Ladhani
---
Changes in v2:
-
48 matches
Mail list logo
