Re: [PATCH v2] staging: erofs: use explicit unsigned int type

2018-09-07 Thread Gao Xiang
Hi Thomas, Thanks for your new patch. It seems that this patch also introduces 2 new 'WARNING: line over 80 characters', could you please fix it in the patch? On 2018/9/8 0:39, Thomas Weißschuh wrote: > Changes since v1: > > * Removed changes that conflicted with > [PATCH 1/6] staging: erofs

[PATCH] usb: octeon-hcd: remove unnecessary unlikely()

2018-09-07 Thread Igor Stoppa
WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another. Signed-off-by: Igor Stoppa Cc: Aaro Koskinen Cc: Greg Kroah-Hartman Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 ins

Re: [PATCH] android:ion: the order and count are in the wrong position

2018-09-07 Thread Laura Abbott
On 09/07/2018 08:20 AM, jun qian wrote: The value in the wrong position will cause misunderstanding, when the debug infomations display in the window. I think the existing order is okay, it's just not separated well. It's "$count pages of order $order". I also just acked a patch to remove all

Re: [PATCH v3] staging: android: ion: Clean unused debug_show memeber of the heap object

2018-09-07 Thread Laura Abbott
On 09/04/2018 10:03 PM, Alexey Skidanov wrote: ION had supported heap debug info under /sys/kernel/debug/ion/. This support have been removed but some leftovers (dead code) still exist. This patch removes the existing dead code. Acked-by: Laura Abbott Fixes: 15c6098cfec5 ("staging: android

[PATCH v2] staging: erofs: use explicit unsigned int type

2018-09-07 Thread Thomas Weißschuh
Changes since v1: * Removed changes that conflicted with [PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c * Added patch description -- >8 -- Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'" detected by checkpatch.pl Signed-off-by: Thomas Weißschuh --- d

[PATCH 1/2] media: cedrus: Fix error reporting in request validation

2018-09-07 Thread Paul Kocialkowski
This fixes error reporting by using the appropriate logging helpers and return codes, while introducing new messages when there are not enough or too many buffers associated with the request. Signed-off-by: Paul Kocialkowski --- drivers/staging/media/sunxi/cedrus/cedrus.c | 15 --- 1

[PATCH 2/2] media: cedrus: Add TODO file with tasks to complete before unstaging

2018-09-07 Thread Paul Kocialkowski
When the elements listed are complete, the Cedrus driver will be ready to move out of the staging area of the kernel. Signed-off-by: Paul Kocialkowski --- drivers/staging/media/sunxi/cedrus/TODO | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 drivers/staging/media/sunxi/cedrus/T

[PATCH 0/2] Follow-up patches for Cedrus v9

2018-09-07 Thread Paul Kocialkowski
This brings the requested modifications on top of version 9 of the Cedrus VPU driver, that implements stateless video decoding using the Request API. Paul Kocialkowski (2): media: cedrus: Fix error reporting in request validation media: cedrus: Add TODO file with tasks to complete before unsta

Re: [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-07 Thread Paul Kocialkowski
Hi, Le vendredi 07 septembre 2018 à 15:13 +0200, Hans Verkuil a écrit : > On 09/07/2018 12:24 AM, Paul Kocialkowski wrote: > > From: Paul Kocialkowski > > > > This introduces the Cedrus VPU driver that supports the VPU found in > > Allwinner SoCs, also known as Video Engine. It is implemented th

[PATCH] android:ion: the order and count are in the wrong position

2018-09-07 Thread jun qian
The value in the wrong position will cause misunderstanding, when the debug infomations display in the window. Signed-off-by: jun qian --- drivers/staging/android/ion/ion_system_heap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_system_

Re: [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-07 Thread Paul Kocialkowski
Hi, Le vendredi 07 septembre 2018 à 16:25 +0200, Maxime Ripard a écrit : > On Fri, Sep 07, 2018 at 03:52:00PM +0200, Hans Verkuil wrote: > > On 09/07/2018 03:26 PM, Maxime Ripard wrote: > > > Hi Hans, > > > > > > On Fri, Sep 07, 2018 at 03:13:19PM +0200, Hans Verkuil wrote: > > > > On 09/07/2018

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-07 Thread Paul Kocialkowski
Hi, Le jeudi 06 septembre 2018 à 09:22 +0200, Hans Verkuil a écrit : > On 09/06/2018 09:01 AM, Hans Verkuil wrote: > > On 09/05/2018 06:29 PM, Paul Kocialkowski wrote: > > > Hi and thanks for the review! > > > > > > Le lundi 03 septembre 2018 à 11:11 +0200, Hans Verkuil a écrit : > > > > On 08/28

Re: [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-07 Thread Maxime Ripard
On Fri, Sep 07, 2018 at 03:52:00PM +0200, Hans Verkuil wrote: > On 09/07/2018 03:26 PM, Maxime Ripard wrote: > > Hi Hans, > > > > On Fri, Sep 07, 2018 at 03:13:19PM +0200, Hans Verkuil wrote: > >> On 09/07/2018 12:24 AM, Paul Kocialkowski wrote: > >>> From: Paul Kocialkowski > >>> > >>> This intr

Re: [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-07 Thread Hans Verkuil
On 09/07/2018 03:26 PM, Maxime Ripard wrote: > Hi Hans, > > On Fri, Sep 07, 2018 at 03:13:19PM +0200, Hans Verkuil wrote: >> On 09/07/2018 12:24 AM, Paul Kocialkowski wrote: >>> From: Paul Kocialkowski >>> >>> This introduces the Cedrus VPU driver that supports the VPU found in >>> Allwinner SoCs

[PATCH v2] ANDROID: binder: Add BINDER_GET_NODE_INFO_FOR_REF ioctl.

2018-09-07 Thread Martijn Coenen
This allows the context manager to retrieve information about nodes that it holds a reference to, such as the current number of references to those nodes. Such information can for example be used to determine whether the servicemanager is the only process holding a reference to a node. This inform

Re: [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-07 Thread Maxime Ripard
Hi Hans, On Fri, Sep 07, 2018 at 03:13:19PM +0200, Hans Verkuil wrote: > On 09/07/2018 12:24 AM, Paul Kocialkowski wrote: > > From: Paul Kocialkowski > > > > This introduces the Cedrus VPU driver that supports the VPU found in > > Allwinner SoCs, also known as Video Engine. It is implemented thr

Re: [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-07 Thread Hans Verkuil
On 09/07/2018 12:24 AM, Paul Kocialkowski wrote: > From: Paul Kocialkowski > > This introduces the Cedrus VPU driver that supports the VPU found in > Allwinner SoCs, also known as Video Engine. It is implemented through > a V4L2 M2M decoder device and a media device (used for media requests). > S

Re: [PATCH] ANDROID: binder: Latelimit binder_debug().

2018-09-07 Thread Martijn Coenen
> Any progress on this problem? A patch was recently submitted to address this: https://lkml.org/lkml/2018/8/7/802 > >> >>> Without disabling by default or latelimit printk(), the system shall become >>> unusable. >>> >>> $ grep binder: log | wc -l >>> 13214 >>> $ head log >>> [ 1167.389978] bi

Re: [PATCH] staging: erofs: use explicit unsigned int type

2018-09-07 Thread Gao Xiang
Hi Dan, On 2018/9/7 17:17, Dan Carpenter wrote: > On Fri, Sep 07, 2018 at 04:48:44PM +0800, Gao Xiang wrote: >> Hi Thomas, >> >> On 2018/9/3 9:53, Chao Yu wrote: >>> Hi, >>> >>> It looks like there is another patch from Pavel Zemlyanoy changing the same >>> place, I think it needs to rebase this p

Re: [PATCH v2 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

2018-09-07 Thread Michael Straube
On 9/6/18 12:41 PM, Joe Perches wrote: On Thu, 2018-09-06 at 13:32 +0300, Dan Carpenter wrote: Thanks. Reviewed-by: Dan Carpenter Trivial, but these case statement blocks should prefer unindented blocks instead of reformatting the test. Perhaps similar to the below for each of the cases:

Re: [PATCH] ANDROID: binder: Latelimit binder_debug().

2018-09-07 Thread Tetsuo Handa
On 2018/07/10 21:40, Martijn Coenen wrote: > On Tue, Jul 10, 2018 at 2:09 PM, Tetsuo Handa > wrote: >> I don't have benchmark data (I'm not an Android user). But an example log at >> https://syzkaller.appspot.com/text?tag=CrashLog&x=12f316fc40 got >> about 13214 messages in 124 seconds (over 1

Re: [PATCH] staging: erofs: use explicit unsigned int type

2018-09-07 Thread Dan Carpenter
On Fri, Sep 07, 2018 at 04:48:44PM +0800, Gao Xiang wrote: > Hi Thomas, > > On 2018/9/3 9:53, Chao Yu wrote: > > Hi, > > > > It looks like there is another patch from Pavel Zemlyanoy changing the same > > place, I think it needs to rebase this patch on that one. > > > > [PATCH 1/6] staging: erof

Re: [linux-sunxi] [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-07 Thread Paul Kocialkowski
Hi, Le vendredi 07 septembre 2018 à 07:33 +, Priit Laes a écrit : > On Fri, Sep 07, 2018 at 12:24:38AM +0200, Paul Kocialkowski wrote: > > From: Paul Kocialkowski > > > > This introduces the Cedrus VPU driver that supports the VPU found in > > Allwinner SoCs, also known as Video Engine. It i

Re: [PATCH 19/19] mtd: rawnand: Move JEDEC code to nand_jedec.c

2018-09-07 Thread Boris Brezillon
On Fri, 7 Sep 2018 10:40:44 +0200 Ladislav Michl wrote: > Hi Boris, > > this patchseries is really amazing clean up. Thank you! I'm glad I'm not the only one to find it useful :-). > > On Fri, Sep 07, 2018 at 12:38:51AM +0200, Boris Brezillon wrote: > > This moves ONFI related code to nand_on

Re: [PATCH] staging: erofs: use explicit unsigned int type

2018-09-07 Thread Gao Xiang
Hi Thomas, On 2018/9/3 9:53, Chao Yu wrote: > Hi, > > It looks like there is another patch from Pavel Zemlyanoy changing the same > place, I think it needs to rebase this patch on that one. > > [PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c > Thanks for your patch. Do you have

Re: [PATCH 19/19] mtd: rawnand: Move JEDEC code to nand_jedec.c

2018-09-07 Thread Ladislav Michl
Hi Boris, this patchseries is really amazing clean up. Thank you! On Fri, Sep 07, 2018 at 12:38:51AM +0200, Boris Brezillon wrote: > This moves ONFI related code to nand_onfi.c and ONFI related > struct/macros to include/linux/mtd/onfi.h. Seems above commit log comes from previous patch. ___

Re: [PATCH] vme: remove unneeded kfree

2018-09-07 Thread Martyn Welch
On Thu, 2018-09-06 at 22:04 -0700, Linus Torvalds wrote: > On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang > wrote: > > > > put_device will call vme_dev_release to free vdev, kfree is > > unnecessary here. > > That does seem to be the case.  I think "unnecessary" is overly kind, > it does seem to be a

Re: [PATCH] android: binder: use kstrdup instead of open-coding it

2018-09-07 Thread Greg Kroah-Hartman
On Fri, Sep 07, 2018 at 10:01:46AM +0200, Rasmus Villemoes wrote: > Signed-off-by: Rasmus Villemoes > --- > drivers/android/binder.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered

[PATCH] android: binder: use kstrdup instead of open-coding it

2018-09-07 Thread Rasmus Villemoes
Signed-off-by: Rasmus Villemoes --- drivers/android/binder.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index d58763b6b009..2abcf4501d9a 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -5667,12

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-07 Thread Tomasz Figa
On Thu, Sep 6, 2018 at 4:39 PM Hans Verkuil wrote: > > On 09/06/2018 09:25 AM, Tomasz Figa wrote: > > On Thu, Sep 6, 2018 at 4:01 PM Hans Verkuil wrote: > >> > >> On 09/05/2018 06:29 PM, Paul Kocialkowski wrote: > >>> Hi and thanks for the review! > >>> > >>> Le lundi 03 septembre 2018 à 11:11 +0

Re: [linux-sunxi] [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-07 Thread Priit Laes
On Fri, Sep 07, 2018 at 12:24:38AM +0200, Paul Kocialkowski wrote: > From: Paul Kocialkowski > > This introduces the Cedrus VPU driver that supports the VPU found in > Allwinner SoCs, also known as Video Engine. It is implemented through > a V4L2 M2M decoder device and a media device (used for me

Re: [PATCH] vme: remove unneeded kfree

2018-09-07 Thread Greg Kroah-Hartman
On Thu, Sep 06, 2018 at 10:04:49PM -0700, Linus Torvalds wrote: > On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang > wrote: > > > > put_device will call vme_dev_release to free vdev, kfree is > > unnecessary here. > > That does seem to be the case. I think "unnecessary" is overly kind, > it does seem t