Re: [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support

On Sat, Oct 6, 2018 at 1:29 PM Marcelo Tosatti wrote: > > On Thu, Oct 04, 2018 at 03:15:32PM -0700, Andy Lutomirski wrote: > > For better or for worse, I'm trying to understand this code. So far, > > I've come up with this patch: > > > >

Re: [PATCH] Staging: rts5208: rtsx_card: Fixed multiple coding style issues

Hi, On 9/29/18 4:03 AM, Maxime Desroches wrote: > Fixed multiple coding style issues > What kind of style issues are you trying to fix? Please, always be specific about what you are trying to fix. This makes it easier for the maintainers to review your patch and give you feedback. Thanks --

Re: [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support

On Thu, Oct 04, 2018 at 03:15:32PM -0700, Andy Lutomirski wrote: > For better or for worse, I'm trying to understand this code. So far, > I've come up with this patch: > >

Re: [PATCH] staging: iio: adc: ad7280a: fix 2 checks

On paź 06, 2018 13:27, Gabriel Capella wrote: > This patch does not change the logic, it only > corrects the checkpatch checks. > > The patch fixes 2 checks of type: > "CHECK: spaces preferred around that '-'" I've made the same mistake few days ago. This change is incorrect. Please see:

[PATCH] staging: iio: adc: ad7280a: fix 2 checks

This patch does not change the logic, it only corrects the checkpatch checks. The patch fixes 2 checks of type: "CHECK: spaces preferred around that '-'" Signed-off-by: Gabriel Capella --- drivers/staging/iio/adc/ad7280a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/2] staging: rtl8188eu: remove dead code from dm_fast_training_init()

The variable AntCombination is initialized to 2 and never changed. So the else if path is never used. Remove the dead code and the variable AntCombination. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 38 1 file changed, 7 insertions(+),

[PATCH 2/2] staging: rtl8188eu: add spaces around operators in odm_rtl8188e.c

Add spaces around '|', '>>' and '/' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

Hi Tuomas, > Tuomas Tynkkynen hat am 4. Oktober 2018 um 11:37 > geschrieben: > > > Drop various pieces of dead code from here and there to get rid of > the remaining users of VCHI_CONNECTION_T. After that we get to drop > entire header files worth of unused code. > > I've tested on a

Re: [PATCH resend 00/15] staging: vboxvideo: Convert to atomic modesetting API

Hi, On 05-10-18 18:01, Daniel Vetter wrote: On Mon, Oct 01, 2018 at 11:20:04AM +0200, Hans de Goede wrote: Hi, On 01-10-18 09:25, Dan Carpenter wrote: Why are you resending this? It's because you added some more patches on the end? Just send those as a new series... I accidentally

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

On Wed 12 Sep 08:08 PDT 2018, Arnd Bergmann wrote: [..] > diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c > index a76b963a7e50..02aefb2b2d47 100644 > --- a/drivers/rpmsg/rpmsg_char.c > +++ b/drivers/rpmsg/rpmsg_char.c > @@ -285,7 +285,7 @@ static const struct file_operations

[PATCH] STAGING/EMXX_UDC: Fixed all meaningful sparse errors.

Fixed all meaningful sparse errors: 1. Added static to udc_controller 2. Added mising __iomem modifier to handle p_regs 3. Added missing le16_to_cpu Signed-off-by: Tamir Carmeli --- drivers/staging/emxx_udc/emxx_udc.c | 69 +++--

Re: [PATCH] staging/rtlwifi: Fixing formatting warnings from checkpatch.pl.

On Fri, 2018-10-05 at 16:58 -0600, Scott Tracy wrote: > Fixing formatting warnings in rtlwifi found by checkpatch.pl > Changes include breaking up functions calls into multi line calls. > No functional/logical changes. I believe the code is better before most of these changes. There are various