RE: [PATCH] binder: ipc namespace support for android binder

2018-10-28 Thread 周威
>> Hi >> We are working for running android in container, but we found that binder >> is >> not isolated by ipc namespace. Since binder is a form of IPC and therefore >> should >> be tied to ipc namespace. With this patch, we can run more than one android >> container on one host. >> This

Re: [PATCH RFC 18/18] staging: vchiq: add more tasks to the TODO list

2018-10-28 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > The more the better. Please try to find a better commit log ;-) > > Signed-off-by: Nicolas Saenz Julienne > --- > .../staging/vc04_services/interface/vchi/TODO | 46 ++- > 1 file changed, 44

Re: [PATCH RFC 16/18] staging: vchiq_arm: rework probe and init functions

2018-10-28 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > Some operations performed in the probe function should have been > implemented in the init function. Namely class and dev region creations. > Please explain the why in the commit log

Re: [PATCH RFC 11/18] staging: vchiq_arm: use completions instead of semaphores

2018-10-28 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > It is preferred in the kernel to avoid using semaphores to wait for > events, as they are optimised for the opposite situation; where the > common case is that they are available and may block only occasionally. >

Re: [PATCH RFC 15/18] stagning: vchiq_core: fix logic redundancy in parse_open

2018-10-28 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > We update sync to reflect that the firmware version is compatible with > that option. We don't need to check both of them again further down the > code. please fix the typo in the subject s/stagning/staging/ for

Re: [PATCH v6 3/3] staging: iio: ad2s1210: Add device tree support.

2018-10-28 Thread Nishad Kamdar
On Sun, Oct 28, 2018 at 02:51:08PM +, Jonathan Cameron wrote: > On Sun, 28 Oct 2018 13:23:23 +0530 > Nishad Kamdar wrote: > > > Replace platform data with device tree support. > > > > Signed-off-by: Nishad Kamdar > The whole gpio in or out thing makes less and less sense to > me and seems

Re: [PATCH RFC 09/18] staging: vchiq_core: do not initialize semaphores twice

2018-10-28 Thread Stefan Wahren
Hi Nicolas, > Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > vchiq_init_state() initialises a series of semaphores to then call > remote_event_create() on the same semaphores, which initializes them > again. i would prefer to have all init stuff at one place in

Re: [PATCH v6 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-28 Thread Nishad Kamdar
On Sun, Oct 28, 2018 at 02:36:07PM +, Jonathan Cameron wrote: > On Sun, 28 Oct 2018 13:21:25 +0530 > Nishad Kamdar wrote: > > > Use the gpiod interface instead of the deprecated old non-descriptor > > interface. > > > > Signed-off-by: Nishad Kamdar > Hi Nishad, > > Sorry it took me most

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2018-10-28 Thread Stefan Wahren
Hi Nicolas, > Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 13:06 geschrieben: > > > Hi Stefan, > > On Thu, 2018-10-25 at 17:29 +0200, Stefan Wahren wrote: > > This patch series improves the load/unload of bcm2835 camera and > > audio > > drivers. It has been tested with Raspberry Pi 3

Re: Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Michael Straube
On 10/28/18 3:13 PM, Greg Kroah-Hartman wrote: On Sun, Oct 28, 2018 at 02:22:40PM +0100, Michael Straube wrote: On 10/28/18 12:27 PM, Greg Kroah-Hartman wrote: On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: Hi, which GPL version should be used in SPDX Identifiers for files

Re: [PATCH v2 1/2] staging: iio: ad7780: update voltage on read

2018-10-28 Thread Jonathan Cameron
On Sun, 28 Oct 2018 13:52:32 -0300 Renato Lui Geh wrote: > Hi Jonathan, > > Thank you for the review. > > >> + voltage_uv = regulator_get_voltage(st->reg); > >> + if (voltage_uv) > >> + st->int_vref_mv = voltage_uv/1000; > >>*val = st->int_vref_mv

Re: [PATCH v2 1/2] staging: iio: ad7780: update voltage on read

2018-10-28 Thread Renato Lui Geh
Hi Jonathan, Thank you for the review. + voltage_uv = regulator_get_voltage(st->reg); + if (voltage_uv) + st->int_vref_mv = voltage_uv/1000; *val = st->int_vref_mv * st->gain; Is there actually a reason (now) to have the

Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 22:59:59 -0300 Matheus Tavares wrote: > This patch set adds scale info to ad2s90's single channel, improve > error handling in it's functions and fix a possible race condition > issue. > > The goal with this patch set is to address the points discussed in the > mailing list

Re: [PATCH v2 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 23:00:04 -0300 Matheus Tavares wrote: > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and > implements the relative read behavior at ad2s90_read_raw. > > Signed-off-by: Victor Colombo > Signed-off-by: Matheus Tavares Hi, A suggestion inline. This is a

Re: [PATCH v2 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 23:00:01 -0300 Matheus Tavares wrote: > Previously, ad2s90_probe ignored the return code from spi_setup, not > handling its possible failure. This patch makes ad2s90_probe check if > the code is an error code and, if so, do the following: > > - Call dev_err with an

Re: [PATCH v2 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 23:00:00 -0300 Matheus Tavares wrote: > Previously, when spi_read returned an error code inside ad2s90_read_raw, > the code was ignored and IIO_VAL_INT was returned. This patch makes the > function return the error code returned by spi_read when it fails. > > Signed-off-by:

Re: [PATCH v2 2/2] staging: iio: ad7780: fix offset read value

2018-10-28 Thread Jonathan Cameron
On Thu, 25 Oct 2018 19:30:37 -0300 Renato Lui Geh wrote: > Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. > This was fixed by assigning the correct value instead. > > Signed-off-by: Renato Lui Geh It obviously doesn't make much difference, but as you are respinning

Re: [PATCH v2 1/2] staging: iio: ad7780: update voltage on read

2018-10-28 Thread Jonathan Cameron
On Thu, 25 Oct 2018 19:30:04 -0300 Renato Lui Geh wrote: > The ad7780 driver previously did not read the correct device output, as > it read an outdated value set at initialization. It now updates its > voltage on read. > > Signed-off-by: Renato Lui Geh > --- >

Re: [PATCH] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-10-28 Thread kbuild test robot
/linux/commits/Nishad-Kamdar/staging-olpc_dcon-olpc_dcon_xo_1-c-Switch-to-the-gpio-descriptor-interface/20181028-124517 config: i386-randconfig-n0-10280159 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make

Re: [PATCH 2/2] staging: iio: ad5933: Remove unnecessary blank line

2018-10-28 Thread Jonathan Cameron
On Mon, 22 Oct 2018 17:41:27 -0300 Victor Colombo wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Blank lines aren't necessary before a close brace '}' > > Signed-off-by: Victor Colombo Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to

Re: [PATCH 1/2] staging: iio: ad5933: Remove unnecessary space on casting

2018-10-28 Thread Jonathan Cameron
On Mon, 22 Oct 2018 17:40:25 -0300 Victor Colombo wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: No space is necessary after a cast > > Signed-off-by: Victor Colombo Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it and

Re: [PATCH] staging: iio: adt7316: Switch to the gpio descriptor interface

2018-10-28 Thread Jonathan Cameron
On Wed, 24 Oct 2018 22:03:54 +0530 Nishad Kamdar wrote: > On Mon, Oct 22, 2018 at 11:22:15PM +0530, Shreeya Patel wrote: > > On Mon, 2018-10-22 at 22:44 +0530, Nishad Kamdar wrote: > > > Use the gpiod interface instead of the deprecated old non-descriptor > > > interface for ldac_pin. > > > >

Re: [PATCH v5 2/2] staging: iio: ad2s1210: Add device tree support.

2018-10-28 Thread Jonathan Cameron
On Sat, 27 Oct 2018 17:49:03 +0200 Slawomir Stepien wrote: > Hi > > On paź 26, 2018 18:55, Nishad Kamdar wrote: > > Add device tree table for matching vendor ID > > and support for retrieving platform data > > from device tree. > > So maybe you should make 2 commits? > > > Signed-off-by:

Re: [PATCH v6 3/3] staging: iio: ad2s1210: Add device tree support.

2018-10-28 Thread Jonathan Cameron
On Sun, 28 Oct 2018 13:23:23 +0530 Nishad Kamdar wrote: > Replace platform data with device tree support. > > Signed-off-by: Nishad Kamdar The whole gpio in or out thing makes less and less sense to me and seems to contradict the datasheet. If I'm not missing something I would just get rid of

Re: [PATCH v6 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-28 Thread Jonathan Cameron
On Sun, 28 Oct 2018 13:21:25 +0530 Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. > > Signed-off-by: Nishad Kamdar Hi Nishad, Sorry it took me most of the week to get to this. It's a trade off when you want to make fast progress, but

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-10-28 Thread Mike Brady
> On 25 Oct 2018, at 08:37, Takashi Iwai wrote: > > On Thu, 25 Oct 2018 00:02:34 +0200, > Kirill Marinushkin wrote: >> When you play sound - the pointer increments. >>> >>> Unfortunately, when you play sound, the pointer does not actually >>> increment, for up to about 10 milliseconds.

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-10-28 Thread Mike Brady
Hi Kirill. Thanks for the post. Mike > On 25 Oct 2018, at 18:20, Kirill Marinushkin wrote: > > Hello Takashi, Mike, > > @Takashi > > On 10/25/18 09:37, Takashi Iwai wrote: >> Well, in the API POV, it's nothing wrong to keep hwptr sticking while >> updating only delay value. It implies that

Re: Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Greg Kroah-Hartman
On Sun, Oct 28, 2018 at 02:22:40PM +0100, Michael Straube wrote: > On 10/28/18 12:27 PM, Greg Kroah-Hartman wrote: > > On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: > > > Hi, > > > > > > which GPL version should be used in SPDX Identifiers for files that > > > are GPL licensed

Re: Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Michael Straube
On 10/28/18 12:27 PM, Greg Kroah-Hartman wrote: On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: Hi, which GPL version should be used in SPDX Identifiers for files that are GPL licensed but do not mention any version? It is not clear to me after reading license-rules.rst. For

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-28 Thread Julia Lawall
On Sun, 28 Oct 2018, Himanshu Jha wrote: > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > The "possible alignement issues" in CHECK report is difficult to figure > > > out by just doing a glance analysis. :) > > > > > > Linus also suggested to use bool as the base type

Re: Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Greg Kroah-Hartman
On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: > Hi, > > which GPL version should be used in SPDX Identifiers for files that > are GPL licensed but do not mention any version? It is not clear to > me after reading license-rules.rst. > > For example: > >

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-28 Thread Himanshu Jha
On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > The "possible alignement issues" in CHECK report is difficult to figure > > out by just doing a glance analysis. :) > > > > Linus also suggested to use bool as the base type i.e., `bool x:1` but > > again sizeof(_Bool) is

Re: [RESEND PATCH 1/2] staging: vboxvideo: Change uint32_t to u32

2018-10-28 Thread Hans de Goede
Hi, On 26-10-18 21:04, Shayenne da Luz Moura wrote: This change was suggested by checkpath.pl. CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Shayenne da Luz Moura So as already mentioned in response to the coverletter of the first posting of this series. The drm headers

Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Michael Straube
Hi, which GPL version should be used in SPDX Identifiers for files that are GPL licensed but do not mention any version? It is not clear to me after reading license-rules.rst. For example: /** * Copyright(c) 2008 -

Re: [PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit()

2018-10-28 Thread Michael Straube
On 10/28/18 1:08 AM, Joe Perches wrote: On Sat, 2018-10-27 at 15:57 -0700, Joe Perches wrote: On Sat, 2018-10-27 at 22:28 +0200, Michael Straube wrote: The function rtw_hal_xmit() returns true or false. Change the return type from s32 to bool. [] diff --git

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-28 Thread Julia Lawall
> The "possible alignement issues" in CHECK report is difficult to figure > out by just doing a glance analysis. :) > > Linus also suggested to use bool as the base type i.e., `bool x:1` but > again sizeof(_Bool) is implementation defined ranging from 1-4 bytes. If bool x:1 has the size of bool,

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

2018-10-28 Thread Stefan Wahren
Hi Dave, > Dave Stevenson hat am 26. Oktober 2018 um > 19:15 geschrieben: > > > Thanks Stefan. > I've picked up your latest patches which mean I can get the driver > loaded via the (almost) approved method. > I do seem to still have issues with not getting the expected address > ranges, so

[PATCH v6 3/3] staging: iio: ad2s1210: Add device tree support.

2018-10-28 Thread Nishad Kamdar
Replace platform data with device tree support. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/resolver/Kconfig| 1 + drivers/staging/iio/resolver/ad2s1210.c | 17 - drivers/staging/iio/resolver/ad2s1210.h | 17 - 3 files changed, 9 insertions(+), 26

[PATCH v6 2/3] staging: iio: ad2s1210: Add device tree table.

2018-10-28 Thread Nishad Kamdar
Add device tree table for matching vendor ID. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/resolver/ad2s1210.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index 93c3c70ce62e..0234869e9d74

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-28 Thread Himanshu Jha
Hi Sasha, On Fri, Oct 26, 2018 at 04:42:25PM -0400, Sasha Levin wrote: > On Fri, Oct 26, 2018 at 04:04:45PM -0300, Shayenne da Luz Moura wrote: > > This change was suggested by checkpath.pl. Use unsigned int with bitfield > > allocate only one bit to the boolean variable. > > > > CHECK: Avoid

[PATCH v6 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-28 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/resolver/ad2s1210.c | 92 ++--- drivers/staging/iio/resolver/ad2s1210.h | 3 - 2 files changed, 50 insertions(+), 45 deletions(-) diff --git

[PATCH v6 0/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface.

2018-10-28 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor Changes in v6: - Split device tree table addition and device tree support addition in two patches. - Replace platform data with device tree support. - Rename boolean property. Changes in v5: - Add device tree support. -

Re: [PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit()

2018-10-28 Thread Joe Perches
On Sat, 2018-10-27 at 15:57 -0700, Joe Perches wrote: > On Sat, 2018-10-27 at 22:28 +0200, Michael Straube wrote: > > The function rtw_hal_xmit() returns true or false. > > Change the return type from s32 to bool. > [] > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c > >

Re: [PATCH] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-10-28 Thread kbuild test robot
/linux/commits/Nishad-Kamdar/staging-olpc_dcon-olpc_dcon_xo_1-c-Switch-to-the-gpio-descriptor-interface/20181028-124517 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386

Re: [PATCH v5 2/2] staging: iio: ad2s1210: Add device tree support.

2018-10-28 Thread Nishad Kamdar
On Sat, Oct 27, 2018 at 05:49:03PM +0200, Slawomir Stepien wrote: > Hi > > On paź 26, 2018 18:55, Nishad Kamdar wrote: > > Add device tree table for matching vendor ID > > and support for retrieving platform data > > from device tree. > > So maybe you should make 2 commits? > Ok. I'll do that. >