Re: [PATCH v2 06/17] Platform: OLPC: Add XO-1.75 EC driver

On Mon, Dec 3, 2018 at 1:13 AM Darren Hart wrote: > On Fri, Nov 16, 2018 at 05:23:52PM +0100, Lubomir Rintel wrote: > > It's based off the driver from the OLPC kernel sources. Somewhat > > modernized and cleaned up, for better or worse. > > > > Modified to plug into the olpc-ec driver

RE: [PATCH 3/4] Drivers: hv: vmbus: Add hooks for per-CPU IRQ

From: Will Deacon Sent: Tuesday, November 27, 2018 2:19 AM > > > The general approach is for patches 1 and 2 of the series to provide > > > all the new code under arch/arm64 to enable Hyper-V. But the code > > > won't get called (or even built) with just these two patches because > > >

[PATCH] [REPOST for the char-misc-linus branch] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

vmbus_process_offer() mustn't call channel->sc_creation_callback() directly for sub-channels, because sc_creation_callback() -> vmbus_open() may never get the host's response to the OPEN_CHANNEL message (the host may rescind a channel at any time, e.g. in the case of hot removing a NIC), and

RE: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

> From: gre...@linuxfoundation.org > Sent: Sunday, December 2, 2018 7:33 AM > To: Dexuan Cui > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; vkuznets > ; o...@aepfle.de; jasow...@redhat.com; Michael >

Re: [PATCH v2 17/17] power: supply: olpc_battery: Add OLPC XO 1.75 support

On Fri, Nov 16, 2018 at 05:24:03PM +0100, Lubomir Rintel wrote: > The battery and the protocol are essentially the same as OLPC XO 1.5, > but the responses from the EC are LSB first. > > Signed-off-by: Lubomir Rintel > Acked-by: Pavel Machek > > --- > Changes since v1: > - s/s16

Re: [PATCH v2 13/17] power: supply: olpc_battery: Use DT to get battery version

On Fri, Nov 16, 2018 at 05:23:59PM +0100, Lubomir Rintel wrote: > Avoid using the x86 OLPC platform specific call to get the board > version. It won't work on FDT-based ARM MMP2 platform. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Andy Shevchenko > Acked-by: Pavel Machek > > --- >

Re: [PATCH] staging: iio: ad5933: add binding doc for ad5933

On Mon, 2018-12-03 at 00:20 +0530, Himanshu Jha wrote: > On Sun, Dec 02, 2018 at 02:57:12PM -0200, Marcelo Schmitt wrote: > > Add a devicetree documentation for the ad5933 and ad5934 impedance > > converter, network analyzer. > > > > Co-Developed-by: Gabriel Capella > > checkpatch spits out: >

Re: [PATCH v2 07/17] Platform: OLPC: Avoid a warning if the EC didn't register yet

On Fri, Nov 16, 2018 at 05:23:53PM +0100, Lubomir Rintel wrote: > Just return ENODEV, so that whoever attempted to use the EC call can I think you meant EPROBE_DEFER here, but the language in the commit message is a bit ambiguous here... > defer their work. > > Signed-off-by: Lubomir Rintel >

Re: [PATCH v2 06/17] Platform: OLPC: Add XO-1.75 EC driver

On Fri, Nov 16, 2018 at 05:23:52PM +0100, Lubomir Rintel wrote: > It's based off the driver from the OLPC kernel sources. Somewhat > modernized and cleaned up, for better or worse. > > Modified to plug into the olpc-ec driver infrastructure (so that battery > interface and debugfs could be

Re: [PATCH] staging: iio: ad5933: add binding doc for ad5933

On Sun, Dec 02, 2018 at 02:57:12PM -0200, Marcelo Schmitt wrote: > Add a devicetree documentation for the ad5933 and ad5934 impedance > converter, network analyzer. > > Co-Developed-by: Gabriel Capella checkpatch spits out: WARNING: Non-standard signature: Co-Developed-by: Co-developed-by Vs

Re: [PATCH] staging: iio: ad5933: replaced kfifo by triggered_buffer

On 11/25, Jonathan Cameron wrote: > On Thu, 22 Nov 2018 10:53:47 -0200 > Marcelo Schmitt wrote: > > > Previously, there was an implicit creation of a kfifo which was replaced > > by a call to triggered_buffer_setup, which is already implemented in iio > > infrastructure. > > > > Signed-off-by:

[PATCH 22/29] staging: wilc1000: refactor wilc_get_mac_address() to avoid deferred handling

From: Ajay Singh Avoid handling of WID_MAC_ADDR wid command in deferred approach. Instead of posting the wid to workqueue now handle directly from the caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 43 ++-

[PATCH 27/29] staging: wilc1000: handle connect ops callback from cfg80211 context

From: Ajay Singh Refactor the connect related cfg callback to be called from cfg80211 context. No need to post connect command internally in case scan is in progress instead simply return the error status in connect ops callback. Signed-off-by: Ajay Singh ---

[PATCH 23/29] staging: wilc1000: use correct 'struct remain_ch' variable in scan complete

From: Ajay Singh Use the correct reference to remain_ch variable in scan complete. Passing 'msg->body.remain_on_ch' to handle_remain_on_chan is not correct. So used the correct reference used to store roc related information during the scan. Signed-off-by: Ajay Singh ---

[PATCH 21/29] staging: wilc1000: delete the unused code after code refactor

From: Ajay Singh After code refactor some of the macro and variables are not required any more, so deleted the unused code. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 31 --- drivers/staging/wilc1000/host_interface.h | 27

[PATCH 24/29] staging: wilc1000: handle remain on channel cfg ops from cfg80211 context

From: Ajay Singh Refactor wilc_remain_on_channel() to handle remain_on_channel callback from cfg80211 context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 36 ++- 1 file changed, 11 insertions(+), 25 deletions(-) diff --git

[PATCH 25/29] staging: wilc1000: handle get_station() ops callback in cfg80211 context

From: Ajay Singh Refactor code to handle the get_station() callback from cfg80211 context. Provided different API's to fetch the station statistics information in sync or async call. From cfg80211 get_station() ops callback calls the sync version of API. Signed-off-by: Ajay Singh ---

[PATCH 29/29] staging: wilc1000: handle scan operation callback from cfg80211 context

From: Ajay Singh Refactor code to handle scan operation callback from cfg80211 context. No need to maintain 'scan_attr' struct as the wid command is directly sent to firmware from cfg80211 context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 143

[PATCH 28/29] staging: wilc1000: avoid extra buffer copy while connect cfg ops

From: Ajay Singh Refactor the code to avoid the use of an extra buffer to store the connection related parameter. No need to call cfg80211_disconnected in case of failure to send the wid command to firmware, an error status is directly returned in cfg80211 connect callback. Signed-off-by: Ajay

[PATCH 18/29] staging: wilc1000: refactor wilc_set_wfi_drv_handler() to avoid deferred handling

From: Ajay Singh Avoid handling of WID_SET_DRV_HANDLER wid command in deferred approach. Instead of posting the wid to work queue now handle directly from the caller context. Remove 'is_sync' parameter from the API as it's not required anymore. Signed-off-by: Ajay Singh ---

[PATCH 19/29] staging: wilc1000: refactor wilc_get_inactive_time() to avoid deferred handling

From: Ajay Singh Avoid handling of inactive time related wid command in deferred manner. Instead of posting the wid to workqueue now handle directly from the caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 91 --- 1 file

[PATCH 15/29] staging: wilc1000: refactor wilc_hif_set_cfg() to avoid deferred handling

From: Ajay Singh Avoid handling configuration params wid command in deferred approach. Instead of posting to workqueue now handle directly from the caller context. Reduce the size of wid array from 32 to 4 as maximum only 4 wid used at a time. Signed-off-by: Ajay Singh ---

[PATCH 26/29] staging: wilc1000: avoid deferred handling of cfg80211 disconnect callback

From: Ajay Singh Refactor disconnect operation callback to handle from the cfg80211 context. The reason code is not required to pass as parameter to the function, so remove it. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 39 +++

[PATCH 20/29] staging: wilc1000: handle key related cfg operation from cfg80211 context

From: Ajay Singh Refactor add/delete key operation to handle directly from cfg80211 context. Also, avoid an extra copy of the information in hif layer and directly fill the buffer in firmware format. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 691

[PATCH 16/29] staging: wilc1000: handle station dump cfg ops from cfg80211 context

From: Ajay Singh Refactor code to handle dump_station() callback from cfg80211 context. Instead of deferring issue of wid command now send it directly from cfg context. Also making use of wilc_get_rssi() error status in case there is a failure to post the wid command to the firmware.

[PATCH 13/29] staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context

From: Ajay Singh Avoid handling of mgmt_frame_register operation callback in a deferred manner. Now set the wid command to firmware directly from caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 70 ++-

[PATCH 17/29] staging: wilc1000: refactor wilc_set_operation_mode() to avoid deferred handling

From: Ajay Singh Avoid handling of WID_CURRENT_CHANNEL wid command in deferred approach. Instead of posting the wid to work queue now handle directly from the caller context. Use structure to fill in the firmware specific format. Signed-off-by: Ajay Singh ---

[PATCH 14/29] staging: wilc1000: refactor wilc_set_mac_chnl_num() to avoid deferred handling

From: Ajay Singh Avoid handling of WID_CURRENT_CHANNEL wid command in deferred approach. Instead of posting the wid to workqueue now handle directly from the caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 46 ++- 1 file

[PATCH 12/29] staging: wilc1000: handle add beacon operation callback from cfg80211 context

From: Ajay Singh Refactor add/change beacon cfg80211 operation callback to handle from cfg context. Also avoided extra copy of information by packing directly in firmware expected format. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 128

[PATCH 06/29] staging: wilc1000: handle setting power management from cfg80211 context

From: Ajay Singh Refactor the code to handle the power management cfg operation from the caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 56 +++ 1 file changed, 13 insertions(+), 43 deletions(-) diff --git

[PATCH 08/29] staging: wilc1000: use void return for wilc_hif_pack_sta_param()

From: Ajay Singh Change the return type from u32 to void for wilc_hif_pack_sta_param() as its value is not used. Also remove the use of extra pointer as it's not required now. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 14 -- 1 file changed, 4

[PATCH 01/29] staging: wilc1000: remove unnecessary checks in wilc_mac_close()

From: Ajay Singh Remove unnecessary 'if' check in wilc_mac_close() as those conditions will not happen. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git

[PATCH 03/29] staging: wilc1000: avoid the use of the static variable to configure wiphy struct

From: Ajay Singh Refactor code to avoid the use of static variables to configure the 'wiphy' structure. Now move static variables as part of 'priv' data so it helped to maintain this information per interface. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c |

[PATCH 04/29] staging: wilc1000: use mutex lock to synchronized sending 'wid' cmd to firmware

From: Ajay Singh Use mutex lock to protect the issuing of wid cmd to the firmware. Currently the wid commands are synchronized by use of hif_workqueue work queue. Now, these changes are required to synchronize the access to wid command, so the commands can be issued directly from cfg80211

[PATCH 10/29] staging: wilc1000: use is_zero_ether_addr() API to check mac address

From: Ajay Singh Use is_zero_ether_addr() API to check if mac address value is zero. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 3 +-- drivers/staging/wilc1000/linux_wlan.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 02/29] staging: wilc1000: make use of put_unaligned_le32 in handle_set_wfi_drv_handler()

From: Ajay Singh Make use of put_unaligned_le32() function to pack the wid command buffer for firmware. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 10 ++ drivers/staging/wilc1000/host_interface.h | 1 - 2 files changed, 2 insertions(+), 9 deletions(-)

[PATCH 11/29] staging: wilc1000: handle delete beacon cfg ops from cfg80211 context()

From: Ajay Singh Refactor the code to handle delete beacon cfg operation from cfg80211 context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 39 --- 1 file changed, 10 insertions(+), 29 deletions(-) diff --git

[PATCH 09/29] staging: wilc1000: handle delete station related callback ops from cfg80211 context

From: Ajay Singh Refactor the code to handle delete/delete_all station operation callback from cfg80211 context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 147 +++--- 1 file changed, 33 insertions(+), 114 deletions(-) diff --git

[PATCH 07/29] staging: wilc1000: handle add and edit station from the cfg80211 context

From: Ajay Singh Refactor the code to avoid handling of add/edit stations using work queue and now set the wid value from caller context. Avoid making an extra copy of buffer and directly copy the data in firmware expected format. Signed-off-by: Ajay Singh ---

[PATCH 05/29] staging: wilc1000: handle tx power related callback from cfg80211 context

From: Ajay Singh Avoid the use of internal work queue to defer the handling of tx power related cfg operations callback. Now issuing the wid command to firmware directly from the caller context. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 85

[PATCH 00/29] staging: wilc1000: avoid deferring of cfg80211 operation callback

From: Ajay Singh This patch series mainly contains the change to handle the cfg80211 operation from its context. Now the WID commands are sent to firmware directly from the caller context. Also added few more patches to address the review comment received earlier in series[1]. [1].

[PATCH] staging: iio: ad5933: add binding doc for ad5933

Add a devicetree documentation for the ad5933 and ad5934 impedance converter, network analyzer. Co-Developed-by: Gabriel Capella Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella --- .../iio/impedance-analyzer/ad5933.txt | 23 +++ 1 file changed, 23

Re: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

On Sun, Dec 02, 2018 at 08:47:03AM +, Dexuan Cui wrote: > Hi Greg, > Please use the attached patch: I rebased the patch to today's char-misc's > char-misc-linus branch. It can also cleanly apply to Linus's master branch > today. I can't use an attached patch, you know better. Please fix up

RE: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

> From: gre...@linuxfoundation.org > Sent: Saturday, December 1, 2018 11:34 PM > To: Dexuan Cui > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; vkuznets > ; o...@aepfle.de; jasow...@redhat.com;