Hi Florian,
On Mon, Dec 17, 2018 at 11:22 PM Florian Fainelli wrote:
>
> On 12/17/18 12:44 PM, Sergio Paracuellos wrote:
> > Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> >
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Sergio Paracuellos
>
> This looks
On 12/17/18 12:44 PM, Sergio Paracuellos wrote:
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Sergio Paracuellos
This looks good, although it looks like you have 2x the amount of tabs
necessary.
--
Florian
staging: iio: adc: ad7280a: fix codestyle in ad7280_event_handler
Signed-off-by: Sergey Efimochkin
---
Changes in v2:
- changed patch prefix
- changed patch description
- removed incorrect fixes to codestyle
drivers/staging/iio/adc/ad7280a.c | 6 ++
1 file changed, 2 insertions(+), 4
On Sun, Dec 16, 2018 at 11:37:56AM +, Jonathan Cameron wrote:
> On Tue, 11 Dec 2018 17:54:55 -0700
> Jeremy Fertic wrote:
>
> > The only assignment to dac_bits is in adt7316_store_da_high_resolution().
> > This function enables or disables 10 bit dac resolution for the adt7316/7
> > and
We agree that preserving the reverse-engineered knowledge is more
important than reducing code size. In turn, we have modified the patch
to keep these defines and converted them to uppercase as well.
Also, we agree that further abbreviating would be a bad idea.
According to the Linux coding guidelines, defines should be written
in uppercase. This patch converts all define-statements in the
ni_pcidio.c file to uppercase, thus matching the coding style of the
kernel.
Signed-off-by: Alexander Schroth
Signed-off-by: Marco Ammon
---
On Mon, Dec 17, 2018 at 8:11 PM Dan Carpenter wrote:
>
> On Mon, Dec 17, 2018 at 07:22:51PM +0100, Sergio Paracuellos wrote:
> > > > +static int ksz_i2c_write(struct ksz_device *dev, u32 reg, u8 *val,
> > > > + unsigned int len)
> > > > +{
> > > > + struct i2c_client
Add device-tree binding example of the ksz9477 switch managed in i2c mode.
Cc: devicet...@vger.kernel.org
Signed-off-by: Sergio Paracuellos
---
Changes v3:
- No changes. Just resent patches together.
Changes v2:
- Use generic name for label of the switch and make sure reg and @X
On Mon, 17 Dec 2018 18:44:12 +
Dexuan Cui wrote:
> > From: devel On Behalf Of
> > Dexuan Cui
> > Sent: Monday, December 17, 2018 10:31 AM
> > > From: Stephen Hemminger
> > >
> > > The old code was risky because it would silently return stack garbage.
> > > Having an error check in
In this mode the switch device and the internal phys will be managed via
I2C interface.
Signed-off-by: Sergio Paracuellos
---
Changes v3:
- return -EINVAL if 'ksz_i2c_write' is called with len 0 to
avoid a possible memory corruption.
Changes v2:
- Use dev->txbuf as transmition
fc96df16a1ce is good and can already fix the "return stack garbage" issue,
but let's also improve hv_ringbuffer_get_debuginfo(), which would silently
return stack garbage, if people forget to check channel->state or
ring_info->ring_buffer, when using the function in the future.
Having an error
Hi,
On Mon, 17 Dec 2018, Greg KH wrote:
On Sun, Dec 16, 2018 at 08:57:43AM -0800, Amir Mahdi Ghorbanian wrote:
@@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
break;
case 2: /* first byte after command */
if (status
On Mon, Dec 17, 2018 at 07:22:51PM +0100, Sergio Paracuellos wrote:
> > > +static int ksz_i2c_write(struct ksz_device *dev, u32 reg, u8 *val,
> > > + unsigned int len)
> > > +{
> > > + struct i2c_client *client = dev->priv;
> > > + unsigned int cnt = len;
> > > +
> From: devel On Behalf Of
> Dexuan Cui
> Sent: Monday, December 17, 2018 10:31 AM
> > From: Stephen Hemminger
> >
> > The old code was risky because it would silently return stack garbage.
> > Having an error check in get_debuginfo would eliminate that.
>
> OK, then let me make another patch
On Sun, 16 Dec 2018, Alexey Skidanov wrote:
>
>
> On 12/16/18 7:20 AM, Liam Mark wrote:
> > On Tue, 6 Feb 2018, Alexey Skidanov wrote:
> >
> >>
> >>
> >> On 02/07/2018 01:56 AM, Laura Abbott wrote:
> >>> On 01/31/2018 10:10 PM, Alexey Skidanov wrote:
>
> On 01/31/2018 03:00 PM, Greg
> From: Stephen Hemminger
> Sent: Monday, December 17, 2018 10:17 AM
> To: Dexuan Cui
>
> On Mon, 17 Dec 2018 18:00:29 +
> Dexuan Cui wrote:
>
> > > From: Stephen Hemminger
> > > On Thu, 13 Dec 2018 16:35:43 +
> > > Dexuan Cui wrote:
> > >
> > > > Before 98f4c651762c, we returned
On Mon, Dec 17, 2018 at 8:38 AM Andrew Lunn wrote:
>
> On Sun, Dec 16, 2018 at 10:49:52AM +0100, Sergio Paracuellos wrote:
> > In this mode the switch device and the internal phys will be managed via
> > I2C interface.
> >
> > Signed-off-by: Sergio Paracuellos
> > ---
> > Changes v2:
> > -
Hi Dan,
Thanks for the feedback.
On Mon, Dec 17, 2018 at 7:55 AM Dan Carpenter wrote:
>
> On Sun, Dec 16, 2018 at 08:57:40AM +0100, Sergio Paracuellos wrote:
> > +static int ksz_i2c_write(struct ksz_device *dev, u32 reg, u8 *val,
> > + unsigned int len)
> > +{
> > +
On Mon, 17 Dec 2018 18:00:29 +
Dexuan Cui wrote:
> > From: Stephen Hemminger
> > On Thu, 13 Dec 2018 16:35:43 +
> > Dexuan Cui wrote:
> >
> > > Before 98f4c651762c, we returned zeros for unopened channels.
> > > With 98f4c651762c, we started to return random on-stack values.
> > >
>
> From: Stephen Hemminger
> On Thu, 13 Dec 2018 16:35:43 +
> Dexuan Cui wrote:
>
> > Before 98f4c651762c, we returned zeros for unopened channels.
> > With 98f4c651762c, we started to return random on-stack values.
> >
> > We'd better return -EINVAL instead.
>
> The concept looks fine, but
On Thu, 13 Dec 2018 16:35:43 +
Dexuan Cui wrote:
> Before 98f4c651762c, we returned zeros for unopened channels.
> With 98f4c651762c, we started to return random on-stack values.
>
> We'd better return -EINVAL instead.
>
> Fixes: 98f4c651762c ("hv: move ringbuffer bus attributes to
On Mon, 2018-12-17 at 17:16 +0300, Dan Carpenter wrote:
> Thanks!
>
My fault. :)
> Reviewed-by: Dan Carpenter
>
> regards,
> dan carpenter
>
___
devel mailing list
de...@linuxdriverproject.org
Thanks!
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Since the channels of a MOST device are now being represented as
individual PCM devices of one sound card, the variable card_name is not
suitable anymore to describe them. Therefore, this patch renames the
variable to device_name.
Signed-off-by: Christian Gromm
---
v2:
Reported-by: Dan Carpenter
This patch uses a static name for the sound card's short name and
long name. Having the card names configurable doesn't make sense
anymore, as the card represents the same physical hardware.
Signed-off-by: Christian Gromm
---
v2:
nothing
v3:
nothing
v4:
nothing
This patch updates driver_usage.txt file to reflect the latest changes
that this patch set introduces.
Signed-off-by: Christian Gromm
---
v2:
nothing
v3:
nothing
v4:
nothing
drivers/staging/most/Documentation/driver_usage.txt | 16 +---
1 file changed, 13
Adding the channel number to the name of the sound card is wrong,
as the card does not represent a single streaming channel of the
MOST device.
Signed-off-by: Christian Gromm
---
v2:
nothing
v3:
nothing
v4:
nothing
drivers/staging/most/sound/sound.c | 3 +--
1 file
This patch avoids that a sound card is created and registered with ALSA
every time a channel is being linked. Instead the channels are hooked on
the same card, which is registered not until the final link has been added
to the component. The string provided by user space that used to be the
card
This patch fixes the lable name that is used to jump to error
handling section of function audio_probe_channel() in case
something went wrong.
Signed-off-by: Christian Gromm
---
v2:
nothing
v3:
- rename label name of added goto instruction
v4:
nothing
Currently, for every synchronous channel allocated on MOST an extra sound
card is being created and registered with ALSA. From a logical point of
view this fails to reflect the actual condition, as all channels originate
in the same physical device. This patch series introduces a way to map this
On Sat, Dec 15, 2018 at 03:56:35AM -0500, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li
> ---
> drivers/staging/rtlwifi/debug.c | 23 ++-
> 1 file changed, 6 insertions(+), 17 deletions(-)
Always test build your
On Sat, Dec 15, 2018 at 05:46:11PM +0100, Michael Straube wrote:
> Covert unsigned char arrays to u8 and make them static and/or const
> where possible.
You are also moving things around here from different .h files in
different places. Always say exactly what you are doing.
And this too needs
On Sat, Dec 15, 2018 at 05:46:08PM +0100, Michael Straube wrote:
> Replace tabs with spaces and/or remove spaces in declarations.
> Remove unused/commented declarations, remove unnecessary comment,
> remove blank lines between declarations and add missing lines after
> declarations. Also clears
On Fri, Dec 14, 2018 at 01:04:38PM +0100, Dominic Braun wrote:
> Typedefing structs is not encouraged in the kernel.
>
> Signed-off-by: Dominic Braun
> Signed-off-by: Tobias Büttner
> ---
> .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 8
> 1 file changed, 4
On Thu, Dec 13, 2018 at 08:53:17AM -0800, Amir Mahdi Ghorbanian wrote:
> From: Amir Mahdi Ghorbanian
>
> Fixed a coding style issue.
>
> Signed-off-by: Amir Mahdi Ghorbanian
> ---
> drivers/staging/comedi/drivers/8255.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Sun, Dec 16, 2018 at 08:57:25AM -0800, Amir Mahdi Ghorbanian wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Amir Mahdi Ghorbanian
> ---
> drivers/staging/comedi/drivers/cb_pcidas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You already sent this patch, right?
What
Move ad7606 ADC driver out of staging and into the mainline.
Signed-off-by: Stefan Popa
---
MAINTAINERS | 7 +
drivers/iio/adc/Kconfig | 27 ++
drivers/iio/adc/Makefile | 3 +
drivers/iio/adc/ad7606.c | 583
This patch replaces the license text at the top of ad7606 driver files
and instead adds SPDX GPL-2.0 license identifier.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7606.c | 5 ++---
drivers/staging/iio/adc/ad7606.h | 3 +--
drivers/staging/iio/adc/ad7606_par.c | 5 ++---
Document support for AD7606 Analog to Digital Converter.
Signed-off-by: Stefan Popa
Reviewed-by: Rob Herring
---
.../devicetree/bindings/iio/adc/adi,ad7606.txt | 65 ++
MAINTAINERS| 1 +
2 files changed, 66 insertions(+)
create
* Placed includes in alphabetical order
* Added brackets around num and mask through out for AD760X_CHANNEL
* Used single line comments where needed
* Removed extra lines and spaces
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7606.c | 27 ---
This patch replaces the use of a polling ring buffer with a threaded
interrupt.
Enabling the buffer sets the CONVST signal to high. When the rising edge
of the CONVST is applied, BUSY signal goes logic high and transitions low
at the end of the entire conversion process. The falling edge of the
Changes in v2:
Patch 1:
- Moved the HAS_IOMEM under AD7606_IFACE_PARALLEL and dropped GPIOLIB.
Patch 2:
- Used SPDX GPL-2.0 license identifier instead of GPL-2.0+.
Patch 3:
- Before disabling the buffer, there is no need to trigger a conversion.
Patches 4, 5, 6:
-
There is no point in having three menu entries that can be selected
individually. Instead, the SPI and parallel interfaces should select
AD7606.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/Kconfig | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
On Du, 2018-12-16 at 13:49 +, Jonathan Cameron wrote:
> On Thu, 13 Dec 2018 14:46:17 +0200
> Stefan Popa wrote:
>
> >
> > This patch replaces the use of a polling ring buffer with a threaded
> > interrupt.
> >
> > Enabling the buffer sets the CONVST signal to high. When the rising
> > edge
On Mon, Dec 17, 2018 at 12:33:49PM +0100, Christian Gromm wrote:
> +static void release_adapter(struct sound_adapter *adpt)
> +{
> + struct channel *channel, *tmp;
> +
> + list_for_each_entry_safe(channel, tmp, >dev_list, list) {
> + list_del(>list);
> +
This patch uses a static name for the sound card's short name and
long name. Having the card names configurable doesn't make sense
anymore, as the card represents the same physical hardware.
Signed-off-by: Christian Gromm
---
v2:
nothing
v3:
nothing
This patch avoids that a sound card is created and registered with ALSA
every time a channel is being linked. Instead the channels are hooked on
the same card, which is registered not until the final link has been added
to the component. The string provided by user space that used to be the
card
Adding the channel number to the name of the sound card is wrong,
as the card does not represent a single streaming channel of the
MOST device.
Signed-off-by: Christian Gromm
---
v2:
nothing
v3:
nothing
drivers/staging/most/sound/sound.c | 3 +--
1 file changed, 1 insertion(+),
This patch updates driver_usage.txt file to reflect the latest changes
that this patch set introduces.
Signed-off-by: Christian Gromm
---
v2:
nothing
v3:
nothing
drivers/staging/most/Documentation/driver_usage.txt | 16 +---
1 file changed, 13 insertions(+), 3
Since the channels of a MOST device are now being represented as
individual PCM devices of one sound card, the variable card_name is not
suitable anymore to describe them. Therefore, this patch renames the
variable to device_name.
Signed-off-by: Christian Gromm
---
v2:
Reported-by: Dan Carpenter
Currently, for every synchronous channel allocated on MOST an extra sound
card is being created and registered with ALSA. From a logical point of
view this fails to reflect the actual condition, as all channels originate
in the same physical device. This patch series introduces a way to map this
This patch fixes the lable name that is used to jump to error
handling section of function audio_probe_channel() in case
something went wrong.
Signed-off-by: Christian Gromm
---
v2:
nothing
v3:
- rename label name of added goto instruction
drivers/staging/most/sound/sound.c |
On Mon, 17 Dec 2018 08:08:54 +0100,
Dan Carpenter wrote:
>
> We free instance here and in the caller. It should be only the caller
> which handles it.
>
> Fixes: d7ca3a71545b ("staging: bcm2835-audio: Operate non-atomic PCM ops")
> Signed-off-by: Dan Carpenter
Reviewed-by: Takashi Iwai
On Mon, 2018-12-10 at 10:18 -0800, Stephen Hemminger wrote:
> This fixes the problem where uio application was unable to
> use multple queues on restart. The root cause is that the callbacks
> are cleared on disconnect. Change to setting up callbacks
> everytime in open.
>
> Fixes: cdfa835c6e5e
On Sun, Dec 16, 2018 at 08:57:43AM -0800, Amir Mahdi Ghorbanian wrote:
> @@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> break;
> case 2: /* first byte after command */
> if (status == (I2C_SL_IRQ | RNW | RCVD)) {
> -
55 matches
Mail list logo
