Re: [PATCH v2] staging: erofs: Add identifier for function definition arguments

2019-01-08 Thread Chao Yu
On 2019/1/8 21:24, Sidong Yang wrote: > Add identifier for function definition arguments in xattr_iter_handlers, > this change clears the checkpatch.pl issue and make code more explicit. > > Signed-off-by: Sidong Yang Reviewed-by: Chao Yu Thanks,

Re: [PATCH v6] gpu: ipu-csi: Swap fields according to input/output field types

2019-01-08 Thread Steve Longerbeam
Please disregard. This patch can't be submitted stand-alone, I will re-submit as part of a v6 of "imx-media: Fixes for interlaced capture" patchset. Steve On 12/14/18 3:46 PM, Steve Longerbeam wrote: The function ipu_csi_init_interface() was inverting the F-bit for NTSC case, in the

[PATCH v6 03/12] gpu: ipu-v3: Add planar support to interlaced scan

2019-01-08 Thread Steve Longerbeam
To support interlaced scan with planar formats, cpmem SLUV must be programmed with the correct chroma line stride. For full and partial planar 4:2:2 (YUV422P, NV16), chroma line stride must be doubled. For full and partial planar 4:2:0 (YUV420, YVU420, NV12), chroma line stride must _not_ be

[PATCH v6 06/12] media: imx-csi: Double crop height for alternate fields at sink

2019-01-08 Thread Steve Longerbeam
If the incoming sink field type is alternate, the reset crop height and crop height bounds must be set to twice the incoming height, because in alternate field mode, upstream will report only the lines for a single field, and the CSI captures the whole frame. Signed-off-by: Steve Longerbeam

[PATCH v6 07/12] media: imx: interweave and odd-chroma-row skip are incompatible

2019-01-08 Thread Steve Longerbeam
If IDMAC interweaving is enabled in a write channel, the channel must write the odd chroma rows for 4:2:0 formats. Skipping writing the odd chroma rows produces corrupted captured 4:2:0 images when interweave is enabled. Reported-by: Krzysztof Hałasa Signed-off-by: Steve Longerbeam Reviewed-by:

[PATCH v6 09/12] media: imx: vdic: rely on VDIC for correct field order

2019-01-08 Thread Steve Longerbeam
prepare_vdi_in_buffers() was setting up the dma pointers as if the VDIC is always programmed to receive the fields in bottom-top order, i.e. as if ipu_vdi_set_field_order() only programs BT order in the VDIC. But that's not true, ipu_vdi_set_field_order() is working correctly. So fix

[PATCH v6 11/12] media: imx: Allow interweave with top/bottom lines swapped

2019-01-08 Thread Steve Longerbeam
Allow sequential->interlaced interweaving but with top/bottom lines swapped to the output buffer. This can be accomplished by adding one line length to IDMAC output channel address, with a negative line length for the interlace offset. This is to allow the seq-bt -> interlaced-bt transformation,

[PATCH v6 05/12] media: imx-csi: Input connections to CSI should be optional

2019-01-08 Thread Steve Longerbeam
Some imx platforms do not have fwnode connections to all CSI input ports, and should not be treated as an error. This includes the imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. Return -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode endpoint parsing will not treat

[PATCH v6 08/12] media: imx-csi: Allow skipping odd chroma rows for YVU420

2019-01-08 Thread Steve Longerbeam
Skip writing U/V components to odd rows for YVU420 in addition to YUV420 and NV12. Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel --- drivers/staging/media/imx/imx-media-csi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/imx/imx-media-csi.c

[PATCH v6 02/12] gpu: ipu-csi: Swap fields according to input/output field types

2019-01-08 Thread Steve Longerbeam
The function ipu_csi_init_interface() was inverting the F-bit for NTSC case, in the CCIR_CODE_1/2 registers. The result being that for NTSC bottom-top field order, the CSI would swap fields and capture in top-bottom order. Instead, base field swap on the field order of the input to the CSI, and

[PATCH v6 04/12] media: imx: Fix field negotiation

2019-01-08 Thread Steve Longerbeam
IDMAC interlaced scan, a.k.a. interweave, should be enabled in the IDMAC output channels only if the IDMAC output pad field type is 'seq-bt' or 'seq-tb', and field type at the capture interface is 'interlaced*'. V4L2_FIELD_HAS_BOTH() macro should not be used on the input to determine enabling

[PATCH v6 10/12] media: imx-csi: Move crop/compose reset after filling default mbus fields

2019-01-08 Thread Steve Longerbeam
If caller passes un-initialized field type V4L2_FIELD_ANY to CSI sink pad, the reset CSI crop window would not be correct, because the crop window depends on a valid input field type. To fix move the reset of crop and compose windows to after the call to imx_media_fill_default_mbus_fields().

Re: [PATCH] hv_balloon: avoid touching uninitialized struct page during tail onlining

2019-01-08 Thread Sasha Levin
On Mon, Jan 07, 2019 at 07:38:20PM +0100, Vitaly Kuznetsov wrote: Sasha Levin writes: On Mon, Jan 07, 2019 at 02:44:30PM +0100, Vitaly Kuznetsov wrote: P.S. I still think about bringing mem_hotplug_begin()/done() to hv_balloon but that's going to be a separate discussion, here I want to have

[PATCH AUTOSEL 4.19 44/97] staging: erofs: fix use-after-free of on-stack `z_erofs_vle_unzip_io'

2019-01-08 Thread Sasha Levin
From: Gao Xiang [ Upstream commit 848bd9acdcd00c164b42b14aacec242949ecd471 ] The root cause is the race as follows: Thread #0 Thread #1 z_erofs_vle_unzip_kickoff z_erofs_submit_and_unzip struct z_erofs_vle_unzip_io io[]

[PATCH AUTOSEL 4.20 055/117] staging: erofs: fix use-after-free of on-stack `z_erofs_vle_unzip_io'

2019-01-08 Thread Sasha Levin
From: Gao Xiang [ Upstream commit 848bd9acdcd00c164b42b14aacec242949ecd471 ] The root cause is the race as follows: Thread #0 Thread #1 z_erofs_vle_unzip_kickoff z_erofs_submit_and_unzip struct z_erofs_vle_unzip_io io[]

[PATCH AUTOSEL 4.20 056/117] media: cedrus: don't initialize pointers with zero

2019-01-08 Thread Sasha Levin
From: Mauro Carvalho Chehab [ Upstream commit e4d7b113fdccde1acf8638c5879f2a450d492303 ] A common mistake is to assume that initializing a var with: struct foo f = { 0 }; Would initialize a zeroed struct. Actually, what this does is to initialize the first element of the struct to

Re: [PATCH] media: imx: queue subdev events to reachable video devices

2019-01-08 Thread Steve Longerbeam
Hi Hans, On 1/8/19 5:26 AM, Hans Verkuil wrote: On 12/09/18 20:57, Steve Longerbeam wrote: From: Steve Longerbeam Forward events from a sub-device to its list of reachable video devices. Note this will queue the event to a video device even if there is no actual _enabled_ media path from

Re: [PATCH v2] staging: erofs: Add identifier for function definition arguments

2019-01-08 Thread Gao Xiang
On 2019/1/8 21:24, Sidong Yang wrote: > Add identifier for function definition arguments in xattr_iter_handlers, > this change clears the checkpatch.pl issue and make code more explicit. > > Signed-off-by: Sidong Yang personally looks good to me. Reviewed-by: Gao Xiang Thanks, Gao Xiang

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-08 Thread Dave Stevenson
Hi Peter On Tue, 8 Jan 2019 at 07:21, Peter Robinson wrote: > > Hi Stefan, > > > This patch series improves the load/unload of bcm2835 camera and audio > > drivers. It has been tested with Raspberry Pi 3 B and a camera module V1. > > > > This series based on current linux-next and Phil Elwell's

Re: [PATCH] hv_balloon: avoid touching uninitialized struct page during tail onlining

2019-01-08 Thread Vitaly Kuznetsov
Dan Carpenter writes: > On Mon, Jan 07, 2019 at 07:38:20PM +0100, Vitaly Kuznetsov wrote: >> (I remember Greg disliked when people were tagging patches for stable@ >> themselves, he prefered maintainers deciding if the particular commit >> deserves stable@ or not - but as you have a tree now we

Re: general protection fault in spk_ttyio_ldisc_close

2019-01-08 Thread Samuel Thibault
Greg KH, le mar. 08 janv. 2019 15:25:07 +0100, a ecrit: > On Tue, Jan 08, 2019 at 09:15:02AM -0500, Kyungtae Kim wrote: > > On Tue, Jan 8, 2019 at 8:50 AM Greg KH wrote: > > > > > > On Tue, Jan 08, 2019 at 08:37:37AM -0500, Kyungtae Kim wrote: > > > > We report a bug in linux-4.20: "general

Re: general protection fault in spk_ttyio_ldisc_close

2019-01-08 Thread Greg KH
On Tue, Jan 08, 2019 at 09:15:02AM -0500, Kyungtae Kim wrote: > On Tue, Jan 8, 2019 at 8:50 AM Greg KH wrote: > > > > On Tue, Jan 08, 2019 at 08:37:37AM -0500, Kyungtae Kim wrote: > > > We report a bug in linux-4.20: "general protection fault in > > > spk_ttyio_ldisc_close" > > > > > > kernel

Re: general protection fault in spk_ttyio_ldisc_close

2019-01-08 Thread Kyungtae Kim
On Tue, Jan 8, 2019 at 8:50 AM Greg KH wrote: > > On Tue, Jan 08, 2019 at 08:37:37AM -0500, Kyungtae Kim wrote: > > We report a bug in linux-4.20: "general protection fault in > > spk_ttyio_ldisc_close" > > > > kernel config: https://kt0755.github.io/etc/config_v4.20_stable > > repro:

Re: general protection fault in spk_ttyio_ldisc_close

2019-01-08 Thread Greg KH
On Tue, Jan 08, 2019 at 08:37:37AM -0500, Kyungtae Kim wrote: > We report a bug in linux-4.20: "general protection fault in > spk_ttyio_ldisc_close" > > kernel config: https://kt0755.github.io/etc/config_v4.20_stable > repro: https://kt0755.github.io/etc/repro.a670e.c > > This occurs when the

general protection fault in spk_ttyio_ldisc_close

2019-01-08 Thread Kyungtae Kim
We report a bug in linux-4.20: "general protection fault in spk_ttyio_ldisc_close" kernel config: https://kt0755.github.io/etc/config_v4.20_stable repro: https://kt0755.github.io/etc/repro.a670e.c This occurs when the function kfree is about to execute (driver/staging/speakup/spk_ttyio.c:68).

Re: [PATCH] media: imx: queue subdev events to reachable video devices

2019-01-08 Thread Hans Verkuil
On 12/09/18 20:57, Steve Longerbeam wrote: > From: Steve Longerbeam > > Forward events from a sub-device to its list of reachable video > devices. > > Note this will queue the event to a video device even if there is > no actual _enabled_ media path from the sub-device to the video device. > So

[PATCH v2] staging: erofs: Add identifier for function definition arguments

2019-01-08 Thread Sidong Yang
Add identifier for function definition arguments in xattr_iter_handlers, this change clears the checkpatch.pl issue and make code more explicit. Signed-off-by: Sidong Yang --- drivers/staging/erofs/xattr.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH v2 1/2] staging: erofs: fixed -Wmissing-prototype warnings by making functions static.

2019-01-08 Thread Jeremy Sowden
Define three functions which are not used outside their own translation-units as static in order to fix the following warnings: drivers/staging/erofs/utils.c:134:6: warning: no previous prototype for ‘erofs_try_to_release_workgroup’ [-Wmissing-prototypes] bool

[PATCH v2 0/2] staging: erofs: fixed -Wmissing-prototype warnings.

2019-01-08 Thread Jeremy Sowden
Fixes for -Wmissing-prototype warnings in the erofs driver. One group of functions have been made static; for the second, prototypes have been moved to a header file. Changes since v1: * amended commit messages to ensure distinct e-mail subjects. Jeremy Sowden (2): staging: erofs: fixed

[PATCH v2 2/2] staging: erofs: fixed -Wmissing-prototype warnings by moving prototypes to header file.

2019-01-08 Thread Jeremy Sowden
Moved prototypes for two functions to a header file in order to fix the following warnings: drivers/staging/erofs/unzip_vle.c:577:6: warning: no previous prototype for ‘erofs_workgroup_free_rcu’ [-Wmissing-prototypes] void erofs_workgroup_free_rcu(struct erofs_workgroup *grp)

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-08 Thread Stefan Wahren
Hi Peter, > Peter Robinson hat am 8. Januar 2019 um 09:56 > geschrieben: > > > Hi Stefan, > > > > > This patch series improves the load/unload of bcm2835 camera and audio > > > > drivers. It has been tested with Raspberry Pi 3 B and a camera module > > > > V1. > > > > > > > > This series

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-08 Thread Ayaka
Sent from my iPad > On Jan 8, 2019, at 4:38 PM, Paul Kocialkowski > wrote: > > Hi, > >> On Tue, 2019-01-08 at 09:16 +0800, Ayaka wrote: >> >> Sent from my iPad >> >>> On Jan 7, 2019, at 5:57 PM, Paul Kocialkowski >>> wrote: >>> >>> Hi, >>> > On Mon, 2019-01-07 at 11:49 +0800,

Re: [PATCH] [v3] staging: rtl8723bs: Clean up dead code

2019-01-08 Thread Dan Carpenter
Your subject does work for `git am` but the more normal way to format it is: [PATCH v4] staging: rtl8723bs: Clean up dead code On Mon, Jan 07, 2019 at 05:20:52PM -0600, Aditya Pakki wrote: > rtw_wps_start() is part of dead code due to CONFIG_INTEL_WIDI. > The fix removes the deadcode and

Re: [PATCH] hv_balloon: avoid touching uninitialized struct page during tail onlining

2019-01-08 Thread Dan Carpenter
On Mon, Jan 07, 2019 at 07:38:20PM +0100, Vitaly Kuznetsov wrote: > (I remember Greg disliked when people were tagging patches for stable@ > themselves, he prefered maintainers deciding if the particular commit > deserves stable@ or not - but as you have a tree now we may as well have > different

Re: [PATCH] hv_balloon: avoid touching uninitialized struct page during tail onlining

2019-01-08 Thread Vitaly Kuznetsov
David Hildenbrand writes: > On 07.01.19 14:44, Vitaly Kuznetsov wrote: >> David Hildenbrand writes: >> ... >>> On 04.01.19 15:19, Vitaly Kuznetsov wrote: if (start_pfn > has->start_pfn && - !PageReserved(pfn_to_page(start_pfn - 1))) +

Re: [PATCH 0/2] staging: erofs: fixed -Wmissing-prototype warnings.

2019-01-08 Thread Gao Xiang
On 2019/1/8 17:08, Jeremy Sowden wrote: > On 2019-01-08, at 09:46:18 +0800, Gao Xiang wrote: >> On 2019/1/8 2:25, Jeremy Sowden wrote: >>> Fixes for -Wmissing-prototype warnings in the erofs driver. One >>> group of functions have been made static; for the second, prototypes >>> have been

Re: [PATCH] hv_balloon: avoid touching uninitialized struct page during tail onlining

2019-01-08 Thread David Hildenbrand
On 07.01.19 14:44, Vitaly Kuznetsov wrote: > David Hildenbrand writes: > >> On 04.01.19 15:19, Vitaly Kuznetsov wrote: >>> Hyper-V memory hotplug protocol has 2M granularity and in Linux x86 we use >>> 128M. To deal with it we implement partial section onlining by registering >>> custom page

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-08 Thread Peter Robinson
Hi Stefan, > > > This patch series improves the load/unload of bcm2835 camera and audio > > > drivers. It has been tested with Raspberry Pi 3 B and a camera module V1. > > > > > > This series based on current linux-next and Phil Elwell's series > > > ("Improve VCHIQ > > > cache line size

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-08 Thread Stefan Wahren
Hi Peter, > Peter Robinson hat am 8. Januar 2019 um 08:21 > geschrieben: > > > Hi Stefan, > > > This patch series improves the load/unload of bcm2835 camera and audio > > drivers. It has been tested with Raspberry Pi 3 B and a camera module V1. > > > > This series based on current linux-next

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-08 Thread Paul Kocialkowski
Hi, On Tue, 2019-01-08 at 09:16 +0800, Ayaka wrote: > > Sent from my iPad > > > On Jan 7, 2019, at 5:57 PM, Paul Kocialkowski > > wrote: > > > > Hi, > > > > > On Mon, 2019-01-07 at 11:49 +0800, Randy Li wrote: > > > > On 12/12/18 8:51 PM, Paul Kocialkowski wrote: > > > > Hi, > > > > > > >