Re: [PATCH] sched/wait: introduce wait_event_freezable_hrtimeout

2019-01-17 Thread Hugo Lefeuvre
Hi Greg, > > introduce wait_event_freezable_hrtimeout, an interruptible and freezable > > version of wait_event_hrtimeout. > > > > simplify handle_vsoc_cond_wait (drivers/staging/android/vsoc.c) using this > > newly added helper and remove useless includes. > > > > Signed-off-by: Hugo Lefeuvre

Re: [PATCH] sched/wait: introduce wait_event_freezable_hrtimeout

2019-01-17 Thread Greg Kroah-Hartman
On Thu, Jan 17, 2019 at 11:41:35PM +0100, Hugo Lefeuvre wrote: > introduce wait_event_freezable_hrtimeout, an interruptible and freezable > version of wait_event_hrtimeout. > > simplify handle_vsoc_cond_wait (drivers/staging/android/vsoc.c) using this > newly added helper and remove useless

Re:From Mr.Dave Fielder.

2019-01-17 Thread Mr.Dave Fielder.
Hello, Following the fought against corrupted staffs that planned to embezzle your fund. Your name appeared as one of those who spent money for fund transfer here in Africa and countries of united nation and Asian and North America. Therefore, you are among victim compensated by the world body

Re: [PATCH] staging: android: ion: move map_kernel to ion_dma_buf_kmap

2019-01-17 Thread Xiaqing (A)
On 2019/1/3 6:36, Laura Abbott wrote: On 12/24/18 12:19 AM, Qing Xia wrote: Now, as Google's user guide, if userspace need clean ION buffer's cache, they should call ioctl(fd, DMA_BUF_IOCTL_SYNC, sync). Then we found that ion_dma_buf_begin_cpu_access/ion_dma_buf_end_cpu_access will do ION

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-17 Thread Liam Mark
On Thu, 17 Jan 2019, Andrew F. Davis wrote: > On 1/16/19 4:54 PM, Liam Mark wrote: > > On Wed, 16 Jan 2019, Andrew F. Davis wrote: > > > >> On 1/16/19 9:19 AM, Brian Starkey wrote: > >>> Hi :-) > >>> > >>> On Tue, Jan 15, 2019 at 12:40:16PM -0600, Andrew F. Davis wrote: > On 1/15/19 12:38

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-17 Thread Liam Mark
On Thu, 17 Jan 2019, Andrew F. Davis wrote: > On 1/16/19 4:48 PM, Liam Mark wrote: > > On Wed, 16 Jan 2019, Andrew F. Davis wrote: > > > >> On 1/15/19 1:05 PM, Laura Abbott wrote: > >>> On 1/15/19 10:38 AM, Andrew F. Davis wrote: > On 1/15/19 11:45 AM, Liam Mark wrote: > > On Tue, 15

[PATCH] sched/wait: introduce wait_event_freezable_hrtimeout

2019-01-17 Thread Hugo Lefeuvre
introduce wait_event_freezable_hrtimeout, an interruptible and freezable version of wait_event_hrtimeout. simplify handle_vsoc_cond_wait (drivers/staging/android/vsoc.c) using this newly added helper and remove useless includes. Signed-off-by: Hugo Lefeuvre --- drivers/staging/android/vsoc.c |

Re: staging/android: questions regarding TODO entries

2019-01-17 Thread Hugo Lefeuvre
> It should probably say "address." Thanks. I'm working on a few patches for staging/android, this issue will be addressed as well. regards, Hugo -- Hugo Lefeuvre (hle)|www.owl.eu.com RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD ed25519_ 37B2 6D38 0B25

Re: [PATCH v2] media: imx-csi: Input connections to CSI should be optional

2019-01-17 Thread Fabio Estevam
Hi Steve, On Thu, Jan 17, 2019 at 6:59 PM Steve Longerbeam wrote: > > Some imx platforms do not have fwnode connections to all CSI input > ports, and should not be treated as an error. This includes the > imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. > Return -ENOTCONN in

Re: [PATCH 2/2] staging: rtl8188eu: cleanup indenting issue in mlme_linux.c

2019-01-17 Thread Joe Perches
On Thu, 2019-01-17 at 20:23 +0100, Michael Straube wrote: > Cleanup indenting issue reported by checkpatch. > CHECK: Alignment should match open parenthesis [] > diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c > b/drivers/staging/rtl8188eu/os_dep/mlme_linux.c [] > @@ -52,9 +52,8 @@

[PATCH v2] media: imx-csi: Input connections to CSI should be optional

2019-01-17 Thread Steve Longerbeam
Some imx platforms do not have fwnode connections to all CSI input ports, and should not be treated as an error. This includes the imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. Return -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode endpoint parsing will not treat

Re: [PATCH] media: imx-csi: Input connections to CSI should be optional

2019-01-17 Thread Steve Longerbeam
Hi Tim, On 1/15/19 8:42 AM, Tim Harvey wrote: On Wed, Jan 9, 2019 at 10:34 AM Steve Longerbeam wrote: Some imx platforms do not have fwnode connections to all CSI input ports, and should not be treated as an error. This includes the imx6q SabreAuto, which has no connections to ipu1_csi1 and

[PATCH v2 2/2] media: imx: prpencvf: Disable CSI immediately after last EOF

2019-01-17 Thread Steve Longerbeam
The CSI must be disabled immediately after receiving the last EOF before stream off (and thus before disabling the IDMA channel). This can be accomplished by moving upstream stream off to just after receiving the last EOF completion in prp_stop(). For symmetry also move upstream stream on to end

[PATCH v2 1/2] media: imx: csi: Disable CSI immediately after last EOF

2019-01-17 Thread Steve Longerbeam
Disable the CSI immediately after receiving the last EOF before stream off (and thus before disabling the IDMA channel). This fixes a complete system hard lockup on the SabreAuto when streaming from the ADV7180, by repeatedly sending a stream off immediately followed by stream on: while true; do

Re: [PATCH 1/2] media: imx: csi: Disable CSI immediately after last EOF

2019-01-17 Thread Steve Longerbeam
Hi Fabio, thanks for the review. On 1/17/19 12:20 PM, Fabio Estevam wrote: Hi Steve, On Thu, Jan 17, 2019 at 6:15 PM Steve Longerbeam wrote: Disable the CSI immediately after receiving the last EOF before stream off (and thus before disabling the IDMA channel). This fixes a complete system

Re: [PATCH hyperv-fixes,0/3] fixes for hash key setting issues

2019-01-17 Thread Sasha Levin
On Tue, Jan 15, 2019 at 12:51:41AM +, Haiyang Zhang wrote: From: Haiyang Zhang Using ethtool to change Hash key failed on Linux VM runnig on Hyper-V. This patch set fix them. It targets Hyper-V tree, hyperv-fixes branch managed by Sasha Levin . Queued all 3 for hyperv-fixes, thank you.

Re: [PATCH 1/2] media: imx: csi: Disable CSI immediately after last EOF

2019-01-17 Thread Fabio Estevam
Hi Steve, On Thu, Jan 17, 2019 at 6:15 PM Steve Longerbeam wrote: > > Disable the CSI immediately after receiving the last EOF before stream > off (and thus before disabling the IDMA channel). > > This fixes a complete system hard lockup on the SabreAuto when streaming > from the ADV7180, by

Re: [PATCH 2/2] staging: rtl8188eu: cleanup indenting issue in mlme_linux.c

2019-01-17 Thread Michael Straube
On 1/17/19 8:44 PM, Joe Perches wrote: On Thu, 2019-01-17 at 20:23 +0100, Michael Straube wrote: Cleanup indenting issue reported by checkpatch. CHECK: Alignment should match open parenthesis [] diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c

[PATCH 1/2] media: imx: csi: Disable CSI immediately after last EOF

2019-01-17 Thread Steve Longerbeam
Disable the CSI immediately after receiving the last EOF before stream off (and thus before disabling the IDMA channel). This fixes a complete system hard lockup on the SabreAuto when streaming from the ADV7180, by repeatedly sending a stream off immediately followed by stream on: while true; do

[PATCH 2/2] media: imx: prpencvf: Disable CSI immediately after last EOF

2019-01-17 Thread Steve Longerbeam
The CSI must be disabled immediately after receiving the last EOF before stream off (and thus before disabling the IDMA channel). This can be accomplished by moving upstream stream off to just after receiving the last EOF completion in prp_stop(). For symmetry also move upstream stream on to end

[PATCH 1/2] staging: rtl8188eu: add spaces around operators in mlme_linux.c

2019-01-17 Thread Michael Straube
Add spaces around '+' and '-' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c

[PATCH 2/2] staging: rtl8188eu: cleanup indenting issue in mlme_linux.c

2019-01-17 Thread Michael Straube
Cleanup indenting issue reported by checkpatch. CHECK: Alignment should match open parenthesis Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c

Re: [PATCH v3] Drivers: hv: vmbus: Expose counters for interrupts and full conditions

2019-01-17 Thread Stephen Hemminger
> +static ssize_t channel_intr_in_full_show(const struct vmbus_channel > *channel, > + char *buf) > +{ > + return sprintf(buf, "%llu\n", channel->intr_in_full); > +} intr_in_full is u64, which is not the same as unsigned long long. to be correct you

RE: [PATCH v3] Drivers: hv: vmbus: Expose counters for interrupts and full conditions

2019-01-17 Thread Michael Kelley
From: Kimberly Brown Sent: Wednesday, January 16, 2019 8:38 PM > > Counter values for per-channel interrupts and ring buffer full > conditions are useful for investigating performance. > > Expose counters in sysfs for 2 types of guest to host interrupts: > 1) Interrupts caused by the channel's

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-17 Thread Andrew F. Davis
On 1/16/19 4:54 PM, Liam Mark wrote: > On Wed, 16 Jan 2019, Andrew F. Davis wrote: > >> On 1/16/19 9:19 AM, Brian Starkey wrote: >>> Hi :-) >>> >>> On Tue, Jan 15, 2019 at 12:40:16PM -0600, Andrew F. Davis wrote: On 1/15/19 12:38 PM, Andrew F. Davis wrote: > On 1/15/19 11:45 AM, Liam

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-17 Thread Andrew F. Davis
On 1/16/19 4:48 PM, Liam Mark wrote: > On Wed, 16 Jan 2019, Andrew F. Davis wrote: > >> On 1/15/19 1:05 PM, Laura Abbott wrote: >>> On 1/15/19 10:38 AM, Andrew F. Davis wrote: On 1/15/19 11:45 AM, Liam Mark wrote: > On Tue, 15 Jan 2019, Andrew F. Davis wrote: > >> On 1/14/19

Re: [PATCH 3/3] PCI: hv: Use vPCI protocol version 1.2 for v4.9

2019-01-17 Thread Bjorn Helgaas
On Fri, Jan 18, 2019 at 02:17:18AM +0530, Ajay Kaher wrote: > Update the Hyper-V vPCI driver to use the Server-2016 version of the vPCI > protocol, fixing MSI creation and retargeting issues. > > Replaced hv_tmp_cpu_nr_to_vp_nr() with vmbus_cpu_number_to_vp_number() > to make this patch

Re: [PATCH 2/3] PCI: hv: Add vPCI version protocol negotiation

2019-01-17 Thread Bjorn Helgaas
On Fri, Jan 18, 2019 at 02:17:17AM +0530, Ajay Kaher wrote: > Hyper-V vPCI offers different protocol versions. Add the infra for > negotiating the one to use. > > Signed-off-by: Jork Loeser > Signed-off-by: Bjorn Helgaas I did not sign off on this, please remove. > Reviewed-by: K. Y.

Re: [PATCH 1/3] PCI: hv: Allocate physically contiguous hypercall params buffer

2019-01-17 Thread Bjorn Helgaas
On Fri, Jan 18, 2019 at 02:17:16AM +0530, Ajay Kaher wrote: > hv_do_hypercall() assumes that we pass a segment from a physically > contiguous buffer. A buffer allocated on the stack may not work if > CONFIG_VMAP_STACK=y is set. > > Use kmalloc() to allocate this buffer. > > Reported-by: Haiyang

[PATCH 12/13] staging: wilc1000: refactor handle_set_mcast_filter()

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Refactor handle_set_mcast_filter() by making use of put_unaligned32() to pack the data instead of byte operation. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 37 +-- drivers/staging/wilc1000/host_interface.h | 2 +-

Re: [PATCH 0/3] PCI: hv: Use vPCI protocol version 1.2 for v4.9

2019-01-17 Thread Greg KH
On Fri, Jan 18, 2019 at 02:17:15AM +0530, Ajay Kaher wrote: > For now, please consider these patches for review and suggest if these can be > merged to mainline kernel v4.9. > > These patches add support for vPCI protocol version 1.2, by baqkpotring from > v4.14 to v4.9. Individual patches are

[PATCH 03/13] staging: wilc1000: use 'struct' to pack cfg header frame in wilc_wlan_cfg_commit()

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Make use of 'struct' to pack cfg header in wilc_wlan_cfg_commit() instead of byte by byte filling. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- drivers/staging/wilc1000/wilc_wlan.c | 25 ++---

[PATCH 00/13] staging: wilc1000: address few mainline review

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh This series contains changes to address few of the review comments[1]. It mainly has the modification to remove the use of scan shadow buffer, make use of kernel provided API, avoid typedef's and few changes to simplify the logic. [1].

[PATCH 02/13] staging: wilc1000: refactor wilc_wlan_set_bssid()

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Refactor code by making use of eth_zero_addr() to clear the mac address value in wilc_wlan_set_bssid(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 6 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 16 +--- 2

[PATCH 07/13] staging: wilc1000: use struct to pack join parameters for FW

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Refactor code to use struct to construct the join parameters. Avoid use of extra buffer before sending to FW instead directly pass the struct pointer. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 404 --

[PATCH 13/13] staging: wilc1000: avoid the use of typedef for function pointers

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Remove typedef for function pointers. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 13 +++-- drivers/staging/wilc1000/host_interface.h | 24 ++-- drivers/staging/wilc1000/wilc_wlan.c | 10 ++

[PATCH 08/13] staging: wilc1000: rename hidden_network related data structure

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Rename hidden_network related data structure to have more appropriate names, as it's used to keep search network SSID details. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 40 +++

[PATCH 01/13] staging: wilc1000: make use of get_unaligned_le16/le32 to pack data

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Make use of get_unaligned_le16/le32 framework api's to pack data. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 15 +++ drivers/staging/wilc1000/wilc_wlan_cfg.c | 27 +-- 2 files changed, 16 insertions(+), 26

[PATCH 09/13] staging: wilc1000: use single struct for 'connect' related parameters

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Use single structure to store the connect request and response information. It helped in avoiding unnecessary buffer allocation to handle request and response flow. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 217 ++

[PATCH 05/13] staging: wilc1000: make use of cfg80211_inform_bss_frame()

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Use cfg80211_inform_bss_frame() api instead of cfg80211_inform_bss() to inform cfg80211 about the BSS frame, to avoid unnecessary parsing of frame in driver. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 144 +-

[PATCH 04/13] staging: wilc1000: remove the use of scan shadow buffer

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Remove scan shadow buffer, which is used to store a copy of scan results. Instead, use cfg80211 provided API's to retrieve required info. Remove the helper functions which are operating on shadow buffer, as it's not require now. Signed-off-by: Ajay Singh ---

[PATCH 10/13] staging: wilc1000: refactor information message parsing logic

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Refactor code to avoid maintaining an unnecessary buffer to keep the information type message ('I' msg type). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 66 --- 1 file changed, 16 insertions(+), 50 deletions(-) diff

[PATCH 06/13] staging: wilc1000: corrected order to pack join param buffer

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Modified packing order for join param as expected by firmware. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 11/13] staging: wilc1000: remove 'disconnect_info' structure

2019-01-17 Thread Ajay.Kathat
From: Ajay Singh Remove 'disconnect_info' struct use because its passed values are not required in cfg_connect_result(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 24 +-- drivers/staging/wilc1000/host_interface.h | 9

[PATCH 3/3] PCI: hv: Use vPCI protocol version 1.2 for v4.9

2019-01-17 Thread Ajay Kaher
Update the Hyper-V vPCI driver to use the Server-2016 version of the vPCI protocol, fixing MSI creation and retargeting issues. Replaced hv_tmp_cpu_nr_to_vp_nr() with vmbus_cpu_number_to_vp_number() to make this patch compatibale for linux v4.9. Signed-off-by: Jork Loeser Signed-off-by: Bjorn

[PATCH 2/3] PCI: hv: Add vPCI version protocol negotiation

2019-01-17 Thread Ajay Kaher
Hyper-V vPCI offers different protocol versions. Add the infra for negotiating the one to use. Signed-off-by: Jork Loeser Signed-off-by: Bjorn Helgaas Reviewed-by: K. Y. Srinivasan Acked-by: K. Y. Srinivasan Signed-off-by: Ajay Kaher --- drivers/pci/host/pci-hyperv.c | 72

[PATCH 1/3] PCI: hv: Allocate physically contiguous hypercall params buffer

2019-01-17 Thread Ajay Kaher
hv_do_hypercall() assumes that we pass a segment from a physically contiguous buffer. A buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is set. Use kmalloc() to allocate this buffer. Reported-by: Haiyang Zhang Signed-off-by: Long Li Signed-off-by: Bjorn Helgaas Acked-by: K.

[PATCH 0/3] PCI: hv: Use vPCI protocol version 1.2 for v4.9

2019-01-17 Thread Ajay Kaher
For now, please consider these patches for review and suggest if these can be merged to mainline kernel v4.9. These patches add support for vPCI protocol version 1.2, by baqkpotring from v4.14 to v4.9. Individual patches are summarised below: Patch 1: PCI: hv: Allocate physically contiguous

[PATCH v3] selftests: add binderfs selftests

2019-01-17 Thread Christian Brauner
This adds the promised selftest for binderfs. It will verify the following things: - binderfs mounting works - binder device allocation works - performing a binder ioctl() request through a binderfs device works - binder device removal works - binder-control removal fails - binderfs unmounting

Re: [PATCH v2] selftests: add binderfs selftests

2019-01-17 Thread Christian Brauner
On Thu, Jan 17, 2019 at 11:55:49AM +0100, Greg KH wrote: > On Thu, Jan 17, 2019 at 11:28:21AM +0100, Christian Brauner wrote: > > This adds the promised selftest for binderfs. It will verify the following > > things: > > - binderfs mounting works > > - binder device allocation works > > -

Re: [PATCH v2] selftests: add binderfs selftests

2019-01-17 Thread Greg KH
On Thu, Jan 17, 2019 at 11:28:21AM +0100, Christian Brauner wrote: > This adds the promised selftest for binderfs. It will verify the following > things: > - binderfs mounting works > - binder device allocation works > - performing a binder ioctl() request through a binderfs device works > -

[PATCH v2] selftests: add binderfs selftests

2019-01-17 Thread Christian Brauner
This adds the promised selftest for binderfs. It will verify the following things: - binderfs mounting works - binder device allocation works - performing a binder ioctl() request through a binderfs device works - binder device removal works - binder-control removal fails - binderfs unmounting

Re: [PATCH v1] selftests: add binderfs selftests

2019-01-17 Thread Christian Brauner
On Wed, Jan 16, 2019 at 04:11:55PM -0700, shuah wrote: > Hi Christian, > > On 1/16/19 3:27 PM, Christian Brauner wrote: > > This adds the promised selftest for binderfs. It will verify the following > > things: > > - binderfs mounting works > > - binder device allocation works > > - performing a

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-17 Thread Christoph Hellwig
On Wed, Jan 16, 2019 at 10:17:23AM -0600, Andrew F. Davis wrote: > I wouldn't go as far as to remove them just yet.. Liam seems pretty > adamant that they have valid uses. I'm just not sure performance is one > of them, maybe in the case of software locks between devices or > something where there