FINANCIAL MANAGEMENT AND ADVISORY SERVICES LIMITED 1ม

2019-01-30 Thread Mr. Martin Jones
Dear de...@driverdev.osuosl.org, Please pardon me for this unsolicited communique. I do have the trusteeship of a PRIVATE investor with a stormy political background to outsource individuals with sound Financial Management abilities to manage over US$1.3B devoid of his name. These funds

[PATCH] staging: prefix header search paths with $(srctree)/

2019-01-30 Thread Masahiro Yamada
Currently, the Kbuild core manipulates header search paths in a crazy way [1]. To fix this mess, I want all Makefiles to add explicit $(srctree)/ to the search paths in the srctree. Some Makefiles are already written in that way, but not all. The goal of this work is to make the notation

Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-30 Thread shuah
On 1/30/19 3:32 AM, Johan Hovold wrote: On Mon, Jan 28, 2019 at 02:29:22PM -0700, shuah wrote: On 1/25/19 9:14 PM, Al Viro wrote: On Fri, Jan 25, 2019 at 04:29:05PM -0700, Shuah Khan wrote: tty_set_termios() has the following WARMN_ON which can be triggered with a syscall to invoke TIOCGETD

Re: [PATCH 2/2] binderfs: remove separate device_initcall()

2019-01-30 Thread Christian Brauner
On Wed, Jan 30, 2019 at 10:17:39PM +0100, Greg KH wrote: > On Wed, Jan 30, 2019 at 06:01:02PM +0100, Christian Brauner wrote: > > On Wed, Jan 30, 2019 at 03:24:12PM +0100, Greg KH wrote: > > > On Wed, Jan 23, 2019 at 12:41:16PM +0100, Christian Brauner wrote: > > > > binderfs should not have a

[PATCH v1] binderfs: remove separate device_initcall()

2019-01-30 Thread Christian Brauner
binderfs should not have a separate device_initcall(). When a kernel is compiled with CONFIG_ANDROID_BINDERFS register the filesystem alongside CONFIG_ANDROID_IPC. This use-case is especially sensible when users specify CONFIG_ANDROID_IPC=y, CONFIG_ANDROID_BINDERFS=y and ANDROID_BINDER_DEVICES="".

Re: patch "staging: erofs: keep corrupted fs from crashing kernel in" added to staging-linus

2019-01-30 Thread Gao Xiang
Hi Dan and Greg, On 2019/1/31 4:00, Dan Carpenter wrote: > On Wed, Jan 30, 2019 at 11:42:41PM +0800, Gao Xiang wrote: >> >> On 2019/1/30 23:05, Gao Xiang wrote: >>> Hi Greg, >>> >>> Dan raised some suggestions to me. And I want to get some review ideas from >>> Chao... >>> Current EROFS works

[PATCH v2 4/7] binder: avoid kernel vm_area for buffer fixups

2019-01-30 Thread Todd Kjos
Refactor the functions to validate and fixup struct binder_buffer pointer objects to avoid using vm_area pointers. Instead copy to/from kernel space using binder_alloc_copy_to_buffer() and binder_alloc_copy_from_buffer(). The following functions were refactored: binder_validate_ptr()

[PATCH v2 5/7] binder: remove kernel vm_area for buffer space

2019-01-30 Thread Todd Kjos
Remove the kernel's vm_area and the code that maps buffer pages into it. Signed-off-by: Todd Kjos --- drivers/android/binder_alloc.c | 40 ++ 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/android/binder_alloc.c

[PATCH v2 6/7] binder: remove user_buffer_offset

2019-01-30 Thread Todd Kjos
Remove user_buffer_offset since there is no kernel buffer pointer anymore. Signed-off-by: Todd Kjos --- v2: removed casts as suggested by Dan Carpenter drivers/android/binder.c | 39 ++ drivers/android/binder_alloc.c | 16 ++

[PATCH v2 0/7] binder: eliminate use of vmalloc space for binder buffers

2019-01-30 Thread Todd Kjos
Binder buffers have always been mapped into kernel space via map_kernel_range_noflush() to allow the binder driver to modify the buffer before posting to userspace for processing. In recent Android releases, the number of long-running binder processes has increased to the point that for 32-bit

[PATCH v2 7/7] binder: use userspace pointer as base of buffer space

2019-01-30 Thread Todd Kjos
Now that alloc->buffer points to the userspace vm_area rename buffer->data to buffer->user_data and rename local pointers that hold user addresses. Also use the "__user" tag to annotate all user pointers so sparse can flag cases where user pointer vaues are copied to kernel pointers. Refactor

[PATCH v2 1/7] binder: create userspace-to-binder-buffer copy function

2019-01-30 Thread Todd Kjos
The binder driver uses a vm_area to map the per-process binder buffer space. For 32-bit android devices, this is now taking too much vmalloc space. This patch removes the use of vm_area when copying the transaction data from the sender to the buffer space. Instead of using copy_from_user() for

[PATCH v2 2/7] binder: add functions to copy to/from binder buffers

2019-01-30 Thread Todd Kjos
Avoid vm_area when copying to or from binder buffers. Instead, new copy functions are added that copy from kernel space to binder buffer space. These use kmap_atomic() and kunmap_atomic() to create temporary mappings and then memcpy() is used to copy within that page. Also, kmap_atomic() /

[PATCH v2 3/7] binder: add function to copy binder object from buffer

2019-01-30 Thread Todd Kjos
When creating or tearing down a transaction, the binder driver examines objects in the buffer and takes appropriate action. To do this without needing to dereference pointers into the buffer, the local copies of the objects are needed. This patch introduces a function to validate and copy binder

Re: [PATCH 2/2] binderfs: remove separate device_initcall()

2019-01-30 Thread Greg KH
On Wed, Jan 30, 2019 at 06:01:02PM +0100, Christian Brauner wrote: > On Wed, Jan 30, 2019 at 03:24:12PM +0100, Greg KH wrote: > > On Wed, Jan 23, 2019 at 12:41:16PM +0100, Christian Brauner wrote: > > > binderfs should not have a separate device_initcall(). When a kernel is > > > compiled with

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 08:01:13PM +, Carlos Henrique Lima Melara wrote: > On 30/01/2019 13:29, gre...@linuxfoundation.org wrote: > > On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > >>This patch fix the checkpatch.p1 warning: > >> > >>WARNING: Missing or

[PATCH v3] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread Carlos Henrique Lima Melara
This patch fixes the checkpatch.p1 warning: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 +/* It includes the SPDX expression for GPL-2.0 according to the text license in the top of the C file. Signed-off-by: Carlos Henrique Lima Melara --- Changes since v2: - Corrects

[PATCH] nfit: Document sysfs interface dirty_shutdown

2019-01-30 Thread Dexuan Cui
The new sysfs node was added in Sep 2018 in: commit 0ead11181fe0 ("acpi, nfit: Collect shutdown status") Now let's document it. Signed-off-by: Dexuan Cui --- Documentation/ABI/testing/sysfs-bus-nfit | 8 1 file changed, 8 insertions(+) diff --git

[PATCH] staging: comedi: comedi_fops.c: Remove redundant blank line

2019-01-30 Thread Sandesh Kenjana Ashok
Removed redunant blank line. Issue found by checkpatch. Signed-off-by: Sandesh Kenjana Ashok --- drivers/staging/comedi/comedi_fops.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 38980fad8be4..0caae4a5c471

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread Carlos Henrique Lima Melara
On 30/01/2019 13:29, gre...@linuxfoundation.org wrote: > On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: >> This patch fix the checkpatch.p1 warning: >> >> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 >> +/* > > Why did you not fix

RE: [PATCH] nfit: Collect shutdown status for NVDIMM_FAMILY_HYPERV

2019-01-30 Thread Dexuan Cui
> From: Linux-nvdimm On Behalf Of > Dexuan Cui > Sent: Wednesday, January 30, 2019 12:03 PM > To: Greg KH > Cc: Josh Poulson ; linux-nvd...@lists.01.org; > Haiyang Zhang ; > driverdev-devel@linuxdriverproject.org; Rafael J. Wysocki > ; linux-ker...@vger.kernel.org; Michael Kelley > ; Sasha Levin

RE: [PATCH] nfit: Collect shutdown status for NVDIMM_FAMILY_HYPERV

2019-01-30 Thread Dexuan Cui
> From: Greg KH > Sent: Wednesday, January 30, 2019 11:38 AM > > On Wed, Jan 30, 2019 at 06:48:40PM +, Dexuan Cui wrote: > > > > Let's expose the info to the userspace (e.g. ntctl) via sysfs. > > If you add a new sysfs file, you need to add a new Documentation/ABI/ > update as well :( It's

Re: patch "staging: erofs: keep corrupted fs from crashing kernel in" added to staging-linus

2019-01-30 Thread Dan Carpenter
On Wed, Jan 30, 2019 at 11:42:41PM +0800, Gao Xiang wrote: > > > On 2019/1/30 23:05, Gao Xiang wrote: > > > > Hi Greg, > > > > Dan raised some suggestions to me. And I want to get some review ideas from > > Chao... > > Current EROFS works good for the normal image, this patch is used for > >

Re: [PATCH] nfit: Collect shutdown status for NVDIMM_FAMILY_HYPERV

2019-01-30 Thread Greg KH
On Wed, Jan 30, 2019 at 06:48:40PM +, Dexuan Cui wrote: > > See http://www.uefi.org/RFIC_LIST ("Virtual NVDIMM 0x1901"): > "Get Unsafe Shutdown Count (Function Index 2)". > > Let's expose the info to the userspace (e.g. ntctl) via sysfs. If you add a new sysfs file, you need to add a new

Re: [PATCH] staging:rtlwifi:base.c Fixed line more than 80 characters

2019-01-30 Thread Greg KH
On Wed, Jan 30, 2019 at 07:42:03PM +0100, SandeshKa07 wrote: > From: Sandesh Kenjana Ashok > > Lines over 80 characters are adjusted according to standards. > > Signed-off-by: Sandesh Kenjana Ashok > --- > drivers/staging/rtlwifi/base.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [PATCH] nfit: Collect shutdown status for NVDIMM_FAMILY_HYPERV

2019-01-30 Thread Dan Williams
On Wed, Jan 30, 2019 at 10:49 AM Dexuan Cui wrote: > > > See http://www.uefi.org/RFIC_LIST ("Virtual NVDIMM 0x1901"): > "Get Unsafe Shutdown Count (Function Index 2)". > > Let's expose the info to the userspace (e.g. ntctl) via sysfs. > > Signed-off-by: Dexuan Cui > --- >

[PATCH] nfit: Collect shutdown status for NVDIMM_FAMILY_HYPERV

2019-01-30 Thread Dexuan Cui
See http://www.uefi.org/RFIC_LIST ("Virtual NVDIMM 0x1901"): "Get Unsafe Shutdown Count (Function Index 2)". Let's expose the info to the userspace (e.g. ntctl) via sysfs. Signed-off-by: Dexuan Cui --- drivers/acpi/nfit/core.c | 51 ++

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread Andrew Lunn
> See the patch about all of this from Thomas on lkml yesterday for > why this is the case. Hi Greg Thanks for the info. I had not seen this, and i guess other have not as well. So here is a link to the patch. https://lkml.org/lkml/2019/1/28/1975 Andrew

[PATCH] staging:rtlwifi:base.c Fixed line more than 80 characters

2019-01-30 Thread SandeshKa07
From: Sandesh Kenjana Ashok Lines over 80 characters are adjusted according to standards. Signed-off-by: Sandesh Kenjana Ashok --- drivers/staging/rtlwifi/base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtlwifi/base.c

Re: patch "staging: erofs: keep corrupted fs from crashing kernel in" added to staging-linus

2019-01-30 Thread Greg KH
On Wed, Jan 30, 2019 at 11:42:41PM +0800, Gao Xiang wrote: > > > On 2019/1/30 23:05, Gao Xiang wrote: > > > > Hi Greg, > > > > Dan raised some suggestions to me. And I want to get some review ideas from > > Chao... > > Current EROFS works good for the normal image, this patch is used for > >

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 05:38:17PM +0100, Andrew Lunn wrote: > On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > > This patch fix the checkpatch.p1 warning: > > > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > > +/* > > > > It

RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-01-30 Thread Mani, Rajmohan
Hi Sakari, > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > Sent: Wednesday, January 30, 2019 12:59 AM > To: Mani, Rajmohan > Cc: Mauro Carvalho Chehab ; Greg Kroah-Hartman > ; linux-me...@vger.kernel.org; > de...@driverdev.osuosl.org;

Re: [PATCH 2/2] binderfs: remove separate device_initcall()

2019-01-30 Thread Christian Brauner
On Wed, Jan 30, 2019 at 03:24:12PM +0100, Greg KH wrote: > On Wed, Jan 23, 2019 at 12:41:16PM +0100, Christian Brauner wrote: > > binderfs should not have a separate device_initcall(). When a kernel is > > compiled with CONFIG_ANDROID_BINDERFS register the filesystem alongside > >

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread Andrew Lunn
On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > This patch fix the checkpatch.p1 warning: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > +/* > > It includes the SPDX expression for GPL-2.0 and corrects the comment

[PATCH] drivers:staging: Fixed line more than 80 characters.

2019-01-30 Thread Sandesh Kenjana Ashok
Lines over 80 characters are adjusted according to standards Signed-off-by: Sandesh Kenjana Ashok --- drivers/staging/wlan-ng/cfg80211.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c

Re: patch "staging: erofs: keep corrupted fs from crashing kernel in" added to staging-linus

2019-01-30 Thread Gao Xiang
On 2019/1/30 23:05, Gao Xiang wrote: > > Hi Greg, > > Dan raised some suggestions to me. And I want to get some review ideas from > Chao... > Current EROFS works good for the normal image, this patch is used for > corrupted image only... > > Could you kindly drop this patch temporarily and

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > This patch fix the checkpatch.p1 warning: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > +/* Why did you not fix up the indentation that was already mentioned? > It

Re: [PATCH] staging: erofs: keep corrupted fs from crashing kernel in erofs_namei()

2019-01-30 Thread Gao Xiang
Hi Dan, Thanks for your kindly review. On 2019/1/30 22:45, Dan Carpenter wrote: > On Tue, Jan 29, 2019 at 11:55:40PM +0800, Gao Xiang wrote: >> +static struct page *find_target_block_classic(struct inode *dir, >> + struct erofs_qstr *name, >> +

[PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread Carlos Henrique Lima Melara
This patch fix the checkpatch.p1 warning: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 +/* It includes the SPDX expression for GPL-2.0 and corrects the comment format to suit the kernel's coding style. Signed-off-by: Carlos (Charles)

Re: [PATCH] staging: erofs: keep corrupted fs from crashing kernel in erofs_namei()

2019-01-30 Thread Dan Carpenter
On Tue, Jan 29, 2019 at 11:55:40PM +0800, Gao Xiang wrote: > +static struct page *find_target_block_classic(struct inode *dir, > + struct erofs_qstr *name, > + int *_diff, > +

Re: [PATCH 2/4] staging: android: ion: Restrict cache maintenance to dma mapped memory

2019-01-30 Thread Andrew F. Davis
On 1/29/19 5:44 PM, Liam Mark wrote: > On Fri, 18 Jan 2019, Liam Mark wrote: > >> On Fri, 18 Jan 2019, Andrew F. Davis wrote: >> >>> On 1/18/19 12:37 PM, Liam Mark wrote: The ION begin_cpu_access and end_cpu_access functions use the dma_sync_sg_for_cpu and dma_sync_sg_for_device APIs to

Re: [PATCH] MIPS: Select PINCTRL_RT2880 when RALINK is enabled

2019-01-30 Thread Nishad Kamdar
On Tue, Jan 29, 2019 at 08:09:07PM +, Paul Burton wrote: > Hi Nishad, > > On Tue, Jan 29, 2019 at 08:55:27PM +0530, Nishad Kamdar wrote: > > This patch selects config PINCTRL_RT2880 when config RALINK is > > enabled as per drivers/staging/mt7621-pinctrl/TODO list. PINCTRL > > is also selected

Re: [PATCH 2/2] binderfs: remove separate device_initcall()

2019-01-30 Thread Greg KH
On Wed, Jan 23, 2019 at 12:41:16PM +0100, Christian Brauner wrote: > binderfs should not have a separate device_initcall(). When a kernel is > compiled with CONFIG_ANDROID_BINDERFS register the filesystem alongside > CONFIG_ANDROID_IPC. This use-case is especially sensible when users specify >

Re: [PATCH v11 05/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2019-01-30 Thread Sakari Ailus
Hi Rui, On Thu, Jan 24, 2019 at 04:09:20PM +, Rui Miguel Silva wrote: > Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI > CSI-2 interface. > > Signed-off-by: Rui Miguel Silva > --- > drivers/staging/media/imx/Makefile |1 + >

Re: [PATCH 2/4] staging: android: ion: Restrict cache maintenance to dma mapped memory

2019-01-30 Thread Brian Starkey
Hi Liam, On Tue, Jan 29, 2019 at 03:44:53PM -0800, Liam Mark wrote: > On Fri, 18 Jan 2019, Liam Mark wrote: > > > On Fri, 18 Jan 2019, Andrew F. Davis wrote: > > > > > On 1/18/19 12:37 PM, Liam Mark wrote: > > > > The ION begin_cpu_access and end_cpu_access functions use the > > > >

Re: [PATCH v11 00/13] media: staging/imx7: add i.MX7 media driver

2019-01-30 Thread Sakari Ailus
On Thu, Jan 24, 2019 at 04:09:15PM +, Rui Miguel Silva wrote: > Hi, > This series introduces the Media driver to work with the i.MX7 SoC. it uses > the > already existing imx media core drivers but since the i.MX7, contrary to > i.MX5/6, do not have an IPU and because of that some changes in

Re: [PATCH v11 03/13] media: staging/imx7: add imx7 CSI subdev driver

2019-01-30 Thread Sakari Ailus
Hi Rui, A few more comments below. On Thu, Jan 24, 2019 at 04:09:18PM +, Rui Miguel Silva wrote: > This add the media entity subdevice and control driver for the i.MX7 > CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva > --- > drivers/staging/media/imx/imx7-media-csi.c | 1360

Re: [PATCH v2 1/2] staging: iio: ad7780: add gain & filter gpio support

2019-01-30 Thread Popa, Stefan Serban
On Du, 2019-01-27 at 18:30 -0200, Renato Lui Geh wrote: > Previously, the AD7780 driver only supported gpio for the 'powerdown' > pin. This commit adds suppport for the 'gain' and 'filter' pin. > > Signed-off-by: Renato Lui Geh > Signed-off-by: Giuliano Belinassi > Co-developed-by: Giuliano

Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-30 Thread Johan Hovold
On Mon, Jan 28, 2019 at 02:29:22PM -0700, shuah wrote: > On 1/25/19 9:14 PM, Al Viro wrote: > > On Fri, Jan 25, 2019 at 04:29:05PM -0700, Shuah Khan wrote: > >> tty_set_termios() has the following WARMN_ON which can be triggered with a > >> syscall to invoke TIOCGETD __NR_ioctl. You meant

Re: [PATCH] staging: speakup: fix tty-operation NULL derefs

2019-01-30 Thread Samuel Thibault
Johan Hovold, le mer. 30 janv. 2019 10:49:34 +0100, a ecrit: > The send_xchar() and tiocmset() tty operations are optional. Add the > missing sanity checks to prevent user-space triggerable NULL-pointer > dereferences. > > Fixes: 6b9ad1c742bf ("staging: speakup: add send_xchar, tiocmset and input

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-30 Thread Ayaka
Sent from my iPad > On Jan 30, 2019, at 3:17 PM, Tomasz Figa wrote: > >> On Wed, Jan 30, 2019 at 3:28 PM Ayaka wrote: >> >> >> >> Sent from my iPad >> >>> On Jan 30, 2019, at 11:35 AM, Tomasz Figa wrote: >>> >>> On Wed, Jan 30, 2019 at 11:29 AM Alexandre Courbot >>> wrote:

[PATCH] staging: speakup: fix tty-operation NULL derefs

2019-01-30 Thread Johan Hovold
The send_xchar() and tiocmset() tty operations are optional. Add the missing sanity checks to prevent user-space triggerable NULL-pointer dereferences. Fixes: 6b9ad1c742bf ("staging: speakup: add send_xchar, tiocmset and input functionality for tty") Cc: stable # 4.13 Cc: Okash Khawaja Cc:

Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-01-30 Thread Sakari Ailus
Hi Rajmohan, On Tue, Jan 29, 2019 at 02:27:36PM -0800, Rajmohan Mani wrote: > Currently concurrent stream off operations on ImgU nodes are not > synchronized, leading to use-after-free bugs (as reported by KASAN). > > [ 250.090724] BUG: KASAN: use-after-free in ipu3_dmamap_free+0xc5/0x116 >