Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier

On 4/1/2019 10:43 PM, Greg KH wrote: On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote: On 4/1/2019 8:07 PM, Marcelo Schmitt wrote: Add SPDX identifier of GPL-2.0 for the ad9832 driver. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/frequency/ad9832.c | 3 +-- 1 file

Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier

On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote: > > On 4/1/2019 8:07 PM, Marcelo Schmitt wrote: > > Add SPDX identifier of GPL-2.0 for the ad9832 driver. > > > > Signed-off-by: Marcelo Schmitt > > --- > > drivers/staging/iio/frequency/ad9832.c | 3 +-- > > 1 file changed, 1

Re: Work on iio: stating: frequency: ad9832

On Mon, 1 Apr 2019 11:25:29 -0300 Marcelo Schmitt wrote: > Hello, > > I was looking for some work on staging: iio: ad9832 and made some > observations while reading the driver. > > Apparently it had no devicetree documentation so I tried to elaborate > one. > It uses a platform_data variable

Re: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

On 3/29/19 7:26 PM, Zengtao (B) wrote: Hi laura: -Original Message- From: Laura Abbott [mailto:labb...@redhat.com] Sent: Friday, March 29, 2019 9:27 PM To: Zengtao (B) ; sumit.sem...@linaro.org Cc: Greg Kroah-Hartman ; Arve Hjønnevåg ; Todd Kjos ; Martijn Coenen ; Joel Fernandes ;

Re: [PATCH v2] Staging: comedi: drivers: pcl818: Fixed a coding style error.

On Mon, Apr 01, 2019 at 10:01:30AM -0400, Will Cunningham wrote: > Removed unnecessary parentheses. > > Signed-off-by: Will Cunningham > --- > Changes in v2: > - Removed a typo from the commit message. > --- > drivers/staging/comedi/drivers/pcl818.c | 8 > 1 file changed, 4

[PATCH 3/4] staging: iio: ad9832: use clock framework for clock reference

Previously external clock were set through platform_data struct. Now device uses clk struct defined in include/linux/clk.h to handle external clock source. It also removes mclk from platform_data struct. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/frequency/ad9832.c | 37

[PATCH 4/4] staging: iio: ad9832: add devicetree documentation

Add a devicetree documentation for the ad9832 direct digital synthesizer, waveform generator. Signed-off-by: Marcelo Schmitt --- .../bindings/iio/frequency/ad9832.txt | 26 +++ 1 file changed, 26 insertions(+) create mode 100644

[PATCH 2/4] staging: iio: ad9832: add SPDX identifier

Add SPDX identifier of GPL-2.0 for the ad9832 driver. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/frequency/ad9832.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c index

[PATCH 1/4] staging: iio: ad9832: organize includes

Organize includes to list them in lexicographic order. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/frequency/ad9832.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c

[PATCH 0/4] staging: iio: ad9832: use clock framework

This series of patches do minor codestyle ajusts, set SPDX licence identifier, set use of linux's clock framework to handle external clock, and add a devicetree documentation. Marcelo Schmitt (4): staging: iio: ad9832: organize includes staging: iio: ad9832: add SPDX identifier staging:

Re: [PATCH v2] Staging: greybus: usb: Fixed a coding style error

On 4/1/19 9:22 AM, Will Cunningham wrote: > Line was >80 characters. This looks fine, but "tmp" is not a meaningful name. That argument to gb_connection_create() is a cport id, so "cport_id" would be a much better name for the variable. It seems picky, but details like this make the code much

Work on iio: stating: frequency: ad9832

Hello, I was looking for some work on staging: iio: ad9832 and made some observations while reading the driver. Apparently it had no devicetree documentation so I tried to elaborate one. It uses a platform_data variable to load external clock frequency (I tried to make it use linux's clock

[PATCH v2] Staging: greybus: usb: Fixed a coding style error

Line was >80 characters. Signed-off-by: Will Cunningham --- Changes in v2: - Created a tmp variable to shorten line length. --- drivers/staging/greybus/usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c

[PATCH v2] Staging: comedi: drivers: pcl818: Fixed a coding style error.

Removed unnecessary parentheses. Signed-off-by: Will Cunningham --- Changes in v2: - Removed a typo from the commit message. --- drivers/staging/comedi/drivers/pcl818.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c

[PATCH v3 14/14] staging: most: Documentation: update driver documentation

This patch updates the driver documentation files to reflect the latest changes regarding configfs. Signed-off-by: Christian Gromm v2: - changed kernel version to 5.2 v3: Signed-off-by: Christian Gromm --- .../most/Documentation/ABI/configfs-most.txt | 204 +

[PATCH v3 10/14] staging: most: allow speculative configuration

This patch makes the driver accept a link configuration eventhough no device is attached to the bus. Instead the configuration is being applied as soon as a device is being registered with the core. Signed-off-by: Christian Gromm --- v2: - follow-up adaptions due to changes introduced w/

[PATCH v3 02/14] staging: most: change signature of function probe_channel

This patch adds the param argument to the function parameter of the call-back probe_channel. This parameter is needed to configure the channels of an attached device. Signed-off-by: Christian Gromm --- v2: v3: drivers/staging/most/cdev/cdev.c | 2 +- drivers/staging/most/core.c| 6

[PATCH v3 13/14] staging: most: configfs: rename config attributes

This patch introduces attribute names that are more self explaining. Signed-off-by: Christian Gromm --- v2: - follow-up adaptions due to changes introduced w/ [PATCH v2 01/14] v3: drivers/staging/most/configfs.c | 97 + 1 file changed, 49

[PATCH v3 08/14] staging: most: usb: remove prefix from description tag

This patch cuts off the usb_device prefix of the description string. It is not needed, as the interface type is already available with the interface attribute of a channel. Signed-off-by: Christian Gromm --- v2: v3: drivers/staging/most/usb/usb.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v3 06/14] staging: most: core: make sysfs attributes read-only

This patch changes the access flags of the channel attributes to read-only. This is needed, because configuration is done via configfs. Signed-off-by: Christian Gromm --- v2: v3: drivers/staging/most/core.c | 122 +++- 1 file changed, 7 insertions(+),

[PATCH v3 07/14] staging: most: core: use device description as name

This patch uses the device description to clearly identity a device attached to the bus. It is needed as the currently useed mdevX notation is not sufficiant in case more than one network interface controller is being used at the same time. Signed-off-by: Christian Gromm --- v2: v3:

[PATCH v3 03/14] staging: most: core: add configfs interface functions

This patch adds the core's interface to configfs file. Signed-off-by: Christian Gromm --- v2: v3: drivers/staging/most/core.c | 142 drivers/staging/most/core.h | 16 - 2 files changed, 157 insertions(+), 1 deletion(-) diff --git

[PATCH v3 01/14] staging: most: add new file configfs.c

This patch adds the file configfs.c to the driver directory. The file registers the necessary subsystems with configfs in order to move the driver configuration from sysfs to configfs. Signed-off-by: Christian Gromm --- v2: Reported-by: Dan Carpenter - remove unnecessary variable init

[PATCH v3 05/14] staging: most: enable configfs support

This patch enables the configfs functionality of the driver by registering the configfs subsystems and compiling the configfs part of the sources. Signed-off-by: Christian Gromm --- v2: - remove call to configfs_exit function v3: drivers/staging/most/Makefile | 1 +

[PATCH v3 09/14] staging: most: core: remove attribute add_link

This patch removes the driver attribute add_link. It is not needed, because the link management is now done via configfs. Signed-off-by: Christian Gromm --- v2: v3: drivers/staging/most/core.c | 61 - 1 file changed, 61 deletions(-) diff --git

[PATCH v3 11/14] staging: most: configfs: make create attributes write-only

Reading the create attribute that triggers the creation of a link to a certain channel is not necessary. Hence, it is being removed. Signed-off-by: Christian Gromm --- v2: v3: drivers/staging/most/configfs.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git

[PATCH v3 00/14] staging: most: switch to configfs

This patch set makes the driver provide its configuration interface via configfs. The configuration interface is being switched to simplify the process of setting up the driver and to introduce the new feature of speculative configuration. v2: v3: Christian Gromm (14): staging: most: add new

[PATCH v3 12/14] staging: most: configfs: add code for link removal

This patch adds code that cleans up established links whenever the destroy attribute is set or if the config_item (directory) is being removed. Signed-off-by: Christian Gromm --- v2: - follow-up adaptions due to changes introduced w/ [PATCH v2 01/14] v3: drivers/staging/most/configfs.c

[PATCH v3 04/14] staging: most: sound: introduce new sound adapter management

This patch adapts the sound card management to the configfs changes. Signed-off-by: Christian Gromm --- v2: v3: Reported-by: Dan Carpenter - return 0 in function audio_create_sound_card drivers/staging/most/sound/sound.c | 41 +- 1 file changed, 23

Re: [PATCH] mips: ralink: allow to choose function which belongs with multiple groups

On 31/03/2019 09:31, NOGUCHI Hiroshi wrote: This allows the signals which can be assigned from multiple GPIO pins to be really assigned as expected. That one case is "refclk" signal in MT76x8. It was forcibily assigned to the pin matched by signal name at first. Eventually it always appears as

Re: [PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.

On 4/1/2019 4:23 AM, Will Cunningham wrote: Removed unnecessary parentheses.` Remove the extra character at the end. Fix the above thing then you can take. Reviewed-by: Mukesh Ojha Cheers, -Mukesh Signed-off-by: Will Cunningham --- drivers/staging/comedi/drivers/pcl818.c | 8

Re: [PATCH] staging: erofs: keep corrupted fs from crashing kernel in erofs_readdir()

Hi, On 2019/3/30 21:45, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 3aa8ec716e52 staging: erofs: add directory operations. > > The bot has tested the following trees: v5.0.5, v4.19.32. > >

Re: [PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.

On Sun, Mar 31, 2019 at 06:53:36PM -0400, Will Cunningham wrote: > Removed unnecessary parentheses.` Odd trailing character :( > > Signed-off-by: Will Cunningham > --- > drivers/staging/comedi/drivers/pcl818.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git