Re: [PATCH] staging: kpc2000: kpc_spi: Fix build error for {read,write}q

On Thu, May 02, 2019 at 07:06:30PM -0700, Nathan Chancellor wrote: > drivers/staging/kpc2000/kpc_spi/spi_driver.c:158:11: error: implicit > declaration of function 'readq' [-Werror,-Wimplicit-function-declaration] > drivers/staging/kpc2000/kpc_spi/spi_driver.c:167:5: error: implicit > declaration o

[PATCH] staging: kpc2000: kpc_spi: Fix build error for {read,write}q

drivers/staging/kpc2000/kpc_spi/spi_driver.c:158:11: error: implicit declaration of function 'readq' [-Werror,-Wimplicit-function-declaration] drivers/staging/kpc2000/kpc_spi/spi_driver.c:167:5: error: implicit declaration of function 'writeq' [-Werror,-Wimplicit-function-declaration] Same as comm

[staging:staging-testing 430/495] drivers/staging//kpc2000/kpc_spi/spi_driver.c:167:5: error: implicit declaration of function 'writeq'; did you mean 'writeb'?

Hi Greg, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: a4ecdcbfc4dd91417706e4644e4e93de43b34bea commit: 7dc7967fc39af81191558f63eeaf3d2b83899b1c [430/495] staging: kpc2000: add initial set of Daktronics d

Hello Dearest One

Hello Dearest One I am writing you this message with tears and sorrow and I know this mail may come to you as a surprise, I am Stephanie Leo. The only daughter. My father was a very wealthy cocoa merchant in Abidjan Ivory Coast (Cote Ivoire) my father was poisoned to death by his business as

Re: [PATCH] staging: most: cdev: fix chrdev_region leak in mod_exit

On Wed, Apr 24, 2019 at 09:23:43PM +0200, Eugeniu Rosca wrote: > From: Suresh Udipi > > It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0 > commit [1] missed to fix the memory leak in mod_exit function. > > Do it now. > > [0] aba258b7310167 ("staging: most: cdev: fix chrdev_region le

Re: [PATCH v3 5/8] media: staging/imx: Remove capture_device_set_format

On 5/2/19 3:01 AM, Rui Miguel Silva wrote: Hi Steve, Thanks for v3 with bisect fixed. On Tue 30 Apr 2019 at 23:50, Steve Longerbeam wrote: Don't propagate the source pad format to the connected capture device. It's now the responsibility of userspace to call VIDIOC_S_FMT on the capture devic

Re: [PATCH 2/2] media: imx7-media-csi: add i.MX6UL support

Hi Sebastien, Many thanks for this patch. Please note that there is another series on top of this code [0], that turns my patch that you mention below obsolete, maybe you may want to rebase on top of that. and also a different patch from me [1]. [0]: https://lore.kernel.org/lkml/20190430225018.3

Re: [PATCH 2/2] media: imx7-media-csi: add i.MX6UL support

Hi Sébastien, On Tue, Apr 30, 2019 at 4:49 AM Sébastien Szymanski wrote: > +static const struct of_device_id imx7_csi_of_match[] = { > + { .compatible = "fsl,imx7-csi", .data = (void *)IMX7 }, > + { .compatible = "fsl,imx6ul-csi", .data = (void *)IMX6UL }, Please add the new "fsl,im

[PATCH] staging: wlan-ng: Fix improper SPDX comment style

The SPDX license identifier should have the form // SPDX-License-Identifier: for a .c source file. File hfa384x_usb.c has instead the form /* SPDX-License-Identifier: */ which is the form for C header files. Hence this patch corrects it. Issue identified by checkpatch. Signed-off-by: Himadri Pan

Re: [PATCH v3 5/8] media: staging/imx: Remove capture_device_set_format

Hi Steve, Thanks for v3 with bisect fixed. On Tue 30 Apr 2019 at 23:50, Steve Longerbeam wrote: > Don't propagate the source pad format to the connected capture device. > It's now the responsibility of userspace to call VIDIOC_S_FMT on the > capture device to ensure the capture format and compose

Re: [PATCH] staging: most: cdev: fix chrdev_region leak in mod_exit

On Mi, 2019-04-24 at 21:23 +0200, Eugeniu Rosca wrote: > External E-Mail > > > From: Suresh Udipi > > It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0 > commit [1] missed to fix the memory leak in mod_exit function. > > Do it now. > > [0] aba258b7310167 ("staging: most: cdev: fix