Re: [PATCH 5/5] Staging: rtl8192u: ieee80211: Use !x in place of NULL comparison

On Tue, May 14, 2019 at 01:11:21AM +0530, Puranjay Mohan wrote: > @@ -2856,7 +2856,7 @@ static int ieee80211_wpa_set_encryption(struct > ieee80211_device *ieee, > goto done; > } > > - if (*crypt == NULL || (*crypt)->ops != ops) { > + if (!(*crypt) || (*crypt)->ops !=

Re: [PATCH 3/5] Staging: rtl8192u: ieee80211: Fix coding style errors

On Tue, May 14, 2019 at 01:09:50AM +0530, Puranjay Mohan wrote: > @@ -746,12 +730,12 @@ int ieee80211_xmit(struct sk_buff *skb, struct > net_device *dev) > txb->payload_size = __cpu_to_le16(bytes); > > //if (ieee->current_network.QoS_Enable) > - if(qos_act

Re: [PATCH 1/5] Staging: rtl8192u: ieee80211: Fix coding style warning

On Tue, May 14, 2019 at 01:08:11AM +0530, Puranjay Mohan wrote: > Remove braces around a single if statement to fix following > checkpatch.pl warning. > WARNING: braces {} are not necessary for single statement blocks > > Signed-off-by: Puranjay Mohan > --- > drivers/staging/rtl8192u/ieee80211/i

[PATCH] Staging: rtl8723bs: os_dep: Fix if-else coding style issues

Fix placement of opening brace in if-else statement to correct coding style issue. Signed-off-by: Puranjay Mohan --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/d

[PATCH 5/5] Staging: rtl8192u: ieee80211: Use !x in place of NULL comparison

Fix comparison to NULL, chang to !x operation. Issue found using checkpatch.pl Signed-off-by: Puranjay Mohan --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac

[PATCH 4/5] Staging: rtl8192u: ieee80211: Add spaces around '&&' operator

Fix coding style errors by adding spaces around '&&' operators. Signed-off-by: Puranjay Mohan --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/stag

[PATCH 3/5] Staging: rtl8192u: ieee80211: Fix coding style errors

Fix coding style errors related to braces for if-else statements. Signed-off-by: Puranjay Mohan --- .../staging/rtl8192u/ieee80211/ieee80211_tx.c | 60 +++ 1 file changed, 22 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers

[PATCH 2/5] Staging: rtl8192u: ieee80211: Fix spelling mistake

Correct spelling mistakes at two places in comments. Signed-off-by: Puranjay Mohan --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211

[PATCH 1/5] Staging: rtl8192u: ieee80211: Fix coding style warning

Remove braces around a single if statement to fix following checkpatch.pl warning. WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Puranjay Mohan --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

On Fri, May 10, 2019 at 05:10:25PM +0200, Oleg Nesterov wrote: > I am starting to think I am ;) > > If you have task1 != task2 this code > > task_lock(task1); > task_lock(task2); > > should trigger print_deadlock_bug(), task1->alloc_lock and task2->alloc_lock > are > the "same" lock

[PATCH v4 5/8] Staging: kpc2000: kpc_dma: Resolve checkpath errors Macros in paranthesis & trailing statements on next line.

This patch fixes below errors reported by checkpath ERROR: Macros with complex values should be enclosed in parentheses CHECK: Prefer using the BIT macro ERROR: trailing statements should be on next line ERROR: trailing statements should be on next line Signed-off-by: Vandana BN --- v2 - split ch

[PATCH v4 7/8] Staging: kpc2000: kpc_dma: Resolve warning to use __func__ insted of funtion name reported by checkpatch.

This patch resolves warnings to use __func__ insted of funtion name. WARNING: Prefer using '"%s...", __func__' to using 'setup_dma_engine', this function's name, in a string Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit message, subject line v4 - edit comm

[PATCH v4 8/8] Staging: kpc2000: kpc_dma: Resolve cast warning and use const for file_operation

This Patch resolves unnecessary cast warning and const file_operations reported by checkpath.pl WARNING: unnecessary cast may hide bugs WARNING: struct file_operations should normally be const Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit message, subject l

[PATCH v4 6/8] Staging: kpc2000: kpc_dma: Resolve warning Missing blank line after declarations & labels not to be indented.

This patch resloves below warnings reported by checkpath in kpc_dma WARNING: Missing a blank line after declarations WARNING: labels should not be indented CHECK: Please don't use multiple blank lines CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: Vanda

[PATCH v4 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{', '!' and open paranthesis '('.

This patch resolves below errors reported by checkpath ERROR: space required before the open brace '{' ERROR: space prohibited after that '!' (ctx:BxW) ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit mes

[PATCH v4 4/8] Staging: kpc2000: kpc_dma: Resolve code indent and trailing statements on next line errors reported by checkpatch.

This patch fixes code indentaion error reported by checkpath ERROR: switch and case should be at the same indent ERROR: trailing statements should be on next line Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit message, subject line v4 - edit commit message

[PATCH v4 1/8] Staging: kpc2000: kpc_dma: Resolve trailing whitespace error reported by checkpatch

Resolve trailing whitespace error from checkpatch.pl ERROR: trailing whitespace Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit message, subject line v4 - edit commit message drivers/staging/kpc2000/kpc_dma/dma.c | 86 ++--- drivers/staging

[PATCH v4 2/8] Staging: kpc2000: kpc_dma: Resolve space errors around pointers and function declarations reported by checkpatch.

This patch resolves below errors reported by checkpatch ERROR: "(foo*)" should be "(foo *)" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo __init bar" should be "foo __init bar" ERROR: "foo __exit bar" should be "foo __exit bar" Signed-off-by: Vandana BN --- v2 - split changes to multiple

Re: [PATCH v3 1/8] Staging: kpc2000: kpc_dma: Resolve trailing whitespace error reported by checkpatch

oh ok.. thanks i will correct it. On 13/05/19 4:19 PM, Dan Carpenter wrote: > The Signed off by has to be before the first --- cut off line. > Everything after the cut off is removed from the commit message. ___ devel mailing list de...@linuxdriverprojec

Re: [PATCH] Staging: vc04_services: Fix a couple error codes

On 13.05.19 13:07, Dan Carpenter wrote: > These are accidentally returning positive EINVAL instead of negative > -EINVAL. Some of the callers treat positive values as success. > > Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera > driver.") > Signed-off-by: Dan Carpenter

[Patch v2] staging: rtl8723bs: os_dep: Remove Unneeded variable ret

fix below issue reported by coccicheck drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2685:5-8: Unneeded variable: "ret". Return "0" on line 3266 Signed-off-by: Hariprasad Kelam Changes in v2: - make subject line more clean --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 +-- 1 f

[PATCH] Staging: vc04_services: Fix a couple error codes

These are accidentally returning positive EINVAL instead of negative -EINVAL. Some of the callers treat positive values as success. Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.") Signed-off-by: Dan Carpenter --- drivers/staging/vc04_services/bcm2835-camera/c

Re: [PATCH v3 1/8] Staging: kpc2000: kpc_dma: Resolve trailing whitespace error reported by checkpatch

On Mon, May 13, 2019 at 03:56:15PM +0530, Vandana BN wrote: > Resolve trailing whitespace error from checkpatch.pl > ERROR: trailing whitespace > --- > v2-split changes to multiple patches > v3 - edit commit message > --- > > Signed-off-by: Vandana BN > --- The Signed off by has to be before the

Re: [PATCH v2 2/8] Staging: kpc2000: kpc_dma: Resolve coding style errors reported by checkpatch.

On 13/05/19 2:12 PM, Greg KH wrote: > On Mon, May 13, 2019 at 05:09:54AM +0530, Vandana BN wrote: >> This patch resolves below errors reported by checkpatch >> ERROR: "(foo*)" should be "(foo *)" >> ERROR: "foo * bar" should be "foo *bar" >> ERROR: "foo __init bar" should be "foo __init bar" >>

Re: [PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret

Please "drivers" out of the subject line. We know it's drivers, so that doesn't add any information. The "staging: " bit tells you which git tree this path is in, and the "rtl8723bs: " tells you which driver it is. regards, dan carpenter ___ devel mai

[PATCH v3 8/8] Staging: kpc2000: kpc_dma: Resolve cast warning and use const for file_operation

This Patch resolves unnecessary cast warning and const file_operations reported by checkpath.pl WARNING: unnecessary cast may hide bugs WARNING: struct file_operations should normally be const --- v2 - split changes to multiple patches v3 - edit commit message --- Signed-off-by: Vandana BN --- d

[PATCH v3 4/8] Staging: kpc2000: kpc_dma: Resolve code indent and trailing statements on next line errors reported by checkpatch.

This patch fixes code indentaion error reported by checkpath ERROR: switch and case should be at the same indent ERROR: trailing statements should be on next line --- v2 - split changes to multiple patches v3 - edit commit message --- Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma

[PATCH v3 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{', '!' and open paranthesis '('.

This patch resolves below errors reported by checkpath ERROR: space required before the open brace '{' ERROR: space prohibited after that '!' (ctx:BxW) ERROR: space prohibited after that open parenthesis '(' --- v2 - split changes to multiple patches v3 - edit commit message --- Signed-off-by: Van

[PATCH v3 7/8] Staging: kpc2000: kpc_dma: Resolve warning to use __func__ insted of funtion name reported by checkpatch.

This patch resolves warnings to use __func__ insted of funtion name. WARNING: Prefer using '"%s...", __func__' to using 'setup_dma_engine', this function's name, in a string --- v2 - split changes to multiple patches v3 - edit commit message --- Signed-off-by: Vandana BN --- drivers/staging/kpc

[PATCH v3 2/8] Staging: kpc2000: kpc_dma: Resolve space errors around pointers and function declarations reported by checkpatch.

This patch resolves below errors reported by checkpatch ERROR: "(foo*)" should be "(foo *)" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo __init bar" should be "foo __init bar" ERROR: "foo __exit bar" should be "foo __exit bar" --- v2 - split changes to multiple patches v3 - edit commit mes

[PATCH v3 6/8] Staging: kpc2000: kpc_dma: Resolve warning Missing blank line after declarations & labels not to be indented.

This patch resloves below warnings reported by checkpath in kpc_dma WARNING: Missing a blank line after declarations WARNING: labels should not be indented CHECK: Please don't use multiple blank lines CHECK: Please use a blank line after function/struct/union/enum declarations --- v2 - split change

[PATCH v3 5/8] Staging: kpc2000: kpc_dma: Resolve checkpath errors Macros in paranthesis & trailing statements on next line.

This patch fixes below errors reported by checkpath ERROR: Macros with complex values should be enclosed in parentheses CHECK: Prefer using the BIT macro ERROR: trailing statements should be on next line ERROR: trailing statements should be on next line --- v2 - split changes to multiple patches v3

[PATCH v3 1/8] Staging: kpc2000: kpc_dma: Resolve trailing whitespace error reported by checkpatch

Resolve trailing whitespace error from checkpatch.pl ERROR: trailing whitespace --- v2-split changes to multiple patches v3 - edit commit message --- Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/dma.c | 86 ++--- drivers/staging/kpc2000/kpc_dma/fileops.c | 1

Re: [PATCH v2] kpc_i2c: Remove unused file

On Thu, May 09, 2019 at 02:47:50PM +, Matt Sickler wrote: > >-Original Message- > >From: Dan Carpenter > > > >Add Staging: to the subject. > > Added to my notes so I don't forget it next time. > > >[PATCH v2] Staging: kpc_i2c: Remove unused file fileops.c > > > >On Thu, May 09, 2019

Re: [PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret

On Sun, May 12, 2019 at 05:02:45PM +0530, Hariprasad Kelam wrote: > fix below issue reported by coccicheck > > drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2685:5-8: Unneeded > variable: "ret". Return "0" on line 3266 > > Signed-off-by: Hariprasad Kelam > --- > drivers/staging/rtl8723bs/os_de

Re: [PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator to previous line.

On Sun, May 05, 2019 at 06:52:53PM +0530, Vatsala Narang wrote: > Move logical operator to previous line to get rid of checkpatch warning. > > Signed-off-by: Vatsala Narang > --- > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > di

Re: [PATCH] staging: rtl8723bs: core fix warning Comparison to bool

On Sun, May 12, 2019 at 05:54:49PM +0530, Hariprasad Kelam wrote: > fix below issue reported by coccicheck > > drivers/staging/rtl8723bs/core/rtw_mlme.c:1675:6-10: WARNING: Comparison > to bool > > Signed-off-by: Hariprasad Kelam > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- > 1 fil

Re: [PATCH v2 2/8] Staging: kpc2000: kpc_dma: Resolve coding style errors reported by checkpatch.

On Mon, May 13, 2019 at 05:09:54AM +0530, Vandana BN wrote: > This patch resolves below errors reported by checkpatch > ERROR: "(foo*)" should be "(foo *)" > ERROR: "foo * bar" should be "foo *bar" > ERROR: "foo __init bar" should be "foo __init bar" > ERROR: "foo __exit bar" should be "foo __exi

Re: [PATCH v3] drivers: staging : wlan-ng : collect return status without variable

Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH v2 3/7] lib/hexdump.c: Optionally suppress lines of repeated bytes

> -Original Message- > From: Geert Uytterhoeven > Sent: Monday, 13 May 2019 5:01 PM > To: Alastair D'Silva > Cc: alast...@d-silva.org; Jani Nikula ; Joonas > Lahtinen ; Rodrigo Vivi > ; David Airlie ; Daniel Vetter > ; Dan Carpenter ; Karsten > Keil ; Jassi Brar ; Tom > Lendacky ; David S

Re: [PATCH v2 3/7] lib/hexdump.c: Optionally suppress lines of repeated bytes

Hi Alastair, Thanks for your patch! On Wed, May 8, 2019 at 9:04 AM Alastair D'Silva wrote: > From: Alastair D'Silva > > Some buffers may only be partially filled with useful data, while the rest > is padded (typically with 0x00 or 0xff). > > This patch introduces a flag to allow the supression

Re: [PATCH 03/16] lib,treewide: add new match_string() helper/macro

On Fri, 2019-05-10 at 17:34 +0300, andriy.shevche...@linux.intel.com wrote: > [External] > > > On Fri, May 10, 2019 at 09:15:27AM +, Ardelean, Alexandru wrote: > > On Wed, 2019-05-08 at 16:22 +0300, Alexandru Ardelean wrote: > > > On Wed, 2019-05-08 at 15:18 +0200, Greg KH wrote: > > > > On W