Re: BUG: Staging: fbtft: Switch to the gpio descriptor interface

2019-07-10 Thread Nishad Kamdar
On Wed, Jul 10, 2019 at 04:31:09PM +0800, Phil Reid wrote: > G'day Nishad, > > I'm just wondering if the commit > c440eee1a7a1d0f "Staging: fbtft: Switch to the gpio descriptor interface" > was tested on anything. > > I've had to apply the following patch to get my display functioning again. >

[PATCH] staging: wlan-ng: use "%*pE" for serial number

2019-07-10 Thread J. Bruce Fields
From: "J. Bruce Fields" Almost every user of "%*pE" in the kernel uses just bare "%*pE". This is the only user of "%pEhp". I can't see why it's needed. Signed-off-by: J. Bruce Fields --- drivers/staging/wlan-ng/prism2sta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] rtl8192*: display ESSIDs using %pE

2019-07-10 Thread J. Bruce Fields
From: "J. Bruce Fields" Everywhere else in the kernel ESSIDs are printed using %pE, and I can't see why there should be an exception here. Signed-off-by: J. Bruce Fields --- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 +- 2 files

Re: [PATCH] Staging: rtl8723bs: hal: rtl8723bs_recv.c: Fix code style

2019-07-10 Thread Joe Perches
On Mon, 2019-07-08 at 12:56 +0300, Fatih ALTINPINAR wrote: > Fixed a coding stlye issue. Removed braces from a single statement if > block. > > Signed-off-by: Fatih ALTINPINAR > --- > drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >

[PATCH] staging: gasket: apex: fix copy-paste typo

2019-07-10 Thread Ivan Bornyakov
In sysfs_show() case-branches ATTR_KERNEL_HIB_PAGE_TABLE_SIZE and ATTR_KERNEL_HIB_SIMPLE_PAGE_TABLE_SIZE do the same. It looks like copy-paste mistake. Signed-off-by: Ivan Bornyakov --- drivers/staging/gasket/apex_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] staging: greybus: add logging statement when kfifo_alloc fails

2019-07-10 Thread Keyur Patel
On Wed, Jul 10, 2019 at 06:35:38PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 10, 2019 at 08:20:17AM -0400, Keyur Patel wrote: > > Added missing logging statement when kfifo_alloc fails, to improve > > debugging. > > > > Signed-off-by: Keyur Patel > > --- > > drivers/staging/greybus/uart.c

Re: [PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-10 Thread Joe Perches
On Wed, 2019-07-10 at 08:45 -0700, Joe Perches wrote: > On Wed, 2019-07-10 at 10:43 +0100, Russell King - ARM Linux admin wrote: > > On Wed, Jul 10, 2019 at 11:17:31AM +0200, Johannes Berg wrote: > > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > > These GENMASK uses are inverted

Re: [PATCH] staging: greybus: add logging statement when kfifo_alloc fails

2019-07-10 Thread Greg Kroah-Hartman
On Wed, Jul 10, 2019 at 08:20:17AM -0400, Keyur Patel wrote: > Added missing logging statement when kfifo_alloc fails, to improve > debugging. > > Signed-off-by: Keyur Patel > --- > drivers/staging/greybus/uart.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

[PATCH] staging: greybus: add logging statement when kfifo_alloc fails

2019-07-10 Thread Keyur Patel
Added missing logging statement when kfifo_alloc fails, to improve debugging. Signed-off-by: Keyur Patel --- drivers/staging/greybus/uart.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index

Re: [PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-10 Thread Joe Perches
On Wed, 2019-07-10 at 10:43 +0100, Russell King - ARM Linux admin wrote: > On Wed, Jul 10, 2019 at 11:17:31AM +0200, Johannes Berg wrote: > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > These GENMASK uses are inverted argument order and the > > > actual masks produced are

[GIT PULL] Staging/IIO driver patches for 5.3-rc1

2019-07-10 Thread Greg KH
The following changes since commit 4b972a01a7da614b4796475f933094751a295a2f: Linux 5.2-rc6 (2019-06-22 16:01:36 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.3-rc1 for you to fetch changes up to

Re: [PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-10 Thread Russell King - ARM Linux admin
On Wed, Jul 10, 2019 at 11:17:31AM +0200, Johannes Berg wrote: > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > These GENMASK uses are inverted argument order and the > > actual masks produced are incorrect. Fix them. > > > > Add checkpatch tests to help avoid more misuses too. > > >

Re: BUG: Staging: fbtft: Switch to the gpio descriptor interface

2019-07-10 Thread Nicolas Saenz Julienne
On Wed, 2019-07-10 at 17:27 +0800, Phil Reid wrote: > On 10/07/2019 17:05, Nicolas Saenz Julienne wrote: > > On Wed, 2019-07-10 at 16:31 +0800, Phil Reid wrote: > > > G'day Nishad, > > > > > > I'm just wondering if the commit > > > c440eee1a7a1d0f "Staging: fbtft: Switch to the gpio descriptor

Re: BUG: Staging: fbtft: Switch to the gpio descriptor interface

2019-07-10 Thread Phil Reid
On 10/07/2019 17:05, Nicolas Saenz Julienne wrote: On Wed, 2019-07-10 at 16:31 +0800, Phil Reid wrote: G'day Nishad, I'm just wondering if the commit c440eee1a7a1d0f "Staging: fbtft: Switch to the gpio descriptor interface" was tested on anything. I've had to apply the following patch to get

Re: [PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-10 Thread Johannes Berg
On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > These GENMASK uses are inverted argument order and the > actual masks produced are incorrect. Fix them. > > Add checkpatch tests to help avoid more misuses too. > > Joe Perches (12): > checkpatch: Add GENMASK tests IMHO this doesn't

Re: BUG: Staging: fbtft: Switch to the gpio descriptor interface

2019-07-10 Thread Nicolas Saenz Julienne
On Wed, 2019-07-10 at 16:31 +0800, Phil Reid wrote: > G'day Nishad, > > I'm just wondering if the commit > c440eee1a7a1d0f "Staging: fbtft: Switch to the gpio descriptor interface" > was tested on anything. > > I've had to apply the following patch to get my display functioning again. > > in

BUG: Staging: fbtft: Switch to the gpio descriptor interface

2019-07-10 Thread Phil Reid
G'day Nishad, I'm just wondering if the commit c440eee1a7a1d0f "Staging: fbtft: Switch to the gpio descriptor interface" was tested on anything. I've had to apply the following patch to get my display functioning again. in particular the devm_gpiod_get_index using dev->driver->name for the

Re: [PATCH 11/12] staging: media: cedrus: Fix misuse of GENMASK macro

2019-07-10 Thread Paul Kocialkowski
Hi, On Tue 09 Jul 19, 22:04, Joe Perches wrote: > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches Good catch, thanks! Acked-by: Paul Kocialkowski Cheers, Paul > --- > drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 2 +- > 1 file changed, 1

Re: [PATCH 4/5] staging: mt7621-dts: add dt nodes for mt7621-pll

2019-07-10 Thread Chuanhong Guo
On Wed, Jul 10, 2019 at 2:22 AM Chuanhong Guo wrote: > > This commit adds device-tree node for mt7621-pll and use its clock > accordingly. > > Signed-off-by: Chuanhong Guo Oops. Please ignore this single patch for now. I forgot to drop cpuclock node in drivers/staging/mt7621-dts/gbpc1.dts I'll