Fixed check patch warnings: converting all 'unsigned' to 'unsigned int'
Signed-off-by: Pratik Shinde
---
drivers/staging/erofs/internal.h | 7 ---
drivers/staging/erofs/unzip_pagevec.h | 11 ++-
drivers/staging/erofs/unzip_vle.h | 8
drivers/staging/erofs/xattr.h
On 7/14/19 1:08 PM, Bharath Vedartham wrote:
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 4ef62a4..b4a4549 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -2694,10 +2694,9 @@ static int io_sqe_buffer_register(struct io_ring_ctx
> *ctx, void __user *arg,
>*
Hi Pratik,
On 2019/7/15 3:30, Pratik Shinde wrote:
> Fixing checkpath warnings : converting all 'unsigned' to 'unsigned int'
>
> Signed-off-by: Pratik Shinde
> ---
> drivers/staging/erofs/internal.h | 6 +++---
> drivers/staging/erofs/unzip_pagevec.h | 10 +-
>
可开票
ⓥⓧ:ⓢⓢｃｃ5⑥87
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Christian Luciano Moreno
Fix 'CHECK: Alignment should match open parenthesis' reported by
checkpatch.
Signed-off-by: Christian Luciano Moreno
---
drivers/staging/rtl8712/xmit_osdep.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
From: Christian Luciano Moreno
Fix 'CHECK: Alignment should match open parenthesis' reported by checkpatch.
Signed-off-by: Christian Luciano Moreno
---
drivers/staging/rtl8712/usb_ops.h | 9 +
drivers/staging/rtl8712/usb_ops_linux.c | 13 +++--
2 files changed, 12
From: Christian Luciano Moreno
Fix 'CHECK: Alignment should match open parenthesis' reported by checkpatch.
Signed-off-by: Christian Luciano Moreno
---
drivers/staging/rtl8712/usb_ops.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git
On 7/14/19 12:08 PM, Bharath Vedartham wrote:
> This patch converts all call sites of get_user_pages
> to use put_user_page*() instead of put_page*() functions to
> release reference to gup pinned pages.
Hi Bharath,
Thanks for jumping in to help, and welcome to the party!
You've caught everyone
Hi Pavel,
On 2019/7/14 18:49, Pavel Machek Wrote:
> On Thu 2019-07-11 22:57:31, Gao Xiang wrote:
>> Changelog from v1:
>> o resend the whole filesystem into a patchset suggested by Greg;
>> o code is more cleaner, especially for decompression frontend.
>>
>> --8<--
>>
>> Hi,
>>
>> EROFS
Fixing checkpath warnings : converting all 'unsigned' to 'unsigned int'
Signed-off-by: Pratik Shinde
---
drivers/staging/erofs/internal.h | 6 +++---
drivers/staging/erofs/unzip_pagevec.h | 10 +-
drivers/staging/erofs/unzip_vle.h | 8
drivers/staging/erofs/xattr.h
This patch converts all call sites of get_user_pages
to use put_user_page*() instead of put_page*() functions to
release reference to gup pinned pages.
This is a bunch of trivial conversions which is a part of an effort
by John Hubbard to solve issues with gup pinned pages and
filesystem
On Thu 2019-07-11 22:57:31, Gao Xiang wrote:
> Changelog from v1:
> o resend the whole filesystem into a patchset suggested by Greg;
> o code is more cleaner, especially for decompression frontend.
>
> --8<--
>
> Hi,
>
> EROFS file system has been in Linux-staging for about a year.
>
> The kfifo_alloc() failure generates enough information and doesn't need
> to be accompanied by another error statement.
I am curious how the acceptance will evolve for this variant of
another different commit description according to a known software
transformation pattern.
> ---
> Changes in
As per TODO ,remove code valid only for 5 GHz(channel > 14).
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index
As per TODO ,remove code valid only for 5 GHz(channel > 14).
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
The kfifo_alloc() failure generates enough information and doesn't need
to be accompanied by another error statement.
Signed-off-by: Keyur Patel
---
Changes in v5:
- change subject line
- simplify commit description
- fix checkpatch warning
- removed braces around if
As per TODO ,remove code valid only for 5 GHz(channel > 14).
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/hal_com.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c
b/drivers/staging/rtl8723bs/hal/hal_com.c
> I think commit message is clear enough to understand why this is needed.
There are differences to consider between the involved software developers.
> You can send me what should I include in commit description
The clarification should be continued with the number “v5”
in the message
I think commit message is clear enough to understand why this is needed.
You can send me what should I include in commit description and I will
add and send it again. Otherwise, Greg can comment on this.
Thanks.
On Sun, Jul 14, 2019 at 06:55:30PM +0200, Markus Elfring wrote:
> > ---
> > Changes
> ---
> Changes in v4:
I find this change log still incomplete.
You have chosen to adjust the commit message once more.
(Some contributors might be also not satisfied with this variant.)
Such a change requires to increase the corresponding patch version number,
doesn't it?
Regards,
Markus
This error message for a failed memory allocation is redundant as
kfifo_alloc just calls kmalloc_array without the __GFP_NOWARN flag,
already does a dump_stack().
Signed-off-by: Keyur Patel
---
Changes in v4:
- change subject line
- improve commit description
- fix checkpatch warning
On Fri, 28 Jun 2019 16:49:22 -0300
Bárbara Fernandes wrote:
> Create list of compatible device ids to be matched with those stated in
> the device tree.
>
> Signed-off-by: Bárbara Fernandes
> Signed-off-by: Wilson Sales
> Co-developed by: Wilson Sales
> ---
Patch is fine and applied to the
> I didn't get you. I stiil need to update changelog
I would appreciate the completion of the listing for V2 till V4.
I guess that a message resend could be sufficient for these adjustments.
> and send more version
This could be another opportunity if you would like to improve
the commit
I didn't get you. I stiil need to update changelog and send more
version or not. If you say so, I can send one more.
Thnaks.
On Sun, Jul 14, 2019 at 05:23:34PM +0200, Markus Elfring wrote:
> > ---
> > Changes in v3:
>
> Thanks for your quick response.
>
> I find the change log incomplete (even
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> ---
> Changes in v3:
Thanks for your quick response.
I find the change log incomplete (even if corresponding information
can be determined also from public message archives).
Regards,
Markus
___
devel mailing list
de...@linuxdriverproject.org
This print statement is redundant as kfifo_alloc just calls kmalloc_array
without the __GFP_NOWARN flag, already does a dump_stack().
Signed-off-by: Keyur Patel
---
Changes in v3:
- fix checkpatch warning
drivers/staging/most/cdev/cdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
> This print statement is redundant as kfifo_alloc just calls kmalloc_array
> and without the __GFP_NOWARN flag, already does a dump_stack().
I suggest to omit the word “and” from this sentence.
Will any further wording adjustments become helpful for commit descriptions?
> Changes in v3:
> -
/commits/christianluciano-m-gmail-com/staging-rtl8712-Add-parenthesis-to-Macro-argument/20190714-103146
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin
29 matches
Mail list logo
