Re: [PATCH] staging: erofs: a few minor style fixes found using checkpatch

Hi Karen, On 2019/7/17 ??2:56, Karen Palacio wrote: > Hello, thanks for the fast reply.?? > > />NACK, all linux filesystems use Opt_xxx. EROFS should obey this practice. > /I wasn't aware of that convention, my apologies. > > Should I fix that, keep the other changes and resend as v2, or >

Re: [PATCH] v2: staging: erofs: fix typo

On Tue, Jul 16, 2019 at 06:16:23PM -0300, Karen Palacio wrote: > Fix typo in Kconfig > Signed-off-by: Karen Palacio I need a blank line before the signed-off-by line :( 3rd try? ___ devel mailing list de...@linuxdriverproject.org

[PATCH] v2: staging: erofs: fix typo

Fix typo in Kconfig Signed-off-by: Karen Palacio diff --git a/drivers/staging/erofs/Kconfig b/drivers/staging/erofs/Kconfig index d04b798..0dcefac 100644 --- a/drivers/staging/erofs/Kconfig +++ b/drivers/staging/erofs/Kconfig @@ -88,7 +88,7 @@ config EROFS_FS_IO_MAX_RETRIES If unsure,

[PATCH] staging: rtl8712: recv_linux.c: Align * on block comment

From: Christian L Moreno Block comments should align the * on each line. This warning was reported by checkpatch.pl Signed-off-by: Christian L Moreno --- drivers/staging/rtl8712/recv_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [staging:staging-testing 1/41] drivers/staging/isdn/hysdn/hysdn_defs.h:227:1: warning: "/*" within comment

On Tue, Jul 16, 2019 at 08:54:52PM +0800, kbuild test robot wrote: > tree: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: a8ee5f6cf86f02b87a0a27abff63ea933cca0bab > commit: b15e62615afd9ea7caf03126ad5d944fc5f5e371 [1/41] staging: isdn:

Re: [PATCH] staging: erofs: fix typo

On Tue, Jul 16, 2019 at 01:47:43PM -0300, Karen Palacio wrote: > Signed-off-by: Karen Palacio > --- > drivers/staging/erofs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I can not take patches without any changelog text, sorry. ___

Re: [PATCH] staging: kpc2000: whitespace and line length cleanup

On 7/16/19 1:36 AM, Greg Kroah-Hartman wrote: > On Mon, Jul 15, 2019 at 02:21:23PM -0700, john.hubb...@gmail.com wrote: >> From: John Hubbard ... >> drivers/staging/kpc2000/kpc2000_i2c.c | 189 +++-- >> drivers/staging/kpc2000/kpc2000_spi.c | 116 +- >>

Re: [PATCH] staging: erofs: a few minor style fixes found using checkpatch

On 2019/7/17 12:35, Karen Palacio wrote: > Fix camel case use in variable names, > Fix multiple assignments done in a single line, > Fix end of line containing '('. One type one patch... > > Signed-off-by: Karen Palacio > --- > drivers/staging/erofs/super.c | 55 >

[PATCH] staging: erofs: fix typo

Signed-off-by: Karen Palacio --- drivers/staging/erofs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/erofs/Kconfig b/drivers/staging/erofs/Kconfig index d04b798..0dcefac 100644 --- a/drivers/staging/erofs/Kconfig +++ b/drivers/staging/erofs/Kconfig

[PATCH] staging: erofs: a few minor style fixes found using checkpatch

Fix camel case use in variable names, Fix multiple assignments done in a single line, Fix end of line containing '('. Signed-off-by: Karen Palacio --- drivers/staging/erofs/super.c | 55 ++- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git

Re: [PATCH] staging: rtl8712: Add parenthesis to Macro argument

Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.2 next-20190716] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

if you agree

My name is Mr. Allen, I have a Business Proposal of Four million five hundred thousand united states dollars for you to handle with me from my bank. I will need you to assist me in executing this Business Allen aj4...@gmail.com ___ devel mailing

[staging:staging-testing 1/41] drivers/staging/isdn/hysdn/hysdn_defs.h:227:1: warning: "/*" within comment

tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: a8ee5f6cf86f02b87a0a27abff63ea933cca0bab commit: b15e62615afd9ea7caf03126ad5d944fc5f5e371 [1/41] staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared. config:

Re: [PATCH v2] staging: erofs: avoid opened loop codes

On 2019/7/16 17:44, Chao Yu wrote: > Use __GFP_NOFAIL to avoid opened loop codes in z_erofs_vle_unzip(). > > Signed-off-by: Chao Yu Reviewed-by: Gao Xiang Thanks, Gao Xiang ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

On Mon, Jul 15, 2019 at 03:01:43PM -0700, John Hubbard wrote: > On 7/15/19 2:47 PM, Matt Sickler wrote: > > It looks like Outlook is going to absolutely trash this email. Hopefully > > it comes through okay. > > > ... > >> > >> Because this is a common pattern, and because the code here doesn't

[PATCH v2] staging: erofs: avoid opened loop codes

Use __GFP_NOFAIL to avoid opened loop codes in z_erofs_vle_unzip(). Signed-off-by: Chao Yu --- v2: - change variable name from 'flags' to 'gfp_flags' to avoid common name. drivers/staging/erofs/unzip_vle.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [PATCH] staging: erofs: avoid opened loop codes

On 2019/7/16 17:27, Chao Yu wrote: > Hi Xiang, > > On 2019/7/16 17:12, Gao Xiang wrote: >> Hi Chao, >> >> On 2019/7/16 16:52, Chao Yu wrote: >>> Use __GFP_NOFAIL to avoid opened loop codes in z_erofs_vle_unzip(). >>> >>> Signed-off-by: Chao Yu >>> --- >>> drivers/staging/erofs/unzip_vle.c |

[PATCH v3] staging: erofs: support bmap

Add erofs_bmap() to support FIBMAP ioctl on flatmode inode. Reviewed-by: Gao Xiang Signed-off-by: Chao Yu --- v3: - use erofs_blk_t instead of unsigned int. - simply judgment condition. drivers/staging/erofs/data.c | 33 + 1 file changed, 33 insertions(+) diff

Re: [PATCH] staging: erofs: avoid opened loop codes

Hi Xiang, On 2019/7/16 17:12, Gao Xiang wrote: > Hi Chao, > > On 2019/7/16 16:52, Chao Yu wrote: >> Use __GFP_NOFAIL to avoid opened loop codes in z_erofs_vle_unzip(). >> >> Signed-off-by: Chao Yu >> --- >> drivers/staging/erofs/unzip_vle.c | 17 - >> 1 file changed, 8

Re: [PATCH v2] staging: erofs: support bmap

Hi Xiang, On 2019/7/16 17:01, Gao Xiang wrote: > Hi Chao, > > Cc lkml mailing list? Oh, no problem, let me update my default cc list. > > On 2019/7/16 16:46, Chao Yu wrote: >> Add erofs_bmap() to support FIBMAP ioctl on flatmode inode. >> >> Signed-off-by: Chao Yu >> --- >> v2: >> - support

Re: [PATCH] staging: erofs: avoid opened loop codes

Hi Chao, On 2019/7/16 16:52, Chao Yu wrote: > Use __GFP_NOFAIL to avoid opened loop codes in z_erofs_vle_unzip(). > > Signed-off-by: Chao Yu > --- > drivers/staging/erofs/unzip_vle.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git

Re: [PATCH] staging: erofs: support bmap

On 2019/7/16 15:37, Gao Xiang wrote: > > > On 2019/7/16 15:35, Chao Yu wrote: >> Hi Xiang, >> >> On 2019/7/16 15:19, Gao Xiang wrote: >>> Hi Chao, >>> >>> On 2019/7/16 15:05, Chao Yu wrote: Add erofs_bmap() to support FIBMAP ioctl on flatmode inode. Signed-off-by: Chao Yu

Re: [PATCH v2] staging: erofs: support bmap

Hi Chao, Cc lkml mailing list? On 2019/7/16 16:46, Chao Yu wrote: > Add erofs_bmap() to support FIBMAP ioctl on flatmode inode. > > Signed-off-by: Chao Yu > --- > v2: > - support mapping normal blocks for inline inode suggested by Xiang > - rebase to linux-next > drivers/staging/erofs/data.c

[PATCH] staging: erofs: avoid opened loop codes

Use __GFP_NOFAIL to avoid opened loop codes in z_erofs_vle_unzip(). Signed-off-by: Chao Yu --- drivers/staging/erofs/unzip_vle.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c index

[PATCH v2] staging: erofs: support bmap

Add erofs_bmap() to support FIBMAP ioctl on flatmode inode. Signed-off-by: Chao Yu --- v2: - support mapping normal blocks for inline inode suggested by Xiang - rebase to linux-next drivers/staging/erofs/data.c | 33 + 1 file changed, 33 insertions(+) diff --git

Re: [PATCH] staging: kpc2000: whitespace and line length cleanup

On Mon, Jul 15, 2019 at 02:21:23PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > This commit was created by running indent(1): > `indent -linux` > > ...and then applying some manual corrections and > cleanup afterward, to keep it sane. No functional changes > were made. > >

Re: [PATCH] staging: erofs: support bmap

On 2019/7/16 15:35, Chao Yu wrote: > Hi Xiang, > > On 2019/7/16 15:19, Gao Xiang wrote: >> Hi Chao, >> >> On 2019/7/16 15:05, Chao Yu wrote: >>> Add erofs_bmap() to support FIBMAP ioctl on flatmode inode. >>> >>> Signed-off-by: Chao Yu >>> --- >>> drivers/staging/erofs/data.c | 29

Re: [PATCH] staging: erofs: support bmap

Hi Xiang, On 2019/7/16 15:19, Gao Xiang wrote: > Hi Chao, > > On 2019/7/16 15:05, Chao Yu wrote: >> Add erofs_bmap() to support FIBMAP ioctl on flatmode inode. >> >> Signed-off-by: Chao Yu >> --- >> drivers/staging/erofs/data.c | 29 + >> 1 file changed, 29

Re: [PATCH] staging: erofs: support bmap

Hi Chao, On 2019/7/16 15:05, Chao Yu wrote: > Add erofs_bmap() to support FIBMAP ioctl on flatmode inode. > > Signed-off-by: Chao Yu > --- > drivers/staging/erofs/data.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/drivers/staging/erofs/data.c

[PATCH] staging: erofs: support bmap

Add erofs_bmap() to support FIBMAP ioctl on flatmode inode. Signed-off-by: Chao Yu --- drivers/staging/erofs/data.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c index fbce71403d87..03da57f04347

[PATCH] staging: mt7621-pci: Add of_node_put() before return

Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in two places. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta

[PATCH] staging: mt7621-pinctrl: Add of_node_put() before return

Each iteration of for_each_compatible_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Add an of_node_put before the return. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta ---