On Tue, 2019-08-20 at 20:18 -0400, Caitlyn wrote:
> Balanced braces to fix some checkpath warnings in inode.c and
> unzip_vle.c
[]
> diff --git a/drivers/staging/erofs/unzip_vle.c
> b/drivers/staging/erofs/unzip_vle.c
[]
> @@ -915,21 +915,21 @@ static int z_erofs_vle_unzip(struct super_block *sb,
As reported by erofs-utils fuzzer, 2 conditions
can happen in corrupted images, which can cause
unexpected behaviors.
- access the same pcluster one more time;
- access the tail end pcluster again, e.g.
_ access again (will trigger tail merging)
|
1 2 3 1 2
On Tue, Aug 20, 2019 at 11:43:06PM +, m...@ehuber.info wrote:
> From: Edmund Huber
>
> ---
> drivers/staging/comedi/drivers/ni_pcimio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I don't think you read all of the issues that my patchbot sent you.
Please re-read that and
On Tue, Aug 20, 2019 at 07:26:46PM -0700, Joe Perches wrote:
> On Tue, 2019-08-20 at 20:18 -0400, Caitlyn wrote:
> > Balanced braces to fix some checkpath warnings in inode.c and
> > unzip_vle.c
> []
> > diff --git a/drivers/staging/erofs/unzip_vle.c
> > b/drivers/staging/erofs/unzip_vle.c
> []
>
On Tue, Aug 20, 2019 at 08:18:19PM -0400, Caitlyn wrote:
> Indented some function arguments to fix checkpath warnings.
>
> Signed-off-by: Caitlyn
> ---
> drivers/staging/erofs/xattr.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Hi,
This is the friendly patch-bot of Greg
On Mon, Aug 19, 2019 at 10:57:42PM +0800, Chao Yu wrote:
> On 2019-8-19 18:34, Gao Xiang wrote:
> > As reported by erofs-utils fuzzer, currently, multiref
> > (ondisk deduplication) hasn't been supported for now,
> > we should forbid it properly.
> >
> > Fixes: 3883a79abd02 ("staging: erofs:
On 2019/8/20 16:46, Qu Wenruo wrote:
> [...]
>>
>> Yeah, it looks like we need searching more levels mapping to find the final
>> physical block address of inode/node/data in btrfs.
>>
>> IMO, in a little lazy way, we can reform and reuse existed function in
>> btrfs-progs which can find the
On 2019/8/21 9:48, Darrick J. Wong wrote:
> On Wed, Aug 21, 2019 at 09:34:02AM +0800, Chao Yu wrote:
>> On 2019/8/20 23:56, Theodore Y. Ts'o wrote:
>>> The reason why there needs to be at least some file system specific
>>> code for fuzz testing is because for efficiency's sake, you don't want
>>>
On Wed, Aug 21, 2019 at 09:34:02AM +0800, Chao Yu wrote:
> On 2019/8/20 23:56, Theodore Y. Ts'o wrote:
> > The reason why there needs to be at least some file system specific
> > code for fuzz testing is because for efficiency's sake, you don't want
> > to fuzz every single bit in the file system,
On 2019/8/20 23:56, Theodore Y. Ts'o wrote:
> The reason why there needs to be at least some file system specific
> code for fuzz testing is because for efficiency's sake, you don't want
> to fuzz every single bit in the file system, but just the ones which
> are most interesting (e.g., the
On Wed, Aug 21, 2019 at 12:35:08AM +0800, Gao Xiang wrote:
>
> For EROFS, it's a special case since it is a RO fs, and erofs mkfs
> will generate reproducable images (which means, for one dir trees,
> it only generates exact one result except for build time).
Agreed, and given that, doing the
On Tue, Aug 20, 2019 at 08:18:20PM -0400, Caitlyn wrote:
> Balanced braces to fix some checkpath warnings in inode.c and
> unzip_vle.c
>
> Signed-off-by: Caitlyn
> ---
> drivers/staging/erofs/inode.c | 4 ++--
> drivers/staging/erofs/unzip_vle.c | 12 ++--
> 2 files changed, 8
Hi Caitlyn,
On Tue, Aug 20, 2019 at 08:18:18PM -0400, Caitlyn wrote:
> Hello!
>
> This patch series cleans up some checkpatch fixes in erofs. The patches
> include balancing conditional braces and fixing some indentation. No testing
> done, all patches build and checkpath cleanly.
I think you
Hello!
This patch series cleans up some checkpatch fixes in erofs. The patches
include balancing conditional braces and fixing some indentation. No testing
done, all patches build and checkpath cleanly.
Caitlyn (2):
staging/erofs/xattr.h: Fixed misaligned function arguments.
staging/erofs:
Balanced braces to fix some checkpath warnings in inode.c and
unzip_vle.c
Signed-off-by: Caitlyn
---
drivers/staging/erofs/inode.c | 4 ++--
drivers/staging/erofs/unzip_vle.c | 12 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/erofs/inode.c
Indented some function arguments to fix checkpath warnings.
Signed-off-by: Caitlyn
---
drivers/staging/erofs/xattr.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/erofs/xattr.h b/drivers/staging/erofs/xattr.h
index 35ba5ac..d86f5cd 100644
---
From: Edmund Huber
These changes remove checkpatch.pl warnings from comedi/drivers/ni_pcimio.c .
No testing done, all patches build and checkpatch cleanly.
Edmund Huber (2):
comedi: remove camelcase
comedi: move #ifdef 0'd stuff to TODO
drivers/staging/comedi/TODO| 1 +
From: Edmund Huber
---
drivers/staging/comedi/drivers/ni_pcimio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_pcimio.c
b/drivers/staging/comedi/drivers/ni_pcimio.c
index 14b26fffe..e2e64e234 100644
---
From: Edmund Huber
---
drivers/staging/comedi/TODO| 1 +
drivers/staging/comedi/drivers/ni_pcimio.c | 48 --
2 files changed, 1 insertion(+), 48 deletions(-)
diff --git a/drivers/staging/comedi/TODO b/drivers/staging/comedi/TODO
index f733c017f..4fe1028ca
On Tue, Aug 20, 2019 at 04:11:54PM -0700, Stephen Brennan wrote:
> Signed-off-by: Stephen Brennan
> ---
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to
Signed-off-by: Stephen Brennan
---
.../staging/rtl8192u/ieee80211/ieee80211.h| 35 ++-
.../staging/rtl8192u/ieee80211/rtl819x_HT.h | 8 ++---
2 files changed, 22 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
Signed-off-by: Stephen Brennan
---
.../staging/rtl8192u/ieee80211/ieee80211.h| 3 +-
.../staging/rtl8192u/ieee80211/ieee80211_rx.c | 116 ++
.../staging/rtl8192u/ieee80211/ieee80211_tx.c | 81 +---
.../staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 +-
Addressed some spacing, brace placement, and macro alignment in this driver. I
do not have the relevent hardware, but I verified that the
drivers/staging/rtl8192u module built between each patch.
Stephen Brennan (3):
staging: rtl8192u: fix OPEN_BRACE errors in ieee80211
staging: rtl8192u: fix
Signed-off-by: Stephen Brennan
---
drivers/staging/rtl8192u/ieee80211/dot11d.c | 10 ++--
.../staging/rtl8192u/ieee80211/ieee80211.h| 4 +-
.../rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
.../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 22
Hi Ted,
On Tue, Aug 20, 2019 at 11:56:23AM -0400, Theodore Y. Ts'o wrote:
> On Tue, Aug 20, 2019 at 10:24:11AM +0800, Chao Yu wrote:
> > Out of curiosity, it looks like every mainstream filesystem has its own
> > fuzz/injection tool in their tool-set, if it's really such a generic
> >
On Tue, Aug 20, 2019 at 10:24:11AM +0800, Chao Yu wrote:
> Out of curiosity, it looks like every mainstream filesystem has its own
> fuzz/injection tool in their tool-set, if it's really such a generic
> requirement, why shouldn't there be a common tool to handle that, let
> specified
>
This patch fix a spelling typo in ni_mio_common.c
Signed-off-by: Masanari Iida
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c
b/drivers/staging/comedi/drivers/ni_mio_common.c
[...]
>
> Yeah, it looks like we need searching more levels mapping to find the final
> physical block address of inode/node/data in btrfs.
>
> IMO, in a little lazy way, we can reform and reuse existed function in
> btrfs-progs which can find the mapping info of inode/node/data according to
>
On Tue, Aug 20, 2019 at 06:58:00AM +, Li, Philip wrote:
> > Subject: Re: [PATCH] staging: erofs: fix an error handling in
> > erofs_readdir()
> >
> > Hi Philip,
> >
> > On Tue, Aug 20, 2019 at 02:50:38PM +0800, Philip Li wrote:
> > > On Sun, Aug 18, 2019 at 09:25:04PM +0800, Gao Xiang
On 2019/8/20 10:38, Qu Wenruo wrote:
>
>
> On 2019/8/20 上午10:24, Chao Yu wrote:
>> On 2019/8/20 8:55, Qu Wenruo wrote:
>>> [...]
>> I have made a simple fuzzer to inject messy in inode metadata,
>> dir data, compressed indexes and super block,
>>
> Subject: Re: [PATCH] staging: erofs: fix an error handling in erofs_readdir()
>
> Hi Philip,
>
> On Tue, Aug 20, 2019 at 02:50:38PM +0800, Philip Li wrote:
> > On Sun, Aug 18, 2019 at 09:25:04PM +0800, Gao Xiang wrote:
> > > On Sun, Aug 18, 2019 at 09:17:52PM +0800, kbuild test robot wrote:
>
Hi Philip,
On Tue, Aug 20, 2019 at 02:50:38PM +0800, Philip Li wrote:
> On Sun, Aug 18, 2019 at 09:25:04PM +0800, Gao Xiang wrote:
> > On Sun, Aug 18, 2019 at 09:17:52PM +0800, kbuild test robot wrote:
> > > Hi Gao,
> > >
> > > I love your patch! Yet something to improve:
> > >
> > > [auto
On Sun, Aug 18, 2019 at 09:25:04PM +0800, Gao Xiang wrote:
> On Sun, Aug 18, 2019 at 09:17:52PM +0800, kbuild test robot wrote:
> > Hi Gao,
> >
> > I love your patch! Yet something to improve:
> >
> > [auto build test ERROR on linus/master]
> > [cannot apply to v5.3-rc4 next-20190816]
> > [if
Hi Qu,
On Tue, Aug 20, 2019 at 02:04:46PM +0800, Qu Wenruo wrote:
> [...]
>
> And performance is another point.
> That tree-checker in btrfs is as fast/slow as CRC32.
> Not sure how it would be for dm-verity, but I guess it's slower than
> CRC32 if using any strong hash.
Just a word, dm-verity
[...]
>> The same tool exists for btrfs, although lacks the write ability, but
>> that dump is more comprehensive and a great tool to learn the on-disk
>> format.
>>
>>
>> And for the fuzzing defending part, just a few kernel releases ago,
>> there is none for btrfs, and now we have a full static
35 matches
Mail list logo
