Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-09-18 Thread Neil Armstrong
Hi, On 19/09/2019 08:55, Xin Ji wrote: > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > for portable device. It converts MIPI to DisplayPort 1.3 4K. > > You can add support to your board with binding. > > Example: > anx_bridge: anx7625@58 { > compatible

Re: [PATCH v1 0/2] Add initial support for slimport anx7625

2019-09-18 Thread Neil Armstrong
Hi, Please Cc dri-de...@lists.freedesktop.org Thanks, Neil On 19/09/2019 08:51, Xin Ji wrote: > Hi all, > > The following series add initial support for the Slimport ANX7625 > transmitter, a > ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable > device. > > This is the f

Re: [PATCH] staging: mt7621-pci-phy: Use devm_platform_ioremap_resource() in mt7621_pci_phy_probe()

2019-09-18 Thread Sergio Paracuellos
Hi Markus, Thanks for the patch. It looks good to me. On Wed, Sep 18, 2019 at 9:12 PM Markus Elfring wrote: > > From: Markus Elfring > Date: Wed, 18 Sep 2019 21:01:32 +0200 > > Simplify this function implementation by using a known wrapper function. > > This issue was detected by using the Cocc

RE: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread Namjae Jeon
[..] > Put it in drivers/staging/sdfat/. > > But really we want someone from Samsung to say that they will treat > the staging version as upstream. It doesn't work when people apply > fixes to their version and a year later back port the fixes into > staging. The staging tree is going to have to

Re: [GIT PULL] Staging/IIO driver patches for 5.4-rc1

2019-09-18 Thread Gao Xiang
On Thu, Sep 19, 2019 at 05:11:28AM +0800, Gao Xiang wrote: > Hi Christoph, > > On Wed, Sep 18, 2019 at 11:24:12AM -0700, Christoph Hellwig wrote: > > Just as a note of record: I don't think either file system move > > is a good idea. erofs still needs a lot of work, especially in > > interacting

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Ju Hyung Park
Welp, looks like I didn't test debug configs properly. Allow me 1-2 days to work on fixing it for v2. Thanks in advance. On Thu, Sep 19, 2019 at 6:31 AM kbuild test robot wrote: > > Hi Park, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [ca

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread kbuild test robot
Hi Park, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190917] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Park-Ju-H

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread kbuild test robot
Hi Park, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190917] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Park-Ju-H

Re: [GIT PULL] Staging/IIO driver patches for 5.4-rc1

2019-09-18 Thread Gao Xiang
Hi Christoph, On Wed, Sep 18, 2019 at 11:24:12AM -0700, Christoph Hellwig wrote: > Just as a note of record: I don't think either file system move > is a good idea. erofs still needs a lot of work, especially in > interacting with the mm code like abusing page->mapping. I know what you mean, th

Re: [GIT PULL] Staging/IIO driver patches for 5.4-rc1

2019-09-18 Thread Christoph Hellwig
On Wed, Sep 18, 2019 at 08:50:10PM +0200, Greg KH wrote: > > exfat is just a random old code drop from Samsung hastily picked up, > > and also duplicating the fat16/32 functionality, and without > > consultation of the developes of that who are trying to work through > > their process of contributi

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Valdis Klētnieks
On Thu, 19 Sep 2019 05:31:21 +0900, Ju Hyung Park said: > We should probably ask Valdis on what happened there. > > Even the old exFAT v1.2.24 from Galaxy S7 is using "either version 2 > of the License, or (at your option) any later version". > You can go check it yourself by searching "G930F" fro

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Ju Hyung Park
On Thu, Sep 19, 2019 at 5:26 AM Greg KH wrote: > That differs from the original exfat code, so something is odd here. I > need some sort of clarification from Samsung as to when they changed the > license in order to be able to relicense these files. We should probably ask Valdis on what happene

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

2019-09-18 Thread Gregory Nowak
On Wed, Sep 18, 2019 at 08:16:42AM +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 17, 2019 at 06:03:53PM -0700, Gregory Nowak wrote: > > On Tue, Sep 17, 2019 at 10:01:18AM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Sep 16, 2019 at 03:38:48PM -0700, Gregory Nowak wrote: > > > > On Mon, Sep 16, 2

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Greg KH
On Thu, Sep 19, 2019 at 05:22:03AM +0900, Ju Hyung Park wrote: > Hi Greg, > > On Thu, Sep 19, 2019 at 5:12 AM Greg KH wrote: > > That's a lot of rewriting :( > > > > How about at least keeping the file names the same to make it easier to > > see what happened here? > > > > Then send a follow-on p

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Ju Hyung Park
Hi Greg, On Thu, Sep 19, 2019 at 5:12 AM Greg KH wrote: > That's a lot of rewriting :( > > How about at least keeping the file names the same to make it easier to > see what happened here? > > Then send a follow-on patch that just does the rename? That's still not quite useful tbh, lemme bring t

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Greg KH
On Thu, Sep 19, 2019 at 04:59:20AM +0900, Park Ju Hyung wrote: > --- a/drivers/staging/exfat/exfat.h > +++ b/drivers/staging/exfat/exfat.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +// SPDX-License-Identifier: GPL-2.0-or-later You just changed the license of this file. Are you

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Greg KH
On Thu, Sep 19, 2019 at 04:59:20AM +0900, Park Ju Hyung wrote: > The new sdFAT driver base brings many improvements to the table. > Quoting Namjae Jeon: > > == > 1. sdfat has been refactored to improve compatibility, readability a

[PATCH] staging: mt7621-pci-phy: Use devm_platform_ioremap_resource() in mt7621_pci_phy_probe()

2019-09-18 Thread Markus Elfring
From: Markus Elfring Date: Wed, 18 Sep 2019 21:01:32 +0200 Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c | 10 +- 1 fi

Re: [GIT PULL] Staging/IIO driver patches for 5.4-rc1

2019-09-18 Thread Greg KH
On Wed, Sep 18, 2019 at 11:24:12AM -0700, Christoph Hellwig wrote: > Just as a note of record: I don't think either file system move > is a good idea. erofs still needs a lot of work, especially in > interacting with the mm code like abusing page->mapping. At least it is special-purpose "read on

Re: [GIT PULL] Staging/IIO driver patches for 5.4-rc1

2019-09-18 Thread Christoph Hellwig
Just as a note of record: I don't think either file system move is a good idea. erofs still needs a lot of work, especially in interacting with the mm code like abusing page->mapping. exfat is just a random old code drop from Samsung hastily picked up, and also duplicating the fat16/32 functiona

Re: [GIT PULL] Staging/IIO driver patches for 5.4-rc1

2019-09-18 Thread pr-tracker-bot
The pull request you sent on Wed, 18 Sep 2019 13:47:54 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > tags/staging-5.4-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e6874fc29410fabfdbc8c12b467f41a16cbcfd2b Thank you! -- Deet-doot-d

[PATCH 3/3] staging: rtl8192u: Remove unnecessary line-breaks in function signatures

2019-09-18 Thread Sumera Priyadarsini
This patch fixes the function signatures for rtl8192_handle_assoc_response, rtl8192_record_rxdesc_forlateruse, rtl819xusb_process_received_packet and other relevant code blocks to avoid the checkpatch.pl warning: CHECK: Lines should not end with a '(' Signed-off-by: Sumera Priyadarsini -

[PATCH 2/3] staging: rtl8192u: Fix alignment to match open parenthesis

2019-09-18 Thread Sumera Priyadarsini
This patch fixes the file r8192U_core.c to avoid the checkpatch.pl warning: CHECK: Alignment should match open parenthesis Signed-off-by: Sumera Priyadarsini --- drivers/staging/rtl8192u/r8192U_core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/

[PATCH 1/3] staging: rtl8192u: Remove unnecessary blank lines

2019-09-18 Thread Sumera Priyadarsini
This patch fixes the file r8192U_core.c to avoid the chechpatch.pl warnings: CHECK: Please don't use multiple blank lines CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Sumera Priyadarsini --- drivers/staging/rtl8192u/r8192U_core.c | 70 -

[PATCH 0/3] staging: rtl8192u: Fix checkpatch warnings in

2019-09-18 Thread Sumera Priyadarsini
This patch series fixes several checkpatch.pl warnings in r8192U_core.c related to unwanted blank lines, line-breaks, and alignment issues. Sumera Priyadarsini (3): staging: rtl8192u: Remove unnecessary blank lines staging: rtl8192u: Fix alignment to match open parenthesis staging: rtl8192u:

[PATCH] drivers:staging:qlge: Removed unnecessary variable

2019-09-18 Thread Aliasgar Surti
From: Aliasgar Surti coccicheck reported warning for unnecessary variable used. This patch fixes the same by removing the variable and returning value directly. Signed-off-by: Aliasgar Surti --- drivers/staging/qlge/qlge_dbg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[GIT PULL] Staging/IIO driver patches for 5.4-rc1

2019-09-18 Thread Greg KH
The following changes since commit d1abaeb3be7b5fa6d7a1fbbd2e14e3310005c4c1: Linux 5.3-rc5 (2019-08-18 14:31:08 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.4-rc1 for you to fetch changes up to 3fb73eddba106a

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread Greg KH
On Wed, Sep 18, 2019 at 07:46:25PM +0900, Ju Hyung Park wrote: > On Wed, Sep 18, 2019 at 7:09 PM Dan Carpenter > wrote: > > Use Kconfig. > > Not just that. > There are a lot of non-static functions that's not marked ex/sdfat-specific. > (which we would have to clean it up eventually) Then clean

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread Ju Hyung Park
On Wed, Sep 18, 2019 at 7:09 PM Dan Carpenter wrote: > Use Kconfig. Not just that. There are a lot of non-static functions that's not marked ex/sdfat-specific. (which we would have to clean it up eventually) Even with sdFAT base, there are some non-static functions named as exfat. Figuring out

Re: [PATCH v2] drivers:staging:rtl8723bs: Removed unneeded variables

2019-09-18 Thread Dan Carpenter
On Wed, Sep 18, 2019 at 02:55:49PM +0530, Aliasgar Surti wrote: > From: Aliasgar Surti > > coccicheck reported warning for unneeded variable used. > > This patch removes the unneeded variables. > > Signed-off-by: Aliasgar Surti > --- > v2: removed unneeded functions and replaced them with NULL

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread Dan Carpenter
On Wed, Sep 18, 2019 at 06:53:49PM +0900, Ju Hyung Park wrote: > Hi Dan, > > On Wed, Sep 18, 2019 at 6:27 PM Dan Carpenter > wrote: > > Put it in drivers/staging/sdfat/. > > It'll conflict with the current exfat staging drivers. Use Kconfig. > And moreover, I don't think it makes sense to use

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread Ju Hyung Park
Hi Dan, On Wed, Sep 18, 2019 at 6:27 PM Dan Carpenter wrote: > Put it in drivers/staging/sdfat/. It'll conflict with the current exfat staging drivers. And moreover, I don't think it makes sense to use sdfat naming in mainline. Samsung uses it since it handles all fat filesystems. >From what I

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread Dan Carpenter
On Wed, Sep 18, 2019 at 06:01:09PM +0900, Ju Hyung Park wrote: > On Wed, Sep 18, 2019 at 5:33 PM Greg KH wrote: > > He did? I do not see a patch anywhere, what is the message-id of it? > > I'm just repeating myself at this point, but again, I'm more than > willing to work on a patch. > I just wa

[PATCH v2] drivers:staging:rtl8723bs: Removed unneeded variables

2019-09-18 Thread Aliasgar Surti
From: Aliasgar Surti coccicheck reported warning for unneeded variable used. This patch removes the unneeded variables. Signed-off-by: Aliasgar Surti --- v2: removed unneeded functions and replaced them with NULL in function array. --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 54 +++--

Re: [PATCH v3 00/26] Add definition for the number of standard PCI BARs

2019-09-18 Thread Andrew Murray
On Mon, Sep 16, 2019 at 11:41:32PM +0300, Denis Efremov wrote: > Code that iterates over all standard PCI BARs typically uses > PCI_STD_RESOURCE_END, but this is error-prone because it requires > "i <= PCI_STD_RESOURCE_END" rather than something like > "i < PCI_STD_NUM_BARS". We could add such a de

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread Ju Hyung Park
On Wed, Sep 18, 2019 at 5:33 PM Greg KH wrote: > He did? I do not see a patch anywhere, what is the message-id of it? I'm just repeating myself at this point, but again, I'm more than willing to work on a patch. I just want to make it clear on how should I. > He took the "best known at the time

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread Sergey Senozhatsky
On (09/18/19 10:26), 'Greg KH' wrote: > On Wed, Sep 18, 2019 at 03:33:04PM +0900, Sergey Senozhatsky wrote: > > On (09/18/19 08:16), 'Greg KH' wrote: > > [..] > > > > Note, that Samsung is still improving sdfat driver. For instance, > > > > what will be realeased soon is sdfat v2.3.0, which will in

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread 'Greg KH'
On Wed, Sep 18, 2019 at 03:33:04PM +0900, Sergey Senozhatsky wrote: > On (09/18/19 08:16), 'Greg KH' wrote: > [..] > > > Note, that Samsung is still improving sdfat driver. For instance, > > > what will be realeased soon is sdfat v2.3.0, which will include support > > > for "UtcOffset" of "File Dir