Re: [PATCH] staging: speakup: document sysfs attributes

2019-09-30 Thread Greg Kroah-Hartman
On Sat, Sep 21, 2019 at 11:22:14AM +0100, Okash Khawaja wrote: > Speakup exposes a set of sysfs attributes under > /sys/accessibility/speakup/ for user-space to interact with and > configure speakup's kernel modules. This patch describes those > attributes. Some attributes either lack a description

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

2019-09-30 Thread Jernej Škrabec
Dne torek, 01. oktober 2019 ob 00:43:34 CEST je Hans Verkuil napisal(a): > On 10/1/19 12:27 AM, Jernej Škrabec wrote: > > Dne ponedeljek, 30. september 2019 ob 10:10:48 CEST je Hans Verkuil > > > > napisal(a): > >> On 9/29/19 10:00 PM, Jernej Skrabec wrote: > >>> This series adds support for decod

RE: [PATCH] ion_system_heap: support X86 archtecture

2019-09-30 Thread Zhang, Jun
Hello, Greg Sorry, I am newcomer, and I don't know why couldn't use #ifdefs? I only refer some kernel code(V4.19) in drivers/hwtracing/intel_th/msu.c. Could you tell me why? And I tell my workmate to avoid the same case. If I define a config in Kconfig, and static inline function in .h file, th

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

2019-09-30 Thread Jernej Škrabec
Dne torek, 01. oktober 2019 ob 00:43:34 CEST je Hans Verkuil napisal(a): > On 10/1/19 12:27 AM, Jernej Škrabec wrote: > > Dne ponedeljek, 30. september 2019 ob 10:10:48 CEST je Hans Verkuil > > > > napisal(a): > >> On 9/29/19 10:00 PM, Jernej Skrabec wrote: > >>> This series adds support for decod

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

2019-09-30 Thread Hans Verkuil
On 10/1/19 12:27 AM, Jernej Škrabec wrote: > Dne ponedeljek, 30. september 2019 ob 10:10:48 CEST je Hans Verkuil > napisal(a): >> On 9/29/19 10:00 PM, Jernej Skrabec wrote: >>> This series adds support for decoding multi-slice H264 frames along with >>> support for V4L2_DEC_CMD_FLUSH and V4L2_BUF_

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

2019-09-30 Thread Jernej Škrabec
Dne ponedeljek, 30. september 2019 ob 10:10:48 CEST je Hans Verkuil napisal(a): > On 9/29/19 10:00 PM, Jernej Skrabec wrote: > > This series adds support for decoding multi-slice H264 frames along with > > support for V4L2_DEC_CMD_FLUSH and V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF. > > > > Code was tes

Re: [PATCH] staging: rtl8192u: fix multiple memory leaks on error path

2019-09-30 Thread Navid Emamdoost
Could you take a look at this patch and confirm it, please? On Thu, Sep 19, 2019 at 9:51 PM Navid Emamdoost wrote: > > In rtl8192_tx on error handling path allocated urbs and also skb should > be released. > > Signed-off-by: Navid Emamdoost > --- > drivers/staging/rtl8192u/r8192U_core.c | 17 ++

Re: [PATCH] binder: Fix comment headers on binder_alloc_prepare_to_free()

2019-09-30 Thread Christian Brauner
On Mon, Sep 30, 2019 at 04:12:50PM -0400, Joel Fernandes wrote: > binder_alloc_buffer_lookup() doesn't exist and is named > "binder_alloc_prepare_to_free()". Correct the code comments to reflect > this. > > Signed-off-by: Joel Fernandes (Google) Reviewed-by: Christian Brauner __

[PATCH] binder: Fix comment headers on binder_alloc_prepare_to_free()

2019-09-30 Thread Joel Fernandes (Google)
binder_alloc_buffer_lookup() doesn't exist and is named "binder_alloc_prepare_to_free()". Correct the code comments to reflect this. Signed-off-by: Joel Fernandes (Google) --- drivers/android/binder_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/bind

Re: [PATCH RESEND v3 00/26] Add definition for the number of standard PCI BARs

2019-09-30 Thread Bjorn Helgaas
On Sat, Sep 28, 2019 at 02:40:26AM +0300, Denis Efremov wrote: > Code that iterates over all standard PCI BARs typically uses > PCI_STD_RESOURCE_END, but this is error-prone because it requires > "i <= PCI_STD_RESOURCE_END" rather than something like > "i < PCI_STD_NUM_BARS". We could add such a de

Re: [PATCH v2 6/6] media: cedrus: Add support for holding capture buffer

2019-09-30 Thread Jernej Škrabec
Dne ponedeljek, 30. september 2019 ob 10:14:32 CEST je Hans Verkuil napisal(a): > On 9/29/19 10:00 PM, Jernej Skrabec wrote: > > When frame contains multiple slices and driver works in slice mode, it's > > more efficient to hold capture buffer in queue until all slices of a > > same frame are deco

Re: [PATCH] staging: rtl8723bs: hal: Fix memcpy calls

2019-09-30 Thread Denis Efremov
On 9/30/19 4:18 PM, David Laight wrote: > From: Denis Efremov >> Sent: 30 September 2019 12:02 >> memcpy() in phy_ConfigBBWithParaFile() and PHY_ConfigRFWithParaFile() is >> called with "src == NULL && len == 0". This is an undefined behavior. > > I'm pretty certain it is well defined (to do nothi

Re: [PATCH] staging: rtl8723bs: hal: Fix memcpy calls

2019-09-30 Thread Denis Efremov
On 9/30/19 4:18 PM, David Laight wrote: > From: Denis Efremov >> Sent: 30 September 2019 12:02 >> memcpy() in phy_ConfigBBWithParaFile() and PHY_ConfigRFWithParaFile() is >> called with "src == NULL && len == 0". This is an undefined behavior. > > I'm pretty certain it is well defined (to do nothi

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-30 Thread 'Greg KH'
On Mon, Sep 30, 2019 at 01:25:13PM +0900, Namjae Jeon wrote: > > > [..] > > > Put it in drivers/staging/sdfat/. > > > > > > But really we want someone from Samsung to say that they will treat > > > the staging version as upstream. It doesn't work when people apply > > > fixes to their version and

Re: [PATCH 1/3] Staging: exfat: exfat_super.c: fixed camelcase coding style issue

2019-09-30 Thread Greg KH
On Sun, Sep 29, 2019 at 09:50:57AM -0500, Jesse Barton wrote: > Changed function names: > ffsUmountVol to ffs_umount_vol > ffsMountVol to ffs_mount_vol > ffsSyncVol to ffs_sync_vol > > That says _what_ you did, but not _why_ you are doing this. And is this really the best name for these functio

Re: [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.

2019-09-30 Thread Greg KH
On Sun, Sep 29, 2019 at 09:52:45AM -0500, Jesse Barton wrote: > Removed function argument wrapping to new line. I don't think you "removed" anything here :( Writing the changelog is usually harder than writing the patch in the first place, welcome to programming! :) thanks, greg k-h __

Re: [PATCH 2/3] Staging: exfat: exfat_super.c: fixed multiple coding style issues with camelcase and parentheses

2019-09-30 Thread Greg KH
On Sun, Sep 29, 2019 at 09:52:29AM -0500, Jesse Barton wrote: > Changed Function Names: > ffsGetVolInfo -> ffs_get_vol_info > ffsLookupFile -> ffs_lookup_file > ffsCreateFile -> ffs_create_file > ffsReadFile -> ffs_read_file > ffsWriteFile -> ffs_write_file > ffsTruncateFile -> ffs_truncate_file >

Re: [PATCH] staging: rtl8723bs: hal: Fix memcpy calls

2019-09-30 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.3.1, v5.2.17, v4.19.75, v4.14.146, v4.9.194, v4.4.194. v5.3.1: Build OK! v5.2.1

RE: [PATCH] staging: rtl8723bs: hal: Fix memcpy calls

2019-09-30 Thread David Laight
From: Denis Efremov > Sent: 30 September 2019 12:02 > memcpy() in phy_ConfigBBWithParaFile() and PHY_ConfigRFWithParaFile() is > called with "src == NULL && len == 0". This is an undefined behavior. I'm pretty certain it is well defined (to do nothing). > Moreover this if pre-condition "pBufLen &

[PATCH] staging: exfat: Fix a typo in Kconfig

2019-09-30 Thread Masanari Iida
This patch fix a spelling typo in Kconfig. Signed-off-by: Masanari Iida --- drivers/staging/exfat/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/exfat/Kconfig b/drivers/staging/exfat/Kconfig index 290dbfc7ace1..12f7af346c9b 100644 --- a/drivers/stagin

[PATCH] staging: rtl8723bs: hal: Fix memcpy calls

2019-09-30 Thread Denis Efremov
memcpy() in phy_ConfigBBWithParaFile() and PHY_ConfigRFWithParaFile() is called with "src == NULL && len == 0". This is an undefined behavior. Moreover this if pre-condition "pBufLen && (*pBufLen == 0) && !pBuf" is constantly false because it is a nested if in the else brach, i.e., "if (cond) { ...

Re: [PATCH v2 6/6] media: cedrus: Add support for holding capture buffer

2019-09-30 Thread Hans Verkuil
On 9/29/19 10:00 PM, Jernej Skrabec wrote: > When frame contains multiple slices and driver works in slice mode, it's > more efficient to hold capture buffer in queue until all slices of a > same frame are decoded. > > Add support for that to Cedrus driver by exposing and implementing > V4L2_BUF_C

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

2019-09-30 Thread Hans Verkuil
On 9/29/19 10:00 PM, Jernej Skrabec wrote: > This series adds support for decoding multi-slice H264 frames along with > support for V4L2_DEC_CMD_FLUSH and V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF. > > Code was tested by modified ffmpeg, which can be found here: > https://github.com/jernejsk/FFmpeg, bran