Re: [PATCH v3 3/4] dt-binding: iio: Add documentation for AD7091R5

2019-11-13 Thread Rob Herring
On Thu, 7 Nov 2019 17:07:58 +0200, Beniamin Bia wrote: > Documentation for AD7091R5 ADC was added. > > Signed-off-by: Beniamin Bia > --- > Changes in v3: > -spdx identifier updated > -compatible property with lower case > -additionalProperties added > -hex value with lower case > >

Re: [PATCH 1/3] iio: Add ADM1177 Hot Swap Controller and Digital Power Monitor driver

2019-11-13 Thread Guenter Roeck
On Wed, Nov 13, 2019 at 08:10:50AM +, Hennerich, Michael wrote: > > > > -Original Message- > > From: Guenter Roeck On Behalf Of Guenter Roeck > > Sent: Dienstag, 12. November 2019 20:18 > > To: Jonathan Cameron > > Cc: Bia, Beniamin ; ji...@kernel.org; > > l...@metafoo.de;

Re: [PATCH 1/2] staging: vchiq: Move retrieval of rpi_firmware to vchiq_platform_init()

2019-11-13 Thread Marcelo Diop-Gonzalez
On Tue, Nov 12, 2019 at 6:09 PM Greg KH wrote: > > On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote: > > This allows the removal of the struct rpi_firmware* member > > from struct vchiq_drvdata. > > > > Signed-off-by: Marcelo Diop-Gonzalez > > --- > >

Re: [PATCH 2/2] staging: vchiq: Remove global bcm*_drvdata

2019-11-13 Thread Stefan Wahren
Hello Marcelo, Am 11.11.19 um 18:14 schrieb Marcelo Diop-Gonzalez: > Moving the DT node check to vchiq_platform_init() > removes the need for these. this comment does match to your changes. Also i'm missing a why this is necessary. > > Signed-off-by: Marcelo Diop-Gonzalez > --- >

[bug report] staging: wilc1000: added support to dynamically add/remove interfaces

2019-11-13 Thread Dan Carpenter
[ When we renamed the files, then all the old warnings showed up as new warnings again. - dan ] Hello Ajay Singh, The patch 9bc061e88054: "staging: wilc1000: added support to dynamically add/remove interfaces" from Jun 26, 2019, leads to the following static checker warning:

Re: [PATCH v3 8/9] staging: exfat: Collapse redundant return code translations

2019-11-13 Thread Dan Carpenter
On Mon, Nov 11, 2019 at 09:09:56PM -0500, Valdis Kletnieks wrote: > Now that we no longer use odd internal return codes, we can > heave the translation code over the side, and just pass the > error code back up the call chain. > > Signed-off-by: Valdis Kletnieks > --- >

Re: [PATCH 2/2] staging: vchiq: Remove global bcm*_drvdata

2019-11-13 Thread Dan Carpenter
On Mon, Nov 11, 2019 at 12:14:24PM -0500, Marcelo Diop-Gonzalez wrote: > @@ -109,7 +108,8 @@ int vchiq_platform_init(struct platform_device *pdev, > struct vchiq_state *state) > if (err < 0) > return err; > > - g_cache_line_size = drvdata->cache_line_size; > + if

Re: [PATCH 1/2] staging: vchiq: Move retrieval of rpi_firmware to vchiq_platform_init()

2019-11-13 Thread Dan Carpenter
On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote: > This allows the removal of the struct rpi_firmware* member > from struct vchiq_drvdata. > Please don't start your commit message in the middle of a sentence. It looks like this:

[PATCH] staging: exfat: fix indentation issue

2019-11-13 Thread Colin King
From: Colin Ian King There is a declaration that requires indentation. Add in the missing tab. Signed-off-by: Colin Ian King --- drivers/staging/exfat/exfat_super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/exfat/exfat_super.c

Re: [PATCH 1/2] staging: vchiq: Move retrieval of rpi_firmware to vchiq_platform_init()

2019-11-13 Thread Marcelo Diop-Gonzalez
On Wed, Nov 13, 2019 at 12:32 AM Greg KH wrote: > > On Tue, Nov 12, 2019 at 06:29:55PM -0500, Marcelo Diop-Gonzalez wrote: > > On Tue, Nov 12, 2019 at 6:09 PM Greg KH wrote: > > > > > > On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote: > > > > This allows the removal of the

[PATCH] staging: align to fix warnings of line over 80 characters

2019-11-13 Thread Jules Irenge
Align to fix multiple warnings of line over 80 characters. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/wfx/bus_sdio.c | 4 +- drivers/staging/wfx/data_rx.h| 3 +- drivers/staging/wfx/debug.c | 15 ++-- drivers/staging/wfx/fwio.c | 65

RE: [PATCH 1/3] iio: Add ADM1177 Hot Swap Controller and Digital Power Monitor driver

2019-11-13 Thread Hennerich, Michael
> -Original Message- > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: Dienstag, 12. November 2019 20:18 > To: Jonathan Cameron > Cc: Bia, Beniamin ; ji...@kernel.org; > l...@metafoo.de; Hennerich, Michael ; > pme...@pmeerw.net; gre...@linuxfoundation.org; linux- >

Re: [PATCH] vboxsf: move out of staging to fs/

2019-11-13 Thread Hans de Goede
Hi, On 13-11-2019 00:12, Linus Torvalds wrote: On Tue, Nov 12, 2019 at 2:54 PM Greg Kroah-Hartman wrote: Christoph, this is what you mean, right? If so, I'll send this to Linus later this week, or he can grab it right from this patch :) No. I was unhappy about a staging driver being