Re: [PATCH v2] staging: fwserial: Fix Kconfig indentation

On Thu, Nov 21, 2019 at 04:20:12AM +0100, Krzysztof Kozlowski wrote: > Adjust indentation from spaces to tab (+optional two spaces) as in > coding style with command like: > $ sed -e 's/^/\t/' -i */Kconfig > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1.

[PATCH v2] staging: fwserial: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Fix also 7-space and tab+1 space indentation issues. ---

[PATCH v2 4/4] staging: vchiq: Have vchiq_dump_* functions return an error code

These functions currently modify the struct dump_context passed to them, and set context->actual to -EFAULT in case of error. The issue is that this is never returned to the user (except accidentally when things align so that that happens). So, have these functions return 0 on success and the

Re: [PATCH 3/3] staging: vchiq: Have vchiq_dump_* functions return an error code

Thanks for the patch. Looks good. Reviewed-by: Dan Carpenter On Wed, Nov 20, 2019 at 10:36:48AM -0500, Marcelo Diop-Gonzalez wrote: > copy_bytes = min_t(int, len, context->space - context->actual); > if (copy_bytes == 0) > - return; > + return 0; > if

Re: [PATCH] staging: fbtft: Fix Kconfig indentation

On Wed, Nov 20, 2019 at 05:41:55PM +0100, Daniel Vetter wrote: > On Wed, Nov 20, 2019 at 09:39:11PM +0800, Krzysztof Kozlowski wrote: > > Adjust indentation from spaces to tab (+optional two spaces) as in > > coding style with command like: > > $ sed -e 's/^/\t/' -i */Kconfig > > > >

Re: [PATCH] staging: fbtft: Fix Kconfig indentation

On Wed, Nov 20, 2019 at 09:39:11PM +0800, Krzysztof Kozlowski wrote: > Adjust indentation from spaces to tab (+optional two spaces) as in > coding style with command like: > $ sed -e 's/^/\t/' -i */Kconfig > > Signed-off-by: Krzysztof Kozlowski Acked-by: Daniel Vetter I expect

Re: [PATCH] staging: vc04: Fix Kconfig indentation

Am 20.11.19 um 14:38 schrieb Krzysztof Kozlowski: > Adjust indentation from spaces to tab (+optional two spaces) as in > coding style with command like: > $ sed -e 's/^/\t/' -i */Kconfig > > Signed-off-by: Krzysztof Kozlowski Acked-by: Stefan Wahren

Re: [PATCH 1/3] staging: vchiq_dump: Replace min with min_t

On Wed, Nov 20, 2019 at 10:36:46AM -0500, Marcelo Diop-Gonzalez wrote: > Replacing this and fixing the block comment format in this > function fixes checkpatch warnings. That is two different things. Which means you need two different patches here. Please fix up. thanks, greg k-h

Re: [PATCH v1 3/5] fbtft: Drop useless #ifdef CONFIG_OF and dead code

On Wed, Nov 20, 2019 at 04:04:17PM +0100, Noralf Trønnes wrote: > Den 20.11.2019 15.43, skrev Noralf Trønnes: > > Den 20.11.2019 10.57, skrev Andy Shevchenko: > >> First of all there is no need to guard GPIO request by CONFIG_OF. > >> It works for everybody independently on resource provider.

Re: [PATCH v1 3/5] fbtft: Drop useless #ifdef CONFIG_OF and dead code

Den 20.11.2019 15.43, skrev Noralf Trønnes: > > > Den 20.11.2019 10.57, skrev Andy Shevchenko: >> First of all there is no need to guard GPIO request by CONFIG_OF. >> It works for everybody independently on resource provider. While here, >> rename the function to reflect the above. >> >>

Re: [PATCH v1 3/5] fbtft: Drop useless #ifdef CONFIG_OF and dead code

Den 20.11.2019 10.57, skrev Andy Shevchenko: > First of all there is no need to guard GPIO request by CONFIG_OF. > It works for everybody independently on resource provider. While here, > rename the function to reflect the above. > > Moreover, since we have a global dependency to OF, the rest

[PATCH] staging: most: core: remove sysfs attr remove_link

This patch removes the sysfs attribute remove_link, as it is not needed anymore since the introduction of the configfs configuration interface. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 86 - 1 file changed, 86 deletions(-)

[PATCH] staging: pi433: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/staging/pi433/Kconfig | 24 1 file changed, 12 insertions(+), 12

[PATCH] staging: nvec: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/staging/nvec/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH] staging: vc04: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/staging/vc04_services/bcm2835-audio/Kconfig | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH] staging: fbtft: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/staging/fbtft/Kconfig | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH] staging: fwserial: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/staging/fwserial/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] staging: most: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/staging/most/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v1 1/5] fbtft: Make sure string is NULL terminated

New GCC warns about inappropriate use of strncpy(): drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_framebuffer_alloc’: drivers/staging/fbtft/fbtft-core.c:665:2: warning: ‘strncpy’ specified bound 16 equals destination size [-Wstringop-truncation] 665 | strncpy(info->fix.id,

[PATCH v1 3/5] fbtft: Drop useless #ifdef CONFIG_OF and dead code

First of all there is no need to guard GPIO request by CONFIG_OF. It works for everybody independently on resource provider. While here, rename the function to reflect the above. Moreover, since we have a global dependency to OF, the rest of conditional compilation is no-op, i.e. it's always be

[PATCH v1 5/5] fbtft: Drop OF dependency

Now, since driver became OF independent, no need to keep OF dependency. Signed-off-by: Andy Shevchenko --- drivers/staging/fbtft/Kconfig | 2 +- drivers/staging/fbtft/fbtft.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/Kconfig

[PATCH v1 4/5] fbtft: Make use of device property API

Make use of device property API in this driver so that both OF based system and ACPI based system can use this driver. Signed-off-by: Andy Shevchenko --- drivers/staging/fbtft/fbtft-core.c | 105 - 1 file changed, 58 insertions(+), 47 deletions(-) diff --git

[PATCH v1 2/5] fbtft: Describe function parameters in kernel-doc

Kernel documentation script complains that some of the function parameters are not described: drivers/staging/fbtft/fbtft-core.c:543: warning: Function parameter or member 'pdata' not described in 'fbtft_framebuffer_alloc' Describe function parameters where it's appropriate. Signed-off-by: