On Tue, Dec 10, 2019 at 04:03:01PM -0500, Sasha Levin wrote:
> From: Paul Burton
>
> [ Upstream commit 17a29fea086ba18b000d28439bd5cb4f2b0a527b ]
>
> When building for a non-Cavium MIPS system with COMPILE_TEST=y, the
> Octeon ethernet driver hits a number of issues due to use of macros
> provid
On Tue, Dec 10, 2019 at 11:27:44PM +0200, Aaro Koskinen wrote:
> On Tue, Dec 10, 2019 at 09:19:57PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Dec 10, 2019 at 09:31:54PM +0200, Aaro Koskinen wrote:
> > > Hi,
> > >
> > > On Tue, Dec 10, 2019 at 10:15:09AM +0100, Greg Kroah-Hartman wrote:
> > > >
On Tue, Dec 10, 2019 at 07:47:59PM -0600, Scott Schafer wrote:
> CHECK: Please don't use multiple blank lines
> CHECK: Blank lines aren't necessary before a close brace '}'
> CHECK: Blank lines aren't necessary after an open brace '{'
> WARNING: Missing a blank line after declarations
> CHECK: No s
On Tue, Dec 10, 2019 at 11:48:49PM +0200, Aaro Koskinen wrote:
> On Tue, Dec 10, 2019 at 12:15:15PM -0800, Guenter Roeck wrote:
> > On Tue, Dec 10, 2019 at 09:46:59PM +0200, Aaro Koskinen wrote:
> > > On Tue, Dec 10, 2019 at 01:01:20PM +0100, Greg Kroah-Hartman wrote:
> > > > I have no idea :(
> >
Arnd,
Arnd Bergmann writes:
> - Most other supported HDLC hardware that we supoprt is for the ISA or
> PCI buses.
I would be surprised if there is anybody left with ISA sync serial
stuff, but the PCI hardware still has some users - these machines don't
need to be upgraded yearly. Most people
On 2019-12-10 14:51, Arnd Bergmann wrote:
On Tue, Dec 10, 2019 at 9:59 AM Martin Schiller wrote:
On 2019-12-09 20:26, Arnd Bergmann wrote:
> On Mon, Dec 9, 2019 at 7:29 PM David Miller
> wrote:
>>
>> From: Arnd Bergmann
>> Date: Mon, 9 Dec 2019 16:12:56 +0100
>>
>> > syzbot keeps finding iss
CHECK: Please don't use multiple blank lines
CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Blank lines aren't necessary after an open brace '{'
WARNING: Missing a blank line after declarations
CHECK: No space is necessary after a cast
CHECK: braces {} should be used on all arm
On Tue, Dec 10, 2019 at 11:48:49PM +0200, Aaro Koskinen wrote:
> On Tue, Dec 10, 2019 at 12:15:15PM -0800, Guenter Roeck wrote:
> > On Tue, Dec 10, 2019 at 09:46:59PM +0200, Aaro Koskinen wrote:
> > > On Tue, Dec 10, 2019 at 01:01:20PM +0100, Greg Kroah-Hartman wrote:
> > > > I have no idea :(
> >
From: Andy Shevchenko
[ Upstream commit 21f585480deb4bcf0d92b08879c35d066dfee030 ]
New GCC warns about inappropriate use of strncpy():
drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_framebuffer_alloc’:
drivers/staging/fbtft/fbtft-core.c:665:2: warning: ‘strncpy’ specified bound 16
equa
From: Connor Kuehl
[ Upstream commit 228241944a48113470d3c3b46c88ba7fbe0a274b ]
Inside a nested 'else' block at the beginning of this function is a
call that assigns 'psta' to the return value of 'rtw_get_stainfo()'.
If 'rtw_get_stainfo()' returns NULL and the flow of control reaches
the 'else i
From: Andy Shevchenko
[ Upstream commit 21f585480deb4bcf0d92b08879c35d066dfee030 ]
New GCC warns about inappropriate use of strncpy():
drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_framebuffer_alloc’:
drivers/staging/fbtft/fbtft-core.c:665:2: warning: ‘strncpy’ specified bound 16
equa
From: Connor Kuehl
[ Upstream commit 228241944a48113470d3c3b46c88ba7fbe0a274b ]
Inside a nested 'else' block at the beginning of this function is a
call that assigns 'psta' to the return value of 'rtw_get_stainfo()'.
If 'rtw_get_stainfo()' returns NULL and the flow of control reaches
the 'else i
From: Navid Emamdoost
[ Upstream commit ca312438cf176a16d4b89350cade8789ba8d7133 ]
In rtl8192_tx on error handling path allocated urbs and also skb should
be released.
Signed-off-by: Navid Emamdoost
Link: https://lore.kernel.org/r/20190920025137.29407-1-navid.emamdo...@gmail.com
Signed-off-by:
From: Andy Shevchenko
[ Upstream commit 21f585480deb4bcf0d92b08879c35d066dfee030 ]
New GCC warns about inappropriate use of strncpy():
drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_framebuffer_alloc’:
drivers/staging/fbtft/fbtft-core.c:665:2: warning: ‘strncpy’ specified bound 16
equa
From: Connor Kuehl
[ Upstream commit 228241944a48113470d3c3b46c88ba7fbe0a274b ]
Inside a nested 'else' block at the beginning of this function is a
call that assigns 'psta' to the return value of 'rtw_get_stainfo()'.
If 'rtw_get_stainfo()' returns NULL and the flow of control reaches
the 'else i
From: Navid Emamdoost
[ Upstream commit ca312438cf176a16d4b89350cade8789ba8d7133 ]
In rtl8192_tx on error handling path allocated urbs and also skb should
be released.
Signed-off-by: Navid Emamdoost
Link: https://lore.kernel.org/r/20190920025137.29407-1-navid.emamdo...@gmail.com
Signed-off-by:
On Tue, Dec 10, 2019 at 12:15:15PM -0800, Guenter Roeck wrote:
> On Tue, Dec 10, 2019 at 09:46:59PM +0200, Aaro Koskinen wrote:
> > On Tue, Dec 10, 2019 at 01:01:20PM +0100, Greg Kroah-Hartman wrote:
> > > I have no idea :(
> >
> > It's stated in the TODO file you are deleting (visible in your
> >
From: Andy Shevchenko
[ Upstream commit 21f585480deb4bcf0d92b08879c35d066dfee030 ]
New GCC warns about inappropriate use of strncpy():
drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_framebuffer_alloc’:
drivers/staging/fbtft/fbtft-core.c:665:2: warning: ‘strncpy’ specified bound 16
equa
From: Connor Kuehl
[ Upstream commit 228241944a48113470d3c3b46c88ba7fbe0a274b ]
Inside a nested 'else' block at the beginning of this function is a
call that assigns 'psta' to the return value of 'rtw_get_stainfo()'.
If 'rtw_get_stainfo()' returns NULL and the flow of control reaches
the 'else i
From: Navid Emamdoost
[ Upstream commit ca312438cf176a16d4b89350cade8789ba8d7133 ]
In rtl8192_tx on error handling path allocated urbs and also skb should
be released.
Signed-off-by: Navid Emamdoost
Link: https://lore.kernel.org/r/20190920025137.29407-1-navid.emamdo...@gmail.com
Signed-off-by:
On Tue, Dec 10, 2019 at 09:19:57PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Dec 10, 2019 at 09:31:54PM +0200, Aaro Koskinen wrote:
> > Hi,
> >
> > On Tue, Dec 10, 2019 at 10:15:09AM +0100, Greg Kroah-Hartman wrote:
> > > This driver was merged back in 2013 and shows no progress toward every
> >
From: Connor Kuehl
[ Upstream commit 228241944a48113470d3c3b46c88ba7fbe0a274b ]
Inside a nested 'else' block at the beginning of this function is a
call that assigns 'psta' to the return value of 'rtw_get_stainfo()'.
If 'rtw_get_stainfo()' returns NULL and the flow of control reaches
the 'else i
From: Navid Emamdoost
[ Upstream commit ca312438cf176a16d4b89350cade8789ba8d7133 ]
In rtl8192_tx on error handling path allocated urbs and also skb should
be released.
Signed-off-by: Navid Emamdoost
Link: https://lore.kernel.org/r/20190920025137.29407-1-navid.emamdo...@gmail.com
Signed-off-by:
From: Sergio Paracuellos
[ Upstream commit 3b2fa0c92686562ac0b8cf00c0326a45814f8e18 ]
Some versions of SoC MT7621 have three PCI express hosts. Some boards
make use of those PCI through the staging driver mt7621-pci. Recently
PCI support has been removed from MT7621 Soc kernel configuration due
From: Andy Shevchenko
[ Upstream commit 21f585480deb4bcf0d92b08879c35d066dfee030 ]
New GCC warns about inappropriate use of strncpy():
drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_framebuffer_alloc’:
drivers/staging/fbtft/fbtft-core.c:665:2: warning: ‘strncpy’ specified bound 16
equa
From: Jernej Skrabec
[ Upstream commit 1fd50a2c294457508f06b8b631d01a58de81cdd2 ]
Accessing capture queue structue directly is not safe. Use helpers for
that.
Acked-by: Paul Kocialkowski
Signed-off-by: Jernej Skrabec
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
Signed-of
From: Fabio Estevam
[ Upstream commit ce22c6f242b6d7b5e0318da2c92b5b00b5bbc698 ]
Currently v4l2-compliance tool returns the following output:
Compliance test for imx-media-captu device /dev/video0:
Driver Info:
Driver name : imx-media-captu
Card type: imx-media-cap
From: Adham Abozaeid
[ Upstream commit 6df6f3849bb8f317bf2d52711aacea4292237ede ]
When killing hostapd, the interface is closed which deinitializes the
device, then change virtual interface is called.
This change checks if the device is initialized before sending the
interface change command to
From: Paul Kocialkowski
[ Upstream commit 06eff2150d4db991ca236f3d05a9dc0101475aea ]
We need to shift and mask values at different occasions to fill up
cedrus registers. This was done using macros that don't explicitly
treat arguments as unsigned, leading to possibly undefined behavior.
Introdu
From: Dan Carpenter
[ Upstream commit d59dc92f1bccd5acde793aebdbb4f7121cf3f9af ]
The "rates_len" value needs to be capped so that the memcpy() doesn't
copy beyond the end of the array.
Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: Dan Carpenter
Reviewed-b
From: Chuhong Yuan
[ Upstream commit a0219deefe9ee5006a28d48522f76b217d198c51 ]
devm_regulator_get may return an error but mipi_csis_phy_init misses
a check for it.
This may lead to problems when regulator_set_voltage uses the unchecked
pointer.
This patch adds a check for devm_regulator_get to
From: Chuhong Yuan
[ Upstream commit a96de139301385e5992768c0f60240ddfbb33325 ]
ad9834_probe misses a check for devm_clk_get and may cause problems.
Add a check like what ad9832 does to fix it.
Signed-off-by: Chuhong Yuan
Reviewed-by: Dan Carpenter
Reviewed-by: Alexandru Ardelean
Signed-off-
From: Paul Burton
[ Upstream commit 17a29fea086ba18b000d28439bd5cb4f2b0a527b ]
When building for a non-Cavium MIPS system with COMPILE_TEST=y, the
Octeon ethernet driver hits a number of issues due to use of macros
provided only for CONFIG_CAVIUM_OCTEON_SOC=y configurations. For
example:
driv
From: Hans Verkuil
[ Upstream commit ae0688f659adb17ae6ae5710c886b20b5406e5c4 ]
Fixes this compliance warning:
$ v4l2-compliance -m0
v4l2-compliance SHA: b514d615166bdc0901a4c71261b87db31e89f464, 32 bits
Compliance test for cedrus device /dev/media0:
Media Driver Info:
Driver name
From: Navid Emamdoost
[ Upstream commit ca312438cf176a16d4b89350cade8789ba8d7133 ]
In rtl8192_tx on error handling path allocated urbs and also skb should
be released.
Signed-off-by: Navid Emamdoost
Link: https://lore.kernel.org/r/20190920025137.29407-1-navid.emamdo...@gmail.com
Signed-off-by:
From: Connor Kuehl
[ Upstream commit 228241944a48113470d3c3b46c88ba7fbe0a274b ]
Inside a nested 'else' block at the beginning of this function is a
call that assigns 'psta' to the return value of 'rtw_get_stainfo()'.
If 'rtw_get_stainfo()' returns NULL and the flow of control reaches
the 'else i
On Tue, Dec 10, 2019 at 10:19 AM Greg Kroah-Hartman
wrote:
>
> On Mon, Dec 09, 2019 at 04:11:13PM +0100, Arnd Bergmann wrote:
> > As described in drivers/staging/isdn/TODO, the drivers are all
> > assumed to be unmaintained and unused now, with gigaset being the
> > last one to stop being maintain
On Tue, Dec 10, 2019 at 09:31:54PM +0200, Aaro Koskinen wrote:
> Hi,
>
> On Tue, Dec 10, 2019 at 10:15:09AM +0100, Greg Kroah-Hartman wrote:
> > This driver was merged back in 2013 and shows no progress toward every
> > being merged into the "correct" part of the kernel.
>
> Do you mean all the p
On Tue, Dec 10, 2019 at 09:46:59PM +0200, Aaro Koskinen wrote:
> On Tue, Dec 10, 2019 at 01:01:20PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Dec 10, 2019 at 12:40:54PM +0100, Sandro Volery wrote:
> > > Doesn't octeon have drivers out of staging already?
> > > What is this module for?
> >
> > I
On Tue, Dec 10, 2019 at 09:00:52PM +0100, Arnd Bergmann wrote:
> The move to staging lost an important dependency:
>
> ERROR: "eth_validate_addr" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "eth_mac_addr" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "alloc_etherdev_mqs" [drivers/staging
The move to staging lost an important dependency:
ERROR: "eth_validate_addr" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "eth_mac_addr" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "alloc_etherdev_mqs" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "register_netdev" [drivers/staging/hp/hp1
On Tue, Dec 10, 2019 at 01:01:20PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Dec 10, 2019 at 12:40:54PM +0100, Sandro Volery wrote:
> > Doesn't octeon have drivers out of staging already?
> > What is this module for?
>
> I have no idea :(
It's stated in the TODO file you are deleting (visible in
Hi,
On Tue, Dec 10, 2019 at 10:15:09AM +0100, Greg Kroah-Hartman wrote:
> This driver was merged back in 2013 and shows no progress toward every
> being merged into the "correct" part of the kernel.
Do you mean all the patches since 2013 were "no progress"? Thanks.
> The code doesn't even build
On Sun, Dec 08, 2019 at 02:28:59PM +0100, Sven Leykauf wrote:
> Change names of variables and functions into proper names,
> according to coding style.
Do one thing at a time here. Like just the functions in a single file.
Or a single structure's fields. As it is, this is impossible to review
an
On Tue, Dec 10, 2019 at 03:04:30PM +0100, Julian Preis wrote:
> Fix spelling mistakes in exfat_core.c and exfat_super.c.
>
> Co-developed-by: Johannes Weidner
> Signed-off-by: Johannes Weidner
> Signed-off-by: Julian Preis
> ---
> drivers/staging/exfat/exfat_core.c | 6 +++---
> drivers/stag
On Tue, Dec 10, 2019 at 03:13:52PM +0100, Takashi Iwai wrote:
> Hi,
>
> this is a patch set to adapt the latest ALSA PCM API to staging
> drivers. Basically these are merely cleanups, as shown in diffstat,
> and there should be no functional changes.
>
> As the corresponding ALSA PCM API change
PCM core deals the empty ioctl field now as default.
Let's kill the redundant lines.
Signed-off-by: Takashi Iwai
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
b/drivers
PCM core deals the empty ioctl field now as default.
Let's kill the redundant lines.
Signed-off-by: Takashi Iwai
---
drivers/staging/most/sound/sound.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/most/sound/sound.c
b/drivers/staging/most/sound/sound.c
index 7c212c0db980..
Hi,
this is a patch set to adapt the latest ALSA PCM API to staging
drivers. Basically these are merely cleanups, as shown in diffstat,
and there should be no functional changes.
As the corresponding ALSA PCM API change is found in 5.5-rc1, please
apply these on 5.5-rc1 or later. Or if you pref
Clean up the driver with the new managed buffer allocation API.
The hw_params and hw_free callbacks became superfluous and dropped.
Signed-off-by: Takashi Iwai
---
.../staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
dif
Clean up the driver with the new managed buffer allocation API.
Also remove the unnecessary checks of channels in hw_params callback
as this is guaranteed by the hw constraints in anyway.
After these cleanups, the hw_params and hw_free callbacks became
empty, hence dropped.
Signed-off-by: Takashi
On Sun, Dec 08, 2019 at 02:28:53PM +0100, Sven Leykauf wrote:
> /*
> - * sii164GetDeviceID
> + * sii164_get_gevice_id
"device" instead of "gevice".
regards,
dan capenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdrive
Rename every instance of to
in file exfat_super.c. Fix resulting overlong lines.
Co-developed-by: Johannes Weidner
Signed-off-by: Johannes Weidner
Signed-off-by: Julian Preis
---
drivers/staging/exfat/exfat_super.c | 99 +++--
1 file changed, 51 insertions(+), 48 dele
Fix spelling mistakes in exfat_core.c and exfat_super.c.
Co-developed-by: Johannes Weidner
Signed-off-by: Johannes Weidner
Signed-off-by: Julian Preis
---
drivers/staging/exfat/exfat_core.c | 6 +++---
drivers/staging/exfat/exfat_super.c | 10 +-
2 files changed, 8 insertions(+), 8 d
On Tue, Dec 10, 2019 at 9:59 AM Martin Schiller wrote:
> On 2019-12-09 20:26, Arnd Bergmann wrote:
> > On Mon, Dec 9, 2019 at 7:29 PM David Miller
> > wrote:
> >>
> >> From: Arnd Bergmann
> >> Date: Mon, 9 Dec 2019 16:12:56 +0100
> >>
> >> > syzbot keeps finding issues in the X.25 implementatio
Well if documentation is missing then it's their fault..
Go ahead and delete it, even tho it kills me since my first
patch was in there :)
Sandro V
> On 10 Dec 2019, at 13:01, Greg Kroah-Hartman
> wrote:
>
> On Tue, Dec 10, 2019 at 12:40:54PM +0100, Sandro Volery wrote:
>> Doesn't octeon h
On Tue, Dec 10, 2019 at 12:40:54PM +0100, Sandro Volery wrote:
> Doesn't octeon have drivers out of staging already?
> What is this module for?
I have no idea :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org
We had quite a few drivers using the first alternate setting instead of
the current one when doing descriptor sanity checks. This is mostly an
issue on kernels with panic_on_warn set due to a WARN() in
usb_submit_urb(), but since we've started backporting such fixes (e.g.
as reported by syzbot), I'
Make sure to use the current alternate setting when verifying the
interface descriptors to avoid binding to an invalid interface.
Failing to do so could cause the driver to misbehave or trigger a WARN()
in usb_submit_urb() that kernels with panic_on_warn set would choke on.
Fixes: 2865d42c78a9 ("
Make sure to use the current alternate setting when verifying the
interface descriptors to avoid binding to an invalid interface.
Failing to do so could cause the driver to misbehave or trigger a WARN()
in usb_submit_urb() that kernels with panic_on_warn set would choke on.
Fixes: c2478d39076b ("
On 10/12/2019 09:14, Chuhong Yuan wrote:
comedi_test_init() forgets to return error when it fails.
Modify the return value to fix it.
Fixes: 9ff7400bd38c ("Staging: comedi: drivers: comedi_test: Add auto-configuration
capability")
Signed-off-by: Chuhong Yuan
---
drivers/staging/comedi/driver
On 12/10/19 1:15 AM, Greg Kroah-Hartman wrote:
This driver has been in the tree since 2009 with no real movement to get
it out. Now it is starting to cause build issues and other problems for
people who want to fix coding style problems, but can not actually build
it.
As nothing is happening he
On Mon, Dec 09, 2019 at 01:25:17PM +, christian.gr...@microchip.com wrote:
> On Fr, 2019-12-06 at 15:35 +0100, Greg KH wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> >
> > On Mon, Nov 25, 2019 at 04:51:32PM +0100, Christian Gromm wro
On Mon, Dec 02, 2019 at 03:55:17PM +0100, Julian Preis wrote:
> Fix spelling mistakes in exfat_core.c and exfat_super.c.
>
> Co-developed-by: Johannes Weidner
> Signed-off-by: Johannes Weidner
> Signed-off-by: Julian Preis
> ---
> drivers/staging/exfat/exfat_core.c | 6 +++---
> drivers/stag
On Tue, Dec 03, 2019 at 07:10:26PM +, adham.aboza...@microchip.com wrote:
>
>
> On 11/25/19 2:26 AM, Julian Calaby wrote:
> > Hi Adham,
> >
> > The OOB interrupt is a GPIO and this is an SDIO card, so why not just
> > set the relevant pin in the devicetree and detect it based on that?
> >
> >
On Mon, Dec 09, 2019 at 04:11:13PM +0100, Arnd Bergmann wrote:
> As described in drivers/staging/isdn/TODO, the drivers are all
> assumed to be unmaintained and unused now, with gigaset being the
> last one to stop being maintained after Paul Bolle lost access
> to an ISDN network.
>
> The CAPI su
comedi_test_init() forgets to return error when it fails.
Modify the return value to fix it.
Fixes: 9ff7400bd38c ("Staging: comedi: drivers: comedi_test: Add
auto-configuration capability")
Signed-off-by: Chuhong Yuan
---
drivers/staging/comedi/drivers/comedi_test.c | 4 +++-
1 file changed, 3
On 2019-12-09 20:26, Arnd Bergmann wrote:
On Mon, Dec 9, 2019 at 7:29 PM David Miller
wrote:
From: Arnd Bergmann
Date: Mon, 9 Dec 2019 16:12:56 +0100
> syzbot keeps finding issues in the X.25 implementation that nobody is
> interested in fixing. Given that all the x25 patches of the past y
68 matches
Mail list logo
