Re: [PATCH] staging: qlge: unify multi-line string

2020-02-21 Thread Joe Perches
On Sat, 2020-02-22 at 00:20 +0530, Kaaira Gupta wrote: > Fix checkpatch.pl warning of 'quoted string split across lines' in > qlge_dbg.c by merging the strings in one line. Fixing this warning is > necessary to ease grep-ing the source for printk. [] > diff --git a/drivers/staging/qlge/qlge_dbg.c b

Re: [PATCH] staging: qlge: add braces on all arms of if-else

2020-02-21 Thread Gustavo A. R. Silva
On 2/21/20 14:29, Kaaira Gupta wrote: > fix all checkpatch.pl warnings of 'braces {} should be used on all arms > of this statement' in the file qlge_ethtool.c by adding the braces. > > Signed-off-by: Kaaira Gupta Acked-by: Gustavo A. R. Silva Thanks for you patch. -- Gustavo > --- > driv

Re: [GIT PULL] Staging driver fixes for 5.6-rc3

2020-02-21 Thread pr-tracker-bot
The pull request you sent on Fri, 21 Feb 2020 12:39:52 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > tags/staging-5.6-rc3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e5553ac71e584c3aa443e211ca2afded6071b5b6 Thank you! -- Deet-doot-d

[PATCH] staging: qlge: add braces on all arms of if-else

2020-02-21 Thread Kaaira Gupta
fix all checkpatch.pl warnings of 'braces {} should be used on all arms of this statement' in the file qlge_ethtool.c by adding the braces. Signed-off-by: Kaaira Gupta --- drivers/staging/qlge/qlge_ethtool.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/

[PATCH] staging: qlge: add braces around macro arguments

2020-02-21 Thread Kaaira Gupta
Fix checkpatch.pl warnings of adding braces around macro arguments to prevent precedence issues by adding braces in qlge_dbg.c Signed-off-by: Kaaira Gupta --- drivers/staging/qlge/qlge_dbg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c

[PATCH] staging: qlge: unify multi-line string

2020-02-21 Thread Kaaira Gupta
Fix checkpatch.pl warning of 'quoted string split across lines' in qlge_dbg.c by merging the strings in one line. Fixing this warning is necessary to ease grep-ing the source for printk. Signed-off-by: Kaaira Gupta --- drivers/staging/qlge/qlge_dbg.c | 20 ++-- 1 file changed, 10

注意:所有者のメールアドレス

2020-02-21 Thread vera nica
注意:所有者のメールアドレス このプログラムは、中国のスロバキアで詐欺の被害者のためにトーゴフォーレグナシンベ大統領によって開始されました。 あなたのメールアドレスとあなたの名前が発見され、あなたは被害者の一人として受取人の一人であり、あなたの総補償基金は300,000,000ドル(3,000米ドル)です。このお金は現在、組織振替部を通じて請求されます。 あなたがしなければならないのは、5営業日以内にあなたの資金の処理とリリースのためにロメトーゴ本部に連絡することです。 ただし、お支払いは銀行振り込みによりお客様の国の直接銀行口座に合計300,000.00ドルで送金されることにご注意く

注意:所有者のメールアドレス

2020-02-21 Thread vera nica
注意:所有者のメールアドレス このプログラムは、中国のスロバキアで詐欺の被害者のためにトーゴフォーレグナシンベ大統領によって開始されました。 あなたのメールアドレスとあなたの名前が発見され、あなたは被害者の一人として受取人の一人であり、あなたの総補償基金は300,000,000ドル(3,000米ドル)です。このお金は現在、組織振替部を通じて請求されます。 あなたがしなければならないのは、5営業日以内にあなたの資金の処理とリリースのためにロメトーゴ本部に連絡することです。 ただし、お支払いは銀行振り込みによりお客様の国の直接銀行口座に合計300,000.00ドルで送金されることにご注意く

Re: [PATCH 3/3] staging: pi433: overlay: Convert to sugar syntax

2020-02-21 Thread Rob Herring
On Fri, Feb 21, 2020 at 6:21 AM Geert Uytterhoeven wrote: > > Using overlay sugar syntax makes the DTS overlay files easier to read > (and write). > > Signed-off-by: Geert Uytterhoeven > --- > Why are there two separate fragments for spi0? Can't they be combined? > Why do you need the spidev@1 en

[PATCH] staging: wilc1000: use YAML schemas for DT binding documentation

2020-02-21 Thread Ajay.Kathat
From: Ajay Singh Use YAML schemas for wilc1000 DT binding documentations. Currently, the files are present in '/drivers/staging/wilc1000/' but these will be moved to '/Documentation/devicetree/bindings/net/wireless/' later once the driver move out-of-staging. Signed-off-by: Ajay Singh --- .../

[PATCH 3/3] staging: pi433: overlay: Convert to sugar syntax

2020-02-21 Thread Geert Uytterhoeven
Using overlay sugar syntax makes the DTS overlay files easier to read (and write). Signed-off-by: Geert Uytterhoeven --- Why are there two separate fragments for spi0? Can't they be combined? Why do you need the spidev@1 entry? --- .../devicetree/pi433-overlay.dts | 79 -

[PATCH 1/3] staging: pi433: overlay: Fix Broadcom vendor prefix

2020-02-21 Thread Geert Uytterhoeven
checkpatch.pl says: WARNING: DT compatible string "bcm,bcm2708" appears un-documented -- check ./Documentation/devicetree/bindings/ The vendor prefix of Broadcom Corporation is "brcm", not "bcm". Signed-off-by: Geert Uytterhoeven --- Why do you need these 3 compatible values at the root of

[PATCH 2/3] staging: pi433: overlay: Fix reg-related warnings

2020-02-21 Thread Geert Uytterhoeven
When running "scripts/dtc/dtc -@ -I dts -O dtb -o pi433-overlay.dtbo.1 drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts": drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts:13.12-15.6: Warning (unit_address_vs_reg): /fragment@0/__overlay__/spidev@0: node has a

[PATCH 0/3] staging: pi433: overlay: Convert to sugar syntax

2020-02-21 Thread Geert Uytterhoeven
Hi all, This patch series fixes common errors in the overlay DTS for the Pi433 radio module, and converts it to overlay sugar syntax. This has not been run-tested due to lack of hardware, but I did look at the resulting changes using scripts/dtc/dtx_diff. Thanks for your comments! Geert

[GIT PULL] Staging driver fixes for 5.6-rc3

2020-02-21 Thread Greg KH
The following changes since commit bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9: Linux 5.6-rc1 (2020-02-09 16:08:48 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.6-rc3 for you to fetch changes up to 9a4556bd8f2320

[PATCH] staging: wilc1000: avoid double unlocking of 'wilc->hif_cs' mutex

2020-02-21 Thread Ajay.Kathat
From: Ajay Singh Possible double unlocking of 'wilc->hif_cs' mutex was identified by smatch [1]. Removed the extra call to release_bus() in wilc_wlan_handle_txq() which was missed in earlier commit fdc2ac1aafc6 ("staging: wilc1000: support suspend/resume functionality"). [1]. https://lists.01.o