On Thu, 2020-04-02 at 18:42 -0700, John B. Wyatt IV wrote:
> DEBUG is not actually used as far as I can tell (I am still new to
> kernel debugging systems to please correct me).
DEBUG is used by the _debug and _dbg macros
(pr_debug, dev_dbg)
___
Align two different lines of arguments with the parenthesis
of their respected function definitions. Fix style warnings
of matching alignment.
Reported by checkpatch.
Signed-off-by: John B. Wyatt IV
---
v2: Change comment title and summary
Suggested-by: Julia Lawall
On Fri, 2020-04-03 at 01:50 +0200, Stefano Brivio wrote:
> On Wed, 1 Apr 2020 19:17:06 -0700
> "John B. Wyatt IV" wrote:
>
> > Remove unused code surrounded by an #if 0 block.
> >
> > Code has not been altered since 2014 as reported by git blame.
> >
> > Reported by checkpatch.
> >
> >
Thanks Dan for your review!!
On Thu, Apr 02, 2020 at 01:29:06PM +0300, Dan Carpenter wrote:
> Looks good. Thanks!
>
> Reviewed-by: Dan Carpenter
>
> regards,
> dan carpenter
>
___
devel mailing list
de...@linuxdriverproject.org
On Wed, 1 Apr 2020 19:17:06 -0700
"John B. Wyatt IV" wrote:
> Remove unused code surrounded by an #if 0 block.
>
> Code has not been altered since 2014 as reported by git blame.
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
> ---
> drivers/staging/emxx_udc/emxx_udc.h | 6
I am Abdul Kareem working with Emirate NBD Bank Dubai,United Arab Emirate as
Sales and Marketing Officer,I have a business proposal concerning you and will
benefit we both financially,Kindly email me now for more details.
Awaiting your response.
Thanks
Abdul Kareem
mac80211 rate control decides which cck rates to use so all of
them should be set enabled at the appropriate bit rate.
This means vnt_get_cck_rate is no longer required.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6656/card.c | 38 ---
1 file changed,
mac80211 rate control decides which odfm rates to use so all of
them should be set enabled at the appropriate bit rate.
This means vnt_get_ofdm_rate is no longer required.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6656/card.c | 54 +++
1 file
The power table can replaced with calculation 0x0404090 | (power << 12)
removing array and length macro.
variable power never goes beyond the maximum setting.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6656/rf.c | 79 ++---
1 file changed, 4
On 4/2/20 9:46 PM, Helen Koike wrote:
>
>
> On 4/2/20 2:20 PM, Johan Jonker wrote:
>> Hi Helen,
>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>>> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>>> index fc0295d2a65a1..815099a0cd0dd 100644
>>> ---
On 4/2/20 2:20 PM, Johan Jonker wrote:
> Hi Helen,
>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> index fc0295d2a65a1..815099a0cd0dd 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> +++
As all known variants of the Salvator board have the HDMI decoder
chip (the ADV7482) connected to the SSI4 on R-Car SoC, the ADV7482
endpoint and the connection definitions are placed in the common board
file.
For the same reason, the CLK_C clock line and I2C configuration (similar
to the ak4613,
As the driver has some support for the audio interface of the device,
the bindings file should mention it.
Signed-off-by: Alexander Riesen
Reviewed-by: Rob Herring
Reviewed-by: Laurent Pinchart
--
v3: remove optionality off MCLK clock cell to ensure the description
matches the hardware
To avoid setting it up even if the hardware is not actually connected
to anything physically.
Besides, the bindings explicitly notes that port definitions are
"optional if they are not connected to anything at the hardware level".
Signed-off-by: Alexander Riesen
---
As there is nothing else (the consumers are supposed to do that) which
enables the clock, do it in the driver.
Signed-off-by: Alexander Riesen
--
v3: added
---
drivers/media/i2c/adv748x/adv748x-dai.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git
This adds an implemention of SoC DAI driver which provides access to the
I2S port of the device.
Signed-off-by: Alexander Riesen
--
v3: fix clock registration in case of multiple adv748x devices
Suggested-by: Geert Uytterhoeven
v4: use clk_hw instead of clk
Suggested-by: Stephen Boyd
Signed-off-by: Alexander Riesen
---
drivers/media/i2c/adv748x/adv748x.h | 32 +
1 file changed, 32 insertions(+)
diff --git a/drivers/media/i2c/adv748x/adv748x.h
b/drivers/media/i2c/adv748x/adv748x.h
index 0a9d78c2870b..1a1ea70086c6 100644
---
The regmap provides a convenient utility for this.
The hdmi_* and dpll_* register modification macros added for symmetry
with the existing operations (io_*, sdp_*).
Signed-off-by: Alexander Riesen
Reviewed-by: Laurent Pinchart
--
v3: remove _update name in favor of existing _clrset
---
To follow the established practice of not depending on others to
pull everything in. While at it, make sure it stays like this.
Signed-off-by: Alexander Riesen
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/adv748x/adv748x-afe.c | 6 ++
drivers/media/i2c/adv748x/adv748x-core.c | 6
Signed-off-by: Alexander Riesen
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/adv748x/adv748x-core.c | 24
drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +-
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/media/i2c/adv748x/adv748x-core.c
This adds minimal support for accessing the HDMI audio provided through the
I2S port available on ADV7481 and ADV7482 decoder devices by ADI.
The port carries audio signal from the decoded HDMI stream.
Currently, the driver only supports I2S in TDM, 8 channels a 24bit at 48kHz.
Furthermore, only
Hi Helen,
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index fc0295d2a65a1..815099a0cd0dd 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1718,6 +1718,33 @@ vopb_mmu:
Define the EnCFG_BBType_MASK bit as an OR operation between two previous
defines instead of using the OR between two new BIT macros. Thus, the
code is more clear.
Signed-off-by: Oscar Carter
Reviewed-by: Dan Carpenter
Reviewed-by: Quentin Deslandes
---
Changelog v1 -> v2
- Remove the "Fixes:"
On Thu, Apr 02, 2020 at 11:58:07AM +0100, Malcolm Priestley wrote:
>
>
> On 02/04/2020 10:19, Quentin Deslandes wrote:
> > On 04/01/20 18:55:38, Oscar Carter wrote:
> > > On Tue, Mar 31, 2020 at 01:29:06PM +0300, Dan Carpenter wrote:
> > > > On Sat, Mar 28, 2020 at 10:54:33AM +0100, Oscar Carter
(+Kishon)
Hi Helen,
I was wondering if we couldn't also move the phy driver out of staging.
Thanks,
Ezequiel
On Wed, 2020-04-01 at 21:02 -0300, Helen Koike wrote:
> Move phy-rockchip-dphy-rx0 bindings to Documentation/devicetree/bindings/phy
>
> Signed-off-by: Helen Koike
> ---
>
On Thursday 2 April 2020 14:42:23 CEST Dan Carpenter wrote:
> On Wed, Apr 01, 2020 at 01:03:34PM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > Add a few check on start of hif_join().
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > drivers/staging/wfx/hif_tx.c | 2 ++
> > 1
Hi,
On Thu, Apr 02, 2020 at 05:22:37PM +0300, Dan Carpenter wrote:
> On Thu, Apr 02, 2020 at 02:16:18PM +0100, Rui Miguel Silva wrote:
> > > > --- a/drivers/staging/greybus/light.c
> > > > +++ b/drivers/staging/greybus/light.c
> > > > @@ -1026,7 +1026,8 @@ static int gb_lights_light_config(struct
Geert Uytterhoeven, Thu, Apr 02, 2020 17:26:15 +0200:
> On Thu, Apr 2, 2020 at 5:03 PM Alex Riesen
> wrote:
> > Geert Uytterhoeven, Mon, Mar 30, 2020 10:32:47 +0200:
> > > On Thu, Mar 26, 2020 at 11:55 AM Alex Riesen
> > > wrote:
> > > > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>
On Thu, Apr 02, 2020 at 11:27:45AM +0300, Dan Carpenter wrote:
> I don't know how this patch made it through two versions without anyone
> complaining that this paragraph should be done as a separate patch...
I often fold comment (and spacing/formatting) patches in to a main
patch, when touching
Hi Alex,
On Thu, Apr 2, 2020 at 5:03 PM Alex Riesen wrote:
> Geert Uytterhoeven, Mon, Mar 30, 2020 10:32:47 +0200:
> > On Thu, Mar 26, 2020 at 11:55 AM Alex Riesen
> > wrote:
> > > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > > +++
Hi Geert,
I'm sorry for late reply. Some unrelated happenings here in south Germany.
Geert Uytterhoeven, Mon, Mar 30, 2020 10:32:47 +0200:
> On Thu, Mar 26, 2020 at 11:55 AM Alex Riesen
> wrote:
> > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > +++
On Thursday 2 April 2020 15:13:39 CEST Dan Carpenter wrote:
> On Wed, Apr 01, 2020 at 01:03:41PM +0200, Jerome Pouiller wrote:
[...]
> This is on the TX side so it's probably okay, but one problem I have
> noticed is that we do this on the RX side as well with checking that
>
> if
Am Donnerstag, 2. April 2020, 16:37:52 CEST schrieb Johan Jonker:
> On 4/2/20 4:31 PM, Heiko Stübner wrote:
> > Am Donnerstag, 2. April 2020, 15:48:02 CEST schrieb Johan Jonker:
> >> Hi Helen,
> >>
> >>> From: Helen Koike
> >>
> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> >>>
On Thursday 2 April 2020 15:05:26 CEST Dan Carpenter wrote:
[...]
> ^
> Not related to this this patch but this confused me initially. UINT_MAX
> would be more readable.
>
> The other unrelated question I had about this function was:
>
>402 /*
Hi Johan,
On 4/2/20 9:16 AM, Johan Jonker wrote:
> Hi Helen,
>
>> # SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> %YAML 1.2
>> ---
>> $id: http://devicetree.org/schemas/phy/rockchip-mipi-dphy-rx0.yaml#
>> $schema: http://devicetree.org/meta-schemas/core.yaml#
>>
>> title: Rockchip SoC MIPI RX0
Hi Johan,
Thanks for your review.
On 4/2/20 8:35 AM, Johan Jonker wrote:
> Hi Helen,
>
>> # SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> %YAML 1.2
>> ---
>> $id: http://devicetree.org/schemas/media/rockchip-isp1.yaml#
>> $schema: http://devicetree.org/meta-schemas/core.yaml#
>>
>
>> title:
Hi,
On 4/2/20 11:31 AM, Heiko Stübner wrote:
> Am Donnerstag, 2. April 2020, 15:48:02 CEST schrieb Johan Jonker:
>> Hi Helen,
>>
>>> From: Helen Koike
>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>>> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>>> index
On 4/2/20 4:31 PM, Heiko Stübner wrote:
> Am Donnerstag, 2. April 2020, 15:48:02 CEST schrieb Johan Jonker:
>> Hi Helen,
>>
>>> From: Helen Koike
>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>>> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>>> index 33cc21fcf4c10..fc0295d2a65a1
Am Donnerstag, 2. April 2020, 15:48:02 CEST schrieb Johan Jonker:
> Hi Helen,
>
> > From: Helen Koike
>
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > index 33cc21fcf4c10..fc0295d2a65a1 100644
> > ---
Hi Dan,
Ah sorry, ok, I will re-send the patch using git.
Can you please tell me which is the correct mailing list to where this
patch should be submitted?
Thanks,
Luís
On Thu, Apr 2, 2020 at 11:42 AM Dan Carpenter wrote:
>
> On Sun, Mar 29, 2020 at 10:59:21PM +0100, Luís Mendes wrote:
> > Fix
On Thu, Apr 02, 2020 at 02:16:18PM +0100, Rui Miguel Silva wrote:
> > > --- a/drivers/staging/greybus/light.c
> > > +++ b/drivers/staging/greybus/light.c
> > > @@ -1026,7 +1026,8 @@ static int gb_lights_light_config(struct gb_lights
> > > *glights, u8 id)
> > >
> > > light->channels_count =
Hi Helen,
> From: Helen Koike
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 33cc21fcf4c10..fc0295d2a65a1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1394,6 +1394,17
Commit a10079c66290 ("staging: remove hp100 driver") removed all files
from ./drivers/staging/hp/, but missed to adjust MAINTAINERS.
Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
warning: no file matches F: drivers/staging/hp/hp100.*
So, drop HP100 Driver entry in
Hi Dan,
On 02/04/20 1:57 pm, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Thu, Mar 26, 2020 at 03:23:36PM +, ajay.kat...@microchip.com wrote:
>> From: George Spelvin
>>
>> The code in lib/ is the desired
Hi Dan,
On Thu, Apr 02, 2020 at 03:22:28PM +0300, Dan Carpenter wrote:
> On Wed, Apr 01, 2020 at 11:00:17AM +0800, Chen Zhou wrote:
> > In gb_lights_light_config(), 'light->name' is allocated by kstrndup().
> > It returns NULL when fails, add check for it.
> >
> > Signed-off-by: Chen Zhou
> >
On Wed, Apr 01, 2020 at 01:03:41PM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller
>
> The last argument of hif_handle_tx_data() was now unused. In add,
> hif_handle_tx_data() has nothing to do with HIF layer and should be
> renamed. Finally, it not convenient to pass a wfx_vif as
On Wed, Apr 01, 2020 at 01:03:37PM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller
>
> In the old days, the driver tried to reorder frames in order to send
> frames from the same queue grouped to the firmware. However, the
> firmware is able to do the job internally for a long time. There
On Wed, Apr 01, 2020 at 01:03:34PM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller
>
> Add a few check on start of hif_join().
>
> Signed-off-by: Jérôme Pouiller
> ---
> drivers/staging/wfx/hif_tx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/wfx/hif_tx.c
Hi Dan：
Sorry. Please ignore this patch and it's based on the old code.
On 4/2/2020 7:21 PM, Dan Carpenter wrote:
This doesn't apply to today's linux-next.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
On Wed, Apr 01, 2020 at 11:00:17AM +0800, Chen Zhou wrote:
> In gb_lights_light_config(), 'light->name' is allocated by kstrndup().
> It returns NULL when fails, add check for it.
>
> Signed-off-by: Chen Zhou
> ---
> drivers/staging/greybus/light.c | 3 ++-
> 1 file changed, 2 insertions(+), 1
Hi Helen,
> # SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> %YAML 1.2
> ---
> $id: http://devicetree.org/schemas/phy/rockchip-mipi-dphy-rx0.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: Rockchip SoC MIPI RX0 D-PHY Device Tree Bindings
>
> maintainers:
> - Helen
randconfig-g002-20200401
x86_64 randconfig-g001-20200401
x86_64 randconfig-h001-20200402
x86_64 randconfig-h002-20200402
x86_64 randconfig-h003-20200402
i386 randconfig-h001-20200402
i386 randconfig-h002-20200402
Hi Helen,
> # SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> %YAML 1.2
> ---
> $id: http://devicetree.org/schemas/media/rockchip-isp1.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: Rockchip SoC Image Signal Processing unit v1
Where do we need 'v1' for? Is there a 'v2'?
This doesn't apply to today's linux-next.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
debugfs_cleanup
branch HEAD: 71280bf8796b28d6fc09ea490276d02e240948b5 powerpc: powernv: no
need to check return value of debugfs_create functions
elapsed time: 1322m
configs tested: 162
configs skipped: 0
On Thu, Apr 02, 2020 at 11:50:00AM +0100, Colin King wrote:
> From: Colin Ian King
>
> The pointer ctx is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused
On 02/04/2020 10:19, Quentin Deslandes wrote:
On 04/01/20 18:55:38, Oscar Carter wrote:
On Tue, Mar 31, 2020 at 01:29:06PM +0300, Dan Carpenter wrote:
On Sat, Mar 28, 2020 at 10:54:33AM +0100, Oscar Carter wrote:
Define the necessary bits in the CHANNEL, PAPEDELAY and GPIOCTL0
registers to
From: Colin Ian King
The pointer ctx is being initialized with a value that is never read
and it is being updated later with a new value. The initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
drivers/android/binderfs.c | 2
On Sun, Mar 29, 2020 at 10:59:21PM +0100, Luís Mendes wrote:
> Fix incongruency in handling of sysfs entries creation.
> This issue could cause invalid memory accesses, by not properly
> detecting the end of the sysfs attributes array.
>
Please add a Fixes tag.
Fixes: 84c45d5f3bf1 ("staging:
Looks good. Thanks!
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sun, Mar 29, 2020 at 12:04:50PM +0200, Michael Straube wrote:
> Refactor while loop in Efuse_GetCurrentSize() to reduce indentation
> level and clear line over 80 characters checkpatch warnings.
>
> Signed-off-by: Michael Straube
Reviewed-by: Dan Carpenter
regards,
dan carpenter
Ignore this one. John sent it by mistake and has already sent a v3.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 04/01/20 18:55:38, Oscar Carter wrote:
> On Tue, Mar 31, 2020 at 01:29:06PM +0300, Dan Carpenter wrote:
> > On Sat, Mar 28, 2020 at 10:54:33AM +0100, Oscar Carter wrote:
> > > Define the necessary bits in the CHANNEL, PAPEDELAY and GPIOCTL0
> > > registers to can use them in the calls to
Em Wed, 1 Apr 2020 13:59:49 +0300
Dan Carpenter escreveu:
> On Wed, Mar 25, 2020 at 04:36:31PM -0300, Helen Koike wrote:
> > Hello,
> >
> > On 3/25/20 1:03 PM, Mauro Carvalho Chehab wrote:
> > > That's the second part of media Kconfig changes. The entire series is
> > > at:
> > >
> > >
On Thu, Mar 26, 2020 at 03:23:36PM +, ajay.kat...@microchip.com wrote:
> From: George Spelvin
>
> The code in lib/ is the desired polynomial, and even includes
> the 1-bit left shift in the table rather than needing to code
> it explicitly.
>
> While I'm in Kconfig, add a description of
On Fri, Mar 27, 2020 at 08:08:07PM -0400, aimannajjar wrote:
> This patch fixes these two long-line checkpatch warnings
> in rtl871x_xmit.c:
>
> WARNING: line over 80 characters
> \#74: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:74:
> + * Please allocate memory with the sz = (struct
On Fri, Mar 27, 2020 at 08:08:07PM -0400, aimannajjar wrote:
> This patch fixes these two long-line checkpatch warnings
> in rtl871x_xmit.c:
>
> WARNING: line over 80 characters
> \#74: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:74:
> + * Please allocate memory with the sz = (struct
Hi Aiman,
On Sat, Mar 28, 2020 at 12:17:19PM -0700, Joe Perches wrote:
> On Fri, 2020-03-27 at 20:08 -0400, aimannajjar wrote:
>
> so these would be
>
> ether_addr_copy(pwlanhdr->addr2, pattr->src);
>
> and pwlanhdr isn't a particularly valuable name
> for an automatic
On Thu, Mar 26, 2020 at 01:56:16AM -0400, Aiman Najjar wrote:
> @@ -350,7 +351,7 @@ static int xmitframe_addmic(struct _adapter *padapter,
> struct sta_info *stainfo;
> struct qos_priv *pqospriv = &(padapter->mlmepriv.qospriv);
> struct pkt_attrib *pattrib = >attrib;
> -
On Wed, 1 Apr 2020, John B. Wyatt IV wrote:
> Fix 2 parenthesis alignment issues.
Please try to find a way to describe what you have done that doesn't
involve the word "Fix". What have you done and why?
julia
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
> ---
>
On Wed, 2020-04-01 at 22:36 -0700, John B. Wyatt IV wrote:
> Fix 4 over 80 char warnings by caching long enum values into local
> variables.
>
> All enums are only used once inside each function (and once inside
> the entire file).
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
Buenos días
Os informamos que se encuentra abierto el plazo de inscripción para la
Convocatoria de Cursos Bonificables para empleados (ABRIL 2020).
Todos los cursos son totalmente Bonificables con cargo al Crédito de Formación
2020 que disponen las empresas.
Dada la situación en la que nos
72 matches
Mail list logo
