Re: [PATCH] staging: iio: ad2s1210: Fix SPI reading

2020-05-03 Thread Ardelean, Alexandru
On Sun, 2020-05-03 at 12:37 +0100, Jonathan Cameron wrote: > [External] > > On Wed, 29 Apr 2020 10:21:29 +0300 > Alexandru Ardelean wrote: > > > From: Dragos Bogdan > > > > If the serial interface is used, the 8-bit address should be latched using > > the rising edge of the WR/FSYNC signal. >

Re: [PATCH] staging: iio: ad5933: rework probe to use devm_ function variants

2020-05-03 Thread Ardelean, Alexandru
On Sat, 2020-05-02 at 19:25 +0100, Jonathan Cameron wrote: > On Tue, 28 Apr 2020 12:31:28 +0300 > Alexandru Ardelean wrote: > > > This change cleans up the driver's probe function to use only devm_ > > function variants. This also gets rid of the remove function and moves the > > clock & regulato

Re: [PATCH v2] staging: wilc1000: Increase the size of wid_list array

2020-05-03 Thread Joe Perches
On Sun, 2020-05-03 at 14:52 +, ajay.kat...@microchip.com wrote: > On 03/05/20 1:21 pm, Oscar Carter wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Increase by one the size of wid_list array as index variable can reach a > > va

Re: Thanks For Reply???

2020-05-03 Thread Reem al-Hashimi
My name is Reem E. Al-Hashimi, the Emirates Minister of State and Managing Director of United Arab Emirates (Dubai) World Expo 2020 Committee. I am writing you to stand as my partner to receive my share of gratification from foreign companies whom I helped during the bidding exercise towards the

Re: Thanks For Reply

2020-05-03 Thread Reem al-Hashimi
My name is Reem E. Al-Hashimi, the Emirates Minister of State and Managing Director of United Arab Emirates (Dubai) World Expo 2020 Committee. I am writing you to stand as my partner to receive my share of gratification from foreign companies whom I helped during the bidding exercise towards the

[PATCH v2 1/2] staging: vt6655: return early if not bNeedAck

2020-05-03 Thread Matej Dujava
This patch will check for bNeedAck before making bb_get_frame_time call, so in case we dont need uAckTime, we can return early. Signed-off-by: Matej Dujava --- drivers/staging/vt6655/rxtx.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c

[PATCH v2 0/2] Early return in s_uGetTxRsvTime

2020-05-03 Thread Matej Dujava
This patch set will fix checkpatch LONG_LINE warnings and will save us one call of bb_get_frame_time in case od !bNeedAck. Change history: v2: Implemented advice of ternary operator from Joe Perches Matej Dujava (2): staging: vt6655: return early if not bNeedAck staging: vt6655: fix LONG_LIN

[PATCH v2 2/2] staging: vt6655: fix LONG_LINE warning

2020-05-03 Thread Matej Dujava
This patch will fix LONG_LINE error from checkpatch, by using ternary operator. Signed-off-by: Matej Dujava --- drivers/staging/vt6655/rxtx.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index dda57

[PATCH] media: atomisp: move ia_css_configure_sc() implementation

2020-05-03 Thread Mauro Carvalho Chehab
With the changes, this function is now undefined if built for ISP2400. So, move its implementation to the file which calls it. Reported-by: Francescodario Cuzzocrea Signed-off-by: Mauro Carvalho Chehab --- .../css_2401_system/hive/ia_css_isp_configs.c | 27 - .../media/atomisp/p

Re: [PATCH v2] staging: wilc1000: Increase the size of wid_list array

2020-05-03 Thread Ajay.Kathat
On 03/05/20 1:21 pm, Oscar Carter wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Increase by one the size of wid_list array as index variable can reach a > value of 5. If this happens, an out-of-bounds access is performed. > > Address

[PATCH 1/5] staging: vt6655: merge two switch cases in s_uGetDataDuration

2020-05-03 Thread Matej Dujava
This patch will reuse code for two cases. Signed-off-by: Matej Dujava --- drivers/staging/vt6655/rxtx.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 2f9c2ead3cb8..28f0cda36dec 100644 ---

[PATCH 3/5] staging: vt6655: remove else after return and invert condition

2020-05-03 Thread Matej Dujava
This patch will prepare us to make return at the end of case body Signed-off-by: Matej Dujava --- drivers/staging/vt6655/rxtx.c | 36 +-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c

[PATCH 4/5] staging: vt6655: return at the ond of case body

2020-05-03 Thread Matej Dujava
This patch will unify exit point for s_uGetDataDuration function. Signed-off-by: Matej Dujava --- drivers/staging/vt6655/rxtx.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 61f7077bb75f

[PATCH 5/5] staging: vt6655: extract index manupulation out of function call

2020-05-03 Thread Matej Dujava
This patch will remove if/else by selecting proper argument before function call, also index is updated before function call. Signed-off-by: Matej Dujava --- drivers/staging/vt6655/rxtx.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/st

[PATCH 2/5] staging: vt6655: do calculation of uAckTime first

2020-05-03 Thread Matej Dujava
This patch is extracting calculation of uAckTime in one place, at the start of case body. Signed-off-by: Matej Dujava --- drivers/staging/vt6655/rxtx.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/

[PATCH 0/5] Cleaning s_uGetDataDuration function

2020-05-03 Thread Matej Dujava
This patch set will eliminate few checkpatch LONG_LINE errors. Simplify code paths by: - returning at the end of case body - removing unnecessary else branches Matej Dujava (5): staging: vt6655: merge two switch cases in s_uGetDataDuration staging: vt6655: do calculation of uAckTime first

Re: [PATCH] staging: iio: ad2s1210: Fix SPI reading

2020-05-03 Thread Jonathan Cameron
On Wed, 29 Apr 2020 10:21:29 +0300 Alexandru Ardelean wrote: > From: Dragos Bogdan > > If the serial interface is used, the 8-bit address should be latched using > the rising edge of the WR/FSYNC signal. > > This basically means that a CS change is required between the first byte > sent, and t

Re: [PATCH 2/2] staging: vt6655: fix LONG_LINE warning

2020-05-03 Thread Matej Dujava
On Sat, May 02, 2020 at 10:11:43PM -0700, Joe Perches wrote: On Sun, 2020-05-03 at 00:16 +0200, Matej Dujava wrote: This patch will fix LONG_LINE error from checkpatch, by createing temporary variable so call to the function is not in if/else block. [] diff --git a/drivers/staging/vt6655/rxtx.

[PATCH v2] staging: wilc1000: Increase the size of wid_list array

2020-05-03 Thread Oscar Carter
Increase by one the size of wid_list array as index variable can reach a value of 5. If this happens, an out-of-bounds access is performed. Addresses-Coverity-ID: 1451981 ("Out-of-bounds access") Fixes: f5a3cb90b802d ("staging: wilc1000: add passive scan support") Signed-off-by: Oscar Carter ---

Re: [PATCH] staging: gasket: Check the return value of gasket_get_bar_index()

2020-05-03 Thread Greg Kroah-Hartman
On Sat, May 02, 2020 at 05:59:18PM -0400, Richard Yeh wrote: > Hi, as a new maintainer, I thought I would try to handle this one. Great, as a start: A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most an

Re: [PATCH] staging: wilc1000: Increase the size of wid_list array

2020-05-03 Thread Oscar Carter
On Fri, May 01, 2020 at 06:26:10PM +, ajay.kat...@microchip.com wrote: > > On 01/05/20 10:32 pm, Oscar Carter wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Increase by one the size of wid_list array as index variable can reach