[PATCH] staging: comedi: comedi_fops.c: changed type in assignment to unsigned int *

2020-07-14 Thread B K Karthik
fixed a sparse warning by changing the type in assignment from void [noderef] __user * to unsigned int * (different address space) Signed-off-by: B K Karthik --- drivers/staging/comedi/comedi_fops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: possible deadlock in shmem_fallocate (4)

2020-07-14 Thread Hillf Danton
On Tue, 14 Jul 2020 10:32:20 -0700 Suren Baghdasaryan wrote: > On Tue, Jul 14, 2020 at 9:41 AM Suren Baghdasaryan wrote: > > > > On Tue, Jul 14, 2020 at 8:47 AM Todd Kjos wrote: > > > > > > +Suren Baghdasaryan +Hridya Valsaraju who support the ashmem driver. > > > > Thanks for looping me in. >

Re: [PATCH v2] staging: gasket: core: Fix a coding style issue in gasket_core.c

2020-07-14 Thread Zhixu Zhao
On Thu, Jun 18, 2020 at 12:11:27AM +0800, Zhixu Zhao wrote: > A coding alignment issue is found by checkpatch.pl. > Fix it by using a temporary for gasket_dev->bar_data[bar_num]. > > Signed-off-by: Zhixu Zhao Hi, there~ Does anybody have any further comments on this? Can it be merged? Zhixu

Re: [PATCH 6/6] staging: qlge: qlge_ethtool: Remove one byte memset.

2020-07-14 Thread Joe Perches
On Wed, 2020-07-15 at 00:36 +0530, Suraj Upadhyay wrote: > On Tue, Jul 14, 2020 at 11:57:23AM -0700, Joe Perches wrote: > > On Mon, 2020-07-13 at 17:17 +0300, Dan Carpenter wrote: > > > On Mon, Jul 13, 2020 at 05:52:22PM +0530, Suraj Upadhyay wrote: > > > > Use direct assignment instead of using

[PATCH] staging: rtl8188eu: core: fix coding style issues

2020-07-14 Thread Arpitha
Fixing WARNING: Prefer using '"%s...", __func__' to using 'function_name' in a string in rtw_ioctl_set.c Signed-off-by: Arpitha <98.a...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: possible deadlock in shmem_fallocate (4)

2020-07-14 Thread Suren Baghdasaryan
On Tue, Jul 14, 2020 at 8:47 AM Todd Kjos wrote: > > +Suren Baghdasaryan +Hridya Valsaraju who support the ashmem driver. Thanks for looping me in. > > > On Tue, Jul 14, 2020 at 7:18 AM Michal Hocko wrote: > > > > On Tue 14-07-20 22:08:59, Hillf Danton wrote: > > > > > > On Tue, 14 Jul 2020

Re: [PATCH 6/6] staging: qlge: qlge_ethtool: Remove one byte memset.

2020-07-14 Thread Suraj Upadhyay
On Tue, Jul 14, 2020 at 12:22:05PM -0700, Joe Perches wrote: > On Wed, 2020-07-15 at 00:36 +0530, Suraj Upadhyay wrote: > > On Tue, Jul 14, 2020 at 11:57:23AM -0700, Joe Perches wrote: > > > On Mon, 2020-07-13 at 17:17 +0300, Dan Carpenter wrote: > > > > On Mon, Jul 13, 2020 at 05:52:22PM +0530,

Re: [PATCH 6/6] staging: qlge: qlge_ethtool: Remove one byte memset.

2020-07-14 Thread Suraj Upadhyay
On Tue, Jul 14, 2020 at 11:57:23AM -0700, Joe Perches wrote: > On Mon, 2020-07-13 at 17:17 +0300, Dan Carpenter wrote: > > On Mon, Jul 13, 2020 at 05:52:22PM +0530, Suraj Upadhyay wrote: > > > Use direct assignment instead of using memset with just one byte as an > > > argument. > > > Issue found

Re: [PATCH 6/6] staging: qlge: qlge_ethtool: Remove one byte memset.

2020-07-14 Thread Joe Perches
On Mon, 2020-07-13 at 17:17 +0300, Dan Carpenter wrote: > On Mon, Jul 13, 2020 at 05:52:22PM +0530, Suraj Upadhyay wrote: > > Use direct assignment instead of using memset with just one byte as an > > argument. > > Issue found by checkpatch.pl. > > > > Signed-off-by: Suraj Upadhyay > > --- > >

Re: [PATCH] drivers: staging: media: atomisp: pci: css_2401_system: host: csi_rx.c: fixed a sparse warning by making undeclared symbols static

2020-07-14 Thread kernel test robot
-static/20200714-212512 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git caaba08f8c0dbe5c8fcb497faa7e3b394c21ff39 config: x86_64-allyesconfig (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8

[PATCH v2] staging: media: atomisp: mark some csi_rx.c symbols static

2020-07-14 Thread B K Karthik
changed symbols N_SHORT_PACKET_LUT_ENTRIES, N_LONG_PACKET_ENTRIES, N_CSI_RX_FE_CTRL_DLANES, N_CSI_RX_BE_SID_WIDTH to static because they were not declared earlier. Signed-off-by: B K Karthik --- .../media/atomisp/pci/css_2401_system/host/csi_rx.c | 8 1 file changed, 4

Re: possible deadlock in shmem_fallocate (4)

2020-07-14 Thread Hillf Danton
On Tue, 14 Jul 2020 10:26:29 +0200 Michal Hocko wrote: > On Tue 14-07-20 13:32:05, Hillf Danton wrote: > > > > On Mon, 13 Jul 2020 20:41:11 -0700 Eric Biggers wrote: > > > On Tue, Jul 14, 2020 at 11:32:52AM +0800, Hillf Danton wrote: > > > > > > > > Add FALLOC_FL_NOBLOCK and on the shmem side

Re: possible deadlock in shmem_fallocate (4)

2020-07-14 Thread Michal Hocko
On Tue 14-07-20 22:08:59, Hillf Danton wrote: > > On Tue, 14 Jul 2020 10:26:29 +0200 Michal Hocko wrote: > > On Tue 14-07-20 13:32:05, Hillf Danton wrote: > > > > > > On Mon, 13 Jul 2020 20:41:11 -0700 Eric Biggers wrote: > > > > On Tue, Jul 14, 2020 at 11:32:52AM +0800, Hillf Danton wrote: > >

Re: [PATCH] drivers: staging: media: atomisp: pci: css_2401_system: host: csi_rx.c: fixed a sparse warning by making undeclared symbols static

2020-07-14 Thread Greg Kroah-Hartman
On Tue, Jul 14, 2020 at 09:23:50AM -0400, B K Karthik wrote: > changed symbols N_SHORT_PACKET_LUT_ENTRIES, N_LONG_PACKET_ENTRIES, > N_CSI_RX_FE_CTRL_DLANES, N_CSI_RX_BE_SID_WIDTH to static because they > were not declared earlier. Your subject line is a little bit crazy long. Perhaps just:

[PATCH 5/6] staging: dpaa2-ethsw: store version information of the DPSW object

2020-07-14 Thread Ioana Ciornei
Store the major and minor versions of the DPSW object in the ethsw structure. This will be used in a subsequent patch to make sure some commands are only called on the appropriate version of object. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 16

[PATCH 1/6] staging: dpaa2-ethsw: fix reported link state

2020-07-14 Thread Ioana Ciornei
On the .ndo_open() callback set netif_carrier_off() until the link state interrupt is received so that the LOWER_UP flag does not show up incorrectly in the output of 'ip link show'. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 7 +++ 1 file changed, 7

[PATCH 0/6] staging: dpaa2-ethsw: cleanup of link state and MAC addresses

2020-07-14 Thread Ioana Ciornei
This patch set is cleaning up the link state handling of the switch ports in patches 1-4. The last two patches are setting up the MAC addresses of the switch ports automatically so that the user is not forced to manually add them before adding them to a bridge. Ioana Ciornei (6): staging:

[PATCH 2/6] staging: dpaa2-ethsw: ignore state interrupts when the interface is not running

2020-07-14 Thread Ioana Ciornei
Link state interrupts will be transmitted to the DPSW object even though the user has not yet issued a 'ifconfig up' on a switch interface. Don't act on those interrupts since there are of no interrest. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++ 1 file

[PATCH 4/6] staging: dpaa2-ethsw: disable switch ports are probe time

2020-07-14 Thread Ioana Ciornei
The MC firmware will enable the switch interfaces at DPSW creation without waiting for an 'ifconfig up' on the switch interfaces. When this happens, the states held by the Linux software vs the firmware are not in sync. Make sure to disable the switch ports at probe time to not encounter this

[PATCH 6/6] staging: dpaa2-ethsw: setup MAC address of switch netdevices

2020-07-14 Thread Ioana Ciornei
At probe time, retrieve the MAC addresses of the switch ports using a firmware call and use that to setup the switch interface net_device instead of relying entirely on the user to configure a MAC address on the interface. In case a switch interface is not connected to a MAC, thus the

[PATCH 3/6] staging: dpaa2-ethsw: use netif_running when checking for port up

2020-07-14 Thread Ioana Ciornei
There are some cases where the switch interface needs to be disabled so that changes in the configuration can be made. In such cases, we should check for a running interface (bit __LINK_STATE_START of the netdev) instead of netif_carrier_ok(). This is because on open() we enable the switch

[PATCH] drivers: staging: media: atomisp: pci: css_2401_system: host: csi_rx.c: fixed a sparse warning by making undeclared symbols static

2020-07-14 Thread B K Karthik
changed symbols N_SHORT_PACKET_LUT_ENTRIES, N_LONG_PACKET_ENTRIES, N_CSI_RX_FE_CTRL_DLANES, N_CSI_RX_BE_SID_WIDTH to static because they were not declared earlier. Signed-off-by: B K Karthik --- .../media/atomisp/pci/css_2401_system/host/csi_rx.c | 8 1 file changed, 4

[PATCH] media: atomisp: Fix error code in ov5693_probe()

2020-07-14 Thread Dan Carpenter
If gmin_camera_platform_data() returns NULL then we should return a negative error instead of success. Fixes: 90ebe55ab886 ("media: staging: atomisp: Add driver prefix to Kconfig option and module names") Signed-off-by: Dan Carpenter ---

[driver-core:driver-core-linus] BUILD SUCCESS 2451e746478a6a6e981cfa66b62b791ca93b90c8

2020-07-14 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-linus branch HEAD: 2451e746478a6a6e981cfa66b62b791ca93b90c8 driver core: Avoid deferred probe due to fw_devlink_pause/resume() elapsed time: 5510m configs tested: 122 configs skipped: 1 The

[staging:staging-testing] BUILD SUCCESS caaba08f8c0dbe5c8fcb497faa7e3b394c21ff39

2020-07-14 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: caaba08f8c0dbe5c8fcb497faa7e3b394c21ff39 staging: qlge: qlge_ethtool: Remove one byte memset. elapsed time: 1239m configs tested: 150 configs skipped: 14 The following configs have

[staging:staging-linus] BUILD SUCCESS ef75e14a6c935eec82abac07ab68e388514e39bc

2020-07-14 Thread kernel test robot
-a016-20200712 i386 randconfig-a015-20200712 i386 randconfig-a011-20200712 i386 randconfig-a012-20200712 i386 randconfig-a013-20200712 i386 randconfig-a014-20200712 i386 randconfig-a016-20200714 i386

[staging:staging-next] BUILD SUCCESS cb22ab20c969615296475b7068c891ca3a849fa9

2020-07-14 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next branch HEAD: cb22ab20c969615296475b7068c891ca3a849fa9 staging: rtl8712/: Using comparison to true is error prone elapsed time: 3059m configs tested: 122 configs skipped: 4 The following configs have

[driver-core:driver-core-testing] BUILD SUCCESS da6d647598a6d182eb6a0344a7b14ae005244399

2020-07-14 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing branch HEAD: da6d647598a6d182eb6a0344a7b14ae005244399 driver core: Add waiting_for_supplier sysfs file for devices elapsed time: 5506m configs tested: 134 configs skipped: 4 The

Re: [PATCH v2] staging: comedi: s626: Remove pci-dma-compat wrapper APIs.

2020-07-14 Thread Ian Abbott
On 13/07/2020 15:32, Suraj Upadhyay wrote: The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below

Re: possible deadlock in shmem_fallocate (4)

2020-07-14 Thread Michal Hocko
On Tue 14-07-20 13:32:05, Hillf Danton wrote: > > On Mon, 13 Jul 2020 20:41:11 -0700 Eric Biggers wrote: > > On Tue, Jul 14, 2020 at 11:32:52AM +0800, Hillf Danton wrote: > > > > > > Add FALLOC_FL_NOBLOCK and on the shmem side try to lock inode upon the > > > new flag. And the overall upside is

[no subject]

2020-07-14 Thread Mrs Nicole Marois Benoite
Dear Beloved I am Mrs Nicole Benoite Marois and i have been suffering from ovarian cancer disease and the doctor says that i have just few days to leave. I am from (Paris) France but based in Africa Burkina Faso since eight years ago as a business woman dealing with gold exportation. Now that i