On Wed, Jul 15, 2020 at 10:45 PM Suren Baghdasaryan wrote:
>
> syzbot report [1] describes a deadlock when write operation against an
> ashmem fd executed at the time when ashmem is shrinking its cache results
> in the following lock sequence:
>
> Possible unsafe locking scenario:
>
>
Make use of the flex_array_size() helper to calculate the size of a
flexible array member within an enclosing structure.
This helper offers defense-in-depth against potential integer
overflows, while at the same time makes it explicitly clear that
we are dealing with a flexible array member.
Hi Dhiraj,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url:
https://github.com/0day-ci/linux/commits/Dhiraj-Sharma/staging-android-ashmem-used-const-keyword/20200729-020222
base: https://git.kernel.org/pub/scm/linux/kernel/git
Hi Dhiraj,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url:
https://github.com/0day-ci/linux/commits/Dhiraj-Sharma/staging-android-ashmem-used-const-keyword/20200729-020222
base: https://git.kernel.org/pub/scm/linux/kernel/git
Clean up multiline function declartions in hal_phy_cfg.h
to improve code readablility
Signed-off-by: Aditya Jain
---
.../staging/rtl8723bs/include/hal_phy_cfg.h | 110 +-
1 file changed, 29 insertions(+), 81 deletions(-)
diff --git
Adjust spacing in macro definitions to align them and improve
readbility
Signed-off-by: Aditya Jain
---
drivers/staging/rtl8723bs/include/hal_phy_cfg.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
Fixing ERROR: "foo *bar" should be "foo *bar" in hal_phy_cfg.h
as reported by checkpatch.pl
Signed-off-by: Aditya Jain
---
.../staging/rtl8723bs/include/hal_phy_cfg.h| 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git
Hey everyone,
Following the comments received I've updated the patch.
The patch cleans up coding style issues in the file
drivers/staging/rtl8723bs/include/hal_phy_cfg.h
Changelog:
v1:
Fixed ERROR: "foo * bar" should be "foo *bar" reported by
checkpatch.pl
v1 -> v2:
Cleaned up multiline
On Wed, 2020-07-29 at 16:27 +0200, Greg KH wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> On Mon, Jul 27, 2020 at 10:30:46AM +0200, Christian Gromm wrote:
> > This patch adds the usb driver source file most_usb.c and
> > modifies the
On Wed, Jul 29, 2020 at 2:19 AM Christoph Hellwig wrote:
>
> On Tue, Jul 28, 2020 at 02:24:51PM -0400, Jim Quinlan wrote:
> > I started using devm_kcalloc() but at least two reviewers convinced me
> > to just use kcalloc(). In addition, when I was using devm_kcalloc()
> > it was awkward because
On Wed, Jul 29, 2020 at 06:38:48PM +0200, Christian Gromm wrote:
> To avoid a name conflict when adding the usb module to the
> driver's directory in the stable branch, this patch simply
> renames the kernel object.
>
> Signed-off-by: Christian Gromm
> Reported-by: Greg Kroah-Hartman
> ---
>
On Wed, Jul 29, 2020 at 5:00 PM Cengiz Can wrote:
>
> `find_gmin_subdev` function that returns a pointer to `struct
> gmin_subdev` can return NULL.
>
> In `gmin_v2p8_ctrl` there's a call to this function but the possibility
> of a NULL was not checked before its being dereferenced. ie:
>
> ```
>
On Wed, Jul 29, 2020 at 02:53:29PM +, christian.gr...@microchip.com wrote:
> On Wed, 2020-07-29 at 16:27 +0200, Greg KH wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> >
> > On Mon, Jul 27, 2020 at 10:30:46AM +0200, Christian Gromm
On Wed, Jul 29, 2020 at 12:19 AM Christoph Hellwig wrote:
>
> On Tue, Jul 28, 2020 at 02:24:51PM -0400, Jim Quinlan wrote:
> > I started using devm_kcalloc() but at least two reviewers convinced me
> > to just use kcalloc(). In addition, when I was using devm_kcalloc()
> > it was awkward because
On Mon, Jul 27, 2020 at 10:30:46AM +0200, Christian Gromm wrote:
> This patch adds the usb driver source file most_usb.c and
> modifies the Makefile and Kconfig accordingly.
>
> Signed-off-by: Christian Gromm
Sorry for the long delay in getting to this.
This looks good to me, but I tried to
`find_gmin_subdev` function that returns a pointer to `struct
gmin_subdev` can return NULL.
In `gmin_v2p8_ctrl` there's a call to this function but the possibility
of a NULL was not checked before its being dereferenced. ie:
```
/* Acquired here v */
struct gmin_subdev *gs =
On Wed, Jul 29, 2020 at 01:19:50PM +0530, Ankit Baluni wrote:
> Removed braces for a 'if' condition as it contain only single line &
> there is no need for braces for such case according to coding style
> rules.
Reviewed-by: Andy Shevchenko
> Signed-off-by: Ankit Baluni
>
> ---
> Changes in
On Wed, Jul 29, 2020 at 11:12 AM Ankit Baluni
wrote:
>
> Added a missing comma and changed 'it it useful' to 'it is useful'.
Reviewed-by: Andy Shevchenko
> Signed-off-by: Ankit Baluni
> ---
> Changes in -v2:
> -Remove space before ':' in subject line.
>
>
From: Colin Ian King
The variable ret is being assigned an error return value that is never
read, the control passes to a return statement and ret is never referenced.
Remove the redundant assignment. Also remove an empty line.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
Added a missing comma and changed 'it it useful' to 'it is useful'.
Signed-off-by: Ankit Baluni
---
Changes in -v2:
-Remove space before ':' in subject line.
drivers/staging/iio/Documentation/overview.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Removed braces in 'if else' condition as it only consists of
one line each and according to coding style rules , in this case
the braces are not required.
Signed-off-by: Ankit Baluni
---
Change in -v2:
-Removed space before ':' in subject line.
-Added space before '<' in 'From'
Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.
Signed-off-by: Ankit Baluni
---
Changes in v2:
-Added more description about the patch.
-Added space before the symobol '<' in 'From'
Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.
Signed-off-by: Ankit Baluni
---
Change in -v2:
-Remove space before ':' in subject .
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 3 +--
1
On Wed, Jul 29, 2020 at 01:09:02PM +0530, Ankit Baluni wrote:
> Removed braces for a 'if' condition as it contain only single line &
> there is no need for braces for such case according to coding style
> rules.
>
> Signed-off-by: Ankit Baluni
>
> ---
> Changes in v2:
> -Added more
Buenos días
Se encuentra abierto el plazo de inscripción de Cursos Bonificables para
empleados en activo y en situación de ERTE (AGOSTO 2020)
Todos los cursos son Bonificables con cargo al Crédito de Formación 2020.
Deseáis que os mandemos la información?
Saludos cordiales.
Alex Pons
Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.
Signed-off-by: Ankit Baluni
---
Changes in v2:
-Added more description about the patch.
-Added space before the symobol '<' in 'From'
Added a missing comma and changed 'it it useful' to 'it is useful'.
Signed-off-by: Ankit Baluni
---
Changes in -v2:
-Remove space before ':' in subject line.
drivers/staging/iio/Documentation/overview.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Wed, Jul 29, 2020 at 3:34 AM Ankit Baluni
wrote:
>
> Added a missing comma and changed 'it it useful' to 'it is useful'.
Please, drop spaces before : in the subject line. In all patches you
submitted there is such an issue.
--
With Best Regards,
Andy Shevchenko
On Tue, Jul 28, 2020 at 02:24:51PM -0400, Jim Quinlan wrote:
> I started using devm_kcalloc() but at least two reviewers convinced me
> to just use kcalloc(). In addition, when I was using devm_kcalloc()
> it was awkward because 'dev' is not available to this function.
>
> It comes down to
>
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
30 matches
Mail list logo