[PATCH -next] staging: spmi: hisi-spmi-controller: Use proper format in call to dev_err()

2020-08-31 Thread YueHaibing
The correct format string for a size_t argument should be %zu. Signed-off-by: YueHaibing --- drivers/staging/hikey9xx/hisi-spmi-controller.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/hikey9xx/hisi-spmi-controller.c

[staging:staging-linus] BUILD SUCCESS c96711e138444d37d6d8b3f0fa7f09e4917cd326

2020-08-31 Thread kernel test robot
allnoconfig powerpc defconfig i386 randconfig-a001-20200831 i386 randconfig-a002-20200831 i386 randconfig-a004-20200831 i386 randconfig-a006-20200831 i386 randconfig-a005-20200831

Re: [PATCH v2 28/47] staging: vchi: Get rid of vchiq_shim's message callback

2020-08-31 Thread Nicolas Saenz Julienne
Hi Jacopo, sorry if I'm a little late with my replies but I'm on vacation. I'll be back Sept 7th, but wanted to reply since I don't want to stop your work. On Fri, 2020-08-28 at 16:31 +0200, Jacopo Mondi wrote: > Hi Nicolas, > >I'm working on a v2 of the bcm2835-isp support which was sent

Re: [PATCH] staging: gdm724x: fixed two macros by adding brackets

2020-08-31 Thread Greg KH
On Mon, Aug 31, 2020 at 06:03:32PM +0200, antoniprzybylik wrote: > Added brackets to two macros. That says _what_ you did, but not _why_ you did it. Why did you do it? What does this fix? Does it make sense to do this? And why these two macros? Be specific please. > > Signed-off-by: Antoni

[PATCH] staging: gdm724x: fixed two macros by adding brackets

2020-08-31 Thread antoniprzybylik
Added brackets to two macros. Signed-off-by: Antoni Przybylik --- drivers/staging/gdm724x/gdm_tty.c | 3 +-- drivers/staging/gdm724x/netlink_k.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c index

Re: [PATCH AUTOSEL 5.8 07/42] speakup: Fix wait_for_xmitr for ttyio case

2020-08-31 Thread Greg Kroah-Hartman
On Mon, Aug 31, 2020 at 11:28:59AM -0400, Sasha Levin wrote: > From: Samuel Thibault > > [ Upstream commit 2b86d9b8ec6efb86fc5ea44f2d49b1df17f699a1 ] > > This was missed while introducing the tty-based serial access. > > The only remaining use of wait_for_xmitr with tty-based access is in >

[PATCH AUTOSEL 4.14 2/9] speakup: Fix wait_for_xmitr for ttyio case

2020-08-31 Thread Sasha Levin
From: Samuel Thibault [ Upstream commit 2b86d9b8ec6efb86fc5ea44f2d49b1df17f699a1 ] This was missed while introducing the tty-based serial access. The only remaining use of wait_for_xmitr with tty-based access is in spk_synth_is_alive_restart to check whether the synth can be restarted. With

[PATCH AUTOSEL 5.4 04/23] speakup: Fix wait_for_xmitr for ttyio case

2020-08-31 Thread Sasha Levin
From: Samuel Thibault [ Upstream commit 2b86d9b8ec6efb86fc5ea44f2d49b1df17f699a1 ] This was missed while introducing the tty-based serial access. The only remaining use of wait_for_xmitr with tty-based access is in spk_synth_is_alive_restart to check whether the synth can be restarted. With

[PATCH AUTOSEL 4.19 02/11] speakup: Fix wait_for_xmitr for ttyio case

2020-08-31 Thread Sasha Levin
From: Samuel Thibault [ Upstream commit 2b86d9b8ec6efb86fc5ea44f2d49b1df17f699a1 ] This was missed while introducing the tty-based serial access. The only remaining use of wait_for_xmitr with tty-based access is in spk_synth_is_alive_restart to check whether the synth can be restarted. With

[PATCH AUTOSEL 5.8 07/42] speakup: Fix wait_for_xmitr for ttyio case

2020-08-31 Thread Sasha Levin
From: Samuel Thibault [ Upstream commit 2b86d9b8ec6efb86fc5ea44f2d49b1df17f699a1 ] This was missed while introducing the tty-based serial access. The only remaining use of wait_for_xmitr with tty-based access is in spk_synth_is_alive_restart to check whether the synth can be restarted. With

[PATCH v3 7/7] crypto: arc4 - mark ecb(arc4) skcipher as obsolete

2020-08-31 Thread Ard Biesheuvel
Cryptographic algorithms may have a lifespan that is significantly shorter than Linux's, and so we need to start phasing out algorithms that are known to be broken, and are no longer fit for general use. RC4 (or arc4) is a good example here: there are a few areas where its use is still somewhat

[PATCH v3 5/7] crypto: bcm-iproc - remove ecb(arc4) support

2020-08-31 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel --- drivers/crypto/bcm/cipher.c | 96 +--- drivers/crypto/bcm/cipher.h | 1 - drivers/crypto/bcm/spu.c| 23 + drivers/crypto/bcm/spu.h| 1 - drivers/crypto/bcm/spu2.c | 12 +-- drivers/crypto/bcm/spu2.h | 1 - 6 files changed, 6

[PATCH v3 1/7] staging/rtl8192e: switch to RC4 library interface

2020-08-31 Thread Ard Biesheuvel
Switch to the ARC4 library interface, to remove the pointless dependency on the skcipher API, from which we will hopefully be able to drop ecb(arc4) skcipher support. Signed-off-by: Ard Biesheuvel Acked-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/Kconfig | 4 +-

[PATCH v3 6/7] net: wireless: drop bogus CRYPTO_xxx Kconfig selects

2020-08-31 Thread Ard Biesheuvel
Drop some bogus Kconfig selects that are not entirely accurate, and unnecessary to begin with, since the same Kconfig options also select LIB80211 features that already imply the selected functionality (AES for CCMP, ARC4 and ECB for TKIP) Signed-off-by: Ard Biesheuvel ---

[PATCH v3 4/7] crypto: n2 - remove ecb(arc4) support

2020-08-31 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel --- drivers/crypto/n2_core.c | 46 1 file changed, 46 deletions(-) diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c index d8aec5153b21..8c8e17d5fb20 100644 --- a/drivers/crypto/n2_core.c +++ b/drivers/crypto/n2_core.c @@ -662,7

[PATCH v3 2/7] staging/rtl8192u: switch to RC4 library interface

2020-08-31 Thread Ard Biesheuvel
Switch to the ARC4 library interface, to remove the pointless dependency on the skcipher API, from which we will hopefully be able to drop ecb(arc4) skcipher support. Signed-off-by: Ard Biesheuvel Acked-by: Greg Kroah-Hartman --- drivers/staging/rtl8192u/Kconfig | 1 +

[PATCH v3 0/7] crypto: mark ecb(arc4) skcipher as obsolete

2020-08-31 Thread Ard Biesheuvel
RC4 hasn't aged very well, and is a poor fit for the skcipher API so it would be good if we could get rid of the ecb(arc4) drivers in the kernel at some point in the future. This prevents new users from creeping in, and allows us to improve the skcipher API without having to care too much about

[PATCH v3 3/7] SUNRPC: remove RC4-HMAC-MD5 support from KerberosV

2020-08-31 Thread Ard Biesheuvel
The RC4-HMAC-MD5 KerberosV algorithm is based on RFC 4757 [0], which was specifically issued for interoperability with Windows 2000, but was never intended to receive the same level of support. The RFC says The IETF Kerberos community supports publishing this specification as an informational

Re: [PATCH] staging: atomisp: Fix fallthrough keyword warning

2020-08-31 Thread Mauro Carvalho Chehab
Em Mon, 31 Aug 2020 16:30:12 +0300 Cengiz Can escreveu: > commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from > Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments > with 'fallthrough' pseudo-keyword. > > However, in one of the switch-case statements,

Re: [PATCH v2] staging: atomisp: Remove unnecessary 'fallthrough'

2020-08-31 Thread Gustavo A. R. Silva
On Mon, Aug 31, 2020 at 04:51:04PM +0300, Cengiz Can wrote: > commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from > Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments > with 'fallthrough' pseudo-keyword. > > However, in one of the switch-case statements,

[PATCH v2] staging: atomisp: Remove unnecessary 'fallthrough'

2020-08-31 Thread Cengiz Can
commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments with 'fallthrough' pseudo-keyword. However, in one of the switch-case statements, Coverity Static Analyzer throws a warning that 'fallthrough' is

Re: [PATCH] staging: atomisp: Fix fallthrough keyword warning

2020-08-31 Thread Dan Carpenter
Really I think this function is pretty buggy. It shouldn't be falling through at all... I reported it a couple days back so it's possible that someone is working on a fix already. regards, dan carpenter ___ devel mailing list

Re: [PATCH] staging: atomisp: Fix fallthrough keyword warning

2020-08-31 Thread Dan Carpenter
On Mon, Aug 31, 2020 at 04:30:12PM +0300, Cengiz Can wrote: > commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from > Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments > with 'fallthrough' pseudo-keyword. > > However, in one of the switch-case statements,

[PATCH] staging: atomisp: Fix fallthrough keyword warning

2020-08-31 Thread Cengiz Can
commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments with 'fallthrough' pseudo-keyword. However, in one of the switch-case statements, Coverity Static Analyzer throws a warning that 'fallthrough' is

Re: [PATCH] Staging: rtl8723bs: os_dep: fixed some coding style issues

2020-08-31 Thread Greg KH
On Fri, Aug 28, 2020 at 08:14:05PM -0500, Ross Schmidt wrote: > Fixed some coding style issues. What issues? Always be specific please. Please fix up and resend. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org