> + fh->buffers.buffer[i].v4l.fbuffer = mem;
> + fh->buffers.buffer[i].v4l.fbuffer_phys = virt_to_phys(mem);
> + fh->buffers.buffer[i].v4l.fbuffer_bus = virt_to_bus(mem);
> + for (off = 0; off < fh->buffers.buffer_size;
> + off +=
On Mon, Sep 21, 2020 at 10:19:59AM +, Corentin Labbe wrote:
> Instead of using a fragile virt_to_bus, let's use proper DMA coherent
> for the stat_com entry.
>
> Signed-off-by: Corentin Labbe
> ---
> drivers/staging/media/zoran/zoran.h| 2 ++
>
On Mon, Sep 21, 2020 at 10:19:41AM +, Corentin Labbe wrote:
> This patch un-split some lines.
> Signed-off-by: Corentin Labbe
Just don't do this. This is a purious change going over 80 chars for
absolutely no reason, and you'd still need a very good reason for that.
Dies ist ein Newsletter von Blue Oak Mortgage and Loans. Bitte melden Sie sich
ab, wenn Sie keine E-Mail mehr von uns erhalten möchten.
Eine kurze Einführung.
Wir sind ein führendes Finanzierungsunternehmen in Europa. Wir finanzieren
Startups / etablierte Unternehmen, finanzieren
The function lm3554_remove() checks for the return code for
lm3554_gpio_uninit() even though this is on the exit path and exits the
function, leaving the variable flash unfreed. Instead, print a warning and
free flash unconditionally.
Signed-off-by: Alex Dewar
---
Address the following issues:
* unnecessary comparison to true/false
* use of 0/1 instead of bool values
* unnecessary conversion to bool
These were fixed using the following Coccinelle scripts:
* scripts/coccinelle/misc/bool{init,conv,return}.cocci
Build-tested with allmodconfig.
In a few places in pci/sh_css_params.c, memset is used to zero memory
immediately before it is freed. As none of these structs appear to
contain sensitive information, just remove the calls to memset.
Suggested-by: Dan Carpenter
Signed-off-by: Alex Dewar
---
The error path for lm3554_probe() contains a number of bugs, including:
* resource leaks
* jumping to error labels out of sequence
* not setting the return value appropriately
Fix it up and give the labels more memorable names.
This issue has existed since the code was originally contributed
We don't really need to know that the LED pin reset successfully.
Signed-off-by: Alex Dewar
---
drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-lm3554.c
Hi Mauro,
Over the last month I've sent a few scattered patches to fix various
warnings from static analysers, but they seem to have fallen through the
cracks? I'm reposting them here as a series to make them easier to
review. If you do have any feedback that'd be great :)
Best,
Alex
Quoting Shubhrajyoti Datta (2020-08-28 06:39:52)
> The patch adds support for dynamic reconfiguration of clock output rate.
> Output clocks are registered as dividers and set rate callback function
> is used for dynamic reconfiguration.
>
> Based on the initial work from Chirag.
>
>
In hi3670_phy_probe(), when reading property tx-vboost-lvl fails, its
default value is assigned to priv->eye_diagram_param, rather than to
priv->tx_vboost_lvl. Fix this.
Fixes: 8971a3b880b2 ("staging: hikey9xx: add USB physical layer for Kirin 3670")
Addresses-Coverity: CID 1497107: Incorrect
Quoting Stephen Boyd (2020-09-21 14:19:59)
> Quoting Shubhrajyoti Datta (2020-08-28 06:39:50)
> > Add clocking wizard driver to clk.
> >
> > Signed-off-by: Shubhrajyoti Datta
> > ---
>
> Can this be combined with patch #6?
Sorry, I meant patch #8.
Quoting Shubhrajyoti Datta (2020-08-28 06:39:50)
> Add clocking wizard driver to clk.
>
> Signed-off-by: Shubhrajyoti Datta
> ---
Can this be combined with patch #6? And then use git format-patch -C -M
when generating patches? I'm trying to see if anything changed from the
file in the staging
Quoting Shubhrajyoti Datta (2020-08-28 06:39:53)
> Currently the set rate granularity is to integral divisors.
> Add support for the fractional divisors.
> Only the first output0 is fractional in the hardware.
>
> Signed-off-by: Shubhrajyoti Datta
Getting closer.
> diff --git
In hi3670_phy_probe(), when reading property tx-vboost-lvl fails, its
default value is assigned to priv->eye_diagram_param, rather than
priv->tx_vboost_lvl. Fix this.
Fixes: 8971a3b880b2 ("staging: hikey9xx: add USB physical layer for Kirin 3670")
Addresses-Coverity: CID 1497107: Incorrect
On Mon, Sep 21, 2020 at 02:33:57PM +0100, Dan Scally wrote:
> On 18/09/2020 14:07, Andy Shevchenko wrote:
> > On Fri, Sep 18, 2020 at 10:51:57AM +0300, Sakari Ailus wrote:
> >> On Thu, Sep 17, 2020 at 03:45:14PM +0300, Andy Shevchenko wrote:
> >>> On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan
On 18/09/2020 14:07, Andy Shevchenko wrote:
> On Fri, Sep 18, 2020 at 10:51:57AM +0300, Sakari Ailus wrote:
>> On Thu, Sep 17, 2020 at 03:45:14PM +0300, Andy Shevchenko wrote:
>>> On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote:
On 17/09/2020 11:33, Sakari Ailus wrote:
> a
Simplify the return expression.
Signed-off-by: Liu Shixin
---
drivers/android/binder.c | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 37a505c41dec..49c0700816a5 100644
---
On Mon, Sep 21, 2020 at 10:20:12AM +, Corentin Labbe wrote:
> This patch adds fallthrough keyword where appropriate.
>
> Signed-off-by: Corentin Labbe
> ---
> drivers/staging/media/zoran/zoran_device.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git
On 2020/9/21 16:08, Christian Brauner wrote:
> On Mon, Sep 21, 2020 at 04:24:23PM +0800, Liu Shixin wrote:
>> Simplify the return expression.
>>
>> Signed-off-by: Liu Shixin
>> ---
> Why not is all I can really say. :) But if this is about simplifying you
> could get rid of the "ret" and
Supporting overlay is not necessary today, so let's reduce the code size
by removing it.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 16 -
drivers/staging/media/zoran/zoran_card.c | 6 -
drivers/staging/media/zoran/zoran_device.c | 143 +
This is it! the ultimate last step, the vb2 conversion.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/Kconfig|2 +-
drivers/staging/media/zoran/zoran.h| 83 +-
drivers/staging/media/zoran/zoran_card.c | 45 +-
drivers/staging/media/zoran/zoran_device.c
Allocate the zoran structure with devm_ functions permit to simplify
code.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
This patchs adds a vb_queue without using it.
This reduce the final VB2 conversion patch.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/Kconfig| 1 +
drivers/staging/media/zoran/zoran.h| 30 +++
drivers/staging/media/zoran/zoran_card.c | 7 +
Adding vidioc_g_parm made v4l compliance happy.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/drivers/staging/media/zoran/zoran_driver.c
index
The framebuffer support is obsolete, so let's reduce code size.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 4 -
drivers/staging/media/zoran/zoran_card.c | 6 --
drivers/staging/media/zoran/zoran_driver.c | 85 --
3 files changed, 95
Zoran is picky about jpeg data it accepts. At least it seems to not support COM
and APPn.
So until a way to filter data will be done, disable output.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 2 ++
drivers/staging/media/zoran/zoran_driver.c | 20
This patch converts all errors dprintk to pci_err/pr_err.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/videocodec.c | 39 +--
drivers/staging/media/zoran/zoran_card.c | 96 ++
drivers/staging/media/zoran/zoran_device.c | 28 +-
We need to get rid of zoran_fh, so move the jpg_settings directly in the
zoran structure.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 2 -
drivers/staging/media/zoran/zoran_driver.c | 103 ++---
2 files changed, 47 insertions(+), 58
We need to get rid of zoran_fh, so move the overlay_settings directly in the
zoran structure.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 1 -
drivers/staging/media/zoran/zoran_device.c | 8 ++---
drivers/staging/media/zoran/zoran_driver.c | 40
We need to get rid of zoran_fh, so move the buffer_size directly in the
zoran structure.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 3 +-
drivers/staging/media/zoran/zoran_device.c | 3 +-
drivers/staging/media/zoran/zoran_driver.c | 62
buffer_size was not set when it should be.
Furthermore, use it instead of recalculate it.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 2 ++
drivers/staging/media/zoran/zoran_driver.c | 9 ++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git
The zoran device only supports 32bit DMA address.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
index
Use pci_request_regions so now we can see zoran in /proc/iomem.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
This patch enables compilation of the zoran driver.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/Makefile b/drivers/staging/media/Makefile
index 25910221b100..965a8b0e6cf2 100644
---
The zoran driver miss some sanity checks, and this made v4l compliance
happy.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
In fact, zoran does not support V4L2_STD_ALL, so let's enumerate what we
support.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
This patch adds the allocation of the stat_com buffer which be used
later.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h | 2 ++
drivers/staging/media/zoran/zoran_card.c | 11 ++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git
The test_interrupts function is useless, remove it.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 3 ---
drivers/staging/media/zoran/zoran_card.c | 27 --
drivers/staging/media/zoran/zoran_device.c | 16 -
3 files changed, 46
The codec_name could be const.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
index
Instead of using hardcoded numbers, let's use some define for ZR NORM.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 4
drivers/staging/media/zoran/zoran_card.c | 8
drivers/staging/media/zoran/zoran_driver.c | 6 +++---
3 files changed, 11
This patch convert dprintk(info) to pci_info (or pci_dbg if the message
is not important).
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 46 +++---
drivers/staging/media/zoran/zoran_device.c | 27 -
Instead of using a fragile virt_to_bus, let's use proper DMA coherent
for the stat_com entry.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 2 ++
drivers/staging/media/zoran/zoran_card.c | 20 +---
drivers/staging/media/zoran/zoran_device.c |
The ns_to_timeval function is removed, so replace it with
v4l2_buffer_set_timestamp().
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
Using video_drvdata() is proper and shorter than using directly
fh pointers.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 40 --
1 file changed, 14 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
We need to get rid of zoran_fh, so let's change function arguments.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
Add myself as maintainer.
Signed-off-by: Corentin Labbe
---
Documentation/media/v4l-drivers/zoran.rst | 22 +++---
MAINTAINERS| 10 ++
drivers/staging/media/zoran/zoran_card.c | 5 -
drivers/staging/media/zoran/zoran_card.h | 5
Using devm_ioremap simplify code.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
index
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_device.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c
b/drivers/staging/media/zoran/zoran_device.c
index 516a7f18ce7a..03ad3562a807 100644
---
This patch convert dprintk(warn) to pci_warn.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 18 --
drivers/staging/media/zoran/zoran_device.c | 13 +++---
drivers/staging/media/zoran/zoran_driver.c | 29 +-
3 files changed, 14
We need to get rid of zoran_fh, so move the v4l_settings directly in the
zoran structure.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 1 -
drivers/staging/media/zoran/zoran_driver.c | 38 ++
2 files changed, 17 insertions(+), 22
This patch adds fallthrough keyword where appropriate.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_device.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/media/zoran/zoran_device.c
b/drivers/staging/media/zoran/zoran_device.c
index
Add TODO for "TRY_FMT cannot handle an invalid pixelformat"
We need to set pixelformat in some case.
We should also handle some minimum requirement.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
Let's use devm allocations for videocodec, this simplify code.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
move function for avoiding forward declaration
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_device.c | 44 +++---
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c
This patch convert zoran to pci_irq functions.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
index
This patch convert dprintk(debug) to pci_dbg.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 30 --
drivers/staging/media/zoran/zoran_card.h | 6 -
drivers/staging/media/zoran/zoran_device.c | 2 +-
Fix some typo in doc.
Signed-off-by: Corentin Labbe
---
Documentation/media/v4l-drivers/zoran.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/media/v4l-drivers/zoran.rst
b/Documentation/media/v4l-drivers/zoran.rst
index a0586514cd8a..2b82b9a47a71
This patch un-split some lines.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 27
drivers/staging/media/zoran/zoran_device.c | 49 +++---
drivers/staging/media/zoran/zoran_driver.c | 27
3 files changed, 34 insertions(+),
Update the TODO of the zoran driver
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/TODO | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/zoran/TODO b/drivers/staging/media/zoran/TODO
index
As asked by checkpath, let's use udelay.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c
b/drivers/staging/media/zoran/zoran_device.c
index
The zoran driver give some debug information in procfs, but this is not
the right place.
So let's remove them, we will use debugfs later.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/Makefile | 2 +-
drivers/staging/media/zoran/zoran.h| 5 -
The structure tvnorm could be consified.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/videocodec.h | 2 +-
drivers/staging/media/zoran/zoran.h| 4 ++--
drivers/staging/media/zoran/zoran_card.c | 24 +++---
drivers/staging/media/zoran/zoran_device.c
This patchs removed the deprecated .vidioc_g_jpegcomp and replace it
with corresponding v4l2_ctrl_ops code.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 22 ++
drivers/staging/media/zoran/zoran_driver.c | 48 --
2 files changed, 22
The slot 0 of guest is never initialized and so we print later random
data.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_device.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/media/zoran/zoran_device.c
The VFL_TYPE_GRABBER type was removed, so let's use the new type.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
Hello
The zoran driver was removed in 5.3
The main reason of the removing was lack of motivation to convert it to
VB2
Since I need it, I worked on bringing it back.
So the plan to achieve it was:
- clean up the coding style.
- convert old usage/API
- clean unused code
- convert to VB2
I have
Simply remove this broken reference
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_device.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c
b/drivers/staging/media/zoran/zoran_device.c
index 04162be80420..79da964c678b 100644
On Mon, Sep 21, 2020 at 04:24:23PM +0800, Liu Shixin wrote:
> Simplify the return expression.
>
> Signed-off-by: Liu Shixin
> ---
Why not is all I can really say. :) But if this is about simplifying you
could get rid of the "ret" and "failure string" variables, and the goto
in that function
Simplify the return expression.
Signed-off-by: Liu Shixin
---
drivers/android/binder.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 37a505c41dec..1f929e0cf39f 100644
--- a/drivers/android/binder.c
+++
71 matches
Mail list logo