[PATCH] MAINTAINERS: rectify ZR36067 VIDEO FOR LINUX DRIVER section

2020-10-08 Thread Lukas Bulwahn
matches F: Documentation/media/v4l-drivers/zoran.rst Point the file entry to the right location and move the section to the right place in MAINTAINERS. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20201008 Corentin, please ack. Mauro, please pick this minor non-urgent cleanup patch into

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-08 Thread Coiby Xu
On Thu, Oct 08, 2020 at 04:39:40PM +0300, Dan Carpenter wrote: On Thu, Oct 08, 2020 at 07:58:04PM +0800, Coiby Xu wrote: -static int -qlge_reporter_coredump(struct devlink_health_reporter *reporter, - struct devlink_fmsg *fmsg, void *priv_ctx, -

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread Coiby Xu
On Thu, Oct 08, 2020 at 04:31:42PM +0300, Dan Carpenter wrote: On Thu, Oct 08, 2020 at 07:58:03PM +0800, Coiby Xu wrote: Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu --- drivers/staging/qlge/Kconfig|

Cursos Bonificables (ÚLTIMA CONVOCATORIA 2020)

2020-10-08 Thread FOESCO
Buenos días Llegadas estas fechas y como cada año, recordamos a todas las empresas Españolas su derecho a consumir el Crédito de Formación del que disponen para la formación de sus empleados en activo o en ERTE, antes de su caducidad a final de año. Actualmente se encuentra abierto el plazo

[PATCH] staging: rtl8188eu: Fix long lines

2020-10-08 Thread Fan Fei
This patch fix long lines found by checkpatch. Signed-off-by: Fan Fei --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 74 1 file changed, 51 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread kernel test robot
Hi Coiby, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Coiby-Xu/staging-qlge-Re-writing-the-debugging-features/20201008-22 base: https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-08 Thread Dan Carpenter
On Thu, Oct 08, 2020 at 07:58:04PM +0800, Coiby Xu wrote: > -static int > -qlge_reporter_coredump(struct devlink_health_reporter *reporter, > - struct devlink_fmsg *fmsg, void *priv_ctx, > - struct netlink_ext_ack *extack) > +static int fill_seg_(struct

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread Dan Carpenter
On Thu, Oct 08, 2020 at 07:58:03PM +0800, Coiby Xu wrote: > Initialize devlink health dump framework for the dlge driver so the > coredump could be done via devlink. > > Signed-off-by: Coiby Xu > --- > drivers/staging/qlge/Kconfig| 1 + > drivers/staging/qlge/Makefile | 2 +- >

Re: [PATCH 0/7] wfx: move out from the staging area

2020-10-08 Thread Dan Carpenter
There are some static checker warnings to look at from linux-next from Tuesday. drivers/staging/wfx/hif_tx.c:319 hif_join() error: we previously assumed 'channel' could be null (see line 315) drivers/staging/wfx/main.c:228 wfx_send_pdata_pds() warn: potential NULL parameter dereference

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread Coiby Xu
On Thu, Oct 08, 2020 at 08:22:44AM -0400, Willem de Bruijn wrote: On Thu, Oct 8, 2020 at 7:58 AM Coiby Xu wrote: Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu @@ -4556,6 +4559,13 @@ static int

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread Willem de Bruijn
On Thu, Oct 8, 2020 at 7:58 AM Coiby Xu wrote: > > Initialize devlink health dump framework for the dlge driver so the > coredump could be done via devlink. > > Signed-off-by: Coiby Xu > @@ -4556,6 +4559,13 @@ static int qlge_probe(struct pci_dev *pdev, > struct ql_adapter *qdev = NULL;

[PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land

2020-10-08 Thread Coiby Xu
The debugging code in the following ifdef land - QL_ALL_DUMP - QL_REG_DUMP - QL_DEV_DUMP - QL_CB_DUMP - QL_IB_DUMP - QL_OB_DUMP becomes unnecessary because, - Device status and general registers can be obtained by ethtool. - Coredump can be done via devlink health reporter. - Structure

[PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-08 Thread Coiby Xu
$ devlink health dump show DEVICE reporter coredump -p -j { "Core Registers": { "segment": 1, "values": [

[PATCH v1 6/6] staging: qlge: add documentation for debugging qlge

2020-10-08 Thread Coiby Xu
Instructions and examples on kernel data structures dumping and coredump. Signed-off-by: Coiby Xu --- .../networking/device_drivers/index.rst | 1 + .../device_drivers/qlogic/index.rst | 18 +++ .../networking/device_drivers/qlogic/qlge.rst | 118 ++

[PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread Coiby Xu
Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu --- drivers/staging/qlge/Kconfig| 1 + drivers/staging/qlge/Makefile | 2 +- drivers/staging/qlge/qlge.h | 9 +++

[PATCH v1 0/6] staging: qlge: Re-writing the debugging features

2020-10-08 Thread Coiby Xu
This patch set aims to avoid dumping registers, data structures and coredump to dmesg and also to reduce the code size of the qlge driver. As pointed out by Benjamin [1], > At 2000 lines, qlge_dbg.c alone is larger than some entire ethernet > drivers. Most of what it does is dump kernel data

[PATCH v1 3/6] staging: qlge: support force_coredump option for devlink health dump

2020-10-08 Thread Coiby Xu
With force_coredump module paramter set, devlink health dump will reset the MPI RISC first which takes 5 secs to be finished. Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_devlink.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/qlge/qlge_devlink.c

[PATCH v1 4/6] staging: qlge: remove mpi_core_to_log which sends coredump to the kernel ring buffer

2020-10-08 Thread Coiby Xu
devlink health could be used to get coredump. No need to send so much data to the kernel ring buffer. Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge.h | 3 --- drivers/staging/qlge/qlge_dbg.c | 11 --- drivers/staging/qlge/qlge_ethtool.c | 1 -

Re: [PATCH 0/7] wfx: move out from the staging area

2020-10-08 Thread Kalle Valo
Jérôme Pouiller writes: > On Thursday 8 October 2020 09:30:06 CEST Kalle Valo wrote: > [...] >> Yes, the driver needs to be reviewed in linux-wireless list. I recommend >> submitting the whole driver in a patchset with one file per patch, which >> seems to be the easiest way to review a full

Re: [PATCH 0/7] wfx: move out from the staging area

2020-10-08 Thread Jérôme Pouiller
On Thursday 8 October 2020 09:30:06 CEST Kalle Valo wrote: [...] > Yes, the driver needs to be reviewed in linux-wireless list. I recommend > submitting the whole driver in a patchset with one file per patch, which > seems to be the easiest way to review a full driver. The final move will > be in

Re: [PATCH 0/7] wfx: move out from the staging area

2020-10-08 Thread Kalle Valo
Kalle Valo writes: > Greg Kroah-Hartman writes: > >> On Wed, Oct 07, 2020 at 12:19:36PM +0200, Jerome Pouiller wrote: >>> From: Jérôme Pouiller >>> >>> I think the wfx driver is now mature enough to be accepted in the >>> drivers/net/wireless directory. >>> >>> There is still one item on the

Re: [PATCH v2] staging: vchiq: Fix list_for_each exit tests

2020-10-08 Thread Nicolas Saenz Julienne
On Tue, 2020-10-06 at 16:47 +0300, Dan Carpenter wrote: > After a list_for_each_entry() loop, the list iterator is always non-NULL > so these conditions don't work. If the "waiter" is not found then this > results in an out of bounds access. > > I have fixed it by introducing a new "found"

Re: [PATCH 0/7] wfx: move out from the staging area

2020-10-08 Thread Kalle Valo
Greg Kroah-Hartman writes: > On Wed, Oct 07, 2020 at 12:19:36PM +0200, Jerome Pouiller wrote: >> From: Jérôme Pouiller >> >> I think the wfx driver is now mature enough to be accepted in the >> drivers/net/wireless directory. >> >> There is still one item on the TODO list. It is an idea to