On Wed, Oct 21, 2020 at 10:11:52AM +0530, Vaishali Thakkar wrote:
> On Wed, Oct 21, 2020 at 8:33 AM Deepak R Varma wrote:
> >
> > Multiple issues reported by checkpatch script around lines exceeding 100
> > columns, indentation of function parameters, extra blank lines. These
> > code formatting
Rename show_engine_regs to engine_regs_show as per the convention
followed. Issue reported by checkpatch script.
Signed-off-by: Deepak R Varma
---
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Reformat lines that exceed 100 column in length. Issue reported by
checkpatch script.
Signed-off-by: Deepak R Varma
---
drivers/staging/kpc2000/kpc_dma/dma.c | 27 +---
drivers/staging/kpc2000/kpc_dma/fileops.c | 44 +++
On Wed, Oct 21, 2020 at 8:33 AM Deepak R Varma wrote:
>
> Multiple issues reported by checkpatch script around lines exceeding 100
> columns, indentation of function parameters, extra blank lines. These
> code formatting changes improves the code readability.
Please send separate patches while
On Wed, Oct 21, 2020 at 12:01 AM Elena Afanasova wrote:
>
> Reported by checkpatch.pl
>
> Signed-off-by: Elena Afanasova
This patch is fixing 2 different checkpatch warnings. They
should be sent as separate patches. One for removing extra
blank lines, another one for fixing the code alignment.
On Tue, Oct 20, 2020 at 8:56 PM Elena Afanasova wrote:
>
> Reported by checkpatch.pl
Hi Elena,
Thanks for your patches. Your commit log should mention
why are you doing certain changes. Above commit log
doesn't give reviewer/maintainer an idea about what are
you fixing and why that change is
allyesconfig
mips allmodconfig
powerpc allyesconfig
powerpc allmodconfig
powerpc allnoconfig
i386 randconfig-a002-20201020
i386 randconfig-a005-20201020
Replace bit masking by BIT macro. This resolves checkpatch issue
"CHECK: Prefer using the BIT macro"
Signed-off-by: Deepak R Varma
---
drivers/staging/kpc2000/kpc2000/dma_common_defs.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
Multiple issues reported by checkpatch script around lines exceeding 100
columns, indentation of function parameters, extra blank lines. These
code formatting changes improves the code readability.
Signed-off-by: Deepak R Varma
---
drivers/staging/kpc2000/kpc2000/cell_probe.c | 71
Good morning,
Concerning the previous email I sent to you, could you kindly indicates if
you will be able to sale the products to my Director directly as proposed. I am
still waiting for your response if you did not received it I can resend it to
you again.
Alternatively, could you
From: Dafna Hirschfeld
> Sent: 20 October 2020 18:10
>
> Am 20.10.20 um 17:29 schrieb David Laight:
> > From: Colin King
> >> Sent: 20 October 2020 15:47
> >>
> >> From: Colin Ian King
> >>
...
> >> diff --git a/drivers/staging/media/rkisp1/rkisp1-resizer.c
> >>
The Rockchip ISP bindings was moved out of staging.
Update MAINTAINERS file with the new path.
Fields sorted according to output of
./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS
--order
Signed-off-by: Helen Koike
Reviewed-by: Tomasz Figa
---
MAINTAINERS | 2 ++
1
Move rkisp1 bindings to Documentation/devicetree/bindings/media
Verified with:
make ARCH=arm64 dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Helen Koike
Acked-by: Rob Herring
Reviewed-by: Tomasz Figa
---
Organize properties order in dt-bindings to move it out of staging.
On top: compatible, reg and interrupts.
Then alphabetical order, then properties starting with '#'.
Signed-off-by: Helen Koike
Acked-by: Rob Herring
Reviewed-by: Tomasz Figa
---
.../bindings/media/rockchip-isp1.yaml
aclk_isp_wrap is a child of aclk_isp, and hclk_isp_wrap is a child of
hclk_isp, thus we can remove parents from the list.
Also, for the isp0, we only need the ISP clock, ACLK and HCLK.
In the future we'll need a pixel clock for RK3288 and RK3399, and a JPEG
clock for RK3288.
So with the goal to
From: Shunqian Zheng
RK3399 has two ISPs, but only isp0 was tested.
Add isp0 node in rk3399 dtsi
Verified with:
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-by: Helen
Fix the following error found with make ARCH=arm64 dt_binding_check:
Documentation/devicetree/bindings/media/rockchip-isp1.example.dts:24.27-101.11:
Warning (unit_address_vs_reg): /example-0/parent@0: node has a unit name, but
no reg or ranges property
Reported-by: Johan Jonker
Signed-off-by:
From: Eddie Cai
Enable ISP and camera sensor ov2685 and ov5695 for Scarlet Chromebook
Verified with:
make ARCH=arm64 dtbs_check
Signed-off-by: Shunqian Zheng
Signed-off-by: Eddie Cai
Signed-off-by: Tomasz Figa
Signed-off-by: Helen Koike
Reviewed-by: Tomasz Figa
---
Add missing required items in Rockchip ISP1 dt-bindings example for
a complete i2c node.
Drop unit address to Fix error:
/example-0/parent/i2c@ff16: node has a unit name, but no reg or ranges
property
Remove unecessary fields for the example.
Signed-off-by: Helen Koike
Acked-by: Rob Herring
Add missing required nodes in json-schema yaml file for
Rockchip ISP1 dt-bindings.
Signed-off-by: Helen Koike
Acked-by: Rob Herring
Reviewed-by: Tomasz Figa
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 8
1 file changed, 8 insertions(+)
diff --git
Move the bindings out of drivers/staging and place them in
Documentation/devicetree/bindings instead.
Also, add DT nodes for RK3399 and verify with make ARCH=arm64 dtbs_check
and make ARCH=arm64 dt_binding_check.
Tested by verifying images streamed from Scarlet Chromebook
Changes in v6:
-
On Tue, Oct 20, 2020 at 11:24:39AM -0700, Elena Afanasova wrote:
> Reported by checkpatch.pl
Checkpatch is wrong.
> +++ b/drivers/staging/rtl8712/rtl871x_recv.h
> @@ -8,7 +8,7 @@
> #define NR_RECVFRAME 256
>
> #define RXFRAME_ALIGN8
> -#define RXFRAME_ALIGN_SZ (1 <<
On Mon, 2020-10-19 at 12:42 -0700, Nick Desaulniers wrote:
> On Sat, Oct 17, 2020 at 10:43 PM Greg KH wrote:
> > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote:
> > > From: Tom Rix
> > >
> > > This is a upcoming change to clean up a new warning treewide.
> > > I am wondering if
Reported by checkpatch.pl
Signed-off-by: Elena Afanasova
---
drivers/staging/rtl8712/rtl871x_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl871x_recv.h
b/drivers/staging/rtl8712/rtl871x_recv.h
index d03859ca1697..2ed2d3edb312 100644
---
Reported by checkpatch.pl
Signed-off-by: Elena Afanasova
---
drivers/staging/rtl8712/rtl871x_recv.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_recv.h
b/drivers/staging/rtl8712/rtl871x_recv.h
index 57a965b9839b..d03859ca1697
Reported by checkpatch.pl
Signed-off-by: Elena Afanasova
---
drivers/staging/rtl8712/rtl871x_recv.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_recv.h
b/drivers/staging/rtl8712/rtl871x_recv.h
index e83c256e1474..57a965b9839b 100644
---
allmodconfig
powerpc allnoconfig
i386 randconfig-a002-20201020
i386 randconfig-a005-20201020
i386 randconfig-a003-20201020
i386 randconfig-a001-20201020
i386 randconfig
Am 20.10.20 um 17:29 schrieb David Laight:
From: Colin King
Sent: 20 October 2020 15:47
From: Colin Ian King
Don't populate the const array dev_names on the stack but instead it
static. Makes the object code smaller by 15 bytes.
Before:
text data bss dec hex
Hi, thanks,
Am 20.10.20 um 16:46 schrieb Colin King:
From: Colin Ian King
Don't populate the const array dev_names on the stack but instead it
static. Makes the object code smaller by 15 bytes.
Before:
text data bss dec hex filename
17091 2648 64
On Tue, 20 Oct 2020 at 14:58, Jerome Pouiller
wrote:
>
> From: Jérôme Pouiller
>
> Add Silabs SDIO ID to sdio_ids.h.
>
> Note that the values used by Silabs are uncommon. A driver cannot fully
> rely on the SDIO PnP. It should also check if the device is declared in
> the DT.
>
> Signed-off-by:
From: Colin King
> Sent: 20 October 2020 15:47
>
> From: Colin Ian King
>
> Don't populate the const array dev_names on the stack but instead it
> static. Makes the object code smaller by 15 bytes.
>
> Before:
>text data bss dec hex filename
> 17091 2648
On Tue, 2020-10-20 at 17:19 +0200, Greg KH wrote:
> On Tue, Oct 20, 2020 at 08:08:23AM -0700, Elena Afanasova wrote:
> > Replace function names with __func__ macro.
> > Remove unnecessary characters in error messages.
> > Reported by checkpatch.pl.
> >
> > Signed-off-by: Elena Afanasova
> > ---
Reported by checkpatch.pl
Signed-off-by: Elena Afanasova
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 118 +++---
1 file changed, 81 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index
On Tue, Oct 20, 2020 at 08:08:23AM -0700, Elena Afanasova wrote:
> Replace function names with __func__ macro.
> Remove unnecessary characters in error messages.
> Reported by checkpatch.pl.
>
> Signed-off-by: Elena Afanasova
> ---
> drivers/staging/rtl8192u/ieee80211/dot11d.c | 12 ++--
On Wed, Oct 14, 2020 at 11:46 AM Helen Koike wrote:
>
> Hi Rob,
>
> Thnaks for your reply.
>
> On 9/22/20 11:24 AM, Rob Herring wrote:
> > On Wed, Jul 22, 2020 at 9:56 AM Helen Koike
> > wrote:
> >>
> >> aclk_isp_wrap is a child of aclk_isp, and hclk_isp_wrap is a child of
> >> hclk_isp, thus
Reported by checkpatch.pl.
Signed-off-by: Elena Afanasova
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h
b/drivers/staging/rtl8192u/ieee80211/dot11d.h
index
Replace function names with __func__ macro.
Remove unnecessary characters in error messages.
Reported by checkpatch.pl.
Signed-off-by: Elena Afanasova
---
drivers/staging/rtl8192u/ieee80211/dot11d.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
Reported by checkpatch.pl.
Signed-off-by: Elena Afanasova
---
drivers/staging/qlge/qlge_mpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index 143a886080c5..2ff3db2661a9 100644
---
Reported by checkpatch.pl.
Signed-off-by: Elena Afanasova
---
drivers/staging/qlge/qlge_ethtool.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/qlge/qlge_ethtool.c
b/drivers/staging/qlge/qlge_ethtool.c
index d44b2dae9213..a28f0254cf60 100644
---
From: Colin Ian King
Don't populate the const array dev_names on the stack but instead it
static. Makes the object code smaller by 15 bytes.
Before:
textdata bss dec hex filename
170912648 64 198034d5b media/rkisp1/rkisp1-resizer.o
After:
textdata
Dear
My name is Nicholas Toms, an investment portfolio manager with ACLL . We offer
the right loan Investment funding with low
interest to finance your business or project ranging from US$1M to US$2BIllion.
Kindly contact me for more details as I am open to questions.
Sincerely,
Nicholas
Dear
My name is Nicholas Toms, an investment portfolio manager with ACLL . We offer
the right loan Investment funding with low
interest to finance your business or project ranging from US$1M to US$2BIllion.
Kindly contact me for more details as I am open to questions.
Sincerely,
Nicholas
On 10/19/20 4:05 PM, Jason Gunthorpe wrote:
> On Mon, Oct 19, 2020 at 12:42:15PM -0700, Nick Desaulniers wrote:
>> On Sat, Oct 17, 2020 at 10:43 PM Greg KH wrote:
>>> On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote:
From: Tom Rix
This is a upcoming change to
On 10/19/20 12:42 PM, Nick Desaulniers wrote:
> On Sat, Oct 17, 2020 at 10:43 PM Greg KH wrote:
>> On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote:
>>> From: Tom Rix
>>>
>>> This is a upcoming change to clean up a new warning treewide.
>>> I am wondering if the change could be
From: Jérôme Pouiller
The wfx driver is now mature enough to leave the staging area.
Signed-off-by: Jérôme Pouiller
---
MAINTAINERS | 3 ++-
drivers/net/wireless/Kconfig | 1 +
drivers/net/wireless/Makefile| 1 +
drivers/net/wireless/silabs/Kconfig
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/data_rx.c | 93 +++
drivers/net/wireless/silabs/wfx/data_rx.h | 18 +
2 files changed, 111 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/data_rx.c
create mode
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/sta.c | 807 ++
drivers/net/wireless/silabs/wfx/sta.h | 73 +++
2 files changed, 880 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/sta.c
create mode 100644
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/scan.c | 132 +
drivers/net/wireless/silabs/wfx/scan.h | 22 +
2 files changed, 154 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/scan.c
create mode 100644
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/traces.h | 501 +++
1 file changed, 501 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/traces.h
diff --git a/drivers/net/wireless/silabs/wfx/traces.h
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/bus_spi.c | 271 ++
1 file changed, 271 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/bus_spi.c
diff --git a/drivers/net/wireless/silabs/wfx/bus_spi.c
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/bus_sdio.c | 258 +
1 file changed, 258 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c
diff --git a/drivers/net/wireless/silabs/wfx/bus_sdio.c
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/main.c | 489 +
drivers/net/wireless/silabs/wfx/main.h | 44 +++
2 files changed, 533 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/main.c
create mode 100644
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/hif_rx.c | 415 +++
drivers/net/wireless/silabs/wfx/hif_rx.h | 18 +
2 files changed, 433 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/hif_rx.c
create mode 100644
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/hwio.c | 352 +
drivers/net/wireless/silabs/wfx/hwio.h | 75 ++
2 files changed, 427 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/hwio.c
create mode
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/data_tx.c | 585 ++
drivers/net/wireless/silabs/wfx/data_tx.h | 67 +++
2 files changed, 652 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/data_tx.c
create mode
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/fwio.c | 405 +
drivers/net/wireless/silabs/wfx/fwio.h | 15 +
2 files changed, 420 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/fwio.c
create mode 100644
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/hif_tx.c | 523 +++
drivers/net/wireless/silabs/wfx/hif_tx.h | 60 +++
drivers/net/wireless/silabs/wfx/hif_tx_mib.c | 324
drivers/net/wireless/silabs/wfx/hif_tx_mib.h
From: Jérôme Pouiller
Add Silabs SDIO ID to sdio_ids.h.
Note that the values used by Silabs are uncommon. A driver cannot fully
rely on the SDIO PnP. It should also check if the device is declared in
the DT.
Signed-off-by: Jérôme Pouiller
---
include/linux/mmc/sdio_ids.h | 5 +
1 file
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/hif_api_cmd.h | 553 ++
.../net/wireless/silabs/wfx/hif_api_general.h | 267 +
drivers/net/wireless/silabs/wfx/hif_api_mib.h | 343 +++
3 files changed, 1163 insertions(+)
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/wfx.h | 166 ++
1 file changed, 166 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/wfx.h
diff --git a/drivers/net/wireless/silabs/wfx/wfx.h
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/Kconfig | 8
drivers/net/wireless/silabs/wfx/Makefile | 25
2 files changed, 33 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/Kconfig
create mode
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/queue.c | 304
drivers/net/wireless/silabs/wfx/queue.h | 45
2 files changed, 349 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/queue.c
create mode
From: Jérôme Pouiller
I think the wfx driver is now mature enough to be accepted in the
drivers/net/wireless directory.
As requested by Kalle[1], I send one file per patch. At the end, all the
patches (or at least the patches 3 to 24) will be squashed (therefore, I
didn't bother to write real
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
.../bindings/net/wireless/silabs,wfx.yaml | 133 ++
1 file changed, 133 insertions(+)
create mode 100644
Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml
diff --git
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/bus.h | 38 +++
1 file changed, 38 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/bus.h
diff --git a/drivers/net/wireless/silabs/wfx/bus.h
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/debug.c | 359
drivers/net/wireless/silabs/wfx/debug.h | 19 ++
2 files changed, 378 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/debug.c
create mode 100644
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/key.c | 241 ++
drivers/net/wireless/silabs/wfx/key.h | 20 +++
2 files changed, 261 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/key.c
create mode 100644
From: Jérôme Pouiller
Signed-off-by: Jérôme Pouiller
---
drivers/net/wireless/silabs/wfx/bh.c | 333 +++
drivers/net/wireless/silabs/wfx/bh.h | 33 +++
2 files changed, 366 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/bh.c
create mode 100644
Hi,
Thank you for testing this patch!
On Tue, Oct 20, 2020 at 06:27:41PM +0800, Shung-Hsi Yu wrote:
On Tue, Oct 20, 2020 at 04:57:11PM +0800, Shung-Hsi Yu wrote:
Hi,
This patch trigger the following KASAN error inside qlge_init_device().
[...] general protection fault, probably for
On Tue, Oct 20, 2020 at 04:57:11PM +0800, Shung-Hsi Yu wrote:
> Hi,
>
> This patch trigger the following KASAN error inside qlge_init_device().
>
> [...] general protection fault, probably for non-canonical address
> 0xdc4b: [#1] SMP DEBUG_PAGEALLOC KASAN PTI
> [...] KASAN:
Hi,
This patch trigger the following KASAN error inside qlge_init_device().
[...] general protection fault, probably for non-canonical address
0xdc4b: [#1] SMP DEBUG_PAGEALLOC KASAN PTI
[...] KASAN: null-ptr-deref in range [0x0258-0x025f]
[...] CPU: 0
On Tue, Oct 20, 2020 at 04:36:09PM +0800, Shung-Hsi Yu wrote:
> This patch trigger the following KASAN error inside qlge_init_device().
Sorry, I meant to reply to the v3 series, please ignore this email.
___
devel mailing list
> On 19 Oct 2020, at 20:42, Nick Desaulniers wrote:
>
> We probably should add all 3 to W=2 builds (wrapped in cc-option).
> I've filed https://github.com/ClangBuiltLinux/linux/issues/1180 to
> follow up on.
It looks as though the URL mangling has been fixed. If anyone sees that
specific
Hi,
This patch trigger the following KASAN error inside qlge_init_device().
[...] general protection fault, probably for non-canonical address
0xdc4b: [#1] SMP DEBUG_PAGEALLOC KASAN PTI
[...] KASAN: null-ptr-deref in range [0x0258-0x025f]
[...] CPU: 0
74 matches
Mail list logo
