Re: [PATCH]: drivers: staging: most: Fixed styling issue.

2021-02-08 Thread Greg KH
On Tue, Feb 09, 2021 at 11:53:11AM +0530, Mukul Mehar wrote: > >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 > From: Mukul Mehar > Date: Mon, 8 Feb 2021 01:03:06 +0530 > Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. Why is this still an attached

[PATCH]: drivers: staging: most: Fixed styling issue.

2021-02-08 Thread Mukul Mehar
>From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 From: Mukul Mehar Date: Mon, 8 Feb 2021 01:03:06 +0530 Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. This patch fixes a warning, of the line ending with a '(', generated by checkpatch.pl. Signed-off-by:

Re: [PATCH] staging: hikey9xx: fix checkpatch error and warning

2021-02-08 Thread Greg KH
On Tue, Feb 09, 2021 at 11:27:04AM +0530, Atul Gopinathan wrote: > Fix the following types of checkpatch error and warning: > > ERROR: code indent should use tabs where possible > WARNING: struct phy_ops should normally be const That is 2 different things, which means this should be 2 different

[PATCH] staging: hikey9xx: fix checkpatch error and warning

2021-02-08 Thread Atul Gopinathan
Fix the following types of checkpatch error and warning: ERROR: code indent should use tabs where possible WARNING: struct phy_ops should normally be const Signed-off-by: Atul Gopinathan --- drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 2 +- drivers/staging/hikey9xx/hi6421v600-regulator.c

Re: [PATCH] staging: fix ignoring return value warning

2021-02-08 Thread Youling Tang
Hi, Dan On 02/09/2021 03:02 AM, Dan Carpenter wrote: On Mon, Feb 08, 2021 at 04:06:18PM +0100, Sascha Hauer wrote: Hi Dan, On Mon, Feb 08, 2021 at 04:45:17PM +0300, Dan Carpenter wrote: On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: Fix the below ignoring return value

[PATCH] staging: rtl8723bs: fix braces for os_dep/mlme_linux.c

2021-02-08 Thread Phillip Potter
Add braces to both branches of an if block for consistency, and also remove braces from a single line for loop. Fixes a checkpatch check and warning, thus clearing this file of any brace check/warning notices. Signed-off-by: Phillip Potter --- drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 6

[PATCH] staging: rtl8723bs: remove braces from two single line if blocks

2021-02-08 Thread Phillip Potter
Remove braces from both occurences of single line if blocks in include/rtw_mlme.h, fixes two checkpatch warnings, thus clearing this type of warning from this file. Also swaps two if statement comparisons around, so the variable is on the left in each one. This fixes two warnings also.

Re: [PATCH v8 11/14] spmi: hisi-spmi-controller: move driver from staging

2021-02-08 Thread Stephen Boyd
Quoting Mauro Carvalho Chehab (2021-01-29 11:51:57) > The Hisilicon 6421v600 SPMI driver is ready for mainstream. > > So, move it from staging. > > Signed-off-by: Mauro Carvalho Chehab > --- Acked-by: Stephen Boyd Rob had some comments on the binding that don't look to be addressed though so

Re: [PATCH]: checkpatch: Fixed styling issue

2021-02-08 Thread Randy Dunlap
On 2/8/21 11:51 AM, Mukul Mehar wrote: More comments (probably duplicates): a. The "checkpatch:" in the subject says that you are making a patch to the "checkpatch" script. You are not doing that. The subject should be more like: "staging: most: fix a style issue in sound.c" e.g. b. This

Re: [PATCH 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

2021-02-08 Thread Guenter Roeck
On 2/5/21 12:08 PM, Bjorn Helgaas wrote: > On Fri, Feb 05, 2021 at 10:28:32AM -0800, Guenter Roeck wrote: >> On Fri, Feb 05, 2021 at 05:44:13PM +0800, Yicong Yang wrote: >>> From: Junhao He >>> >>> Use subdir-ccflags-* instead of ccflags-* to inherit the debug >>> settings from Kconfig when

Re: [PATCH v7 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-02-08 Thread Nicolas Saenz Julienne
On Mon, 2021-01-18 at 13:32 +0100, Nicolas Saenz Julienne wrote: > Adds support to control the PWM bus available in official Raspberry Pi > PoE HAT. Only RPi's co-processor has access to it, so commands have to > be sent through RPi's firmware mailbox interface. > > Signed-off-by: Nicolas Saenz

Re: [PATCH AUTOSEL 5.10 14/36] media: rkisp1: uapi: change hist_bins array type from __u16 to __u32

2021-02-08 Thread Hans Verkuil
On 08/02/2021 18:57, Sasha Levin wrote: > From: Dafna Hirschfeld > > [ Upstream commit 31f190e0ccac8b75d33fdc95a797c526cf9b149e ] > > Each entry in the array is a 20 bits value composed of 16 bits unsigned > integer and 4 bits fractional part. So the type should change to __u32. > In addition

Re: [PATCH]: checkpatch: Fixed styling issue

2021-02-08 Thread Greg KH
On Tue, Feb 09, 2021 at 01:21:16AM +0530, Mukul Mehar wrote: > >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 > From: Mukul Mehar > Date: Mon, 8 Feb 2021 01:03:06 +0530 > Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. > > This patch fixes a warning,

[PATCH]: checkpatch: Fixed styling issue

2021-02-08 Thread Mukul Mehar
>From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 From: Mukul Mehar Date: Mon, 8 Feb 2021 01:03:06 +0530 Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. This patch fixes a warning, of the line ending with a '(', generated by checkpatch.pl. This is my

Re: [PATCH] staging: fix ignoring return value warning

2021-02-08 Thread Dan Carpenter
On Mon, Feb 08, 2021 at 04:06:18PM +0100, Sascha Hauer wrote: > Hi Dan, > > On Mon, Feb 08, 2021 at 04:45:17PM +0300, Dan Carpenter wrote: > > On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > > > Fix the below ignoring return value warning for device_reset. > > > > > >

Re: [PATCH]: checkpatch: Fixed styling issue

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 11:58:02PM +0530, Mukul Mehar wrote: > >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 > From: Mukul Mehar > Date: Mon, 8 Feb 2021 01:03:06 +0530 > Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. > > This patch fixes a warning,

[PATCH]: checkpatch: Fixed styling issue

2021-02-08 Thread Mukul Mehar
>From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 From: Mukul Mehar Date: Mon, 8 Feb 2021 01:03:06 +0530 Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. This patch fixes a warning, of the line ending with a '(', generated by checkpatch.pl. This is my

[PATCH AUTOSEL 5.10 16/36] media: rkisp1: stats: mask the hist_bins values

2021-02-08 Thread Sasha Levin
From: Dafna Hirschfeld [ Upstream commit a802a0430b863f03bc01aaea2d2bf6ff464f03e7 ] hist_bins is an array of type __u32. Each entry represents a 20 bit value. So mask out the unused bits. Signed-off-by: Dafna Hirschfeld Acked-by: Helen Koike Signed-off-by: Hans Verkuil Signed-off-by: Mauro

[PATCH AUTOSEL 5.10 15/36] media: rkisp1: stats: remove a wrong cast to u8

2021-02-08 Thread Sasha Levin
From: Dafna Hirschfeld [ Upstream commit a76f8dc8be471028540df24749e99a3ec0ac7c94 ] hist_bins is an array of type __u32. Each entry represent a 20 bit fixed point value as documented inline. The cast to u8 when setting the values is wrong. Remove it. Signed-off-by: Dafna Hirschfeld

[PATCH AUTOSEL 5.10 14/36] media: rkisp1: uapi: change hist_bins array type from __u16 to __u32

2021-02-08 Thread Sasha Levin
From: Dafna Hirschfeld [ Upstream commit 31f190e0ccac8b75d33fdc95a797c526cf9b149e ] Each entry in the array is a 20 bits value composed of 16 bits unsigned integer and 4 bits fractional part. So the type should change to __u32. In addition add a documentation of how the measurements are done.

Re: [PATCH] staging: fix ignoring return value warning

2021-02-08 Thread Sascha Hauer
Hi Dan, On Mon, Feb 08, 2021 at 04:45:17PM +0300, Dan Carpenter wrote: > On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > > Fix the below ignoring return value warning for device_reset. > > > > drivers/staging/mt7621-dma/mtk-hsdma.c:685:2: warning: ignoring return value > > of

Re: Sound issues with the 5.10.x kernel (alsa)

2021-02-08 Thread Diederik de Haas
On maandag 8 februari 2021 15:00:26 CET Ryutaroh Matsumoto wrote: > > With kernel version 5.10.9 (linux-image-5.10.0-2-arm64) it all seemed > > fixed, but returned with 5.10.12 (linux-image-5.10.0-3-arm64) and is also > > present with 5.10.13. > > The difference in Debian kernel 5.10.9 was that

[PATCH] staging: wfx: fix possible panic with re-queued frames

2021-02-08 Thread Jerome Pouiller
From: Jérôme Pouiller When the firmware rejects a frame (because station become asleep or disconnected), the frame is re-queued in mac80211. However, the re-queued frame was 8 bytes longer than the original one (the size of the ICV for the encryption). So, when mac80211 try to send this frame

Re: [PATCH] staging: fix ignoring return value warning

2021-02-08 Thread Sascha Hauer
On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > Fix the below ignoring return value warning for device_reset. > > drivers/staging/mt7621-dma/mtk-hsdma.c:685:2: warning: ignoring return value > of function declared with 'warn_unused_result' attribute [-Wunused-result] >

[staging:staging-next 67/73] drivers/staging/hikey9xx/hi6421-spmi-pmic.c:238 hi6421_spmi_pmic_probe() warn: 'ddata->irq' not released on lines: 238.

2021-02-08 Thread Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next head: 06b0c0dce88e2aa2f01343db0f26d214d7f264a0 commit: a2e904fc59e15d9e4128415579a2664ab3a1ed14 [67/73] staging: hikey9xx: hi6421-spmi-pmic: cleanup probe code config: x86_64-randconfig-m001-20210207

Re: [PATCH] staging: fix ignoring return value warning

2021-02-08 Thread Dan Carpenter
On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > Fix the below ignoring return value warning for device_reset. > > drivers/staging/mt7621-dma/mtk-hsdma.c:685:2: warning: ignoring return value > of function declared with 'warn_unused_result' attribute [-Wunused-result] >

Re: Sound issues with the 5.10.x kernel (alsa)

2021-02-08 Thread Diederik de Haas
On maandag 8 februari 2021 13:22:56 CET Stefan Wahren wrote: > > TL;DR: I have a RPi 3B+ running pure Debian Bullseye arm64 (~from > > raspi.debian.net), named rpi-mpd, connected via HDMI cable to my AV > > Receiver. > can you please confirm that the bcm2835-audio driver causing the issues? How

Re: [PATCH] staging: fieldbus: arcx-anybus: constify static structs

2021-02-08 Thread Sven Van Asbroeck
Hi Rikard, thank you for the contribution. On Sun, Feb 7, 2021 at 3:25 PM Rikard Falkeborn wrote: > > Constify two static structs which are never modified, to allow the > compiler to put them in read-only memory. > > The only usage of controller_attribute_group is to put its address in an >

Re: [PATCH]: checkpatch: Fixed styling issue

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 06:36:14PM +0530, Mukul Mehar wrote: > >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 > From: Mukul Mehar > Date: Mon, 8 Feb 2021 01:03:06 +0530 > Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. > Signed-off-by: Mukul Mehar >

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-08 Thread Yicong Yang
On 2021/2/8 18:47, Greg KH wrote: > On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote: >> Hi Greg, >> >> On 2021/2/5 17:53, Greg KH wrote: >>> On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: From: Junhao He Use subdir-ccflags-* instead of ccflags-* to inherit

[PATCH]: checkpatch: Fixed styling issue

2021-02-08 Thread Mukul Mehar
>From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 From: Mukul Mehar Date: Mon, 8 Feb 2021 01:03:06 +0530 Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. Signed-off-by: Mukul Mehar This patch fixes a warning, of the line ending with a '(', generated by

Re: Sound issues with the 5.10.x kernel (alsa)

2021-02-08 Thread Stefan Wahren
Hi Diederik, Am 08.02.21 um 12:47 schrieb Diederik de Haas: > Hi, > > This is basically me forwarding the bug I reported on Debian's BTS: > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=978025 > > TL;DR: I have a RPi 3B+ running pure Debian Bullseye arm64 (~from > raspi.debian.net), named

Re: [PATCH] staging: octeon: remove braces from single-line block

2021-02-08 Thread Phillip Potter
On Mon, Feb 08, 2021 at 08:14:02AM +0100, Alexander Sverdlin wrote: > Hi! > > On 06/02/2021 21:17, Phillip Potter wrote: > > This removes the braces from the if statement that checks the > > physical node return value in cvm_oct_phy_setup_device, as this > > block contains only one statement.

Re: [PATCH 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

2021-02-08 Thread Yicong Yang
On 2021/2/6 4:08, Bjorn Helgaas wrote: > On Fri, Feb 05, 2021 at 10:28:32AM -0800, Guenter Roeck wrote: >> On Fri, Feb 05, 2021 at 05:44:13PM +0800, Yicong Yang wrote: >>> From: Junhao He >>> >>> Use subdir-ccflags-* instead of ccflags-* to inherit the debug >>> settings from Kconfig when

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote: > Hi Greg, > > On 2021/2/5 17:53, Greg KH wrote: > > On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: > >> From: Junhao He > >> > >> Use subdir-ccflags-* instead of ccflags-* to inherit the debug > >> settings from Kconfig

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-08 Thread Yicong Yang
Hi Greg, On 2021/2/5 17:53, Greg KH wrote: > On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: >> From: Junhao He >> >> Use subdir-ccflags-* instead of ccflags-* to inherit the debug >> settings from Kconfig when traversing subdirectories. > > That says what you do, but not _why_ you

Re: [PATCH] staging: emxx_udc: Fix incorrectly defined global

2021-02-08 Thread Geert Uytterhoeven
Hi Kumar, CC Nishad, Magnus, linux-renesas-soc, On Sun, Feb 7, 2021 at 8:40 AM Kumar Kartikeya Dwivedi wrote: > On Sun, Feb 07, 2021 at 12:04:41PM IST, Stephen Rothwell wrote: > > Given that drivers/staging/emxx_udc/emxx_udc.h is only included by > > drivers/staging/emxx_udc/emxx_udc.c,

Re Thanks.

2021-02-08 Thread Mr. Richard Thomas
Dear Friend, I will be pleased if you can allow me to invest $104M Dollars in Estate Management,in your company or any area you best that will be of good profit to both of us Please do well to respond including your information for more details. Thanks. Mr.Richard Thomas