On Wed, Mar 17, 2021 at 01:55:40AM -0400, Tong Zhang wrote:
> Thanks for pointing that out.
> Yes you are right there is a mistake.
> I am a human. Human make mistakes. Therefore I make mistakes.
>
Yep. We all make mistakes. One thing to do is if you make a mistake
then check to see if anyone e
On 3/17/21 1:50 AM, Ricardo Ribalda wrote:
> Hi Bingbu
>
> Thanks for your review
>
> On Tue, Mar 16, 2021 at 12:29 PM Bingbu Cao
> wrote:
>>
>> Hi, Ricardo
>>
>> Thanks for your patch.
>> It looks fine for me, do you mind squash 2 patchsets into 1 commit?
>
> Are you sure? There are two dif
On Tue, 2021-03-16 at 20:05 +0800, Qiang Ma wrote:
> Add spaces between operators for a better readability
> in function 'rtw_seccalctkipmic'.
Perhaps better would be to refactor it a bit to
follow the comments. Something like:
---
drivers/staging/rtl8723bs/core/rtw_security.c | 24 ++---
On Tue, Mar 16, 2021 at 06:42:26PM -0400, Tong Zhang wrote:
> request_irq() wont accept a name which contains slash so we need to
> repalce it with something else -- otherwise it will trigger a warning
^^^
I don't normally comment on spelling mistakes in the commit message but
you're copy and
On Mon, Mar 15, 2021 at 05:21:35PM +0100, Jérôme Pouiller wrote:
> Hi Leon,
>
> On Monday 15 March 2021 16:11:52 CET Leon Romanovsky wrote:
> > On Mon, Mar 15, 2021 at 02:24:40PM +0100, Jerome Pouiller wrote:
> > > From: Jérôme Pouiller
> > >
> > > Signed-off-by: Jérôme Pouiller
> > > ---
> > >
Removed additional whitespaces in the r8192U_wx.c file.
Signed-off-by: zhaoxiao
---
v3: add the specify a description of why the patch is needed.
drivers/staging/rtl8192u/r8192U_wx.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/r
defconfig
mips allyesconfig
powerpc allyesconfig
powerpc allmodconfig
powerpc allnoconfig
i386 randconfig-a001-20210316
i386 randconfig
From: Julian Braha
[ Upstream commit 7c36194558cf49a86a53b5f60db8046c5e3013ae ]
When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
Depends on [n]: CRYPTO [=n]
Selected by [m]:
-
From: Julian Braha
[ Upstream commit 7c36194558cf49a86a53b5f60db8046c5e3013ae ]
When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
Depends on [n]: CRYPTO [=n]
Selected by [m]:
-
defconfig
mips allyesconfig
powerpc allyesconfig
powerpc allmodconfig
powerpc allnoconfig
i386 randconfig-a001-20210316
i386 randconfig-a005-20210316
On Tue, Mar 16, 2021 at 6:37 AM Ian Abbott wrote:
>
> Thanks. I think the only other Comedi driver with the same problem is
> "drivers/staging/comedi/drivers/das800.c". It passes dev->board_name as
> the name argument of request_irq(), but that is "cio-das802/16" for one
> of the boards supporte
request_irq() wont accept a name which contains slash so we need to
repalce it with something else -- otherwise it will trigger a warning
and the entry in /proc/irq/ will not be created
since the .name might be used by userspace and we don't want to break
userspace, so we are changing the parameter
On Tue, Mar 16, 2021 at 7:17 PM Edmundo Carmona Antoranz
wrote:
>
> Removing 2 instances of alignment warnings
>
> drivers/staging/vt6655/rxtx.h:153:1: warning: alignment 1 of ‘struct vnt_cts’
> is less than 2 [-Wpacked-not-aligned]
> drivers/staging/vt6655/rxtx.h:163:1: warning: alignment 1 of ‘
Removing 2 instances of alignment warnings
drivers/staging/vt6655/rxtx.h:153:1: warning: alignment 1 of ‘struct vnt_cts’
is less than 2 [-Wpacked-not-aligned]
drivers/staging/vt6655/rxtx.h:163:1: warning: alignment 1 of ‘struct
vnt_cts_fb’ is less than 2 [-Wpacked-not-aligned]
The root cause se
Hi Bingbu
Thanks for your review
On Tue, Mar 16, 2021 at 12:29 PM Bingbu Cao wrote:
>
> Hi, Ricardo
>
> Thanks for your patch.
> It looks fine for me, do you mind squash 2 patchsets into 1 commit?
Are you sure? There are two different issues that we are solving.
Best regards!
>
> On 3/15/21 8
The * of the comment was not aligned properly. Ran checkpatch and
found the warning. Resolved it in this patch.
Signed-off-by: Anish Udupa
---
drivers/staging/qlge/qlge_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/q
remove conditional code blocks checked by unused
CONFIG_MULTI_VIR_IFACES
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/drv_types.h | 3 ---
1 file changed, 3 deletions(-)
dif
remove conditional code blocks checked by unused
CONFIG_R871X_TEST
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/osdep_intf.h | 6 --
1 file changed, 6 deletions(-)
diff
remove conditional code blocks checked by unused
CONFIG_BSD_RX_USE_MBUF
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/rtw_recv.h | 5 -
1 file changed, 5 deletions(-)
dif
remove conditional code blocks checked by unused
CONFIG_RX_INDICATE_QUEUE
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/rtw_recv.h | 4
1 file changed, 4 deletions(-)
di
remove conditional code blocks checked by unused
CONFIG_SINGLE_RECV_BUF
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/rtw_recv.h | 8 ++--
1 file changed, 2 insertions(+),
remove conditional code blocks checked by unused
CONFIG_USB_VENDOR family defines
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/drv_conf.h | 10 --
1 file changed, 10
remove conditional code blocks checked by unused
CONFIG_LAYER2_ROAMING_ACTIVE
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 ---
1 file changed, 3 deletions(-)
di
remove conditional code blocks checked by unused
CONFIG_VALIDATE_SSID
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 11 ---
1 file changed, 11 deletions
remove conditional code blocks checked by unused
CONFIG_UPDATE_INDICATE_SEQ_WHILE_PROCESS_ADDBA_REQ
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 8
1
remove conditional code blocks checked by unused
CONFIG_DISABLE_MCS13TO15
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 16 +---
drivers/staging/rtl
remove conditional code blocks checked by unused
CONFIG_INTERRUPT_BASED_TXBCN family defines
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 30 ++-
remove conditional code blocks checked by unused
CONFIG_CMCC_TEST
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Signed-off-by: Fabio Aiuto
---
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 19 ---
1 file changed, 19 deleti
Remove unused code clocks, as required in TODO list:
find and remove code blocks guarded by never set CONFIG_FOO defines
Fabio Aiuto (12):
staging: rtl8723bs: remove unused code blocks
conditioned by never set CONFIG_CMCC_TEST
staging: rtl8723bs: remove unused code blocks conditio
remove conditional code blocks checked by unused
CONFIG_GPIO_API
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Changes in v2:
rebase of conflicting code in public staging-testing
Signed-off-by: Fabio Aiuto
---
.../staging/rtl8723bs
remove conditional code blocks checked by unused CONFIG_AP_WOWLAN
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
Changes in v2:
rebase of conflicting code with public tree
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/cor
On Tue, Mar 16, 2021 at 12:39:19PM +0100, Greg KH wrote:
> On Mon, Mar 15, 2021 at 11:15:02AM +0100, Fabio Aiuto wrote:
> > remove conditional code blocks checked by unused CONFIG_PM
> >
> > cleaning required in TODO file:
> >
> > find and remove code blocks guarded by never set CONFIG_FOO define
On Mon, Mar 15, 2021 at 11:13:49AM +0100, Fabio Aiuto wrote:
> Remove unused code blocks as required in TODO file
>
> Fabio Aiuto (15):
> staging: rtl8723bs: remove unused code blocks conditioned by never set
> CONFIG_AUTO_AP_MODE
> staging: rtl8723bs: remove unused code blocks conditioned
Add spaces between operators for a better readability
in function 'rtw_seccalctkipmic'.
Signed-off-by: Qiang Ma
---
drivers/staging/rtl8723bs/core/rtw_security.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c
b/drivers/sta
Fixed the indentation of the else part of the conditional statement.
Signed-off-by: Shreya Ajith
---
v1-> v2:
Changed name in signed-off-by to match name in From.
v2-> v3:
Reversed the change and made change in From instead.
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
1 file changed,
On Mon, Mar 15, 2021 at 11:15:02AM +0100, Fabio Aiuto wrote:
> remove conditional code blocks checked by unused CONFIG_PM
>
> cleaning required in TODO file:
>
> find and remove code blocks guarded by never set CONFIG_FOO defines
>
> Signed-off-by: Fabio Aiuto
> ---
> drivers/staging/rtl8723bs
On Mon, Mar 15, 2021 at 07:12:20PM +0800, Hao Peng wrote:
> Add one empty line upon return for easy reading.
Why? Is this really needed?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driver
On Mon, Mar 15, 2021 at 07:04:18PM +0800, Hao Peng wrote:
> Remove extra lines in rtl819x_BAProc.c.
>
> Signed-off-by: Hao Peng
Same issue here, please fix up the changelog text.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linu
On Mon, Mar 15, 2021 at 06:33:20PM +0800, Hao Peng wrote:
> Remove extra spaces in rtl819x_BAProc.c.
That says what you did, but not _why_ you are doing this.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what is needed in or
Hi, Ricardo
Thanks for your patch.
It looks fine for me, do you mind squash 2 patchsets into 1 commit?
On 3/15/21 8:34 PM, Ricardo Ribalda wrote:
> We are losing the reference to an allocated memory if try. Change the
> order of the check to avoid that.
>
> Cc: sta...@vger.kernel.org
> Fixes: 6d
On Sun, Mar 14, 2021 at 09:58:55PM +0530, Shreya wrote:
> Fixed the indentation of the else part of the conditional statement.
>
> Signed-off-by: Shreya
> ---
> v1 -> v2:
> Changed name in signed-off-by to match name in From
No, change it the other way around, you had your "real" name in the
sig
On Tue, Mar 16, 2021 at 05:59:22PM +0800, zhaoxiao wrote:
> Remove extra lines in the struct r8192_private_args.
>
> Signed-off-by: zhaoxiao
> ---
> drivers/staging/rtl8192u/r8192U_wx.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
> b/drivers/
On Tue, Mar 16, 2021 at 06:03:17PM +0800, 赵晓 wrote:
> This email message is intended only for the use of the individual or entity
> who
> /which is the intended recipient and may contain information that is
> privileged
> or confidential. If you are not the intended recipient, you are hereby
> n
On 15/03/2021 20:00, Tong Zhang wrote:
Thanks Ian,
I have submitted a v2 patch based on your suggestions.
Thanks,
- Tong
Thanks. I think the only other Comedi driver with the same problem is
"drivers/staging/comedi/drivers/das800.c". It passes dev->board_name as
the name argument of request
On 15/03/2021 19:58, Tong Zhang wrote:
request_irq() wont accept a name which contains slash so we need to
repalce it with something else -- otherwise it will trigger a warning
and the entry in /proc/irq/ will not be created
since the .name might be used by userspace and we don't want to break
us
On 15/03/2021 19:59, Tong Zhang wrote:
request_irq() wont accept a name which contains slash so we need to
repalce it with something else -- otherwise it will trigger a warning
and the entry in /proc/irq/ will not be created
since the .name might be used by userspace and we don't want to break
us
From: Greg Kroah-Hartman
The drivers/staging/ tree has a new mailing list,
linux-stag...@lists.linux.dev, so move the MAINTAINER entry to point to
it so that we get patches sent to the proper place.
There was no need to specify a list for the hikey9xx driver, the tools
pick up the "base" list fo
Remove extra lines in the struct r8192_private_args.
Signed-off-by: zhaoxiao
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 6ead461e3279..e9de7dc8f049 100644
--- a/d
On Mon, Mar 15, 2021 at 06:05:21PM +0100, Marco Cesati wrote:
> This set of patches fixes 522 checkpatch.pl errors of type
> POINTER_LOCATION in the staging/rtl8723bs souce code. Every patch is
> purely syntactical: it does not change the generated machine code.
> Furthermore, every single patch le
> Subject: [kbuild-all] Re: [PATCH] wfx: fix irqf_oneshot.cocci warnings
>
> Hello,
>
> On Monday 15 March 2021 22:09:20 CET kernel test robot wrote:
> >
> > From: kernel test robot
> >
> > drivers/net/wireless/silabs/wfx/bus_sdio.c:134:8-33: ERROR: Threaded IRQ
> > with no primary handler requ
From: Krzysztof Kozlowski
COMMON_CLK is a user-selectable option with its own dependencies. The
most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers
should not select COMMON_CLK because they will create a dependency cycle
and build failures.
Signed-off-by: Krzysztof Kozlowski
Hello,
On Monday 15 March 2021 22:09:20 CET kernel test robot wrote:
>
> From: kernel test robot
>
> drivers/net/wireless/silabs/wfx/bus_sdio.c:134:8-33: ERROR: Threaded IRQ with
> no primary handler requested without IRQF_ONESHOT
>
> Since commit 1c6c69525b40 ("genirq: Reject bogus threaded
52 matches
Mail list logo
