[driver-core:umn.edu-reverts-round2] BUILD SUCCESS d0d179fc4d792164b97135263d5561f77476311d

2021-04-28 Thread kernel test robot
ig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a005-20210428 i386 randconfig-a002-20210428 i386 randconfig-a001-20210428 i386 randconfig-a006-202

[driver-core:umn.edu-reverts] BUILD SUCCESS 73d201b5c3bcd9af293eb8b5f8010f479b96a590

2021-04-28 Thread kernel test robot
nfig sparc defconfig mips allyesconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a005-20210428 i386

[driver-core:readfile] BUILD SUCCESS eb9c2f4bdf48492684e41e3ebd1304e006db6492

2021-04-28 Thread kernel test robot
allyesconfig nds32 allnoconfig mips allyesconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a005-20210428

Re: [PATCH v4 79/79] media: hantro: do a PM resume earlier

2021-04-28 Thread Ezequiel Garcia
Hi Mauro, Thanks a lot for taking care of this. On Wed, 2021-04-28 at 16:52 +0200, Mauro Carvalho Chehab wrote: > The device_run() first enables the clock and then > tries to resume PM runtime, checking for errors. > > Well, if for some reason the pm_runtime can not resume, > it would be better

Re: [PATCH v4 78/79] media: hantro: use pm_runtime_resume_and_get()

2021-04-28 Thread Ezequiel Garcia
On Wed, 2021-04-28 at 16:52 +0200, Mauro Carvalho Chehab wrote: > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with > usage counter") > added pm_runtime_resume_and_get() in order to automatically handle > dev->power.usage_count decrement on errors. > > While there's no

Re: [PATCH v4 00/79] Address some issues with PM runtime at media subsystem

2021-04-28 Thread Johan Hovold
On Wed, Apr 28, 2021 at 04:51:21PM +0200, Mauro Carvalho Chehab wrote: > During the review of the patches from unm.edu, one of the patterns > I noticed is the amount of patches trying to fix pm_runtime_get_sync() > calls. > > After analyzing the feedback from version 1 of this series, I noticed >

Re: [PATCH v4 20/79] staging: media: rkvdec: fix pm_runtime_get_sync() usage count

2021-04-28 Thread Johan Hovold
On Wed, Apr 28, 2021 at 04:51:41PM +0200, Mauro Carvalho Chehab wrote: > The pm_runtime_get_sync() internally increments the > dev->power.usage_count without decrementing it, even on errors. > Replace it by the new pm_runtime_resume_and_get(), introduced by: > commit dd8088d5a896 ("PM: runtime: Add

[PATCH v4 25/79] staging: media: tegra-vde: use pm_runtime_resume_and_get()

2021-04-28 Thread Mauro Carvalho Chehab
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho C

[PATCH v4 20/79] staging: media: rkvdec: fix pm_runtime_get_sync() usage count

2021-04-28 Thread Mauro Carvalho Chehab
The pm_runtime_get_sync() internally increments the dev->power.usage_count without decrementing it, even on errors. Replace it by the new pm_runtime_resume_and_get(), introduced by: commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") in order to properly d

[PATCH v4 78/79] media: hantro: use pm_runtime_resume_and_get()

2021-04-28 Thread Mauro Carvalho Chehab
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. While there's nothing wrong with the current usage on this driver, as we're getting rid of t

[PATCH v4 26/79] staging: media: tegra-video: use pm_runtime_resume_and_get()

2021-04-28 Thread Mauro Carvalho Chehab
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho C

[PATCH v4 79/79] media: hantro: do a PM resume earlier

2021-04-28 Thread Mauro Carvalho Chehab
The device_run() first enables the clock and then tries to resume PM runtime, checking for errors. Well, if for some reason the pm_runtime can not resume, it would be better to detect it beforehand. So, change the order inside device_run(). Signed-off-by: Mauro Carvalho Chehab --- drivers/stag

[PATCH v4 00/79] Address some issues with PM runtime at media subsystem

2021-04-28 Thread Mauro Carvalho Chehab
During the review of the patches from unm.edu, one of the patterns I noticed is the amount of patches trying to fix pm_runtime_get_sync() calls. After analyzing the feedback from version 1 of this series, I noticed a few other weird behaviors at the PM runtime resume code. So, this series start ad

[PATCH v4 24/79] staging: media: cedrus_video: use pm_runtime_resume_and_get()

2021-04-28 Thread Mauro Carvalho Chehab
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho C

[PATCH v4 22/79] staging: media: imx7-mipi-csis: use pm_runtime_resume_and_get()

2021-04-28 Thread Mauro Carvalho Chehab
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Acked-by: Rui Miguel Silva Sig

[PATCH v4 21/79] staging: media: atomisp: use pm_runtime_resume_and_get()

2021-04-28 Thread Mauro Carvalho Chehab
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho C

[PATCH v4 23/79] staging: media: ipu3: use pm_runtime_resume_and_get()

2021-04-28 Thread Mauro Carvalho Chehab
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho C

Re: [PATCH v3 79/79] media: hantro: document the usage of pm_runtime_get_sync()

2021-04-28 Thread Ezequiel Garcia
Hi Mauro, On Wed, 2021-04-28 at 08:44 +0200, Mauro Carvalho Chehab wrote: > Em Wed, 28 Apr 2021 08:27:42 +0200 > Mauro Carvalho Chehab escreveu: > > > Em Tue, 27 Apr 2021 12:18:32 -0300 > > Ezequiel Garcia escreveu: > > > > > On Tue, 2021-04-27 at 16:08 +0100, Robin Murphy wrote:  > > > > On

Re: [PATCH 00/78] media: use pm_runtime_resume_and_get() instead of pm_runtime_get_sync()

2021-04-28 Thread Dan Carpenter
There was a Smatch check for these bugs. This was a good source of recurring Reported-by tags for me. ;) Thanks for doing this. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman

Re: [PATCH v3 25/79] staging: media: vde: use pm_runtime_resume_and_get()

2021-04-28 Thread Dmitry Osipenko
28.04.2021 10:20, Mauro Carvalho Chehab пишет: > Em Tue, 27 Apr 2021 14:47:01 +0300 > Dmitry Osipenko escreveu: > >> 27.04.2021 13:26, Mauro Carvalho Chehab пишет: >>> @@ -1088,8 +1090,9 @@ static int tegra_vde_remove(struct platform_device >>> *pdev) >>> { >>> struct tegra_vde *vde = platf

Re: [PATCH] staging: rtl8192e: fix array of flexible structures

2021-04-28 Thread Jitendra
On Wed, Apr 28, 2021 at 08:01:21AM +0200, Greg KH wrote: On Wed, Apr 28, 2021 at 12:28:44AM +0530, Jitendra wrote: On Tue, Apr 27, 2021 at 08:10:20PM +0200, Greg KH wrote: > On Tue, Apr 27, 2021 at 11:19:45PM +0530, Jitendra Khasdev wrote: > > This patch fixes sparse warning "array of flexible s

Re: [PATCH v3 25/79] staging: media: vde: use pm_runtime_resume_and_get()

2021-04-28 Thread Mauro Carvalho Chehab
Em Tue, 27 Apr 2021 14:47:01 +0300 Dmitry Osipenko escreveu: > 27.04.2021 13:26, Mauro Carvalho Chehab пишет: > > @@ -1088,8 +1090,9 @@ static int tegra_vde_remove(struct platform_device > > *pdev) > > { > > struct tegra_vde *vde = platform_get_drvdata(pdev); > > struct device *dev = &p