Re: [PATCH] staging: octeon: remove braces from single-line block

2021-02-07 Thread Alexander Sverdlin
t;, 0); > - if (!phy_node && of_phy_is_fixed_link(priv->of_node)) { > + if (!phy_node && of_phy_is_fixed_link(priv->of_node)) > phy_node = of_node_get(priv->of_node); > - } > if (!phy_node) > goto no_phy; &g

Re: [PATCH v2 net] staging: octeon: Drop on uncorrectable alignment or FCS error

2020-10-19 Thread Alexander Sverdlin
what is going on here. Can this > incorrectly match a destination MAC address of xD:XX:XX:XX:XX:XX. > >> /* Port received 0xd preamble */ >> work->packet_ptr.s.addr += i; >> work->word1.len -= i + 4; -- Best regards, Alexander Sverdlin. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] stating: octeon: Drop on uncorrectable alignment or FCS error

2020-10-12 Thread Alexander Sverdlin
dented to match the old code and it no longer matches. > (Please update the whitespace). thanks to your comment I took a fresh look onto the patch and found a logic error in the change. Please ignore the whole patch for now. >> /* >> * We r

Re: [PATCH] staging: octeon: Drop on uncorrectable alignment or FCS error

2020-10-09 Thread Alexander Sverdlin
Hello Greg, On 10/01/2020 13:48, Greg Kroah-Hartman wrote: > On Wed, Jan 08, 2020 at 05:10:42PM +0100, Alexander X Sverdlin wrote: >> From: Alexander Sverdlin >> >> Currently in case of alignment or FCS error if the packet cannot be >> corrected it's still not dropped

Re: [PATCH] staging: octeon: repair "fixed-link" support

2020-10-09 Thread Alexander Sverdlin
Hello Greg, Dave and all, the below patch is still applicable as-is, would you please re-consider it now, as the driver has been undeleted? On 08/01/2020 17:09, Alexander X Sverdlin wrote: > From: Alexander Sverdlin > > The PHYs must be registered once in device probe function, not

Re: [PATCH 01/23] mtd: rawnand: plat_nand: Pass a nand_chip object to all platform_nand_ctrl hooks

2018-08-19 Thread Alexander Sverdlin
the platform_nand_ctrl hooks to take a nand_chip object instead of an mtd_info. We had temporary plat_nand_xxx() wrappers to the do the mtd -> chip conversion, but those will be dropped when doing the patching nand_chip hooks to take a nand_chip object. Signed-off-by: Boris Brezillon Reviewed-by: Alexander Sverd