[PATCH v2] staging:rtl8723bs: removed unwanted if..else condition

2019-10-17 Thread Aliasgar Surti
From: Aliasgar Surti There is use of if..elseif..else condition which has same logic in all three blocks. Removed if..else block and placed log message instead that. Signed-off-by: Aliasgar Surti --- v2: Fixed alignment problem. --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 16

Re: [PATCH] staging:rtl8723bs: removed unwanted if..else condition

2019-10-17 Thread Aliasgar Surti
On Wed, Oct 16, 2019 at 05:59:50PM +0300, Dan Carpenter wrote: > On Wed, Oct 16, 2019 at 07:37:53PM +0530, Aliasgar Surti wrote: > > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c > > @@ -507,19 +507,9 @@ int rtw_cmd

[PATCH] staging:rtl8723bs: removed unwanted if..else condition

2019-10-16 Thread Aliasgar Surti
From: Aliasgar Surti There is use of if..elseif..else condition which has same logic in all three blocks. Removed if..else block and placed log message instead that. Signed-off-by: Aliasgar Surti --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 16 +++- 1 file changed, 3 insertions

[PATCH] drivers:staging:qlge: Removed unnecessary variable

2019-09-18 Thread Aliasgar Surti
From: Aliasgar Surti coccicheck reported warning for unnecessary variable used. This patch fixes the same by removing the variable and returning value directly. Signed-off-by: Aliasgar Surti --- drivers/staging/qlge/qlge_dbg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH v2] drivers:staging:rtl8723bs: Removed unneeded variables

2019-09-18 Thread Aliasgar Surti
From: Aliasgar Surti coccicheck reported warning for unneeded variable used. This patch removes the unneeded variables. Signed-off-by: Aliasgar Surti --- v2: removed unneeded functions and replaced them with NULL in function array. --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 54

[PATCH] drivers:staging:rtl8723bs: Removed unneeded variables

2019-09-17 Thread Aliasgar Surti
From: Aliasgar Surti coccicheck reported warning for unneeded variable used. This patch removes the unneeded variables. Signed-off-by: Aliasgar Surti --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git

[PATCH 1/1] staging: media: fix style problem

2019-06-21 Thread Aliasgar Surti
From: Aliasgar Surti checkpatch reported "WARNING: line over 80 characters". This patch fixes the warning for file soc_camera/soc_ov5642.c Signed-off-by: Aliasgar Surti --- drivers/staging/media/soc_camera/soc_ov5642.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)