Re: [PATCH v2] staging: greybus: Use gpio_is_valid()

2018-05-02 Thread Arvind Yadav
On Wednesday 02 May 2018 03:27 PM, Johan Hovold wrote: On Wed, May 02, 2018 at 03:15:05PM +0530, Arvind Yadav wrote: On Wednesday 02 May 2018 02:13 PM, Johan Hovold wrote: On Sat, Apr 28, 2018 at 10:05:39AM +0530, Arvind Yadav wrote: Replace the manual validity checks for the GPIO

Re: [PATCH v2] staging: greybus: Use gpio_is_valid()

2018-05-02 Thread Arvind Yadav
On Wednesday 02 May 2018 02:13 PM, Johan Hovold wrote: On Sat, Apr 28, 2018 at 10:05:39AM +0530, Arvind Yadav wrote: Replace the manual validity checks for the GPIO with the gpio_is_valid(). Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- chnage in v2 : Ret

Re: [greybus-dev] [PATCH] staging: greybus: Use gpio_is_valid()

2018-04-27 Thread Arvind Yadav
On Friday 27 April 2018 05:47 PM, Alex Elder wrote: On 04/27/2018 05:52 AM, Arvind Yadav wrote: Replace the manual validity checks for the GPIO with the gpio_is_valid(). I haven't looked through the code paths very closely, but I think that get_named_gpio() might return -EPROBE_DEFER, which

[PATCH] staging: greybus: Use gpio_is_valid()

2018-04-27 Thread Arvind Yadav
Replace the manual validity checks for the GPIO with the gpio_is_valid(). Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/greybus/arche-platform.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/arche-plat

[PATCH] vmbus: use put_device() if device_register fail

2018-03-18 Thread Arvind Yadav
if device_register() returned an error. Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/hv/vmbus_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c

[PATCH 0/3] Handle return value of platform_get_irq

2017-11-30 Thread Arvind Yadav
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Remove unnecessary 'err' initialization for irda driver. Arvind Yadav (3): [PATCH 1/3] iio: trigger: Fix platform_get_irq's error

[PATCH 3/3] staging: irda: Remove unnecessary 'err' initialization.

2017-11-30 Thread Arvind Yadav
Here, variable 'err' is already initialised. So no need to reinitialize. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/irda/drivers/pxaficp_ir.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/irda/drivers/pxaficp_ir.c b/drivers/stagin

[PATCH 1/3] iio: trigger: Fix platform_get_irq's error checking

2017-11-30 Thread Arvind Yadav
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 4 ++--

[PATCH 2/3] staging: irda: Handle return value of platform_get_irq

2017-11-30 Thread Arvind Yadav
platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/irda/drivers/pxaficp_ir.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/irda/drivers/pxaficp_ir.c b/drivers/s

[PATCH 1/4] staging: ccree: Remove a attribute group from a kobject

2017-11-24 Thread Arvind Yadav
All attribute group created during sys_init_dir() should be removed in sys_free_dir() Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/ccree/ssi_sysfs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_sysfs.c b/d

[PATCH 4/4] staging: most: Remove a attribute group from a kobject

2017-11-24 Thread Arvind Yadav
All attribute group created during dim2_sysfs_probe() should be removed in dim2_sysfs_destroy(). Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/most/hdm-dim2/dim2_sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/most/hdm-dim2/dim2_s

[PATCH 2/4] staging: lustre: ldlm: Remove a attribute group from a kobject

2017-11-24 Thread Arvind Yadav
All attribute group created during ldlm_setup() should be removed in ldlm_cleanup(). Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/

[PATCH 0/4] Remove a attribute group from a kobject

2017-11-24 Thread Arvind Yadav
Arvind Yadav (4): [PATCH 1/4] staging: ccree: Remove a attribute group from a kobject [PATCH 2/4] staging: lustre: ldlm: Remove a attribute group from a kobject [PATCH 3/4] staging: lustre: obdclass: Remove a attribute group from a kobject [PATCH 4/4] staging: most: Remove a attribute

[PATCH 3/4] staging: lustre: obdclass: Remove a attribute group from a kobject

2017-11-24 Thread Arvind Yadav
All attribute group created during class_procfs_init() should be removed. if class_procfs_init() will fail and also in class_procfs_clean(). Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 3 +++ 1 file chan

[PATCH] staging: comedi: ni_atmio: Handle return value of pnp_*

2017-11-15 Thread Arvind Yadav
pnp_irq() and pnp_port_start() can fail here and we must check its return value. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/comedi/drivers/ni_atmio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/d

[PATCH] staging: rtl8192e: set priv->irq as 0 after the irq is freed

2017-10-28 Thread Arvind Yadav
_rtl92e_init can fail here, we must set priv->irq as 0 after free_irq. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/driver

[PATCH] staging: rtl8723bs: Fix space before '[' error.

2017-10-25 Thread Arvind Yadav
Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/

[PATCH v2] staging: comedi: dt282x: fix IRQ assignment for dev->irq.

2017-10-06 Thread Arvind Yadav
Here, dev->irq is not assigned with irq. comedi_legacy_detach() is using dev->irq for release irq and dt282x_attach() is using dev->irq for initialize comedi_subdevice. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- changes in v2: comedi_isadma_alloc() can f

[PATCH] staging: comedi: dt282x: fix IRQ assignment for dev->irq.

2017-10-06 Thread Arvind Yadav
Here, dev->irq is not assigned with irq(irq_num). comedi_legacy_detach() is using dev->irq for release irq and dt282x_attach() is using dev->irq for initialize comedi_subdevice. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/comedi/drivers/dt282x.c

[PATCH] staging: comedi: dt282x: release irq on dt282x detach

2017-10-06 Thread Arvind Yadav
free_irq() should be called on driver 'dt282x' detach. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/comedi/drivers/dt282x.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/comedi/drivers/dt282x.c b/drivers/staging/comedi/drivers/dt

[PATCH 4/4] staging: rtlwifi: pr_err() strings should end with newlines

2017-10-03 Thread Arvind Yadav
pr_err() messages should end with a new-line to avoid other messages being concatenated. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c | 6 +++--- drivers/staging/rtlwifi/rtl8822be/phy.c | 4 +

[PATCH 3/4] staging: bcm2835-camera: pr_err() strings should end with newlines

2017-10-03 Thread Arvind Yadav
pr_err() messages should end with a new-line to avoid other messages being concatenated. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s

[PATCH 0/4] staging: rtlwifi: pr_err() strings should end with newlines

2017-10-03 Thread Arvind Yadav
pr_err() messages should end with a new-line to avoid other messages being concatenated. Arvind Yadav (4): [PATCH 1/4] staging: gs_fpgaboot: pr_err() strings should end with newlines [PATCH 2/4] staging: media: davinci_vpfe: pr_err() strings should end with newlines [PATCH 3/4] staging

[PATCH 2/4] staging: media: davinci_vpfe: pr_err() strings should end with newlines

2017-10-03 Thread Arvind Yadav
pr_err() messages should end with a new-line to avoid other messages being concatenated. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 1/4] staging: gs_fpgaboot: pr_err() strings should end with newlines

2017-10-03 Thread Arvind Yadav
pr_err() messages should end with a new-line to avoid other messages being concatenated. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gs_fp

[PATCH] HID: hyperv: pr_err() strings should end with newlines

2017-09-25 Thread Arvind Yadav
pr_err() messages should terminated with a new-line to avoid other messages being concatenated onto the end. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/hid/hid-hyperv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-hyperv.c b/d

Re: [PATCH] ANDROID: binder: pr_err() strings should end with newlines

2017-09-25 Thread Arvind Yadav
On Monday 25 September 2017 12:31 PM, Greg KH wrote: On Mon, Sep 25, 2017 at 12:21:47PM +0530, Arvind Yadav wrote: Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- I can't take patches without any changelog text, sorry. As per your concern, I will update. greg k-h ~

[PATCH] ANDROID: binder: pr_err() strings should end with newlines

2017-09-25 Thread Arvind Yadav
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/android/binder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index d055b3f..044b1c2 100644 --- a/drivers/android/binder.c +++ b/drivers/android/bi

[PATCH] staging: greybus: light: remove unnecessary error check

2017-09-23 Thread Arvind Yadav
It is not necessary to check return value of gb_lights_channel_flash_config. gb_lights_channel_config returns both successful and error value. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/greybus/light.c | 6 +- 1 file changed, 1 insertion(+), 5 del

[PATCH v3] staging: greybus: light: Release memory obtained by kasprintf

2017-09-23 Thread Arvind Yadav
Free memory region, if gb_lights_channel_config is not successful. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- changes in v2: - Subject line changed. - add kfree in __gb_lights_led_unregister(). - No need to check return

[PATCH v2] staging: greybus: light: Release memory obtained by kasprintf

2017-09-21 Thread Arvind Yadav
- Free memory region, if gb_lights_channel_config is not successful. - No need to add check for gb_lights_channel_flash_config(). Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- changes in v2: - Subject line changed. - add kfree in __gb_lights_led_unre

[PATCH] media: staging: greybus: Release memory obtained by kasprintf

2017-09-21 Thread Arvind Yadav
Free memory region, if gb_lights_channel_config is not successful. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/greybus/light.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/g

[PATCH] Staging: atomisp: constify driver_attribute

2017-08-31 Thread Arvind Yadav
driver_attribute are not supposed to change at runtime. Functions driver_create_file/driver_remove_file are working with const driver_attribute. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/media/atomisp/pci/at

[PATCH] staging: lustre: constify cl_lock_operations

2017-08-27 Thread Arvind Yadav
cl_lock_operations are not supposed to change at runtime. cl_lock_slice_add is working with const cl_lock_operations. So mark the non-const cl_lock_operations structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/lustre/lustre/obdecho/echo_client

[PATCH] staging: atomisp: constify v4l2_subdev_sensor_ops

2017-08-26 Thread Arvind Yadav
v4l2_subdev_sensor_ops are not supposed to change at runtime. v4l2_subdev_sensor_ops are working with const 'sensor' field of sturct v4l2_subdev_ops. So mark the non-const v4l2_subdev_sensor_ops structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging

Re: [PATCH 4/4] staging: iio: tsl2x7x: constify i2c_device_id

2017-08-21 Thread Arvind Yadav
Hi On Tuesday 22 August 2017 01:50 AM, Dan Carpenter wrote: Don't say "[PATCH 4/4]". It's not a patchset or a part of an email thread. Yes, It's part of these patchset. [PATCH 1/4] misc: apds9802als: constify i2c_device_id [PATCH 2/4] misc: hmc6352: constify i2c_device_id [PATCH 3/4]

[PATCH 4/4] staging: iio: tsl2x7x: constify i2c_device_id

2017-08-21 Thread Arvind Yadav
i2c_device_id are not supposed to change at runtime. All functions working with i2c_device_id provided by work with const i2c_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/iio/light/tsl2x7x.c | 2 +- 1 file c

[PATCH] staging: vboxvideo: constify drm_fb_helper_funcs

2017-08-21 Thread Arvind Yadav
drm_fb_helper_funcs are not supposed to change at runtime. All functions working with drm_fb_helper_funcs provided by work with const drm_fb_helper_funcs. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/vboxvideo/vbox_fb

[PATCH] staging: greybus: audio: constify snd_soc_dai_ops structures

2017-08-20 Thread Arvind Yadav
snd_soc_dai_ops are not supposed to change at runtime. All functions working with snd_soc_dai_ops provided by work with const snd_soc_dai_ops. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/greybus/audio_codec.c | 2 +-

[PATCH] staging: most: hdm-dim2: constify platform_device_id

2017-08-13 Thread Arvind Yadav
platform_device_id are not supposed to change at runtime. All functions working with platform_device_id provided by work with const platform_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/most/hdm-dim2/dim2

[PATCH] staging: bcm2835-audio: constify snd_pcm_ops structures

2017-08-09 Thread Arvind Yadav
snd_pcm_ops are not supposed to change at runtime. All functions working with snd_pcm_ops provided by work with const snd_pcm_ops. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm

[PATCH 1/3] staging: most: usb: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/most/hdm-usb/hdm_usb.c | 2 +-

[PATCH 2/3] staging: rtl8188eu: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-

[PATCH 3/3] staging: rtl8712: constify usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/rtl8712/usb_intf.c | 2 +- 1 file c

[PATCH 0/3] constify staging usb_device_id

2017-08-08 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Arvind Yadav (3): [PATCH 1/3] staging: most: usb: constify usb_device_id [PATCH 2/3] staging: rtl8188eu: constify

[PATCH] staging: ccree: constify dev_pm_ops structures.

2017-08-08 Thread Arvind Yadav
dev_pm_ops are not supposed to change at runtime. All functions working with dev_pm_ops provided by work with const dev_pm_ops. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/ccree/ssi_driver.c | 2 +- 1 file chan

[PATCH v3 2/3] staging: lustre: ldlm: constify attribute_group structures.

2017-07-21 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- Changes in v2: patch wa

[PATCH v3 1/3] staging: lustre: constify attribute_group structures.

2017-07-21 Thread Arvind Yadav
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- Changes in v2: Fix kbuild error: conflicting types for 'lprocfs_obd_setup'. By changing protype of 'lprocfs_obd_setup'. Changes in v3: typo error in cover-latter. drivers/staging/lustre/

[PATCH v3 3/3] staging: lustre: obdclass: linux: constify attribute_group structures.

2017-07-21 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- Changes in v2: patch wa

[PATCH v3 0/3] Constify lustre attribute_group structures.

2017-07-21 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (3): [PATCH v3 1/3] staging: lustre: constify attribute_group structures. [PATCH v3 2/3

[PATCH v2 0/3] Constify lustre attribute_group structures.

2017-07-20 Thread Arvind Yadav
ttribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (3): [PATCH v2 1/3] staging: lustre: constify attribute_group structures. [PATCH v2 2/3

[PATCH v2 3/3] staging: lustre: obdclass: linux: constify attribute_group structures.

2017-07-20 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- Changes in v2: patch wa

[PATCH v2 2/3] staging: lustre: ldlm: constify attribute_group structures.

2017-07-20 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- Changes in v2: patch wa

[PATCH v2 1/3] staging: lustre: constify attribute_group structures.

2017-07-20 Thread Arvind Yadav
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- Changes in v2: Fix kbuild error: conflicting types for 'lprocfs_obd_setup'. By changing protype of 'lprocfs_obd_setup'. drivers/staging/lustre/lustre/include/lprocfs_status.h | 4 ++-- drivers/staging/

[PATCH v4] staging: unisys: visorbus: Constify attribute_group structures.

2017-07-18 Thread Arvind Yadav
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- Changes in v2: Change lo

Re: [PATCH v3] staging: unisys: visorbus: Constify attribute_group structures.

2017-07-18 Thread Arvind Yadav
Hi Greg, On Tuesday 18 July 2017 01:30 PM, Greg KH wrote: On Tue, Jul 18, 2017 at 01:24:42PM +0530, Arvind Yadav wrote: attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs

[PATCH v3] staging: unisys: visorbus: Constify attribute_group structures.

2017-07-18 Thread Arvind Yadav
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/unisys/visorbus/visorbus_main

[PATCH v2] staging: unisys: visorbus: Constify attribute_group structures.

2017-07-17 Thread Arvind Yadav
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- Changes in v2: Change lo

Re: [PATCH] staging: unisys: visorbus: constify attribute_group structures.

2017-07-17 Thread Arvind Yadav
Hi Greg, On Monday 17 July 2017 04:15 PM, Greg KH wrote: On Mon, Jul 17, 2017 at 02:55:37PM +0530, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const

[PATCH] staging: unisys: visorbus: constify attribute_group structures.

2017-07-17 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/unisys/visorbus/visorbus_

Re: [PATCH 1/4] staging: lustre: constify attribute_group structures.

2017-07-17 Thread Arvind Yadav
git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arvind-Yadav/constify-lustre-attribute_group-structures/20170717-142957 config: sparc64-allyesconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705

Re: [PATCH 0/4] constify lustre attribute_group structures

2017-07-17 Thread Arvind Yadav
Sorry for noise. Please ignore this. It's having build error. Again, I will push all changes. ~arvind On Monday 17 July 2017 11:18 AM, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const

Re: [PATCH 2/4] staging: lustre: ldlm: constify attribute_group structures.

2017-07-17 Thread Arvind Yadav
Sorry for noise. Please ignore this. ~arvind On Monday 17 July 2017 11:18 AM, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed

Re: [PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures.

2017-07-17 Thread Arvind Yadav
Sorry for noise. Please ignore this. ~arvind On Monday 17 July 2017 11:18 AM, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed

Re: [PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures.

2017-07-17 Thread Arvind Yadav
Sorry for noise. Please ignore this. ~arvind On Monday 17 July 2017 11:18 AM, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed

Re: [PATCH 4/4] staging: lustre: obdclass: constify attribute_group structures.

2017-07-17 Thread Arvind Yadav
Sorry for noise. Please ignore this. This change should not be separate. ~arvind On Monday 17 July 2017 11:19 AM, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark

[PATCH 4/4] staging: lustre: obdclass: constify attribute_group structures.

2017-07-16 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/lustre/lustre/ob

[PATCH 2/4] staging: lustre: ldlm: constify attribute_group structures.

2017-07-16 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/lustre/lustre/ldlm/ldlm_l

[PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures.

2017-07-16 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/lustre/lustre/obdclass/linux

[PATCH 1/4] staging: lustre: constify attribute_group structures.

2017-07-16 Thread Arvind Yadav
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/lustre/lustre/include/lprocfs_status.h | 4 ++-- drivers/staging/lustre/lustre/lmv/lproc_lmv.c | 2 +- drivers/staging/lustre/lustre/lov/lproc_lov.c | 2 +- drivers/staging/lustre/lustre/mdc/lproc

[PATCH 0/4] constify lustre attribute_group structures

2017-07-16 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (4): [PATCH 1/4] staging: lustre: constify attribute_group structures. [PATCH 2/4] staging

[PATCH] staging: atomisp: gc2235: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
/staging/media/atomisp/i2c/gc2235.o File size After adding 'const': textdata bss dec hex filename 108181296 4 121182f56 drivers/staging/media/atomisp/i2c/gc2235.o Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/media/atomi

[PATCH] staging: atomisp: mt9m114: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
/staging/media/atomisp/i2c/mt9m114.o File size After adding 'const': textdata bss dec hex filename 152442512 8 177644564 drivers/staging/media/atomisp/i2c/mt9m114.o Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/media/atomi

[PATCH] staging: atomisp: ov5693: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
/staging/media/atomisp/i2c/ov5693/ov5693.o File size After adding 'const': textdata bss dec hex filename 207933200 0 239935db9 drivers/staging/media/atomisp/i2c/ov5693/ov5693.o Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging

[PATCH] staging: atomisp: ov2722: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
/staging/media/atomisp/i2c/ov2722.o File size After adding 'const': textdata bss dec hex filename 148351816 0 16651410b drivers/staging/media/atomisp/i2c/ov2722.o Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/media/atomi

[PATCH] staging: atomisp: gc0310: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
/staging/media/atomisp/i2c/gc0310.o File size After adding 'const': textdata bss dec hex filename 103611824 0 121852f99 drivers/staging/media/atomisp/i2c/gc0310.o Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/media/atomi

[PATCH] staging: atomisp: ov8858: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
/staging/media/atomisp/i2c/ov8858.o File size After adding 'const': textdata bss dec hex filename 238688384 0 322527dfc drivers/staging/media/atomisp/i2c/ov8858.o Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/media/atomi

[PATCH] staging: atomisp: ov2680: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
/staging/media/atomisp/i2c/ov2680.o File size After adding 'const': textdata bss dec hex filename 125303056 8 155943cea drivers/staging/media/atomisp/i2c/ov2680.o Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/media/atomi

[PATCH] staging: atomisp: lm3554: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
/staging/media/atomisp/i2c/lm3554.o File size After adding 'const': textdata bss dec hex filename 54111856 2472911c7b drivers/staging/media/atomisp/i2c/lm3554.o Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/media/atomi

[PATCH] staging: ccree: constify dev_pm_ops structures.

2017-06-29 Thread Arvind Yadav
/ssi_driver.o File size After adding 'const': textdata bss dec hex filename 4010 288 0429810ca drivers/staging/ccree/ssi_driver.o Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/ccree/ssi_driver.c | 2 +- 1 file chan

[PATCH] staging: unisys: visorbus: constify channel_attr_grp and dev_attr_grp

2017-06-23 Thread Arvind Yadav
/unisys/visorbus/visorbus_main.o Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/vi

[PATCH] staging: unisys: visorbus: constify visorchipset_parahotplug_group

2017-06-23 Thread Arvind Yadav
/unisys/visorbus/visorchipset.o Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/unisys/visorbus/visorchipset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchi

[PATCH] Staging: media: davinci_vpfe Fix resource leaks in error paths.

2017-06-07 Thread Arvind Yadav
Free memory, if ipipe_s_config and ipipe_g_config are not successful. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH] Staging: media: Unmap and release region obtained by ioremap_nocache

2017-03-17 Thread Arvind Yadav
Free memory mapping, if vpfe_ipipe_init is not successful. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/davinc

[PATCH v2 01/2] rtl8192u: r8192U:- Do not use 'asm/io.h' directly, use 'linux/io.h'.

2017-01-05 Thread Arvind Yadav
'commit 2584cf83578c ("arch, drivers: don't include directly, use instead")' Make uniform definition of ioremap, ioremap_wc, ioremap_wt and ioremap_cache, tree-wide. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/rtl8192u/r8192U.h | 2 +- 1

Re: [v1] i4l: act2000: act2000:- Do not use 'asm/io.h' directly, use 'linux/io.h'.

2017-01-05 Thread Arvind Yadav
Thanks for your suggestion :). I have done the changes as per your concern . Please review it. Thanks :) -Arvind On Thursday 05 January 2017 05:35 PM, Greg KH wrote: On Thu, Jan 05, 2017 at 05:25:05PM +0530, Arvind Yadav wrote: Please find my comment below. Where? What happened to your

[PATCH v2 02/2] i4l: act2000: act2000:- Do not use 'asm/io.h' directly, use 'linux/io.h'.

2017-01-05 Thread Arvind Yadav
'commit 2584cf83578c ("arch, drivers: don't include directly, use instead")' Make uniform definition of ioremap, ioremap_wc, ioremap_wt and ioremap_cache, tree-wide. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/i4l/act2000/act2000.h | 2 +- 1

Re: [v1] i4l: act2000: act2000:- Do not use 'asm/io.h' directly, use 'linux/io.h'.

2017-01-05 Thread Arvind Yadav
Please find my comment below. Thanks -Arvind On Thursday 05 January 2017 05:16 PM, Greg KH wrote: On Thu, Jan 05, 2017 at 04:09:24PM +0530, Arvind Yadav wrote: Make uniform definition of ioremap, ioremap_wc, ioremap_wt and ioremap_cache, tree-wide. That doesn't make much sense, and doesn't

[v1] rtl8192u: r8192U:- Do not use 'asm/io.h' directly, use 'linux/io.h'.

2017-01-05 Thread Arvind Yadav
Make uniform definition of ioremap, ioremap_wc, ioremap_wt and ioremap_cache, tree-wide. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/rtl8192u/r8192U.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U.h b/d

[v1] i4l: act2000: act2000:- Do not use 'asm/io.h' directly, use 'linux/io.h'.

2017-01-05 Thread Arvind Yadav
Make uniform definition of ioremap, ioremap_wc, ioremap_wt and ioremap_cache, tree-wide. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/i4l/act2000/act2000.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/i4l/act2000/act200

[PATCH] android: ashmem: handle the failures in ashmen driver

2016-08-29 Thread Arvind Yadav
Check return value of range_alloc, ashmem_shrink_scan and register_shrinker. Handle errors correctly. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> --- drivers/staging/android/ashmem.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/d