Re: [PATCH v2 31/34] fs/nfs: convert put_page() to put_user_page*()

2019-08-04 Thread Calum Mackay
fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). Cc: Calum Mackay Cc: Trond Myklebust Cc: Anna Schumaker Cc: linux-...@vger.kernel.org Signed-off-by: John Hubbard --- fs/nfs/direct.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) Reviewed

Re: [PATCH 31/34] nfs: convert put_page() to put_user_page*()

2019-08-04 Thread Calum Mackay
On 03/08/2019 2:41 am, John Hubbard wrote: On 8/2/19 6:27 PM, Calum Mackay wrote: On 02/08/2019 3:20 am, john.hubb...@gmail.com wrote: ... Since it's static, and only called twice, might it be better to change its two callers [nfs_direct_{read,write}_schedule_iovec()] to call put_user_pages

Re: [PATCH 31/34] nfs: convert put_page() to put_user_page*()

2019-08-02 Thread Calum Mackay
On 02/08/2019 3:20 am, john.hubb...@gmail.com wrote: From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit