[PATCH] scsi: vmw_pscsi: Rearrange code to avoid multiple calls to free_irq during unload

of pvscsi_release_resources. Signed-off-by: Cathy Avery Reviewed-by: Ewan D. Milne --- drivers/scsi/vmw_pvscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c index 6e49102..0d6b2a8 100644 --- a/drivers/scsi/vmw_pvscsi.c +++ b/drivers/scsi

Re: [PATCH] scsi: storvsc: missing error code in storvsc_probe()

} #endif return 0; Reviewed-by: Cathy Avery <cav...@redhat.com> ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error

/O to complete while holding scsi_sd_probe_domain. Also returning the default error of DID_TARGET_FAILURE causes multipath to not retry the I/O resulting in applications receiving I/O errors before a failover can occur. Signed-off-by: Cathy Avery <cav...@redhat.com> Signed-off-by: Long L

Re: [PATCH] storvsc: Avoid excessive host scan on controller change

ailover while running fio and taking hyperV snap shots while luns are being hot added and removed. Tested-by: Cathy Avery <cav...@redhat.com> ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH V3] scsi: storvsc: Allow only one remove lun work item to be issued per lun

kqueue to serialize work in storvsc_handle_error [Christoph Hellwig] Changes since v2: Replaced create_singlethread_workqueue with alloc_ordered_workqueue [Christoph Hellwig] Added reviewed by's. Signed-off-by: Cathy Avery <cav...@redhat.com> Reviewed-by: Christoph Hellwig <h...@lst.de> Reviewe

Re: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun

On 10/31/2017 08:24 AM, Martin K. Petersen wrote: If you use alloc_ordered_workqueue directly instead of create_singlethread_workqueue you can pass a format string and don't need the separate allocation. But I'm not sure if Tejun is fine with using __WQ_LEGACY directly.. The only thing that

[PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun

kqueue to serialize work in storvsc_handle_error [Christoph Hellwig] Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c i

[PATCH] scsi: storvsc: Allow only one remove lun work item to be issued per lun

kqueue to serialize work in storvsc_handle_error [Christoph Hellwig] Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c i

Re: [PATCH] scsi: storvsc: Allow only one remove lun work item to be issued per lun

On 04/15/2017 10:06 AM, Christoph Hellwig wrote: Just add a singlethreaded workqueue for storvsc_handle_error and you'll get serialization for all error handling for free. The problem I am seeing is that many work items can be queued up for the same lun before it goes away. The single

[PATCH v3 2/2] scsi: storvsc: Add support for FC rport.

to scan the scsi stack via echo "- - -" > /sys/class/scsi_host/hostX/scan. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers

[PATCH v3 0/2] scsi: storvsc: Add support for FC rport

. Changes since v2: - Additional patch adding FC_PORT_ROLE_FCP_DUMMY_INITIATOR role to fc_transport - Changed storvsc rport role to FC_PORT_ROLE_FCP_DUMMY_INITIATOR Changes since v1: - Fix fc_rport_identifiers init [Stephen Hemminger] - Better error checking Cathy Avery (2): scsi

[PATCH v3 1/2] scsi: scsi_transport_fc: Add dummy initiator role to rport

rport's role in fc_rport_identifiers. This insures that a valid scsi_target_id is assigned to the newly created rport and it can meet the requirements of fc_user_scan_tgt calling scsi_scan_target. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/scsi_transport_fc.c | 10 +

[PATCH] scsi: storvsc: Allow only one remove lun work item to be issued per lun

ted as scsi_remove_device also tries to take host->scan_mutex. This results in dragging the VM down and sometimes completely. This patch only allows one remove lun to be issued to a particular lun while it is an instantiated member of the scsi stack. Signed-off-by: Cathy Avery <cav...@r

[PATCH v3 2/2] scsi: storvsc: Add support for FC rport.

to scan the scsi stack via echo "- - -" > /sys/class/scsi_host/hostX/scan. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers

[PATCH v3 1/2] scsi: scsi_transport_fc: Add dummy initiator role to rport

rport's role in fc_rport_identifiers. This insures that a valid scsi_target_id is assigned to the newly created rport and it can meet the requirements of fc_user_scan_tgt calling scsi_scan_target. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/scsi_transport_fc.c | 10 +

[PATCH v3 0/2] scsi: storvsc: Add support for FC rport

. Changes since v2: - Additional patch adding FC_PORT_ROLE_FCP_DUMMY_INITIATOR role to fc_transport - Changed storvsc rport role to FC_PORT_ROLE_FCP_DUMMY_INITIATOR Changes since v1: - Fix fc_rport_identifiers init [Stephen Hemminger] - Better error checking Cathy Avery (2): scsi

Re: [PATCH v2] scsi: storvsc: Add support for FC rport.

On 04/03/2017 08:17 AM, Christoph Hellwig wrote: if (host->transportt == fc_transport_template) { + struct fc_rport_identifiers ids = { + .roles = FC_PORT_ROLE_FCP_TARGET, + }; I don't think storvsc ever acts as FCP target. In order to

[PATCH v2] scsi: storvsc: Add support for FC rport.

"- - -" > /sys/class/scsi_host/hostX/scan now works. Signed-off-by: Cathy Avery <cav...@redhat.com> --- Changes since v1: - Fix fc_rport_identifiers init [Stephen Hemminger] - Better error checking --- drivers/scsi/storvsc_drv.c | 23 ++- 1 file changed, 18 inserti

Re: [REGRESSION][Stable][v3.12.y][v4.4.y][v4.9.y][v4.10.y][v4.11-rc1] scsi: storvsc: properly set residual data length on errors

Hi, So which commit is moving forward and which one is not? f1c635b439a5c01776fe3a25b1e2dc546ea82e6f or 40630f462824ee24bc00d692865c86c3828094e0? We have backported 40630f462824ee24bc00d692865c86c3828094e0 and I am unclear if this is a regression and must be removed or it is a regression

[PATCH v2] scsi: storvsc: Add support for FC rport.

"- - -" > /sys/class/scsi_host/hostX/scan now works. Signed-off-by: Cathy Avery <cav...@redhat.com> --- Changes since v1: - Fix fc_rport_identifiers init [Stephen Hemminger] - Better error checking --- drivers/scsi/storvsc_drv.c | 23 ++- 1 file changed, 18 inserti

Re: [PATCH] scsi: storvsc: Add support for FC rport.

Good catch. Thanks! On 03/14/2017 12:42 PM, Stephen Hemminger wrote: On Tue, 14 Mar 2017 12:01:03 -0400 Cathy Avery <cav...@redhat.com> wrote: #if IS_ENABLED(CONFIG_SCSI_FC_ATTRS) if (host->transportt == fc_transport_template) { + struct fc_rport_identi

[PATCH] scsi: storvsc: Add support for FC rport.

"- - -" > /sys/class/scsi_host/hostX/scan now works. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 638e

Re: [PATCH] scsi: storvsc: Add support for FC rport.

Hi, I haven't received any feedback yet. Should I resend? Thanks, Cathy On 02/28/2017 01:45 PM, Cathy Avery wrote: Included in the current storvsc driver for Hyper-V is the ability to access luns on an FC fabric via a virtualized fiber channel adapter exposed by the Hyper-V host. The driver

[PATCH] scsi: storvsc: Add support for FC rport.

"- - -" > /sys/class/scsi_host/hostX/scan now works. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 585e

[PATCH v2 0/2] scsi: storvsc: Add support for FC lightweight host.

ed that the word lightweight may not be the best choice of terms when describing the new FC transport option. I can offer a few new ones but I am not particularly imaginative. Virtual FC Mini FC Host only FC Changes from V1: Added more comments and documentation in the code regarding the lightweight

[PATCH v2 1/2] scsi: scsi_transport_fc: Provide a lightweight option for Virtual FC Hosts.

created when the transport driver loads. They are just not populated when running in lightweight mode. Conceptually both lightweight and heavyweight clients could coexist. 4) fc_transport_template->user_scan is now null and the bus can be scanned. Signed-off-by: Cathy Avery <cav...@redh

[PATCH v2 2/2] scsi: storvsc: Add support for FC lightweight host.

scsi_times_out() scsi_error.c. So the workaround is no longer necessary. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 8

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

; /sys/class/scsi_host/hostX/scan. Cathy On 01/22/2017 10:13 PM, Fam Zheng wrote: On Wed, 01/18 15:28, Cathy Avery wrote: Enable FC lightweight host option so that the luns exposed by the driver may be manually scanned. Hi Cathy, out of curiosity: how does this relate to issue_lip opera

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

necessitating its own patch. I will break it out in the next go round. Thanks, Cathy On 01/20/2017 04:31 AM, Dan Carpenter wrote: On Thu, Jan 19, 2017 at 12:55:27PM -0500, Cathy Avery wrote: On 01/18/2017 06:15 PM, Dan Carpenter wrote: On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote

Re: [PATCH 1/2] scsi: scsi_transport_fc: Provide a lightweight option for Virtual FC Hosts.

On 01/19/2017 10:11 AM, Christoph Hellwig wrote: On Wed, Jan 18, 2017 at 03:28:57PM -0500, Cathy Avery wrote: The patch provides a means to offer a lightweight option to the current FC transport class. The new option is selected by a driver when it indicates it wants the lightweight transport

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

On 01/18/2017 06:15 PM, Dan Carpenter wrote: On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote: Enable FC lightweight host option so that the luns exposed by the driver may be manually scanned. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv

[PATCH 1/2] scsi: scsi_transport_fc: Provide a lightweight option for Virtual FC Hosts.

The patch provides a means to offer a lightweight option to the current FC transport class. The new option is selected by a driver when it indicates it wants the lightweight transport via fc_function_template. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/scsi_transpor

[PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

Enable FC lightweight host option so that the luns exposed by the driver may be manually scanned. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/driver

[PATCH 0/2] scsi: Create a lightweight FC Transport option for Virtual FC Hosts.

. Patch 1: The patch provides a lightweight option to the current FC transport class. The new option is selected by a driver when it indicates it wants the lightweight transport in fc_function_template. Patch 2: storvsc elects using the new lightweight FC host option. Cathy Avery (2): scsi

[RFC PATCH] scsi: scsi_transport_fc: Create a lightweight option for Virtual FC Hosts.

the lightweight transport in fc_function_template. I have included the changes for storvsc_drv.c in this patch as an example of a driver making use of the lightweight transport option. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/scsi_transport_fc.c

Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

Hi, Is the double semicolon a typo? Thanks, Cathy diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c index 763ff87..ca553df 100644 --- a/drivers/pci/host/pci-hyperv.c +++ b/drivers/pci/host/pci-hyperv.c @@ -378,6 +378,8 @@ struct hv_pcibus_device { struct

[PATCH v2] [hv] storvsc: Payload buffer incorrectly sized for 32 bit kernels.

On a 32 bit kernel sizeof(void *) is not 64 bits as hv_mpb_array requires. Also the buffer needs to be cleared or the upper bytes will contain junk. Suggested-by: Vitaly Kuznetsov <vkuzn...@redhat.com> Signed-off-by: Cathy Avery <cav...@redhat.com> ChangeLog: v1) Initial submissio

[PATCH] [hv] storvsc: Payload buffer incorrectly sized for 32 bit kernels.

On a 32 bit kernel sizeof(void *) is not 64 bits as hv_mpb_array requires. Also the buffer needs to be cleared or the upper bytes could contain junk. Suggested-by: Vitaly Kuznets <vkuzn...@redhat.com> Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 3

Re: [PATCH 1/2 v2] pci-hyperv: properly handle pci bus remove

I have not been able to try out your second patch. So once that happens you can add my name. Cathy On 09/27/2016 07:54 PM, Long Li wrote: Thanks for pointing that out. If you don't mind, I will also add "Tested-by: Cathy Avery <cav...@redhat.com>". -Original Message-

Re: [PATCH 1/2 v2] pci-hyperv: properly handle pci bus remove

Hi, You seem to be missing the Reported-by tag. That's xiaof...@redhat.com. Cathy On 09/14/2016 10:10 PM, Long Li wrote: From: Long Li hv_pci_devices_present is called in hv_pci_remove when we remove a PCI device from host (e.g. by disabling SRIOV on a device). In

[PATCH] PCI: hv: Fix interrupt cleanup path

without freeing int_desc as part of hv_int_desc_free(). Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/pci/host/pci-hyperv.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c index 7

Re: [PATCH v15 net-next 1/1] hv_sock: introduce Hyper-V Sockets

tests ( host to vm and vm to host ) using apps provided by Dexuan. Reviewed-by: Cathy Avery <cav...@redhat.com> Tested-by: Cathy Avery <cav...@redhat.com> On 07/08/2016 03:47 AM, Dexuan Cui wrote: Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism betw

[PATCH 1/1] scsi: storvsc: Filter out storvsc messages CD-ROM medium not present

When a virtual scsi DVD device is present with no image file attached the storvsc driver logs all resulting unnecessary sense errors whenever IO is issued to the device. [storvsc] Sense Key : Not Ready [current] [storvsc] Add. Sense: Medium not present - tray closed Signed-off-by: Cathy Avery

Re: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

Hi, I will be working with Dexuan to possibly port this functionality into RHEL. Here are my initial comments. Mostly stylistic. They are prefaced by CAA. Thanks, Cathy Avery On 04/07/2016 09:36 PM, Dexuan Cui wrote: Hyper-V Sockets (hv_sock) supplies a byte-stream based communication

Re: [PATCH v2] Drivers: hv: kvp: fix IP Failover

Sorry acking wrong email. Thanks, Cathy On 03/30/2016 08:21 AM, Cathy Avery wrote: On 03/29/2016 08:30 AM, Vitaly Kuznetsov wrote: Hyper-V VMs can be replicated to another hosts and there is a feature to set different IP for replicas, it is called 'Failover TCP/IP'. When such guest starts

Re: [PATCH v2] Drivers: hv: kvp: fix IP Failover

EOUT 30 /* + * Timeout for guest-host handshake for services. + */ +#define HV_UTIL_NEGO_TIMEOUT 60 + +/* * The below CPUID leaves are present if VersionAndFeatures.HypervisorPresent * is set by CPUID(HVCPUID_VERSION_FEATURES). */ Acked-by: Cathy Avery <cav...@redhat.com>