Hi syzbot administrator,
CONFIG_EROFS_DEBUG was introduced for debug purpose during
development, this should not be enabled on release version.
Can you please turn off this config, and retest with erofs module?
Thanks,
On 2020/9/29 4:36, Gao Xiang wrote:
Hi,
On Mon, Sep 28, 2020 at 12:27:24A
by: Theodore Ts'o
> fs/erofs/internal.h | 2 --
> fs/f2fs/f2fs.h | 1 -
Acked-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> most deleted code are from erofs specific fault injection, which was
> followed f2fs and previously discussed in earlier topic [1], but
> let's follow what Christoph's said now.
Reviewed-by: Chao Yu
Thanks,
>
> Comments and suggestions are welcome...
>
>
On 2019/9/2 22:20, David Sterba wrote:
> Oh right, I think the reasons are historical and that we can remove the
> options nowadays. From the compatibility POV this should be safe, with
> ACLs compiled out, no tool would use them, and no harm done when the
> code is present but not used.
>
> There
On 2019-9-2 21:06, David Sterba wrote:
> On Mon, Sep 02, 2019 at 05:57:11AM -0700, Christoph Hellwig wrote:
>>> +config EROFS_FS_XATTR
>>> + bool "EROFS extended attributes"
>>> + depends on EROFS_FS
>>> + default y
>>> + help
>>> + Extended attributes are name:value pairs associated wi
On 2019/8/30 19:51, David Sterba wrote:
> On Fri, Aug 30, 2019 at 10:06:25AM +0800, Chao Yu wrote:
>> On 2019/8/29 23:43, Dan Carpenter wrote:
>>>> p.s. There are 2947 (un)likely places in fs/ directory.
>>>
>>> I was complaining about you adding new poin
ession filesystem, I
think it will enrich diversity of compression filesystem, and bring healthy
competition there.
I do believe this is the right time to promote erofs to fs/ directory, let it be
the formal member of filesystem clubhouse.
Acked-by: Chao Yu
Thanks
>
> Thank you in a
Xiang, the code itself looks clean to me.
Reviewed-by: Chao Yu
Thanks,
On 2019/8/30 14:31, Gao Xiang wrote:
> Hi Chao,
>
> On Fri, Aug 30, 2019 at 02:25:13PM +0800, Chao Yu wrote:
>> On 2019/8/30 11:36, Gao Xiang wrote:
>>> As Dan Carpenter suggested [1], I have to rem
; if (bio_add_page(bio, page, PAGE_SIZE, 0) != PAGE_SIZE) {
> err = -EFAULT;
> goto err_out;
> }
>
> [1]
> https://lore.kernel.org/r/74c4784319b40deabfbaea92468f7e3ef44f1c96.ca...@perches.com/
> Reporte
On 2019/8/30 11:36, Gao Xiang wrote:
> As Dan Carpenter suggested [1], I have to remove
> all erofs likely/unlikely annotations.
>
> [1] https://lore.kernel.org/linux-fsdevel/20190829154346.GK23584@kadam/
> Reported-by: Dan Carpenter
> Signed-off-by: Gao Xiang
I suggest we can modify this by fo
ion, add a "rcu_barrier()" when exit_fs();
>
> [1] https://lore.kernel.org/r/20190829101545.gc20...@infradead.org/
> Reported-by: Christoph Hellwig
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
urally aligned.
>
> [1] https://lore.kernel.org/lkml/20190829095954.gb20...@infradead.org/
> Reported-by: Christoph Hellwig
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http:
On 2019/8/30 11:36, Gao Xiang wrote:
> As Christoph suggested [1], these marcos are much
> more readable as a function.
>
> [1] https://lore.kernel.org/r/20190829095954.gb20...@infradead.org/
> Reported-by: Christoph Hellwig
> Signed-off-by: Gao Xiang
Reviewed-by
ome lines
>have to exceed 80 characters.
> [1]
> https://lore.kernel.org/r/67d6efbbc9ac6db23215660cb970b7ef29dc0c1d.ca...@perches.com/
> Reported-by: Joe Perches
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
On 2019/8/30 11:00, Gao Xiang wrote:
> As Christoph claimed [1], on-disk format should have
> explicitly assigned numbers. I have to change it.
>
> [1] https://lore.kernel.org/r/20190829095954.gb20...@infradead.org/
> Reported-by: Christoph Hellwig
> Signed-off-by: Gao Xiang
On 2019/8/29 23:43, Dan Carpenter wrote:
>> p.s. There are 2947 (un)likely places in fs/ directory.
>
> I was complaining about you adding new pointless ones, not existing
> ones. The likely/unlikely annotations are supposed to be functional and
> not decorative. I explained this very clearly.
>
>
> Anyway, let's fix these issues for KERNEL_HEADER_TEST feature instead
> of adding to blacklist...
>
> [1] https://lore.kernel.org/lkml/20190826162432.11100...@canb.auug.org.au/
> Reported-by: Stephen Rothwell
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Cc: # 4.19+
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 2019/8/20 16:46, Qu Wenruo wrote:
> [...]
>>
>> Yeah, it looks like we need searching more levels mapping to find the final
>> physical block address of inode/node/data in btrfs.
>>
>> IMO, in a little lazy way, we can reform and reuse existed function in
>> btrfs-progs which can find the mappin
On 2019/8/21 9:48, Darrick J. Wong wrote:
> On Wed, Aug 21, 2019 at 09:34:02AM +0800, Chao Yu wrote:
>> On 2019/8/20 23:56, Theodore Y. Ts'o wrote:
>>> The reason why there needs to be at least some file system specific
>>> code for fuzz testing is because for e
o rewrite whole generic fwk for each filesystem, because
existed filesystem userspace tool should has included above callback's detail
codes...
> On Tue, Aug 20, 2019 at 10:24:11AM +0800, Chao Yu wrote:
>> filesystem fill the tool's callback to seek a node/block and supported fields
&
On 2019/8/20 10:38, Qu Wenruo wrote:
>
>
> On 2019/8/20 上午10:24, Chao Yu wrote:
>> On 2019/8/20 8:55, Qu Wenruo wrote:
>>> [...]
>>>>>> I have made a simple fuzzer to inject messy in inode metadata,
>>>>>> dir data, compressed indexes
On 2019/8/20 8:55, Qu Wenruo wrote:
> [...]
I have made a simple fuzzer to inject messy in inode metadata,
dir data, compressed indexes and super block,
https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/commit/?h=experimental-fuzzer
I am testing with som
+
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 2019-8-19 18:34, Gao Xiang wrote:
> As reported by erofs-utils fuzzer, currently, multiref
> (ondisk deduplication) hasn't been supported for now,
> we should forbid it properly.
>
> Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support")
> Cc: # 4.19+
> Signed-off-by: Gao
gain (will trigger tail merging)
>|
> 1 2 3 1 2 -> 1 2 3 1
> |_ tail end of the chain\___/ (unexpected behavior)
> Let's detect and avoid them now.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
_
333a5895 ("staging: erofs: add compacted compression indexes
> support")
> Cc: # 5.3+
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
;
> Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support")
> Cc: # 4.19+
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
o keep the page
> working properly (page unlocked with PG_error set, PG_uptodate
> not set).
>
> Let's fix it now.
>
> Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support")
> Cc: # 4.19+
> Si
o keep the page
> working properly (page unlocked with PG_error set, PG_uptodate
> not set).
>
> Let's fix it now.
>
> Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support")
> Cc: # 4.19+
> Si
n the future.
>
> [1]
> https://lore.kernel.org/r/1133002215.69049.1566119033047.javamail.zim...@nod.at/
>
> Reported-by: Richard Weinberger
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
dev
245.javamail.zim...@nod.at/
>
> Reported-by: Richard Weinberger
> Fixes: 3aa8ec716e52 ("staging: erofs: add directory operations")
> Cc: # 4.19+
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing lis
Hi Xiang,
On 2019-8-18 18:52, Gao Xiang wrote:
> Hi Chao,
>
> On Sun, Aug 18, 2019 at 06:39:52PM +0800, Chao Yu wrote:
>> On 2019-8-18 10:53, Matthew Wilcox wrote:
>>> On Sun, Aug 18, 2019 at 10:32:45AM +0800, Gao Xiang wrote:
>>>> On Sat, Aug 17, 2019 at 07
On 2019-8-18 10:53, Matthew Wilcox wrote:
> On Sun, Aug 18, 2019 at 10:32:45AM +0800, Gao Xiang wrote:
>> On Sat, Aug 17, 2019 at 07:20:55PM -0700, Matthew Wilcox wrote:
>>> On Sun, Aug 18, 2019 at 09:56:31AM +0800, Gao Xiang wrote:
@@ -82,8 +82,12 @@ static int erofs_readdir(struct file *f, s
Hi Richard,
On 2019-8-18 17:21, Richard Weinberger wrote:
> For normal use I see no problem at all.
> I fear distros that try to mount anything you plug into your USB.
>
> At least SUSE already blacklists erofs:
> https://github.com/openSUSE/suse-module-tools/blob/master/suse-module-tools.spec#L2
type conversion").
>
> [1]
> https://lore.kernel.org/r/CAHk-=wiUs+b=ivkm3mvooxgvk7cmmc67ktmnaul0cd_cmmv...@mail.gmail.com/
>
> Reported-by: Linus Torvalds
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
de
On 2019/8/14 18:37, Gao Xiang wrote:
> As Chao pointed out [1], ENOTSUPP is used for NFS
> protocol only, we should use EOPNOTSUPP instead...
>
> [1]
> https://lore.kernel.org/lkml/108ee2f9-75dd-b8ab-8da7-b81c17baf...@huawei.com/
>
> Reported-by: Chao Yu
> Signed-off-
On 2019/8/14 12:32, Gao Xiang wrote:
> For some specific fields, use ENOTSUPP instead of EIO
> for values which look sane but aren't supported right now.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
> + return -ENOTSUPP;
A little bit confused about
by: Pavel Machek
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 2019/8/14 11:52, Pratik Shinde wrote:
> Yes.since we already have a function with same name (and we are using it in
> same
> context).
> 'inode_loc' was the most meaningful name I could come up with :)
[snip]
On Wed, Aug 14, 2019 at 7:37 AM Gao Xiang wrote:
> iloc is the name of static inlin
bjection of this patch, but I'd like to
> hear Chao/Greg's idea about this...
It looks more clean. :)
Nitpick, maybe change 'inode_loc' to shorter 'iloc' will be better.
Reviewed-by: Chao Yu
Thanks,
>
> Thanks,
> Gao Xiang
>
>> ---
>
Hi Xiang,
On 2019/8/13 11:57, Gao Xiang wrote:
> Hi Chao,
>
> On Tue, Aug 13, 2019 at 11:20:22AM +0800, Chao Yu wrote:
>> On 2019/8/13 10:30, Gao Xiang wrote:
>>> Kill all the remaining BUG_ON in EROFS:
>>> - one BUG_ON was used to detect xattr on-disk corrupt
ON only in (eng) debugging version.
BTW, do we need add WARN_ON() into DBG_BUGON() to show some details function or
call stack in where we encounter the issue?
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@l
y: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 2019/8/13 10:30, Gao Xiang wrote:
> As a helper in erofs_fs.h, erofs_inode_is_data_compressed()
> should be inlined.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproj
On 2019/7/31 23:57, Gao Xiang wrote:
> For historical reasons, __GFP_NOFAIL was set for managed inode.
> It's no need using that since EROFS can handle it properly.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
deve
sted-by: David Sterba
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 2019/7/31 23:57, Gao Xiang wrote:
> Because #include "internal.h" is included in xattr.h
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriver
On 2019/7/31 20:54, Gao Xiang wrote:
>
>
> On 2019/7/31 20:07, Chao Yu wrote:
>> Hi Xiang,
>>
>> On 2019/7/31 15:08, Gao Xiang wrote:
>>> Hi Chao,
>>>
>>> On 2019/7/31 15:03, Chao Yu wrote:
>>>> On 2019/7/29 14:51, Gao Xiang
Hi Xiang,
On 2019/7/31 15:11, Gao Xiang wrote:
> Hi Chao,
>
> On 2019/7/31 15:05, Chao Yu wrote:
>> On 2019/7/29 14:51, Gao Xiang wrote:
>>> CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting
>>> and users have no idea about the change in behaviour.
>>&
Hi Xiang,
On 2019/7/31 15:08, Gao Xiang wrote:
> Hi Chao,
>
> On 2019/7/31 15:03, Chao Yu wrote:
>> On 2019/7/29 14:51, Gao Xiang wrote:
>>> Because #include "internal.h" is included in xattr.h
>>
>> I think it would be better to remove "interna
On 2019/7/29 14:51, Gao Xiang wrote:
> Keep in line with erofs-outofstaging patchset:
> - turn on CONFIG_EROFS_FS_ZIP by default;
> - turn on CONFIG_EROFS_FS_SECURITY by default suggested by David;
> - update Kconfig description.
>
> Signed-off-by: Gao Xiang
Reviewed-by
On 2019/7/29 14:51, Gao Xiang wrote:
> Keep in line with erofs-outofstaging patchset:
> - "Chao Yu" is most commonly used in Linux community;
Either is okay to me, anyway, thanks for the correction. :)
BTW, I notice that .mailmap can map different email or name to single one on
On 2019/7/29 14:51, Gao Xiang wrote:
> keep in line with erofs-outofstaging patchset:
> - remove an extra #ifdef CONFIG_EROFS_FS_ZIP;
> - add tags at the end of #endif acrossing several lines.
>
> Signed-off-by: Gao Xiang
Reviewed-by: C
On 2019/7/29 14:51, Gao Xiang wrote:
> keep in line with erofs-outofstaging patchset:
> - Update comments in erofs_try_to_release_workgroup;
> - code style cleanup.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
dev
will be fallen out
> over time, which can be refined in the later version if some
> requirement is needed. Update related document as well.
>
> Suggested-by: Theodore Ts'o
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
On 2019/7/29 14:51, Gao Xiang wrote:
> clustersize can now be set on per-file basis
> rather than per-filesystem basis.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproj
scription.
>
> Signed-off-by: Gao Xiang
I hope I don't miss anything, since this is so huge cleanup...
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 2019/7/29 14:51, Gao Xiang wrote:
> Remove redundant braces in inode.c since
> these are all single statements.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproj
On 2019/7/29 14:51, Gao Xiang wrote:
> - use shorter function names:
> z_erofs_pagevec_enqueue and z_erofs_pagevec_dequeue;
> - minor code cleanup.
>
> In order to keep in line with erofs-outofstaging patchset.
>
> Signed-off-by: Gao Xiang
Reviewed
/* retry two more times (totally 3 times) */
> - if (addr || ++i >= 3)
> - return addr;
> - vm_unmap_aliases();
> + if (!use_vmap) {
Minor thing.
if (use_vmap)
return vmap(pages, count, VM_MAP, PAGE_KERNEL);
while (
lder)
> static inline struct page *__stagingpage_alloc(struct list_head *pagepool,
> gfp_t gfp)
> {
> - struct page *page = erofs_allocpage(pagepool, gfp);
> + struct page *page = erofs_allocpage(pagepool, gfp, true);
>
> if (unlik
mapping->a_ops = &managed_cache_aops;
> mapping_set_gfp_mask(inode->i_mapping,
> - GFP_NOFS | __GFP_HIGHMEM |
> - __GFP_MOVABLE | __GFP_NOFAIL);
> - return inode;
> + GFP_NOFS | __GFP_HIGHMEM
r our debugging use and it's
> better to just use s_id in community and delete
> the whole erofs_mount_private stuff.
>
> Suggested-by: Al Viro
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
n;
> - localize erofs_shrinker_info by introducing
> erofs_init_shrinker and erofs_exit_shrinker.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverp
On 2019/7/29 14:51, Gao Xiang wrote:
> CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting
> and users have no idea about the change in behaviour.
>
> Let's remove the setting currently and fold it into code,
> turn it into a module parameter if it's really needed.
>
> Suggested-by: David Ster
On 2019/7/29 14:51, Gao Xiang wrote:
> Because #include "internal.h" is included in xattr.h
I think it would be better to remove "internal.h" in xattr.h, and include them
both in .c file in where we need xattr definition.
Thanks,
___
devel mailing list
On 2019/7/29 14:51, Gao Xiang wrote:
> Tidy up relative order of variables / declarations in internal.h,
> and moving some local static functions out to other files.
>
> No logic change.
>
> Signed-off-by: Gao Xiang
Reviewed-by
On 2019/7/29 14:51, Gao Xiang wrote:
> It was used for Linux backward compatibility, and no use
> for upstream kernel.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproj
On 2019/7/29 14:51, Gao Xiang wrote:
> The main change is to reserve all checksums except for superblock,
> since it's more useful to do block-based verity for read-only fs.
>
> Some comments change as well, which is minor.
>
> Signed-off-by: Gao Xiang
Review
"]
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 2019/7/29 14:51, Gao Xiang wrote:
> Keep in line with erofs-outofstaging patchset as well, see
> https://lore.kernel.org/linux-fsdevel/20190725095658.155779-1-gaoxian...@huawei.com/
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao
On 2019/7/29 14:51, Gao Xiang wrote:
> - Use the correct style for all SPDX License Identifiers;
> - Get rid of the unnecessary license boilerplate;
> - Use "GPL-2.0-only" instead of "GPL-2.0" suggested-by Stephen.
>
> Signed-off-by: Gao Xi
On 2019/7/18 4:11, Karen Palacio wrote:
> Fix typo in Kconfig
>
> Signed-off-by: Karen Palacio
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Use __GFP_NOFAIL to avoid opened loop codes in z_erofs_vle_unzip().
Signed-off-by: Chao Yu
---
v2:
- change variable name from 'flags' to 'gfp_flags' to avoid common
name.
drivers/staging/erofs/unzip_vle.c | 16
1 file changed, 8 insertions(+), 8 deleti
Add erofs_bmap() to support FIBMAP ioctl on flatmode inode.
Reviewed-by: Gao Xiang
Signed-off-by: Chao Yu
---
v3:
- use erofs_blk_t instead of unsigned int.
- simply judgment condition.
drivers/staging/erofs/data.c | 33 +
1 file changed, 33 insertions(+)
diff
Hi Xiang,
On 2019/7/16 17:12, Gao Xiang wrote:
> Hi Chao,
>
> On 2019/7/16 16:52, Chao Yu wrote:
>> Use __GFP_NOFAIL to avoid opened loop codes in z_erofs_vle_unzip().
>>
>> Signed-off-by: Chao Yu
>> ---
>> drivers/staging/erofs/unzip_vle.c | 17
Hi Xiang,
On 2019/7/16 17:01, Gao Xiang wrote:
> Hi Chao,
>
> Cc lkml mailing list?
Oh, no problem, let me update my default cc list.
>
> On 2019/7/16 16:46, Chao Yu wrote:
>> Add erofs_bmap() to support FIBMAP ioctl on flatmode inode.
>>
>> Signed-off-by: Ch
On 2019/7/16 15:37, Gao Xiang wrote:
>
>
> On 2019/7/16 15:35, Chao Yu wrote:
>> Hi Xiang,
>>
>> On 2019/7/16 15:19, Gao Xiang wrote:
>>> Hi Chao,
>>>
>>> On 2019/7/16 15:05, Chao Yu wrote:
>>>> Add erofs_bmap() to suppor
Use __GFP_NOFAIL to avoid opened loop codes in z_erofs_vle_unzip().
Signed-off-by: Chao Yu
---
drivers/staging/erofs/unzip_vle.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/erofs/unzip_vle.c
b/drivers/staging/erofs/unzip_vle.c
index
Add erofs_bmap() to support FIBMAP ioctl on flatmode inode.
Signed-off-by: Chao Yu
---
v2:
- support mapping normal blocks for inline inode suggested by Xiang
- rebase to linux-next
drivers/staging/erofs/data.c | 33 +
1 file changed, 33 insertions(+)
diff --git
Hi Xiang,
On 2019/7/16 15:19, Gao Xiang wrote:
> Hi Chao,
>
> On 2019/7/16 15:05, Chao Yu wrote:
>> Add erofs_bmap() to support FIBMAP ioctl on flatmode inode.
>>
>> Signed-off-by: Chao Yu
>> ---
>> drivers/staging/erofs/data.c | 29 +
Add erofs_bmap() to support FIBMAP ioctl on flatmode inode.
Signed-off-by: Chao Yu
---
drivers/staging/erofs/data.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c
index fbce71403d87..03da57f04347
On 2019/7/12 15:12, Nishka Dasgupta wrote:
> Remove function erofs_kill_sb as all it does is call kill_block_super.
> Modify references to the former to point to the latter.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta
Reviewed-by: C
Hi xiang,
On 2019/7/3 14:06, Gao Xiang wrote:
> Hi Chao,
>
> On 2019/7/3 10:09, Gao Xiang wrote:
>>
>>
>> On 2019/7/3 9:50, Chao Yu wrote:
>>> On 2019/7/1 2:58, Gao Xiang wrote:
>>>> From: Gao Xiang
>>>>
>>>> Like all lz7
ANCE_PAGES);
> + DBG_BUGON(top >= LZ4_MAX_DISTANCE_PAGES);
> + availables[top++] = rq->out[i - LZ4_MAX_DISTANCE_PAGES];
Maybe we can change 'i - LZ4_MAX_DISTANCE_PAGES' to 'j' directly for better
readability.
Otherwise
:
> erofs_err("inode[%s] file_type error =%d",
> d->i_fullpath,
> ```
>
> No special inode layout operations, so this change should be fine.
>
> Thx.
>
>>
>> I think that is fine in priciple, however, in case
On 2019/6/27 13:31, Shobhit Kukreti wrote:
> Resolve checkpatch warning:
> Prefer kzalloc(sizeof(*ptr)...) over kzalloc(sizeof(struct ..)
>
> Signed-off-by: Shobhit Kukreti
Reviewed-by: Chao Yu
Thanks,
___
devel mai
; fill_inline_data() to stand for successful filling.
>
> Signed-off-by: Yue Hu
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 2019/6/26 11:28, Yue Hu wrote:
> From: Yue Hu
>
> Already check if ->datamode is supported in read_inode(), no need to check
> again in the next fill_inline_data() only called by fill_inode().
>
> Signed-off-by: Yue Hu
Reviewed
On 2019/6/21 18:42, Gao Xiang wrote:
> Hi Chao,
>
> On 2019/6/21 17:46, Chao Yu wrote:
>> On 2019/6/21 0:07, Gao Xiang wrote:
>>> This patch adds a new generic decompression framework
>>> in order to replace the old LZ4-specific decompression code.
>>
On 2019/6/24 15:22, Gao Xiang wrote:
> This is patch v3 of erofs decompression inplace approach, which is sent
> out by my personal email since I'm out of office to attend Open Source
> Summit China 2019 these days. No major change from PATCH v2 since no
> noticeable issue raised from landing to ou
further, but obvious
> performanace regression (about 2% for sequential read) was
> observed.
>
> Therefore let's leave it as it is instead, just move
> to utils.c and I'll try to dig into the root cause later.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
_
ssion
> backend is used.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
on inplace
> is enabled.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
2be29dd48c8e8c
> https://github.com/lz4/lz4/commit/5997e139f53169fa3a1c1b4418d2452a90b01602
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
el(&availables[j]->lru);
> + DBG_BUGON(page_ref_count(availables[j]) != 1);
> + } else {
> + availables[j] = alloc_pages(GFP_KERNEL, 0);
> + if (!availables[j])
> +
On 2019/6/21 0:07, Gao Xiang wrote:
> stagingpages are behaved as bounce pages for temporary use.
> Move to compress.h since the upcoming decompressor will
> allocate stagingpages as well.
>
> Signed-off-by: Gao Xiang
Reviewed-by: C
On 2019/6/21 0:07, Gao Xiang wrote:
> +static inline void *erofs_get_pcpubuf(unsigned int pagenr)
> +{
> + return ERR_PTR(-ENOTSUPP);
> +}
[snip]
> + percpu_data = erofs_get_pcpubuf(0);
If erofs_get_pcpubuf may return error once EROFS_PCPUBUF_NR_PAGES equals to
zero, we'd better to check
/s) on enwik9 dataset if compacted 2B
> feature is enabled.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
> +static int vle_legacy_load_cluster_from_disk(struct z_erofs_maprecorder *m,
> + unsigned long lcn)
> +{
>
1 - 100 of 236 matches
Mail list logo
