Re: [PATCH] staging: ion: fix corruption of ion_import_dma_buf

2015-09-09 Thread Colin Cross
On Wed, Sep 9, 2015 at 10:19 AM, Laura Abbott wrote: > (adding Colin and John) > > > On 09/09/2015 12:41 AM, Shawn Lin wrote: >> >> we found this issue but still exit in lastest kernel. Simply >> keep ion_handle_create under mutex_lock to avoid this race. >> >> WARNING: CPU: 2

Re: [PATCH v2 2/2] staging: ion: chunk_heap: use %pad for printing dma_addr_t's

2015-05-04 Thread Colin Cross
On Mon, May 4, 2015 at 1:22 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Thu, Apr 09, 2015 at 06:10:04PM -0700, Mitchel Humpherys wrote: We're currently using %lu and %ld to print some variables of type dma_addr_t, which results in the following warning when dma_addr_t is 64-bits wide:

Re: Re: [PATCH 1/1] [ion]: system-heap use PAGE_ALLOC_COSTLY_ORDER for high order

2014-10-07 Thread Colin Cross
On Tue, Oct 7, 2014 at 9:07 AM, PINTU KUMAR pint...@samsung.com wrote: - Original Message - From: Colin Cross ccr...@android.com To: pint...@samsung.com Cc: Laura Abbott lau...@codeaurora.org; Heesub Shin heesub.s...@samsung.com; a...@linux-foundation.org a...@linux-foundation.org

Re: Re: [PATCH 1/1] [ion]: system-heap use PAGE_ALLOC_COSTLY_ORDER for high order

2014-10-06 Thread Colin Cross
On Mon, Oct 6, 2014 at 9:26 AM, PINTU KUMAR pint...@samsung.com wrote: Hi, From: Laura Abbott lau...@codeaurora.org To: Heesub Shin heesub.s...@samsung.com; Pintu Kumar pint...@samsung.com; a...@linux-foundation.org; gre...@linuxfoundation.org;

Re: staging: Unwritten function for ion_carveout_heap.c

2014-07-23 Thread Colin Cross
On Wed, Jul 23, 2014 at 1:04 PM, Nick Krause xerofo...@gmail.com wrote: Hey Greg and others. Sorry for another email but it seems the function, ion_carveout_heap_unmap_dma is just returning and not doing anything useful. Furthermore I am new so I don't known how to write this function but

Re: [PATCH] staging/android: Remove ram_console.h

2014-04-23 Thread Colin Cross
linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ Acked-by: Colin Cross ccr...@android.com ___ devel mailing list de

Re: [PATCH] staging : android : uapi : fix coding style

2014-04-16 Thread Colin Cross
(resending without the html) On Wed, Apr 16, 2014 at 9:36 AM, John Stultz john.stu...@linaro.org wrote: On 04/16/2014 07:39 AM, Joe Perches wrote: On Wed, 2014-04-16 at 23:27 +0900, Seunghun Lee wrote: This patch fix checkpatch.pl warnings and errors. [] diff --git

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Colin Cross
On Wed, Dec 4, 2013 at 10:35 AM, Greg KH gre...@linuxfoundation.org wrote: snip And finally, is this all really needed? Why not just fix the structures to be correct, and then fix userspace to use the correct structures as well, thereby not needing a compat layer at all? Some of the binder

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Colin Cross
On Wed, Dec 4, 2013 at 1:43 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Dec 04, 2013 at 12:46:42PM -0800, Colin Cross wrote: On Wed, Dec 4, 2013 at 10:35 AM, Greg KH gre...@linuxfoundation.org wrote: snip And finally, is this all really needed? Why not just fix the structures

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Colin Cross
On Wed, Dec 4, 2013 at 2:02 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Dec 04, 2013 at 01:55:34PM -0800, Colin Cross wrote: On Wed, Dec 4, 2013 at 1:43 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Dec 04, 2013 at 12:46:42PM -0800, Colin Cross wrote: On Wed, Dec 4, 2013

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Colin Cross
On Wed, Dec 4, 2013 at 4:02 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Dec 04, 2013 at 02:22:13PM -0800, Colin Cross wrote: On Wed, Dec 4, 2013 at 2:02 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Dec 04, 2013 at 01:55:34PM -0800, Colin Cross wrote: On Wed, Dec 4, 2013

Re: [PATCH] LMK: Optimize lowmem_shrink

2013-08-19 Thread Colin Cross
On Mon, Aug 19, 2013 at 7:23 PM, Colin Cross ccr...@android.com wrote: On Mon, Aug 19, 2013 at 6:16 PM, Leon Ma xindong...@intel.com wrote: From: Leon Ma xindong...@intel.com Date: Mon, 19 Aug 2013 14:22:38 +0800 Subject: [PATCH] LMK: Optimize lowmem_shrink. By comparing

Re: [PATCH] LMK: Optimize lowmem_shrink

2013-08-19 Thread Colin Cross
On Mon, Aug 19, 2013 at 6:16 PM, Leon Ma xindong...@intel.com wrote: From: Leon Ma xindong...@intel.com Date: Mon, 19 Aug 2013 14:22:38 +0800 Subject: [PATCH] LMK: Optimize lowmem_shrink. By comparing with selected_oom_score_adj instead of min_score_adj, we may do less calculation.